=== Eickmeyer is now known as studiobot | ||
=== studiobot is now known as Eickmeyer | ||
=== Eickmeyer is now known as studiobot | ||
mborzecki | morning | 06:12 |
---|---|---|
mborzecki | mvo: morning | 07:43 |
mvo | mborzecki: hey, good morning | 07:44 |
mvo | mborzecki: how are things? tests look pretty unhappy still :/ | 07:48 |
mborzecki | mvo: restarted some jobs | 07:48 |
mborzecki | mvo: i'd think about landing #6422 to see if it helps with random mount errors on core-18 | 07:48 |
mvo | mborzecki: did you notice any patterns? | 07:48 |
mup | PR #6422: tests/prepare: prevent console-conf from running <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6422> | 07:48 |
pedronis | mvo: hi, last night we had lots of runs >50mins | 07:49 |
mvo | mborzecki: good idea | 07:49 |
pedronis | but unclear what changed | 07:49 |
mvo | mborzecki: lets see if it helps | 07:49 |
mborzecki | mvo: some kill timeouts, (one in snap run --strace test), some network issues (go get from github fails) | 07:49 |
mup | PR snapd#6422 closed: tests/prepare: prevent console-conf from running <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6422> | 07:49 |
mvo | pedronis: yeah, I noticed that too | 07:49 |
mvo | pedronis: usual time is ~35min these days it seems | 07:49 |
pedronis | mvo: I re-run things a bit, but failed, then I gave up | 07:49 |
pedronis | mvo: I'm landing #6471 and will update #6473 | 07:50 |
mup | PR #6471: snap-confine: fix classic snaps for users with /var/lib/* homedirs <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6471> | 07:50 |
mup | PR #6473: snap-confine: remove special handling of /var/lib/jenkins <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6473> | 07:50 |
pedronis | mvo: jdstrand asked for tweaks to #6466 | 07:51 |
mup | PR #6466: cmd/snap-confine: handle death of helper process <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/6466> | 07:51 |
mvo | pedronis: certainly, looking | 07:51 |
mup | PR snapd#6471 closed: snap-confine: fix classic snaps for users with /var/lib/* homedirs <⚠ Critical> <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/6471> | 07:52 |
pedronis | mvo: I'm a bit confused by the test change in #6473 | 07:55 |
mup | PR #6473: snap-confine: remove special handling of /var/lib/jenkins <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6473> | 07:55 |
pedronis | I think we still want both tests | 07:56 |
mup | PR snapd#6474 opened: snap-confine: fix classic snaps for users with /var/lib/* homedirs (2.37) <Created by mvo5> <https://github.com/snapcore/snapd/pull/6474> | 07:57 |
mvo | pedronis: you mean we want both "special-home" and "special-home-run-classic-snaps" tests? | 08:00 |
pedronis | yes | 08:00 |
mvo | pedronis: jenkins can no longer run confined snaps after the change | 08:01 |
mvo | pedronis: and it never could before | 08:01 |
mvo | pedronis: it was only ever able to run classic snaps | 08:01 |
pedronis | mvo: that is true, but I tought they would run partially at least? | 08:02 |
pedronis | they break already in snap-confine? | 08:02 |
mvo | pedronis: let me double check | 08:02 |
mvo | pedronis: I think so, let me quickly boot my test vm | 08:02 |
=== pstolowski|afk is now known as pstolowski | ||
pedronis | mvo: the issue is that they will not have a home dir | 08:02 |
pstolowski | good morning | 08:02 |
pedronis | but it might well be that snap-confine is unhappy | 08:03 |
pedronis | (it does some things related to home after the pivot) | 08:03 |
mvo | pedronis: I will double check again, give me 2min | 08:04 |
pedronis | mvo: thx | 08:04 |
=== phoenix_firebrd is now known as murthy | ||
mvo | pedronis: https://github.com/snapcore/snapd/pull/6473#issuecomment-460548241 I will dig a bit into the snap-confine code to double check my empirical findings too, I have the vm running if you have any further questions | 08:13 |
mup | PR #6473: snap-confine: remove special handling of /var/lib/jenkins <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6473> | 08:13 |
pedronis | mvo: ok | 08:15 |
pedronis | thx | 08:15 |
pedronis | mvo: I updated 6473 | 08:21 |
mborzecki | pstolowski: spent some time looking at your pr, feels tricky | 08:22 |
mvo | pedronis: thanks, did I made a dirty merge? | 08:25 |
pedronis | mvo: ? | 08:25 |
mvo | pedronis: I noticed you force pushed 6473, was there anything wrong in the original push? | 08:25 |
pedronis | mvo: no, but I squash merged the previous one | 08:26 |
pedronis | so I had to | 08:26 |
=== murthy is now known as phoenix_firebrd_ | ||
mvo | pedronis: aha, ok | 08:26 |
pstolowski | mborzecki: yes i can see that. perhaps we should just reduce retry timeout, unless there is some other more obvious fix | 08:26 |
pedronis | mvo: so we get 1 commit each | 08:26 |
mvo | pedronis: +1 | 08:26 |
pedronis | mborzecki: tricky in which sense | 08:26 |
mvo | pedronis: I think I did the same earlier but its fine :) | 08:27 |
mborzecki | pedronis: maybe fiddly, had to spent some time figuring out what's happening there | 08:27 |
pedronis | mborzecki: I think the tricky bit is that we need to trust what go says about timers | 08:28 |
pedronis | (which has already changed over time) | 08:28 |
mborzecki | pedronis: that's another story | 08:28 |
pedronis | that indeed is a bit uncomfortable | 08:28 |
mvo | pedronis: I added a comment to 6473 about the code and how things worked before and why strict snaps for non /home users never worked, hope this makes things clear. ideally zyga would double check 6473 but I'm pretty confident in the findings | 08:29 |
pedronis | mvo: I gave a +1 to #6470, it needs a 2nd review | 08:30 |
mvo | mborzecki: 6470 needs a second review | 08:30 |
mup | PR #6470: packaging: disable systemd environment generator on 18.04 <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6470> | 08:30 |
mvo | pedronis: thank you! | 08:30 |
mvo | mborzecki: you looked at this before so hopefully easy :) | 08:31 |
=== phoenix_firebrd_ is now known as murthy | ||
pedronis | mvo: your comment in 6473 about strict confinement is not ture, we never copied the host into var/lib | 08:33 |
pedronis | we copied core plus host lxd | 08:33 |
mvo | pedronis: we create a writable mimic of the original host, let me search | 08:33 |
pedronis | mvo: no, it's a writable mimic of core plus host lxd | 08:34 |
pedronis | (it's all confusing) | 08:34 |
mvo | pedronis: yeah, re-reading it now | 08:37 |
mup | PR snapd#6470 closed: packaging: disable systemd environment generator on 18.04 <⚠ Critical> <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/6470> | 08:39 |
pedronis | mvo: squash merged ^ | 08:39 |
pedronis | let me prep a backport | 08:39 |
pedronis | done | 08:44 |
mup | PR snapd#6475 opened: packaging: disable systemd environment generator on 18.04 (2.37) <Created by pedronis> <https://github.com/snapcore/snapd/pull/6475> | 08:45 |
mvo | pedronis: thanks you | 08:56 |
mvo | pedronis: if 6470 can be cherry picked I can just do that, we only need the backport when there are conflicts | 08:56 |
mvo | pedronis: you are right of course, its just the core /var/lib that goes into the namespace | 08:56 |
pedronis | mvo: ah | 08:57 |
mvo | pedronis: which means my testing with jenkins was not ideal as this is now availalbe in the core snap. i retested using postgres and got also a failure but a different one | 08:57 |
pedronis | mvo: ah, we should remove jenkins from the cores | 08:57 |
mvo | pedronis: +1 | 08:57 |
mvo | pedronis: if this branch lands, then yes | 08:57 |
mvo | pedronis: https://github.com/snapcore/snapd/pull/6473#issuecomment-460558531 hopefully solves the mystery | 08:58 |
mup | PR #6473: snap-confine: remove special handling of /var/lib/jenkins <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6473> | 08:58 |
pedronis | mvo: btw I'm *not* working on 6466 because I will need to review it | 08:58 |
mvo | pedronis: I can work on that now | 08:59 |
pedronis | mvo: thx | 08:59 |
pedronis | mvo: one of the backports got red | 08:59 |
pedronis | 6474 :/ | 08:59 |
pedronis | mvo: +1 to #6473 | 09:02 |
mup | PR #6473: snap-confine: remove special handling of /var/lib/jenkins <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6473> | 09:02 |
mvo | pedronis: the red is 'protocol' error in mount again :( | 09:02 |
pstolowski | mvo: hey, quick question about apt wrt to nested vm. i'm having an issue where apt install -y ... as part of the test triggers an interactive debconf prompt and hangs there till kill timeout - https://pastebin.ubuntu.com/p/R35sJvhfWH/ ; i'd have though -y takes care of that, i cannot find anything obvious in apt man | 09:02 |
mvo | pedronis: thanks for the review | 09:03 |
mvo | pstolowski: try DEBIAN_FRONTEND=noninteractive in your environment | 09:03 |
pstolowski | mvo: ack, thanks! | 09:04 |
pedronis | mvo: we are back with 50+ mins runs | 09:16 |
pedronis | not sure what changed | 09:16 |
mvo | pedronis: its strange, the results are uneven it seems, some finish in 35min but others overrun quite a bit | 09:17 |
Chipaca | I'd put 2¢ on it being images now being old and having to update a lot of stuff | 09:17 |
pedronis | Chipaca: mmh, how do we get the 35 mins run tough? | 09:18 |
pedronis | shouldn't image updating be a constant | 09:18 |
pedronis | or are we saying network perf is very uneven? | 09:18 |
Chipaca | pedronis: I am | 09:18 |
Chipaca | I'm not sure if it accounts for the whole of it, but it's an important chunk when doing qemu runs | 09:18 |
Chipaca | (and my network at home is pretty good at not being variable) | 09:19 |
mvo | pedronis: yeah, that seems plausible - I think Chipaca is on something, iirc cachio was doing the updates only semi-automatic | 09:19 |
Chipaca | "Chipaca is on something" only coffee i swear | 09:20 |
Chipaca | and maybe too little sleep | 09:20 |
pedronis | mvo: yes, we need to find a way to have both automatic and safe | 09:20 |
pedronis | I think the "safe" part was why they aren't automatic | 09:20 |
* mvo nods | 09:20 | |
pedronis | Chipaca: you are working on the epochs PR, right? | 09:21 |
Chipaca | pedronis: yes | 09:21 |
pedronis | ok | 09:21 |
Chipaca | pedronis: the "have one refresh fail and two others succeed" test is failing all of them | 09:21 |
Chipaca | pedronis: so i'm having "fun" | 09:21 |
pedronis | we all having "fun" I fear, different sort of "fun" | 09:22 |
mvo | indeed, so much fun | 09:23 |
mvo | signal handling in unix ftw | 09:23 |
Chipaca | mvo: you sound like the lispers from the unix hater's handbook :-) | 09:25 |
mvo | Chipaca: thats how I feel! | 09:27 |
Chipaca | mvo: old and crusty and smelling slightly of pizza? | 09:28 |
Chipaca | that's what my copy of it was at least | 09:28 |
Chipaca | :-) | 09:28 |
mvo | Chipaca: hahahaa | 09:28 |
mvo | Chipaca: yeah, except the smell is more of tea but otherwise quite close | 09:29 |
* Chipaca hugs mvo | 09:29 | |
Chipaca | mvo: you'll get through it, i'm sure | 09:29 |
* mvo hugs Chipaca | 09:29 | |
mvo | Chipaca: yeah, its just … oh well | 09:29 |
Chipaca | yeah | 09:30 |
* mvo drinks more to get through it | 09:30 | |
* mvo really likes his tea today | 09:30 | |
mwhudson | signal handling and threads are no fun | 09:33 |
mwhudson | and go means mandatory threads | 09:33 |
juliank | mvo: Is snapd installing the apt integration on all releases? I think the apt side is only available in bionic+ now, but it will probably migrate back to older releases shortly; though, I don't think it will work correctly for snapd purposes on trusty | 10:17 |
juliank | (IIRC, on the the trusty backport, it can't figure out which packages were not found, but I'll have to do some digging) | 10:18 |
mvo | juliank: we install the hook everywhere, I can disable it on trusty if that is a problem | 10:22 |
juliank | I think it will just do nothing, but I'll test it before doing any SRUing | 10:23 |
mvo | juliank: thank you | 10:31 |
zigford | Wondering if someone could help me get snaps working on Gentoo. I've had it going before, but now setting it up on a new machine and have some kind of issues with apparmor profiles | 10:35 |
zigford | I'm getting the following message: snap-confine has elevated permissions and is not confined but should be. Refusing to continue to avoid permission escalation attacks | 10:36 |
zigford | i see /snap/core/6350/user/lib/snapd/snap-confine and **snap-confine//mount-namespace-capture-helper listed ad being in enforce mode when running "aa-status" | 10:38 |
zigford | snap version is 2.36.1, series 16, kernel 4.20.6 | 10:38 |
zigford | only errors I see in journalctl for snapd is: Apparmor is enabled but some features are missing, dbus, netwok | 10:40 |
zigford | and some stuff about the executable not containing a buildid | 10:41 |
Chipaca | zigford: I'd suggest using the forum for this | 10:45 |
Chipaca | zigford: for one, because the people that can help you might be busy right this instant | 10:45 |
Chipaca | zigford: for two, because then people can find it written down the next time :-) | 10:46 |
pstolowski | pedronis: wrt to ensureUniqueName/proposedName bit, are you ok if in the existing PR i only extract this code into a helper as you suggested, and we will iterate on the details in a followup? | 10:46 |
zigford | I'm okay with waiting, I can leave IRC open for a few days. But i agree with you on the second point. | 10:47 |
pedronis | pstolowski: yes, assuming we can iterate relatively quickly | 10:47 |
zigford | I will update my 'Snaps on Gentoo' blog post when I find the answer for others too. But the forums are probs way more discoverable than my little blog | 10:47 |
Chipaca | zigford: forum.snapcraft.io is the forum i meant fwiw | 10:48 |
zigford | gotcha | 10:48 |
pstolowski | pedronis: yes, should be quick | 10:52 |
pstolowski | ty | 10:52 |
Chipaca | pstolowski: https://forum.snapcraft.io/t/log-snapd-and-btrfs-message/9809 | 10:53 |
Chipaca | pstolowski: is that something you know about? udevmon.go thing | 10:53 |
pstolowski | Chipaca: yes. i was wondering if it's going to create a lot of noise. not a bug, just noise for virtual devices that get removed and that we didn't know about | 10:54 |
pstolowski | maybe it should be DEBUG, although initially i wanted to be sure we are not missing something important | 10:55 |
pedronis | mvo: not urgent, when will edge contain prepare-image --classic that landed yesterday? | 10:56 |
pstolowski | Chipaca: i'll reply | 10:57 |
pedronis | mvo: #6474 is green | 10:58 |
mup | PR #6474: snap-confine: fix classic snaps for users with /var/lib/* homedirs (2.37) <Created by mvo5> <https://github.com/snapcore/snapd/pull/6474> | 10:58 |
Wimpress | zyga pedronis Please, can you remind me what the status of layouts is in snapd? | 11:05 |
mvo | pedronis: hm, depending on timing either today or tomorrow its trivial for me to kick it | 11:05 |
pedronis | Wimpress: they are not behind a flag anymore, they might not be supported directly (without passthrough) in snapcraft for something without tough, that's a snapcraft question, it's one of our most complex features so I do expect some bugs still | 11:10 |
pedronis | *without base: | 11:10 |
Wimpress | So layouts require `base:`? | 11:10 |
pedronis | Wimpress: as I said, may be, you can passthrough them tough | 11:11 |
pedronis | if you don't have one | 11:11 |
pedronis | Wimpress: a question for snapcraft | 11:11 |
zigford | https://forum.snapcraft.io/t/troubleshooting-snap-confine-and-apparmor-on-gentoo/9812 | 11:13 |
Chipaca | zigford: <3 | 11:13 |
Chipaca | zigford: where does that funky version string come from? | 11:14 |
Wimpress | degville: See my question above regarding layouts. Is there documentation for how to use layouts? | 11:14 |
pedronis | mvo: no, not urgent just wondering | 11:15 |
Chipaca | zigford: asked in the forum to keep the conversation in one place :-D | 11:15 |
degville | Wimpress: https://docs.snapcraft.io/snap-layouts/7207 | 11:16 |
Wimpress | degville: Excellent! Thank you :-) | 11:16 |
mborzecki | troubles with the store? | 11:17 |
mborzecki | https://status.snapcraft.io doesn't seem to work here | 11:18 |
popey | degville: fyi, I just ninjaed the 'snap version' out of https://forum.snapcraft.io/t/installing-snap-on-opensuse/8375 | 11:20 |
popey | because no other distro install guide has it, seemed unnecessary | 11:20 |
Wimpress | mborzecki: All green from here. Store appears to be working for me. | 11:20 |
degville | popey: yep, ok. makes sense. maybe the colon too :) | 11:21 |
zigford | Chipaca: What's funky about the version string? What should it look like? | 11:21 |
popey | on it | 11:21 |
degville | thanks! | 11:21 |
popey | np | 11:21 |
mvo | pedronis: I updated 6466 - I added some more comments there, for me the sanity timeout thing is dubious, details in the PR | 11:33 |
mvo | pedronis: but also not relevant for the particular PR | 11:34 |
pstolowski | pedronis: addressed/responded to your 1st pass feedback on #6465 ; now working on a followup for the slot naming | 11:35 |
mup | PR #6465: overlord/ifacestate: hotplug-add-slot handler <Hotplug 🔌> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6465> | 11:35 |
mvo | pedronis: added another comment to 6466 and will stop for now on this one | 11:44 |
mup | PR snapd#6475 closed: packaging: disable systemd environment generator on 18.04 (2.37) <Created by pedronis> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/6475> | 11:53 |
mup | PR snapd#6474 closed: snap-confine: fix classic snaps for users with /var/lib/* homedirs (2.37) <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6474> | 12:04 |
pedronis | mvo: I reviewed #6466 | 12:19 |
mup | PR #6466: cmd/snap-confine: handle death of helper process <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/6466> | 12:19 |
mvo | pedronis: thank you | 12:37 |
pedronis | pstolowski: thx, I queued to re-review hotplug-add-slot , have some other (older) things to review first plus 2.37.x stuff | 12:39 |
pedronis | though | 12:40 |
Chipaca | mvo: did you see the thing about wekan? | 12:44 |
mup | PR snapcraft#2459 closed: catkin plugin: describe how to build all packages <Created by kyrofa> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2459> | 12:46 |
Son_Goku | mvo, niemeyer, zyga, uhh | 12:51 |
Son_Goku | we have a problem | 12:51 |
ogra | nah ... | 12:51 |
ogra | you have a "challenge" | 12:51 |
Son_Goku | MongoDB is being removed from Fedora is a bit of a problem | 12:51 |
Son_Goku | the mgo driver currently depends on it | 12:52 |
Son_Goku | which is a snapd dependency | 12:52 |
* ogra wonders why snapd would depend on a database driver | 12:53 | |
* Son_Goku shrugs | 12:53 | |
ogra | sounds like a failure | 12:53 |
Son_Goku | I think it uses the mgo driver's bson and json code | 12:53 |
ogra | ah | 12:54 |
Son_Goku | and it's only in one place: errtracker | 12:54 |
Chipaca | time to vendor bson | 12:54 |
Son_Goku | well, niemeyer wrote the driver | 12:55 |
Chipaca | Son_Goku: why's mongo being removed from fedora? the licensing thing? | 12:55 |
Son_Goku | yes | 12:55 |
Son_Goku | Debian is doing the same thing, btw | 12:55 |
Son_Goku | and this will affect snapd in the same manner | 12:55 |
ogra | yeah, the license | 12:55 |
Chipaca | Son_Goku: mgo wrote it but afaik no longer maintains it | 12:56 |
ogra | this is the year of the mongodb snap ! | 12:56 |
Son_Goku | fuck mongodb | 12:56 |
Chipaca | Son_Goku: er, i meant gustavo, not mgo. I wish mgo wrote things. | 12:56 |
Son_Goku | haha | 12:56 |
Chipaca | that "mongodb is webscale" youtube thing never ever got old | 12:56 |
niemeyer | Yeah, that was part of the problem.. I was trying to convince it to write itself but didn't work | 12:56 |
Son_Goku | XD | 12:57 |
Chipaca | https://www.youtube.com/watch?v=b2F-DItXtZs | 12:57 |
mborzecki | off to pick up the kids | 13:04 |
sil2100 | mvo: hey! Once you're back from lunch, just a quick question: we'll be spinning .2 bionic core18 point-release images soonish, is snapd 2.37.1 from stable good-enough for the new images? | 13:06 |
Chipaca | sil2100: I don't have an answer, but I absolutely love that question | 13:10 |
=== ricab is now known as ricab|lunch | ||
mpt | Hi, I’m looking for a description of the default snap update frequency. is there anything clearer than the “within 6 hours” on <https://docs.snapcraft.io/getting-started/3876>? | 13:17 |
mpt | LOL the snap man page gets narrower and narrower until it’s one word per line | 13:19 |
cjwatson | It does? I don't see that here | 13:23 |
cjwatson | (up-to-date bionic) | 13:24 |
cjwatson | mpt: https://forum.snapcraft.io/t/system-options/87 maybe? | 13:25 |
Chipaca | sparkiegeek: thank you for reminding me about how much license sucks | 13:26 |
Chipaca | mpt: which manpage where? | 13:26 |
sparkiegeek | Chipaca: you're not wrong | 13:26 |
Chipaca | sparkiegeek: i commented on the bug, mostly with a "yeah sucks" | 13:27 |
Chipaca | sparkiegeek: but it's a whole-stack suckage, if that helps ¯\_(ツ)_/¯ | 13:27 |
mpt | cjwatson, perfect, thanks | 13:27 |
sparkiegeek | Chipaca: well... it doesn't :D | 13:27 |
mpt | Chipaca, “man snap” for snap 2.37.1 on Ubuntu 14.04 | 13:27 |
mpt | I’m reporting a bug now | 13:27 |
Chipaca | mpt: could you also do | 13:28 |
Chipaca | mpt: snap help --man | man -l - | 13:28 |
Chipaca | mpt: and report whether that looks any better? | 13:28 |
mpt | Chipaca, same result | 13:28 |
Chipaca | mpt: https://i.redd.it/yl57urxpoje21.jpg | 13:29 |
* sparkiegeek reloads https://twitter.com/mptbugs | 13:29 | |
mpt | 🔜 | 13:30 |
cjwatson | Super-confused; extracting the man page manually on pepo and piping to man -l - doesn't show that | 13:31 |
Chipaca | ooh ooh | 13:32 |
Chipaca | mpt: snap help --man < /dev/null | man -l - | 13:32 |
Chipaca | mpt: how does that one work | 13:32 |
mpt | Chipaca, same result | 13:33 |
Chipaca | aww | 13:33 |
Chipaca | mpt: I'm all out of "thanks i hate it" images | 13:33 |
Chipaca | cjwatson: 14.04? | 13:34 |
cjwatson | Yes. Trying a container now | 13:34 |
Chipaca | cjwatson: 2.37.1? | 13:35 |
cjwatson | Yes. Trying a container now :) | 13:35 |
Chipaca | cjwatson: trying a container now? | 13:35 |
* Chipaca runs | 13:35 | |
cjwatson | I sure am | 13:35 |
sparkiegeek | Chipaca: if you want to help move the license handling forward, I believe we still need a response to https://forum.snapcraft.io/t/snap-license-metadata/856/52 | 13:35 |
Chipaca | sparkiegeek: dang | 13:36 |
Chipaca | sparkiegeek: let's blame niemeyer | 13:36 |
sparkiegeek | Chipaca: we all do :D | 13:36 |
Chipaca | pedronis: could you pick that up ^ ? | 13:37 |
mpt | https://bugs.launchpad.net/snapd/+bug/1814767 | 13:38 |
mup | Bug #1814767: “man snap” gets narrower and narrower until it’s 1 word/line <snapd:New> <https://launchpad.net/bugs/1814767> | 13:38 |
cjwatson | Oh yes, now I see it | 13:39 |
pedronis | Chipaca: we had a discussion in december how to go a bit forward, but no work on it is planned for right now | 13:39 |
cjwatson | This is surely a groff bug or something, but how was I previously unaware of something like that | 13:42 |
mpt | So this is the kind of Postel’s Law thing that turns into two bugs? | 13:43 |
cjwatson | Oh, it's due to the doubled .TP lines | 13:43 |
mpt | One on groff and one on the man page | 13:43 |
cjwatson | I think the meaning of two .TP lines in a row is probably not especially well-defined | 13:43 |
cjwatson | https://git.savannah.gnu.org/cgit/groff.git/commit/?id=49abd7a9093ae903bb0032eb74d647fb481d2acb | 13:44 |
pedronis | mvo: #6473 is green, I do think we do want it | 13:45 |
mup | PR #6473: snap-confine: remove special handling of /var/lib/jenkins <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6473> | 13:45 |
pedronis | mvo: the description/commit needs updating tough | 13:45 |
cjwatson | left a diagnosis in 1814767 | 13:45 |
Chipaca | cjwatson: thank you | 13:46 |
* mpt applauds | 13:46 | |
Chipaca | we already do nasty things to get that manpage, I guess removing excess TP won't be that bad | 13:46 |
cjwatson | For good measure I manually stripped out the doubled .TP requests and confirmed that that fixes it | 13:47 |
Wimpress | zyga pedronis We discussed GPU issues when building snaps against core18. I've been testing the last few days, and so far can't reproduce the issues using snapd 2.37.x | 13:48 |
Wimpress | So far xonotic and ffmpeg migrated to core18 and tested using nvidia and intel on the host. | 13:49 |
Wimpress | Just letting you know, because that bug I said I would file might not be required now. | 13:50 |
pedronis | Wimpress: ah, I was wondering, I don't see anything we did that actively would have fixed something | 13:50 |
pedronis | but not sure | 13:50 |
pedronis | when zyga is around he might chime in on this | 13:51 |
Wimpress | We do have some failures, but we're investigating because it may not be snapd related. | 13:51 |
Wimpress | Getting ffmpeg working gives me good confidence since it uses all the accelerated capabilities. | 13:52 |
cjwatson | Chipaca: Might be easier to just fix it in go-flags? | 13:52 |
sergiusens | mvo: hey, do you have any experience with aborted tasks from spread? I get aborted, I understand the reason from the docs on why it is good, I just cannot find a reason for it happening | 13:52 |
Chipaca | cjwatson: go-flags author is burstily responsive, and getting the right version everywhere is very slow | 13:53 |
cjwatson | Oh :( | 13:53 |
Chipaca | cjwatson: I'm also wanting to give go-flags support for generating manpages in sections other than 1 | 13:54 |
Chipaca | need to revisit the pending PRs and see why they haven't been merged | 13:54 |
pedronis | Chipaca: btw, could you do a first pass over https://github.com/snapcore/snapd/pull/6079 when you have a bit of time | 13:56 |
mup | PR #6079: cmd/snap: `snap connections` command <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6079> | 13:56 |
sparkiegeek | "Channel latest/beta for multipass is closed; temporarily forwarding to beta." - huh? I guess snapd is not resolving the "lack of track == 'latest'" when interpreting closed channels | 14:24 |
Chipaca | sparkiegeek: that should be fixed in … 2.37? 2.38? | 14:25 |
Chipaca | one of those | 14:25 |
sparkiegeek | Chipaca: ok, well that was from 2.37.1 | 14:33 |
* sparkiegeek fights Chipaca in #1814640 | 14:34 | |
mup | Bug #1814640: snap info showing "unset" license for snaps <snapd:Confirmed> <Snap Store:Invalid> <snapd (Ubuntu):New> <https://launchpad.net/bugs/1814640> | 14:34 |
hunterk | mborzecki: are you available for a couple of questions about getting vulkan working in snaps? | 14:39 |
=== ricab|lunch is now known as ricab | ||
mup | PR snapcraft#2457 closed: lifecyle: avoid installation of snaps in docker <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2457> | 14:44 |
mborzecki | hunterk: i'm hardly an expert, but feel free to ask | 14:46 |
hunterk | kk, no worries :) I'm just trying to get the vulkan renderer in my snap, RetroArch, to work: https://forum.snapcraft.io/t/problem-with-vulkan-support-in-snaps/9744 | 14:47 |
hunterk | as it is, I always get "failed to open vulkan loader", which is the same error I get outside of the snap if I don't have the right libs installed | 14:47 |
hunterk | but I have them listed in the build and stage packages, so I'm not sure if there's anything else I need to do to make them visible/accessible to the snap | 14:48 |
jdstrand | pedronis: fyi, https://bugs.launchpad.net/snapstore/+bug/1814592/comments/5 | 14:53 |
mup | Bug #1814592: cannot compile personal-files/system-files snap declaration constraints <Snap Store:New> <https://launchpad.net/bugs/1814592> | 14:53 |
pedronis | jdstrand: I answered | 14:53 |
jdstrand | pedronis: I just pressed Enter on my comment to your answer... | 14:54 |
jdstrand | pedronis: ie, look at comment $5 | 14:54 |
jdstrand | #5 | 14:54 |
pedronis | jdstrand: we cannot do that change | 14:54 |
pedronis | jdstrand: you need a regexp using | for the multiple entry case | 14:54 |
pedronis | jdstrand: as I said for a list attribute the regexp needs to much all entries | 14:55 |
jdstrand | pedronis: I know that is the current implementation, but do you acknowledge the awkwardness of the current situation? | 14:56 |
jdstrand | pedronis: this should've come up in PR review for the interfaces. We've never had an attribute that is a list of strings | 14:56 |
jdstrand | pedronis: I mean, we can mark it Won't Fix and just use the awkward syntax if you want | 14:57 |
pedronis | jdstrand: no, we thought about lists | 14:57 |
mup | PR snapd#6476 opened: cmd/snap: tweak man output to have no doubled up .TP lines <Simple 😃> <Created by chipaca> <https://github.com/snapcore/snapd/pull/6476> | 14:57 |
Chipaca | mpt, cjwatson ^ | 14:58 |
pedronis | it's really designed that for a list the regexp needs to matches all entries | 14:58 |
mpt | \o/ | 14:58 |
pedronis | jdstrand: we don't have exact check on lists but we shouldn't not really design something that needs them | 14:58 |
pedronis | as you said is then awkard if you remove things | 14:58 |
pedronis | jdstrand: anyway as also said most of this in the bug itself | 14:58 |
cjwatson | Chipaca: LGTM, thanks | 15:00 |
cjwatson | not that my Go is exactly fluent | 15:00 |
pedronis | jdstrand: so yes from my POV is a won't fix, if you think we should really do something (but as I said is not trivial) we can talk at the sprint | 15:02 |
jdstrand | pedronis: I'm reading the design doc and it seems to indicate that my interpretation would be supported. there is even an example that describes a case that matches my 'awkward if you remove things' | 15:03 |
jdstrand | page 4, "Please note that this logic may be applied also at the top-level. For example:" | 15:03 |
mvo | we need a second review for 6473 and 6466 | 15:04 |
pedronis | jdstrand: If the slot or plug attribute value is a list, every element of the list must match the provided regexp. | 15:04 |
jdstrand | pedronis: regardless, the awkwardness of not matching when the snap drops a path is probably enough for this conversation | 15:04 |
pedronis | jdstrand: sorry I understand your readin, that logic = alt interpretation | 15:05 |
pedronis | that's at least how I read it | 15:05 |
pedronis | I don't understand | 15:05 |
jdstrand | that doc has always been confusing to me on this point | 15:06 |
jdstrand | "If the constraint itself is specified as a list, though, it carries a different meaning" | 15:07 |
jdstrand | it doesn't matter though, the 'Granted' part of my statement is enough to not do what the bug is suggesting so I'll adjust | 15:08 |
pedronis | jdstrand: to be clear I'm not saying that this is not awkward sometimes, but is not unworkable or not fitting how we intended interfaces to use attributes usually | 15:11 |
jdstrand | pedronis: that's fine. I look at this like once every 6 months and didn't write the spec or the snapd code so it isn't completely internalized so when something new comes up, I have to reread. parts of that document I find unclear at times | 15:14 |
jdstrand | the review-tools will need an update unfortunately | 15:14 |
mvo | Chipaca: can I interest you in 6466 and 6473 :) | 15:16 |
Chipaca | mvo: probably | 15:19 |
jdstrand | mvo (cc Chipaca) I reviewed PR 6466 (approved) | 15:22 |
mup | PR #6466: cmd/snap-confine: handle death of helper process <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/6466> | 15:22 |
Chipaca | jdstrand: mvo: so did I :-p | 15:26 |
mup | PR snapd#6466 closed: cmd/snap-confine: handle death of helper process <⚠ Critical> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6466> | 15:31 |
mup | PR snapd#6473 closed: snap-confine: remove special handling of /var/lib/jenkins <⚠ Critical> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6473> | 15:32 |
mvo | Chipaca: \o/ | 15:33 |
* mvo hugs Chipaca and jdstrand | 15:33 | |
* Chipaca takes those hugs to the bank | 15:33 | |
* jdstrand hugs mvo and Chipaca (group hug!) | 15:35 | |
* zyga joins the group hug | 15:42 | |
zyga | back from the hospital, | 15:43 |
* jdstrand hugs zyga | 15:43 | |
jdstrand | zyga: I hope everything is ok! | 15:43 |
zyga | jdstrand: yeah just unfortunate to get cold when the newborn is coming home | 15:43 |
zyga | jdstrand: unless something changes they will be back tomorrow | 15:44 |
* jdstrand nods | 15:44 | |
jdstrand | zyga: I don't think I said congrats. congrats! | 15:44 |
mup | PR snapcraft#2461 opened: tests: disable legacy runs driven by the python test runner <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2461> | 15:44 |
zyga | thank you, mom did all the hard work :) | 15:44 |
jdstrand | heh :) | 15:44 |
* mvo hugs zyga | 15:47 | |
cwayne | congratulations zyga!! | 15:49 |
zyga | thank you :) | 15:49 |
pstolowski | hey zyga! congratulations! | 15:53 |
zyga | thank you all :) | 15:53 |
pstolowski | pedronis: what do you think about https://paste.ubuntu.com/p/HCj5cdpZtd/ ? the last string in each row is the name returned by hotplugSlotName helper for the inputs on the left? | 16:25 |
pedronis | pstolowski: seems in the right direction | 16:26 |
mup | PR snapd#6477 opened: cmd/snap, overlord/snapstate: silently ignore classic flag when a snap is strictly confined <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6477> | 16:27 |
mborzecki | mvo: ^^ | 16:27 |
mvo | mborzecki: \o/ thank you | 16:30 |
mvo | mborzecki: and approved with tiny nitpicks, if pedronis or someone else would have a look at 6477 that would be awesome | 16:36 |
pedronis | mvo: I reviewed it, I'm also interested if others have opinion where the warning should go (after or before), Chipaca maybe? | 16:38 |
pedronis | Chipaca: talking about #6477 for clarity | 16:44 |
mup | PR #6477: cmd/snap, overlord/snapstate: silently ignore classic flag when a snap is strictly confined <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6477> | 16:44 |
mup | PR snapd#6478 opened: overlord/ifacestate: tweak logic for generating unique slot names <Hotplug 🔌> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6478> | 16:53 |
=== pstolowski is now known as pstolowski|afk | ||
Chipaca | pedronis: pushed rerefreresh | 17:28 |
pedronis | Chipaca: thanks, any opinion on the warning placement in 6477 | 17:31 |
Chipaca | pedronis: before, as you said | 17:33 |
pedronis | ok, we agree | 17:33 |
Chipaca | we do the same with the path warning | 17:34 |
pedronis | Chipaca: yes, this is targeted at 2.37.2 | 17:34 |
pedronis | btw | 17:34 |
Chipaca | :+1: | 17:34 |
pedronis | mborzecki: thanks for addressing the feedback quickly | 17:41 |
pedronis | mvo: now we need 6477 to get green | 17:41 |
mvo | pedronis: indeed, I will baby sit it (while listening to jamiroquai | 18:28 |
cwayne | I don't know what that was ^ but I love it | 18:51 |
mborzecki | mvo: pushed a little fix there | 18:57 |
mvo | mborzecki: ta | 18:59 |
mvo | cwayne: people were making fun of me because apparently I look in a HO like these guys in the video - anyway… :) | 19:01 |
cwayne | hahaha oh that makes it so much better | 19:03 |
mborzecki | mvo: tough luck, the osx job fails for some reason https://travis-ci.org/snapcore/snapd/jobs/489189315 | 19:43 |
mup | PR snapcraft#2461 closed: ci: use non virt-enabled gce instances for 16.04 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2461> | 19:48 |
Chipaca | mborzecki: looks like yaml doing 1.10 -> 1.1 | 20:47 |
Chipaca | mborzecki: OSX build and minimal runtime sanity check | 20:47 |
Chipaca | Go: 1.1 | 20:47 |
mborzecki | Chipaca: yeah, but it didn't happen earlier today | 20:47 |
Chipaca | mborzecki: it's not happened until right now :-) | 20:48 |
mborzecki | Chipaca: imo travis guys have deployed a new 'feature' | 20:48 |
Chipaca | mborzecki: I'd laugh if I didn't need to quote version strings in snapcraft.yaml | 20:52 |
mborzecki | Chipaca: hm that may be a good idea | 20:53 |
mborzecki | heh, let's see how that goes | 20:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!