[06:07] <mborzecki> morning
[06:44] <zyga> Hello
[06:58] <mborzecki> zyga: hey
[07:03] <zyga> Hey :-)
[07:03] <zyga> Thank you for the archlinux update
[07:05] <mborzecki> zyga: wa debian updated too?
[07:21] <zyga> Yes
[07:41] <mborzecki> heh go linters stopped working when i switched to 1.12
=== pstolowski|afk is now known as pstolowski
[08:08] <pstolowski> morning
[08:09] <zyga> Hey
[08:33] <mup> PR snapd#6487 closed: interfaces: add new intel-mei interface <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/6487>
[08:33] <mborzecki> pstolowski: hey hey
[08:38] <zyga> 2nd coffee
[08:49] <mup> PR snapd#6554 opened: interfaces/intel-mei: small follow up tweaks <Created by pedronis> <https://github.com/snapcore/snapd/pull/6554>
[09:01] <zyga> plan for this weekend:
[09:01] <zyga> sleeeeep
[09:01] <zyga> and bike ride
[09:01] <zyga> pedronis: we are all good on 2.37.4 so far
[09:02] <zyga> pedronis: I will work with cachio and mvo next week on ubuntu release and bug gardening
[09:03] <zyga> let's get back to branches and patches
[09:07] <mborzecki> heh, looks like master will be failing with arch due to go1.12 update
[09:08] <zyga> what's the status?
[09:10] <greyback> hi folks, can I get another pair of eyes on https://github.com/snapcore/snapd/pull/6281 please? I've a jamie +1 already
[09:10] <zyga> certainly
[09:10] <mup> PR #6281: interfaces: add Multipass-support interface <Created by gerboland> <https://github.com/snapcore/snapd/pull/6281>
[09:10] <zyga> looking
[09:11] <mborzecki> zyga: i'll open a PR in a bit
[09:12] <zyga> greyback: I'm going through the review again
[09:12] <pstolowski> pedronis: hey, i'm addressing mvo's comment to #6322 re a new helper; what do you think about applyChanges for its name? https://paste.ubuntu.com/p/Ngv3yyR6qv/
[09:12] <mup> PR #6322: overlord/hookstate: apply pending transaction changes onto temporary configuration for snapctl get <Complex> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6322>
[09:12] <zyga> greyback: as a general comment please ensure that all questions are answered
[09:12] <zyga> greyback: even if the answer is +1 or done or "no longer applicable"
[09:12] <greyback> zyga: ah ok
[09:12] <zyga> this helps when there are multiple comments
[09:13] <zyga> it is easier to see the status this way
[09:13] <pedronis> pstolowski: looks ok, I would swap its arguments though
[09:13] <pstolowski> pedronis: ok
[09:16] <zyga> greyback: I'm sure it is fine, I'm sorry for asking for some responses or clarifications
[09:16] <zyga> greyback: it helps me since I was not involved with the review and design as deeply as Jamie was
[09:16] <greyback> zyga: not at all
[09:16] <greyback> happy to clarify anything I can
[09:17] <zyga> I will read the full diff enxt
[09:17] <zyga> *next
[09:27] <mup> PR snapd#6555 opened: tests/main/high-user-handling: fix the test for Go 1.12 <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6555>
[09:51] <pedronis> degville: thanks for looking at my new interface doc,  are you at the office? did John joined in the end or not?
[09:52] <degville> pedronis: yep, I'm in the office. John isn't here.
[09:56] <pedronis> degville: thx
[09:58] <zyga> greyback: done
[10:01] <zyga> pstolowski: hey, the description on https://github.com/snapcore/snapd/pull/6552 has some unusual formatting, is that intentional?
[10:01] <mup> PR #6552: ifacestate/tests: fix/improve udev mon test <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6552>
[10:36] <mborzecki> can we land #6555 ?
[10:36] <mup> PR #6555: tests/main/high-user-handling: fix the test for Go 1.12 <Simple 😃> <⚠ Critical> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6555>
[10:36] <zyga> yes
[10:36] <zyga> lets
[10:36] <zyga> pedronis: ^
[10:42] <mborzecki> or pstolowski maybe ^^ ?
[10:48] <pedronis> merged
[10:49] <mup> PR snapd#6555 closed: tests/main/high-user-handling: fix the test for Go 1.12 <Simple 😃> <⚠ Critical> <Created by bboozzoo> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/6555>
[10:49] <mborzecki> pedronis: thanks!
[10:50] <pedronis> mborzecki: it was not clear from the descr that it was for a failing test though and not local to some people
[10:54] <zyga> mborzecki, pedronis: some idea on https://github.com/snapcore/snapd/pull/6485#pullrequestreview-209527174
[10:54] <mup> PR #6485: interfaces/seccomp: regenerate changed profiles only <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6485>
[10:55] <mborzecki> zyga: yeah, that's what we discussed with mvo
[10:55] <zyga> ah, that's great
[10:55] <zyga> I think it is an easy win for some performance
[10:55] <zyga> ah, I see now
[10:56] <zyga> +1 on that :)
[10:56] <zyga> pedronis: do you think you will have some time to look at https://github.com/snapcore/snapd/pull/6502 today?
[10:56] <mup> PR #6502: dirs,overlord/snapstate: add Soft and Hard refresh checks <Created by zyga> <https://github.com/snapcore/snapd/pull/6502>
[10:56] <mborzecki> zyga: another win would be not forking to run snap-seccomp, but that probably has more constraints
[10:56] <zyga> yeah
[10:56] <zyga> but that's more complex
[10:56] <zyga> I have some ideas
[10:56] <zyga> but not for a minor change
[10:57] <pedronis> zyga: not today,  monday, I prioritized a bit 2.38 stuff
[10:57] <zyga> sounds good, thank you
[10:57] <zyga> I'm going through reviews
[10:58] <pedronis> (and long outstanding store stuff)
[10:58] <zyga> understood
[11:17] <zyga> https://github.com/snapcore/snapd/pull/6482/files seems like a low hanging fruit
[11:17] <mup> PR #6482: [RFC] cmd/snap: make 'snap list' show disabled snaps dimmed <Created by chipaca> <https://github.com/snapcore/snapd/pull/6482>
[11:22] <pedronis> I'm very undecided about it
[11:23] <pedronis> atm
[11:23] <zyga> should we mark it as blocked?
[11:23] <pedronis> it's cute but then is another thing that we need to consistently everywhere
[11:25] <pedronis> I'm closing it for now with a comment
[11:26] <mup> PR snapd#6482 closed: [RFC] cmd/snap: make 'snap list' show disabled snaps dimmed <Created by chipaca> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/6482>
[11:41] <mup> PR snapd#6548 closed: release: snapd 2.37.4 <Created by mvo5> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/6548>
[12:16] <mborzecki> Chipaca is off today, isn'the?
[12:16] <zyga> I think so
[12:16] <zyga> I think I should burn my holidays
[12:17] <mborzecki> pedronis: i've updated the snap connections branch
[12:20] <mborzecki> ok, now the bpf branch
[12:21] <mborzecki> there should be a button on github that'd allow merging master to a PR
[12:21] <zyga> yeah
[12:21] <zyga> or rebase
[12:23] <pedronis> mborzecki: I need to comment on the plan there (the bpf branch)
[12:24] <mborzecki> pedronis: ok
[12:27] <pedronis> mborzecki: done, asked a couple of questions on the plan
[12:35] <pedronis> mborzecki: oops, sorry I should have commented before,  we probably want printing the deprecation warning in a separate PR (to go with early 2.39, not 2.38)
[12:36] <mborzecki> pedronis: ok, i'll revert the patch then
[12:45] <pstolowski> zyga: thanks for looking at hotplug test PR!
[12:52] <zyga> the greengrass PR is complex
[12:52] <zyga> but almost done
[12:54] <pedronis> mborzecki: thanks for reverting that bit, feel free to propose a PR with just it
[12:58] <pstolowski> zyga: re hotplug test, is there a better way than 'test -w ...' than doesn't require real writes to serial port?
[12:58] <zyga> pstolowski: I doubt it
[12:58] <pstolowski> and that would fail on cgroup
[12:58] <zyga> pstolowski: maybe reverse the test
[12:58] <zyga> pstolowski: write when you expect it to fail
[12:58] <zyga> and look for faiure
[12:59] <zyga> *failure
[12:59] <zyga> *failure
[13:01] <pstolowski> zyga: would be better to test positive scenario as well. i think qemu serial port allows read/writes, need to investigate
[13:01] <zyga> I'm sure they do
[13:01] <zyga> perhaps the output goes to a file on the host?
[13:01] <mborzecki> off to pick up the kids
[13:01] <pstolowski> zyga: yeah i think you can redirect it wherever you want
[13:01] <mup> PR snapd#6556 opened: cmd/snap: hide 'interfaces' command, show deprecation notice <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6556>
[13:31] <zyga> brb, tea time ahead of the standup
=== ricab is now known as ricab|lunch
[13:57] <degville> pedronis / zyga: I'm not going to be able to make it to the standup - still in discussions n the office.
[13:58] <pedronis> degville: ok
[14:00] <zyga> degville: ack thank you
[14:02] <zyga> pedronis: are you able to attend the standup today?
[14:12] <zyga> mborzecki: please cherry pick the fix to 2.37 in case we need more releases, easier while we remember about the issue
[14:21] <mup> PR snapd#6557 opened: tests/main/high-user-handling: fix the test for Go 1.12 (2.37) <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6557>
[14:21] <mborzecki> zyga: ^^
[14:28] <zyga> thank you
[14:30] <zyga> mborzecki: I started looking at the selinux branch
[14:30] <zyga> I will review it carefully but I need to take the dog out first because it's very late already
[14:30] <zyga> mborzecki: I left a few comments
[14:30] <zyga> two small actions: cleanup functions please
[14:30] <zyga> I'll be back in 30-40 minutes
[14:30] <mborzecki> zyga: thanks, will take a look
[14:30] <zyga> pedronis: I didn't give my update but I was mainly doing reviews, forum and yesterday release work
[14:31] <zyga> pedronis: the issue with personal files is interesting, it's just a hidden assumption, I will have some more thoughts on the forum about that
[14:33] <pedronis> zyga: sorry
[14:33] <pedronis> zyga: thanks
[14:33] <pedronis> zyga: I created the card
[14:48]  * cachio afk
=== ricab|lunch is now known as ricab
[15:04] <jdstrand> pedronis and zyga: responded to/addressed all feedback in https://github.com/snapcore/snapd/pull/6549, but please see my comments wrt 2.38
[15:04] <mup> PR #6549: apparmor: support AppArmor 2.13 <Created by jdstrand> <https://github.com/snapcore/snapd/pull/6549>
[15:07] <pstolowski> mborzecki: do you have a moment? would be nice to land https://github.com/snapcore/snapd/pull/6552
[15:07] <mup> PR #6552: ifacestate/tests: fix/improve udev mon test <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6552>
[15:10] <mup> PR snapd#6281 closed: interfaces: add multipass-support interface <Created by gerboland> <Merged by jdstrand> <https://github.com/snapcore/snapd/pull/6281>
[15:23]  * mborzecki off to the swimming pool
=== chrisccoulson__ is now known as chrisccoulson
[15:52] <mup> PR snapd#6552 closed: ifacestate/tests: fix/improve udev mon test <Simple 😃> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6552>
[16:18] <zyga> I need to take a nap see you later
[16:24] <kyrofa> roadmr, I got a "Task 40048685-93b9-49b7-96b6-83dabd1d83bb failed" on a nextcloud snap (that's the error-- no review issues, just a job failure) that causes all other uploads to fail with  "Waiting for previous upload(s) to complete their review process". That really sucks
[16:26] <kyrofa> Jobs are going to fail sometimes. I get it. But it shouldn't require manual intervention from the snap dev to get back up and running
[16:26] <roadmr> kyrofa: which manual intervention did you need to do?
[16:29] <roadmr> kyrofa: ah, "reject and remove from review queue" probably
[16:35] <kyrofa> Yeah, and re-spin all the builds that failed to upload
[18:12] <mup> PR core#103 opened: hooks: apt warning should return an error <Created by townsend2010> <https://github.com/snapcore/core/pull/103>
[19:22]  * cachio EOW
[19:46] <lborda> hey I built a simple reproducer for a bug while trying to create a snap for cdk collector logs... have you ever experienced this issue ? https://github.com/lborda/snap-bug/issues/1
[20:02] <mup> PR snapd#6554 closed: interfaces/intel-mei: small follow up tweaks <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/6554>
[20:13] <mup> PR snapd#6494 closed: interfaces/builtin/udev: add spec to disable udev + device cgroup <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/6494>
[21:58] <mup> PR snapcraft#2493 opened: Specify default expiration time for export-login <Created by felicianotech> <https://github.com/snapcore/snapcraft/pull/2493>
=== bloodearnest_ is now known as bloodearnest
=== Dmitrii-Sh_ is now known as Dmitrii-Sh
=== davdunc_ is now known as davdunc
=== tomwardill_ is now known as tomwardill
=== pstolowski_ is now known as pstolowski
=== PaulW2U_ is now known as PaulW2U
=== niemeyer_ is now known as niemeyer
=== kenvandine_ is now known as kenvandine
=== diddledan_ is now known as diddledan
=== tedg_ is now known as tedg
=== jamespage_ is now known as jamespage
=== plars_ is now known as plars
=== zyga_ is now known as zyga
=== nottrobin_ is now known as nottrobin
=== hfjvjffju_ is now known as hfjvjffju