/srv/irclogs.ubuntu.com/2019/03/14/#snappy.txt

zygaGood morning05:41
mborzeckimorning06:31
zygaHey mborzecki :-)06:39
mborzeckizyga: hey06:45
mborzeckizyga: simple review ? https://github.com/snapcore/snapd/pull/659606:46
mupPR #6596: spread: restore SELinux context when we mess with system files <SELinux> <Simple πŸ˜ƒ> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6596>06:46
zygaOn it06:50
zygaDone06:52
mborzeckizyga: thanks06:52
zygaHello mvo07:15
mvohey zyga07:19
mborzeckimvo: hey07:24
zygaγ˜γ‚ƒγ‚γΎγŸ07:25
zygaThat was what you asked about last time07:25
mvohey mborzecki07:26
mvozyga: !!!07:26
mvozyga: amazing07:26
mvozyga: looking forward for you teaching me some more07:26
zygaI’ll be around shortly07:29
mvohey sil2100 ! quick question - can we get https://launchpad.net/ubuntu/bionic/+queue?queue_state=1&queue_text=systemd into core18 via your foundations ppa maybe? this way we can run our regression test (and full suite) with the fix just like we did with xenial07:43
=== pstolowski|afk is now known as pstolowski
pstolowskimorning08:04
mvohey pstolowski08:04
zygaHey Pawel08:14
mborzeckimvo: https://www.viva64.com/en/b/0600/08:22
mborzeckizyga: ^^08:22
mborzeckipstolowski: hey08:22
mvomborzecki: looks good, we should try it08:23
zygaApplied08:27
zygaThank you08:27
=== chihchun_afk is now known as chihchun
pedronismvo: couple of Q/comments on 6401  , I didn't notice but we are trying not to add anymore to api.go, see recent work by Chipaca and me08:37
mvopedronis: oh, ok. I have a look, I missed that. thank you08:39
Chipacamvo: i'd gladly pick that up if you're otherwise busy08:42
* Chipaca dreading the merge-the-health-checks work08:42
Chipaca:-)08:42
mvoChipaca: yeah, that is welcome08:42
Chipacaok08:42
mvoChipaca: \o/08:42
* mvo tries to tame wait-chains right now08:43
pedronisChipaca: did you update the Reason: scheduled one?08:44
pedronisand morning08:44
Chipacafirst i'll address pedronis's comment on #659808:44
mupPR #6598: overlord/snapstate, store: set a header when auto-refreshing <Created by chipaca> <https://github.com/snapcore/snapd/pull/6598>08:44
Chipacapedronis: morning08:44
Chipacapedronis: i'd written up to # and went looking for the number :-)08:44
Chipacapedronis: it's just the flag -> opt thing, right?08:45
pedronisChipaca: there's a suggested if reorg as well08:45
Chipacapedronis: or do you want me to also do the cleanups of things that were already there?08:45
pedronisChipaca: ideally also the cleanups, yes08:45
Chipaca(that'll make the diff bigger, meaning less chance convincing pedronis it's minimal and can go in 2.38 :-p)08:46
pedronisChipaca: you can do a follow up instead08:46
pedronisbut it would be good to address them08:47
Chipacapedronis: your call, I don't mind if this doesn't make 2.38 :-)08:47
pedronisChipaca: either maybe the if, but the rename should be rather innocuous08:50
pedronisChipaca: I mean, I don't think the diff will be that much bigger08:50
pedronisthe biggest addition are the tests in fact08:50
Chipacai wonder why we decided rate limit would be an int64 (and not a uint64)08:50
pedronisChipaca: no clue, I don't think I reviewed that code08:51
pedronisChipaca: it starts with ParseByteSize returning int6408:52
pedronis(but that doesn't support -5b)08:52
pedronisChipaca: anyway that is a bigger change08:53
pedronisnot for this one08:53
pedronisChipaca: but yes, it makes one wonder if rateLimit can be -12808:53
Chipacatotally08:53
ChipacaI'll change things around a little, hopefully for the better, and push a change to make the rate thing not be negative separately08:54
ChipacaParseByteSize doesn't support negative numbers more by accident than by design i fear08:54
pedronisChipaca: do negative sizes make sense though?08:54
Chipacano08:54
ChipacaI mean, they might be used in the kernel or something to indicate errors08:55
Chipacabut for our use, no08:55
Chipaca(and our use of ParseByteSize is purely about rate limiting)08:55
* dot-tobias waves hello09:04
Chipacapedronis: reqOptions() -> downloadReqOpts() ok with you?09:10
pedronisChipaca: yes, it is used in download and connectivity check, right?09:11
Chipacapedronis: yes, and in conn check it's used for the download endpoint09:13
pedronisyup09:13
zygahey Chipaca :)09:17
* zyga is happy despite the rainy day09:17
Chipacazyga: morning sah :-)09:18
zygaChipaca: brexit makes my sleeping pattern erratic09:23
Chipacazyga: welcome to my world09:23
zygaChipaca: on the up side, the current state, as chaotic as it is, feels like an improvement over last few weeks09:23
zygaChipaca: at least from far away here, I don't know how it feels to be directly affected09:24
Chipacazyga: I'm refusing to get my hopes up, but my favourite outcome is still in the race09:24
mvoChipaca: I did an unrelated change (unrelated to the api layout we discussed) you may need to git pull for 640109:24
Chipacamvo: will do09:24
pedronismvo: thank you for adding that check09:33
mvomy pleasure09:34
Chipacapedronis, mvo, pushed to 640109:44
Chipacamaybe i should've pushed two commits09:44
mvoChipaca: thank you!09:44
Chipacainstead of one with two changes09:44
Chipacahm09:44
Chipacapedronis: again not daemon_test package because apiBaseSuite is a beast09:45
pedronisChipaca: that's ok, we can look into that at some point09:45
pedronisbut at least the beasts are not growing09:45
Chipacay09:45
Chipacayes09:45
Chipacaogra: you around?10:07
mborzecki#6596 is one unlucky PR10:07
mupPR #6596: spread: restore SELinux context when we mess with system files <SELinux> <Simple πŸ˜ƒ> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6596>10:07
mborzeckithe travis job just keeps on failing and failing, either github, or store timeout, or some from-repo package installation taking too long10:08
ograChipaca, in a meeting, so half way ...10:08
=== chihchun is now known as chihchun_afk
ackkhi, I'm trying to build a core18 snap with multipass, but it seems to just hang there after starting the vm. if I "multipass shell" in it, I don't see anything running. how can I debug this?10:15
mvopedronis: quick question (if you have a moment) - in doUpdate we merge a bunch of taskSets and the "edge" information (DownloadAndChecksDoneEdge) gets lot - one approach would be to transfer edges in ts.AddAll(anotherTs), I drafted this in http://paste.ubuntu.com/p/tDJf9XbTGg/ would love to hear your thoughts http://paste.ubuntu.com/p/tDJf9XbTGg/10:15
mvo(ups, sorry for the same url twice)10:16
=== chihchun_afk is now known as chihchun
mborzeckiguys, so how about we land https://github.com/snapcore/snapd/pull/6270 ?10:23
mupPR #6270: data/selinux, tests: refactor SELinux policy, add minimal tests <SELinux> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6270>10:23
pedronismvo: Chipaca: I made a help suggestion in 640110:24
pedronismvo: it's a bit problematic because some edges might not make sense in the larger task set10:24
mvopedronis: I can also just transfer the edge over in doUpdate explicitely10:24
mvopedronis: thats the simplest one10:25
mvopedronis: its slightly annoying that this area of code has to have knowledge about this though10:25
mvopedronis: or I can try to rework the way doUpdate is using []*TaskSet but that seems to be hard10:25
mvopedronis: anyway, would love some ideas :)10:26
pedronismvo: let me look at the code10:26
mborzeckipedronis: updated #659310:26
mupPR #6593: sandbox/seccomp: a helper package wrapping calls to snap-seccomp <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6593>10:26
pedronismvo: I think it would be fine to have  separate AddAllWithEdges (my point is mostly tha whether to copy them over, rename them around etc needs to be conscious decision)10:32
mvopedronis: ok - with the same error handling as is in there already? i.e. error on dupes?10:35
pedronismvo: yes10:35
mvopedronis: great, thank you! I make this happen10:35
Chipacapedronis: a problem with that help message is that AIUI it breaks https://forum.snapcraft.io/t/convention-for-command-help-text/185610:35
pedronisChipaca: fix it10:36
Chipaca:-)10:36
Chipacapedronis: the docs, or the help message :-D10:36
pedronisChipaca: I mean the original was saying too little10:36
Chipacaa'ight10:36
pedroniswe need something that respect the style guide10:36
pedronisbut also tells more10:37
pedronismborzecki: what's the difference between InternalToolPath and the helper? I'm obtuse10:38
mborzeckipedronis: in that PR none, in the final one InternalToolPath won't work because it assumes it's either distro libexecdir or a path under snap-mount-dir10:39
mborzeckipedronis: and in bootstrap the mount path is none of the 2 locations10:39
pedronismborzecki: does it mean InternalToolPath is broken?10:41
pedronisI mean are we sure it doesn't it this issue in some cases10:41
mborzeckipedronis: i wouldn't say it's broken, it's more like there is an assumption that snapd is installed in the system in some way, which is true in general, but not true during bootstrap10:43
Chipacahuh, Nonce is missing or invalid10:44
ackkdoes snapcraft keep any state other than the usual (parts/ stage/ prime/) dirs when run in --destructive-mode ?10:44
pedronismborzecki: are we failing generate key during bootstrap, I see similar code10:46
pedronisthere10:46
pedronismborzecki: findSnapdPath10:47
mborzeckipedronis: that code is correct10:48
mborzeckipedronis: it does not fall back to filepath.Join(dirs.DistroLibexecDir,...)10:49
mborzeckipedronis: perhaps an update to InternalToolPath would make sense10:49
mborzeckipedronis: after all if the tool is 'internal' it's supposed to be where snapd binary is10:50
pedronisafaict it does fallback10:50
pedronismaybe I'm reading it wrong10:50
pedronisanyway I'm a bit worried about all this places doing slightly different with self/exe10:50
Chipacapedronis: I just split it :-)10:53
* Chipaca context-switches pedronis for fun & profit10:54
mborzeckihaha10:54
pedronismborzecki: if I read correctly we do a full seeding with snapd running from the tmp dir10:54
mborzeckipedronis: yes10:54
pedronisso any place is potentially buggy10:54
mborzeckiyup, fortunately it's only system key and seccomp at this point10:54
pedroniswell, no10:54
pedronisthere's a place using InternalToolPath10:55
pedronismaybe it's buggy10:55
pedronisor not10:55
dot-tobiasCan I somehow check how snapd reads my gadget.yaml by invoking some CLI command? I have a default configuration that has to be fed to the configure hook as a string, but it really is a YAML file thus should preserve line breaks.10:55
mborzeckipedronis: haha :P10:56
Chipacadot-tobias: have you looked at what the online yaml parser makes of it?10:56
Chipaca(was it you i showed that one to yesterday?)10:56
mborzeckipedronis: i'd say that in the general case we should just do filepath.Dir(Readlink("/proc/self/exe")) and use that10:57
pedronismborzecki: interfaces/mount/ns.go10:57
mborzeckipedronis: unless realdink fails, in which case fallback to distro libexecdir may be ok10:57
pedronismborzecki: the code is not like that though, in most of these places10:58
pedronisthey all check mount dir10:58
dot-tobiasChipaca: Yes, I was the one from yesterday 😊 I checked and it preserves line breaks as \n, but feeding this to mir-kiosk (display-config can be set as a string) results in an erroneous miral-kiosk.display file with newline printed as literal \n10:59
Chipacadot-tobias: can you show me?10:59
mborzeckipedronis: at least for the seccomp tool, I updated this here https://github.com/snapcore/snapd/pull/6485/files#diff-a5ed6485262fae2e80ad61a8b843504eR6811:00
Chipacadot-tobias: to answer your question directly, there isn't a way to do that right now11:00
mupPR #6485: interfaces/seccomp: regenerate changed profiles only <β›” Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6485>11:00
pedronismborzecki: I have a bit lost track of why the check11:01
dot-tobiasChipaca: Sure, here's the current gadget.yaml: https://gitlab.com/glancr/gadget-snap-pi-kiosk/blob/master/gadget.yaml#L1211:01
pedroniswe probably need to talk with mvo11:01
mborzeckipedronis: a chat then?11:01
pedronisyes11:01
mborzeckimvo: ^^11:01
mborzeckipedronis: mvo: HO?11:02
mvomborzecki: in a meeting right now11:02
mborzeckimvo: ok, once you're finished then?11:02
dot-tobiasChipaca: If I run "snap set mir-kiosk display-config="$(cat a config file with the exact same contents)", everything works fine. But I suspect the multiline string from gadget.yaml is mangled somewhere.11:02
dot-tobiasChipaca: I can't really check what the actual result is from the device intialization as snapd errors (mir-kiosk configure hook can't parse the mess it gets from the yaml default) and rolls back. I occasionally check on-device but I'm always either too early or too late to see the actual file created 😞11:05
Chipacadot-tobias: which 'actual file created'?11:06
Chipacadot-tobias: (i'm not super familiar with this part of the code :) )11:06
=== chihchun is now known as chihchun_afk
dot-tobiasChipaca: mir-kiosk's configure hook saves display-config to a file in $SNAP_DATA/miral_kiosk.display (cf. https://github.com/MirServer/mir-kiosk/blob/ad041e6b19205acacaf9881568061d8fd5a5742e/snap/hooks/configure#L29).11:08
Chipacaright, but the first boot config isn't done from the file11:08
Chipacait's done from reading the snap.yaml11:08
Chipacadot-tobias: let me load and dump that yaml file and see what snapd makes of it11:09
dot-tobiasChipaca: That would be great, thank you. Correct me if wrong, but I thought that the gadget setup was roughly this: boot > mir-kiosk snap is installed from prefetched .snap, including any default config > gadget.yaml is read for default settings > snapd basically runs β€œsnap set snap-name some-setting=specified-value-from-gadget.yaml – if that's the case, I don't quite follow your statement about first boot config11:12
Chipacadot-tobias: snapd does basically run snap set …11:12
Chipacadot-tobias: but the file comes after 'snap set', not before11:13
Chipacadot-tobias: so if the file has mangled \n's, it's because whatever called the equivalent of 'snap set' did it wrong11:13
Chipacadot-tobias: and the codepath is simple enough that it's _probably_ reading it wrong in the first place but idunno11:14
Chipacagetting there11:14
Chipacadot-tobias: the problematic config is display-config, yes?11:14
dot-tobiasChipaca: I guess we're talking about the same thing, but not sure πŸ˜„11:14
dot-tobiasChipaca: yes, display-config is the one I'm trying to set.11:15
Chipacathe config is loaded jus' fine11:16
Chipacaso the problem is in the setting of it11:16
Chipacahmm11:16
Chipacaoh wait what is this normalize code11:17
dot-tobiasChipaca: Yes, I suspect that the gadget.yaml multiline string is parsed somewhere and passed to β€œsnap set” with literal \n newlines, which mir-kiosk's configure hook does not further parse or validate (just echoes the passed string to miral-kiosk.display) – thus resulting in one long string with literal \n instead of a valid YAML dict11:18
Chipacaindeed11:19
dot-tobiasChipaca: And that's the part where I don't know if β€œI'm holding it wrong” or if preserving a config file with implicit newlines (dunno if that's the correct term) through this whole YAML parsing is currently just not possible. 😊11:22
Chipacadot-tobias: so, there's a bug, this should work11:23
Chipacadot-tobias: we should fix it11:23
Chipacadot-tobias: but that doesn't unblock you11:23
Chipacadot-tobias: however, there's a way out for you11:23
Chipacai hope11:23
Chipacadot-tobias: but it's a bit nasty11:23
dot-tobiasChipaca: I'm all for nasty workarounds if they do the job until the elegant way is possible 😊11:24
Chipacadot-tobias: rewrite the config file yaml using the json-like syntax11:26
Chipacadot-tobias: gimme a sec i'll do it for you11:26
mupPR snapd#6596 closed: spread: restore SELinux context when we mess with system files <SELinux> <Simple πŸ˜ƒ> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6596>11:26
Chipacadot-tobias: layouts: {normal: {cards: [{card-id: 0, HDMI-A-1: null}]}, right: {cards: [{card-id: 0, HDMI-A-1: {orientation: right}}]}, left: {cards: [{card-id: 0, HDMI-A-1: {orientation: left}}]}, inverted: {cards: [{card-id: 0, HDMI-A-1: {orientation: inverted}}]}}11:29
Chipacadot-tobias: no comments in this format :-/11:29
Chipacapedronis: pstolowski: we have some issue with spurious escaping of config values coming from gadget.yaml11:30
dot-tobiasChipaca: Can live without comments for now. Thank you very much! So I put that into gadget.yaml > defaults > display.config as a string?11:30
Chipacadot-tobias: yes11:30
Chipacadot-tobias: let me know if it actually works of course :-)11:31
Chipacapedronis: pstolowski: meaning the snaps get \\n instead of \n for ex11:31
dot-tobiasChipaca: Will do, thank you!11:32
pedronisChipaca: escaping where?11:32
mborzeckipedronis: mvo: can we land #6270?11:33
mupPR #6270: data/selinux, tests: refactor SELinux policy, add minimal tests <SELinux> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6270>11:33
Chipacapedronis: the Configure hook that's run using the values from the gadget.yaml11:33
pedronisChipaca: yes11:34
pedronisChipaca: where is the escaping,   snapctl get? or before?11:34
pedronisor it's misunderstanding about what the result is11:35
Chipacapedronis: the loading seems to be fine, no spurious escaping11:35
Chipacapedronis: I don't know where it's happening, don't have an easy way to repro11:35
pedroniswe do need a repro11:36
* pedronis lunch11:36
Chipacapedronis: I mean, dot-tobias was hitting this IRL11:36
Chipacapedronis: I mean I don't have a _minimal_ way to reproduce it that doesn't involve a gadget and a device and first-booting it11:37
Chipacafortunately there's a workaround for them, as it's yaml so you can just scrunch it up (ewww), but if it'd been an .ini file we would've been SOL11:37
pedronisChipaca: we do have spread test like that11:37
pedronisI mean we should be able to write a spread test11:38
ChipacaI know :-) i'm saying I haven't -- I was trying to make it SEP11:38
pedronisChipaca: did we learn anything more about the 19.40 seeeding woes?11:42
pedronis19.0411:42
* pedronis really lunch11:42
Chipacapedronis: I'm trying to reproduce them locally11:43
Chipacas/them/it/11:43
Chipacathem == the woes, clearly11:43
Chipacaright now I'm struggling to get a new disco install to _boot_, let alone be snappy11:45
Chipacatwo different icons for installation, with arrows pointing different ways11:46
ograChipaca, so what was that ping about ?11:49
Chipacaogra: who knows :-)11:53
ograheh11:53
mvohrm, hrm, whats up with tests11:55
mvoogra: while you are here - you probably like https://launchpad.net/ubuntu/bionic/+queue?queue_state=1&queue_text=systemd11:55
mvoogra: we just need to convince someone from the sru team to actually approve :)11:56
ograYAY !!!11:56
mvomborzecki: you wanted to talk about something earlire? sorry was in a meeting and then forgot11:56
mborzeckimvo: yes, we need pedronis too11:57
mvohey sil2100 ! quick question - can we get https://launchpad.net/ubuntu/bionic/+queue?queue_state=1&queue_text=systemd into core18 via your foundations ppa maybe? this way we can run our regression test (and full suite) with the fix just like we did with xenia11:57
mvomborzecki: probably after lunch, what was the question?11:57
mvoand why are tests unhappy currently :( ?11:57
mborzeckimvo: some concerns about finding internal tools11:58
mvomborzecki: ok, so - for snapd its easy, just os.dirname(os.link("/proc/self/exe"))11:59
mvomborzecki: but for the "snap" binary its not12:00
mvomborzecki: I think we need to lookup something (snap-exec?) there12:00
mvomborzecki: maybe the answer is that the toolpath is also just relative for the snap binary "../lib/snapd"12:01
mvomborzecki: am I actually speaking about the right question or am I lost in something else :) ?12:01
mborzeckimvo: ../lib{exec}/snapd12:01
mborzeckimvo: right, we were discussing the case of 'snapd' and cmd.InternalToolPath which does not work for boostrap environment12:02
mvomborzecki: yeah, for snapd my suggestion is to always look into the same dir12:02
mvomborzecki: and maybe (to support running from a git tree) to fallback to /usr/lib{,exec}/snapd12:03
mvomborzecki: but for snap its slightly more complicated12:03
sil2100mvo: hey! Let me take a look12:04
mupPR snapd#6599 opened: snapstate,state: add TaskSet.AddAllWithEdges() and use in doUpdate <Created by mvo5> <https://github.com/snapcore/snapd/pull/6599>12:05
sil2100mvo: hm, I can review it today for -proposed and then copy it over to the PPA for testing (with a lower version)12:05
mvosil2100: cool, let me know if I can help in any way (but I probably don't have the right permissions)12:06
=== chihchun_afk is now known as chihchun
mborzeckimvo: i can try and open a PR cleaning up cmd.InternalToolPath/findSnapdPath/seccompToBpfPath to be consistent12:10
pedronisChipaca: do we understand enough from dot-tobias situation to make a LP bug?12:12
mvomborzecki: I think that would be good12:12
mvomborzecki: maybe a separate PR?12:12
Chipacapedronis: I think so yes12:12
mborzeckimvo: right12:12
Chipacadot-tobias: could you do that? file an lp bug about this12:12
pedronisChipaca: could you make one?12:12
pedronisor dot-tobias12:12
Chipacapedronis: trying to punt it :-)12:12
pedronismborzecki: yes, simplifiying would be good12:12
pedronismborzecki: mvo: do we compute  system key from snap ? or only from snapd?12:13
mborzeckipedronis: only snapd apparently12:13
pedronisok12:13
pedronismborzecki: no, both, snap run uses SystemKeyMismatch12:15
pedronisso findSnapdPath is abit more delicate12:15
pedronisafaict12:15
mborzeckipedronis: right, but only snapd build-id is used in the system key data12:16
pedronismborzecki: well and snap-seccomp output in your PRs? no?12:16
mborzeckiyes12:16
* pstolowski lunch12:24
sil2100mvo: ok, bionic looks good, accepted for bionic-proposed12:25
seb128Chipaca, where do you see those inconsistant arrows for installation?12:25
Chipacaheh12:26
sil2100I will copy it to the PPA but please please please shepherd the bionic-proposed systemd upload12:26
Chipacaseb128: https://snapforum.s3.amazonaws.com/original/2X/6/6db33b0da7456be46210985f939a0e2040284e6b.jpg12:26
seb128Chipaca, did you sort out your non booting image? maybe worth mentioning on #ubuntu-desktop12:26
seb128if you need help figuring it out12:26
sil2100mvo: systemd uploads trigger a lot of tests and a lot of failures and the uploader needs to make sure they pass and/or are identified as flaky12:26
Chipacaseb128: it was booting, just not doing anything graphic12:26
jdstrandpedronis: can you advise on what to do about https://travis-ci.org/snapcore/snapd/jobs/505983378?12:26
sil2100Wouldn't want this upload to be stuck in bionic forever12:26
seb128Chipaca, ah, thx12:26
Chipacaseb128: -vga qxl fixed that12:26
seb128Chipaca, ah, good12:27
Chipacaseb128: https://forum.snapcraft.io/t/no-more-preinstalled-snap-on-ubuntu-19-04/10339/49?u=chipaca12:27
jdstrandpedronis: hello btw :)12:27
Chipaca(just writing random stuff there as i try to repro the issue at hand)12:27
jdstrandpedronis: sergiusens said something about a rebase, but I thought that would confuse github12:28
pedronisjdstrand: did you see my comment on why it's blocked?  (it was about the tests, I think we talked about it but I forgot to write the reason in the PR)12:28
seb128Chipaca, ah, tb didn't charge the image from the email for some reason, I see it now, the 'other arrow' on the desktop is because it's a symlink, it's a bit unfortunate how it 'conflicts' with the icon own arrows placed in the same corner12:28
* jdstrand doesn't have 'zyga@xenial' anywhere in the tree12:29
Chipacaseb128: if it didn't, then it'd have two opposite arrows :-)12:29
seb128Chipaca, Ken didn't get the issue every time, might be racy, so I guess "how you reproduce' is by trying a new install again12:29
zygajdstrand: does git log do?12:29
zygajdstrand: it's the history12:29
Chipacaseb128: yep12:29
jdstrandpedronis: I thought you said it could go in so long as tests came later. you want the tests now?12:29
seb128Chipaca, right :)12:29
pedronisjdstrand: sorry, it was not about the tests12:29
pedronisjdstrand: please read the comment in the PR12:29
jdstrandzyga: 'does git log do'? can you rephrase?12:30
pedronisand answer there12:30
zygajdstrand: run git log | grep zyga@xenial12:30
jdstrandpedronis: "I agree though with niemeyer comments regarding the summaries, we probably want to change those before merging." I did that12:30
jdstrandzyga: yes, I have that:12:31
jdstrandAuthor: zyga <zyga@xenial-server>12:31
jdstrand    Signed-off-by: zyga <zyga@xenial-server>12:31
zygathe author needs to be changed12:31
Chipacaevery time I try gnome shell i miss the keyboard-friendliness of unity :-(12:31
=== ricab is now known as ricab|lunch
* Chipaca hugs his 16.04 to his chest12:31
pedronisjdstrand: this comment: https://github.com/snapcore/snapd/pull/5644#issuecomment-47272388312:32
mupPR #5644: interfaces: add audio-playback/audio-record and make pulseaudio manually connect <β›” Blocked> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/5644>12:32
pedronisfrom this morning12:32
jdstrandzyga: uhh, everyone has to do this?12:32
zygajdstrand: perhaps I misunderstand but this is in an incoming PR?12:32
zygajdstrand: if so,  just that needs to change12:32
dot-tobiasChipaca / pedronis : I'll open a LP bug (for snapd?) and try to describe the problem as detailed as possible; Chipaca feel free to make amends if I misunderstood the actual issue (but at least I can describe what the outcome is)12:33
pedronisjdstrand: we can work on landing it on our side12:33
Chipacadot-tobias: thanks!12:33
pedronisjdstrand: I'm still interested if what I described is a blocker or not12:33
jdstrandpedronis: I answered in the PR. I don't consider it a blocker since at worst I will see things come into the queue and manually approve them/grant the snap decl while I'm working through all the grants12:36
jdstrandpedronis: but if you do, then I can try to get to it. it's several hundred so it will take me a while12:37
pedronisjdstrand: what I'm worried is if somebody installs with snapd beta one of the affected snaps before the declaration is changed12:37
jdstrandzyga: it isn't a new PR, it is an ancient PR at this point that all of a sudden started failing that cause I did a git fetch/merge12:38
pedroniswill not the install fail?12:38
pedroniswell, not fail12:38
pedronisbut not work until it connects things manually12:38
pedroniswhich is not expected12:38
jdstrandyes, that would happen12:39
jdstrandthat is a fair point12:39
* jdstrand doesn't understand how all of a sudden 92a096278e040b452125260b00742ae6e62caf2c from October is now causing me problems12:41
ackkSaviq, hi, how can I debug what snapcraft is doing inside a multipass vm?12:41
ackkSaviq, I'm trying to figure out why a snapcraft build seems to hang after having launched the vm12:42
jdstrandzyga: ^ why am I seeing this now and why doesn't master change it so that no one else will be affected?12:42
zygajdstrand: I don't understand, can you tell me where exactly are you seeing it?12:43
jdstrandzyga: https://travis-ci.org/snapcore/snapd/jobs/50598337812:43
zygajdstrand: I see your ping now, sorry for the interrupt12:43
zygajdstrand: wow, no idea now12:45
jdstrandperhaps tests/lib/cla_check.py should ignore that email if people don't want to rewrite history. how is this passing for anyone?12:45
zygano idea, it's odd12:45
jdstrandpedronis: oh, this is all set for 2.39 anyway. that's right. I was thinking as soon as it was committed, I'd get started, do 50 a day or something12:46
jdstrandChipaca: hey, you seem to have written ./tests/lib/cla_check.py12:47
zygajdstrand: sorry I was not of much help12:48
jdstrandChipaca: after a recent fetch/merge with master for an existing PR, I started seeing https://travis-ci.org/snapcore/snapd/jobs/50598337812:48
zygajdstrand: perhaps do a test: rebase and open a new PR12:48
zygajdstrand: if that passes it's a data point12:48
Chipacajdstrand: huh12:48
jdstrandChipaca: the email address that is failing is from 92a096278e040b452125260b00742ae6e62caf2c october12:49
Chipacajdstrand: should be easy to fix12:49
Chipacajdstrand: somehow :-|12:49
Chipacajdstrand: I mean, should be easy to fix the script to catch that exception12:50
jdstrandChipaca: I mean, I can adjust the author with a git rebase, but is that the right thing to do? why aren't others seeing this? (granted, my pr started before october, so maybe the check was added after that and I'm only seeing this cause I'm the only one with commits that stretch that far back?)12:50
Chipacajdstrand: I don't know why it's trying to verify an email already on master though12:50
Chipacahmm12:50
Chipacaoh12:51
zygathis branch predates october12:51
zygais that the reason?12:51
Chipacajdstrand: there's been a change in travis.yaml that might be relevant12:51
Chipacaor was that in snapcraft12:51
Chipacalooks like it was just in snapcraft12:51
jdstrandChipaca: at this point I'm happen to be told what to do and I'll mash buttons like a monkey :)12:52
jdstrandhappy*12:52
Chipacajdstrand: http://paste.ubuntu.com/p/QdXzftpW3b/12:53
Chipacajdstrand: that might help12:53
jdstrandpedronis: please advise since this is for 2.39 if I need to slog though all of them or can go at my own pace12:53
* Chipaca ⇝ lunch12:54
pedronisjdstrand: I would recommend to start12:54
jdstrandpedronis: well there is starting and there is slogging so the PR is unblocked. it sounds like you mean the latter12:55
sergiusensjdstrand: we rebase all the time in snapcraft, github is really saavy, it even mentions you rebased in the  PR... the only drawback is when you amend new code from the PR (problem for the reviewer, not github), but stuff that is in master is usually fine12:56
jdstrandChipaca: that shange seems unrelated to my PR and should be in a separate PR. I don't know why that is fixing things or what side effects it may have so am uncomfortable proposing it12:56
jdstrandsergiusens: when you say rebase, what are you saying, change the order so the merges happen before my stuff?12:57
jdstrandsergiusens: or are you saying change the author12:58
jdstrand?12:58
sergiusensgit rebase origin/master (it will even remove the merge commit)12:58
pedronisjdstrand: sorry, I would prefer not to buy a conscious regression, we already have our fair share of unconscious ones12:58
jdstrandpedronis: well, since it is for 2.39, I don't need to drop everything, so I'll go at whatever pace works for me and that makes it commitable for 2.3912:59
sergiusensjdstrand: here's an example of a rebase https://github.com/snapcore/snapcraft/pull/2479 (search for force-pushed)12:59
mupPR snapcraft#2479: store: support registering to a specific store <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2479>13:00
pedronisjdstrand: that sounds good13:00
pedronismborzecki: btw to be clear I don't thik that cleanup should block 6593 but is good to have a plan forward for that area13:07
mborzeckioff to pick up the kids13:09
jdstrandsergiusens: that's fine, and I use rebase all the time. I was wondering what you were specifically suggesting since I have gotten several suggestions. I think I know what to try13:10
dot-tobiasChipaca / pedronis: Filed https://bugs.launchpad.net/snapd/+bug/1820060 β†’ let me know if it's clear enough13:17
mupBug #1820060: multiline strings in gadget.yaml defaults are mangled <snapd:New> <https://launchpad.net/bugs/1820060>13:18
ackk sergiusens, hi, I have a snapcraft build that's been stuck for ages at "Launched: <vm>", it seems nothing is happening in the VM itself, how can I debug that?13:19
mupPR snapd#6600 opened: timings: add new helpers, Measurer interface and DurationThreshold <Created by stolowski> <https://github.com/snapcore/snapd/pull/6600>13:19
dot-tobiasIs there a command I can run to retry a failed change? My system init change (gadget snap) is failing and I want to retry so that I can inspect some files which are deleted as soon as it err's13:25
jdstrandpedronis, Chipaca, zyga, sergiusens: ok, just a simple rebase was enough to put the PRs changes on top (and after the problematic commit) and make cla check happy13:29
zygawoot :)13:35
Chipacazyga: just seen news that A50 is blocked13:42
Chipacazyga: thought you might like to hear that13:42
kenvandineChipaca: well... today's iso seems fixed!13:43
willcookeChipaca, using the great troubleshooting method of "maybe it will just fix itself" kenvandine and I have tested with today's ISO and everything is back to normal.13:43
kenvandineno idea what the hell was up with the past few days13:43
willcookeII'll keep testing and make sure it's reliable13:43
willcookeSorry for the wild goose chase13:43
kenvandinei noticed the iso size is a little different13:43
Chipacakenvandine: willcooke: from the description it was a race, so i'd expect it to come back in the same way13:43
mvosil2100: thanks for accepting13:44
mvosil2100: I will watch out for it13:44
Chipacakenvandine: willcooke: I have been trying to reproduce it, and only saw it happen once in ~20 installs so far13:44
willcookeusing todays iso?13:44
Chipacakenvandine: willcooke: of course that was before i had debug logs so i leraned nothing :-(13:44
kenvandineChipaca: oh... so you have reproduced it?13:44
=== ricab|lunch is now known as ricab
Chipacakenvandine: or something very much like it13:45
Chipacawillcooke: yes13:45
willcookenod13:45
Chipacawillcooke: it _might_ have been something different, but it looked the same :-)13:46
willcooke:)13:46
Chipacathis was before I got systematic about it, after which nothing13:46
willcookeHeisenbug13:46
Chipacado we still have the iso that _did_ have the issue? maybe i should use that one13:46
* willcooke checks his trash13:47
kenvandineso... can we increase the log verbosity in the devel images?13:47
Chipacakenvandine: yes, easily13:47
kenvandineChipaca: yes13:47
willcookeI have it13:47
willcookethe ISO that is13:47
kenvandineit's still up on cdimage13:47
willcookeoh, even better13:47
kenvandinegrab 2019031313:47
Chipacakenvandine: When installing, once it prompts you to restart, before clicking restart edit /target/etc/environment and add SNAPD_DEBUG=113:48
Chipacakenvandine: that will give you debug logs in the install13:48
willcookeI did that yesterday on the broken image and it didnt seem to work13:48
Chipacawillcooke: disco seems to rotate journal a lot more aggressively13:48
Chipacawillcooke: so you need to look in /var/log/syslog13:48
willcookeooooooooh13:49
willcookethanks13:49
kenvandineChipaca: i meant in the future, during the devel cycle we should just turn up the verbosity in the images13:49
Chipaca(which is a pain btw)13:49
kenvandinemaybe up until RC or something13:49
Chipacakenvandine: i'd like that :-)13:49
kenvandinejust so when things like this happen we have a means to debug it13:49
Chipaca<313:49
kenvandineok, i've done 2 installs of today's image and both worked fine13:50
kenvandineand booted the live session 3 times13:50
kenvandineall good13:50
kenvandine:/13:50
Chipacakenvandine: did you ever get this in the live session itself?13:50
kenvandineyes13:51
Chipacanice13:51
Chipaca(for negative values of nice)13:51
Chipacakenvandine: dropping "[Service]\nEnvironment=SNAPD_DEBUG=1 SNAPD_DEBUG_HTTP=7\n" into /etc/systemd/system/snapd.service.d/debug.conf would do that fwiw13:52
mupPR snapd#6601 opened: errortracker: fix panic in Report if db cannot be opened <⚠ Critical> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6601>13:53
zygajoinign14:01
dot-tobiasChipaca: re: Workaround for mir-kiosk config: While JSON-like syntax seems to make it through snapd, mir-kiosk's configure hook expects exactly two spaces (== yaml indentation) and fails otherwise: https://github.com/MirServer/mir-kiosk/blob/ad041e6b19205acacaf9881568061d8fd5a5742e/snap/hooks/configure#L6214:05
dot-tobiasChipaca: So I'm running from one issue into the next πŸ˜„ Will now try if creating the whole file via clout-init happens at the right time (i.e. after the snap has been installed)14:06
Chipacadot-tobias: maybe that one can be fixed from mir-kiosk14:06
dot-tobiasChipaca: I'll open a PR there once I figure out how to check for JSON-like syntax without breaking their (surely sensible) strict grep line in the YAML case. Thanks again so far!14:10
seb128kenvandine, willcooke, I would strongly recommend against thinking around the line of 'oh, we did nothing, it's fixed in today's daily, let's move on', that's going to bite us back in release week14:16
kenvandineseb128: i agree14:16
mupPR # closed: snapd#5644, snapd#5822, snapd#5915, snapd#6108, snapd#6177, snapd#6238, snapd#6258, snapd#6270, snapd#6325, snapd#6327, snapd#6329, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6401, snapd#6404, snapd#6410, snapd#6418, snapd#6436, snapd#6485, snapd#6491, snapd#6502,14:17
mupsnapd#6541, snapd#6553, snapd#6559, snapd#6564, snapd#6575, snapd#6577, snapd#6583, snapd#6588, snapd#6591, snapd#6592, snapd#6593, snapd#6594, snapd#6595, snapd#6597, snapd#6598, snapd#6599, snapd#6600, snapd#660114:17
kenvandinei'm trying to see what's different in the isos14:17
seb128it doesn't matter, does it?14:17
seb128if it's timing and something changed it's not going to tell us anything on fixing14:17
seb128imho someone from the snappy team needs to do an install which has the issue and debug snapd14:17
seb128anything else is a waste of effort14:17
mupPR # opened: snapd#5644, snapd#5822, snapd#5915, snapd#6108, snapd#6177, snapd#6238, snapd#6258, snapd#6270, snapd#6325, snapd#6327, snapd#6329, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6401, snapd#6404, snapd#6410, snapd#6418, snapd#6436, snapd#6485, snapd#6491, snapd#6502,14:18
mupsnapd#6541, snapd#6553, snapd#6559, snapd#6564, snapd#6575, snapd#6577, snapd#6583, snapd#6588, snapd#6591, snapd#6592, snapd#6593, snapd#6594, snapd#6595, snapd#6597, snapd#6598, snapd#6599, snapd#6600, snapd#660114:18
kenvandineseb128: you're probably right14:18
kenvandineChipaca: are you trying the 20190313 iso?14:18
Chipacakenvandine: y14:18
Chipacakenvandine: yes14:18
kenvandinegreat14:18
diddledandoes the desktop team have a channel I can discuss desktop non-snap issues?14:36
mupPR snapd#6270 closed: data/selinux, tests: refactor SELinux policy, add minimal tests <SELinux> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6270>14:39
mborzeckibtw. if you want to see the tests break and get weird errors like "Settle is not converging" you need to build an image with yocto14:45
mupPR pc-i386-gadget#8 closed: Adding empty configure hook to enable configuration for gadget <Created by kubiko> <https://github.com/snapcore/pc-i386-gadget/pull/8>15:17
mupPR pc-i386-gadget#9 closed: Adding empty configure hook to enable configuration for gadget <Created by kubiko> <https://github.com/snapcore/pc-i386-gadget/pull/9>15:17
mupPR snapd#6602 opened: [RFC] cmd, interfaces: replace local helpers with cmd.InternalToolPath() <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6602>15:17
Chipacakenvandine: willcooke: walk with me please15:17
Chipacakenvandine: willcooke: remember when I asked you if any of the seeded snaps were 'base: core18', and you assured me they weren't?15:18
* willcooke puts his shoes obn15:18
mupPR pc-i386-gadget#8 opened: Adding empty configure hook to enable configuration for gadget <Created by kubiko> <https://github.com/snapcore/pc-i386-gadget/pull/8>15:18
mupPR pc-i386-gadget#9 opened: Adding empty configure hook to enable configuration for gadget <Created by kubiko> <https://github.com/snapcore/pc-i386-gadget/pull/9>15:18
Chipacakenvandine: willcooke: this is true of today's image: snap info --verbose /var/lib/snapd/seed/snaps/*  shows no base: core1815:18
Chipacakenvandine: willcooke: this is, however, _not_ true of the 20190313 image15:18
Chipacakenvandine: willcooke: gnome-system-monitor and gnome-calculator in yesterday's image use core1815:19
Chipacaso you need to seed core18 as well, or, well, not :-)15:19
mvo6401 needs a second review15:20
kenvandineChipaca: oh... but the revisions of those that were on the iso did not use core1815:21
mupPR # closed: snapd#5644, snapd#5822, snapd#5915, snapd#6108, snapd#6177, snapd#6238, snapd#6258, snapd#6325, snapd#6327, snapd#6329, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6401, snapd#6404, snapd#6410, snapd#6418, snapd#6436, snapd#6485, snapd#6491, snapd#6502, snapd#6541,15:21
mupsnapd#6553, snapd#6559, snapd#6564, snapd#6575, snapd#6577, snapd#6583, snapd#6588, snapd#6591, snapd#6592, snapd#6593, snapd#6594, snapd#6595, snapd#6597, snapd#6598, snapd#6599, snapd#6600, snapd#6601, snapd#660215:21
kenvandinei confirmed that, they were the old revision15:22
mupPR # opened: snapd#5644, snapd#5822, snapd#5915, snapd#6108, snapd#6177, snapd#6238, snapd#6258, snapd#6325, snapd#6327, snapd#6329, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6401, snapd#6404, snapd#6410, snapd#6418, snapd#6436, snapd#6485, snapd#6491, snapd#6502, snapd#6541,15:22
mupsnapd#6553, snapd#6559, snapd#6564, snapd#6575, snapd#6577, snapd#6583, snapd#6588, snapd#6591, snapd#6592, snapd#6593, snapd#6594, snapd#6595, snapd#6597, snapd#6598, snapd#6599, snapd#6600, snapd#6601, snapd#660215:22
Chipacakenvandine: as I say, in yesterday's iso, the snaps in seed are base:core1815:22
Chipacakenvandine: 'snap info --verbose' on the file says as much15:23
pedronissome of them at least15:23
Chipacatwo of 'em15:23
pedronisyup15:23
Chipacagnome-calculator and gnome-system-monitor15:23
kenvandineChipaca: what revision of gnome-calculator was it?15:23
Chipacakenvandine: the file says 33515:24
kenvandinethat was core1815:24
kenvandinesigh...15:24
pedronis33515:24
kenvandinei was checking those revisions... but that might have been when i was using the iso from 2019030915:24
kenvandinewhich was the iso the original reported used15:24
kenvandinebut... i could never reproduce this problem on that iso15:24
kenvandine:/15:25
mupPR snapd#6603 opened:  snapstate: add new NoReRefresh flag and use in Remodel() <Created by mvo5> <https://github.com/snapcore/snapd/pull/6603>15:25
Chipacakenvandine: I'll comment on the forum, see if it's just been that they downloaded a different one or something15:25
Chipacakenvandine: does an iso 'know' when it was made, anywhere?15:26
kenvandinei think that original report for 20190309 had some other issue...15:26
kenvandineand started misleading us15:26
kenvandineprobably15:26
Chipacakenvandine: perhaps, although by comment #3 it looks a lot like this one15:26
Chipacakenvandine: I'm going to explain what we know so far, and see if that explains the whole thing15:28
kenvandineChipaca: we are going to be publishing the seeded snaps based on core18 to stable in the next couple days :)15:30
kenvandineso we'll need to update the seed15:30
pedroniskenvandine: have you tested the upgrade from old base to new base, somebody reported issues with that (changing the base of a snap over refresh), zyga can tell more15:31
kenvandinei actually just tested that on xenial15:32
* cachio lunch15:32
kenvandinerefreshed from stable to candidate15:32
kenvandinecandidate now has base: core1815:32
kenvandineworked fine15:32
Chipacakenvandine: did you have core18 before refreshing15:33
zygakenvandine: there's a bug where changing bases runs the new revision on the old base15:33
kenvandinei probably did have the old base15:34
kenvandinebut i can test right now15:34
kenvandineChipaca zyga: started out with no core18, refreshed candidate which did pull down core1815:38
kenvandinestill installing :)15:39
=== chihchun is now known as chihchun_afk
kenvandineChipaca zyga: works fine!15:39
kenvandineon disco, installed from today's iso15:40
ChipacaGREAT SUCCESS15:40
kenvandine:)15:40
Chipacapedronis: mvo: should I squash-merge #6598 then?15:42
mupPR #6598: overlord/snapstate, store: set a header when auto-refreshing <Created by chipaca> <https://github.com/snapcore/snapd/pull/6598>15:42
mvoChipaca: last I looked it was two commits, I can cherry pick two :)15:43
mvoChipaca: so either way is fine15:43
Chipacajust regular merge, then15:43
Chipaca:-)15:43
mupPR snapd#6598 closed: overlord/snapstate, store: set a header when auto-refreshing <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6598>15:43
mvo6401 needs a second review15:51
Chipacajdstrand: when you have a sec, could you tell me if I did something wrong wrt icdiff such that I can't install the version from candidate?15:56
Chipacamvo: would it be very cheeky if I reviewed that myself?15:56
mvoChipaca: its fine, I can review your bits15:57
Chipacamvo: ok, i +1'ed your bits :-p15:57
mvoChipaca: thank you!16:07
mvoChipaca: I did the same16:08
Chipacamvo: also i restarted spread because it hates you16:08
* mvo nods16:08
mvoI wonder if I need to merge master16:08
mvoor if it just hates me regardless16:08
pedronismvo: Chipaca: seems we have forgotten about ForSnapSetup  (noticed when looking at the NoReRefresh PR)16:12
Chipacapedronis: ?16:12
Chipacapedronis: in what sense?16:12
mvowhat is ForSnapSetup?16:13
pedronisChipaca: we have added flags that are not used in handlers, and we are not clearing them16:13
pedronisin it16:13
Chipacamvo: a method on flags that drops things in flags that are for snapstate and not snapsetup16:13
Chipacapedronis: ah, in that sense16:13
Chipacapedronis: maybe we should turn it around16:13
Chipacapedronis: less likely to forget to add things to it that are needed16:14
pedronisChipaca: maybe16:14
pedronisChipaca: mvo: anyway afaict only Amend has this problem16:14
pedronisbut the new flag would as well16:14
pedronis(not deep consequences just a bit more unused data in the state)16:15
* mvo nods16:15
pstolowskimvo, cachio can https://github.com/snapcore/snapd/pull/6553 land?16:17
mupPR #6553: tests: enable opensuse tumbleweed back <Created by stolowski> <https://github.com/snapcore/snapd/pull/6553>16:17
cachiopstolowski, checking16:28
cachiopstolowski, done16:30
cachiopstolowski, thanks!!16:30
mupPR snapd#6553 closed: tests: enable opensuse tumbleweed back <Created by stolowski> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6553>16:31
cachiomvo, ./run-checks --static16:38
jdstrandpedronis: there is something not right with icdiff. I thought I got the declaration right: https://paste.ubuntu.com/p/sBYQd2PWCB/ based on your comment in https://bugs.launchpad.net/snapstore/+bug/1814592/comments/616:41
mupBug #1814592: cannot compile personal-files/system-files snap declaration constraints <Snap Store:Invalid> <https://launchpad.net/bugs/1814592>16:42
pedronisjdstrand: no, you really need to squash them into one regexp with |16:43
pedronisjdstrand: otherwise one of the two entries will fail16:43
pedronisfor one of the side of your ORed plug-attributes16:44
pedronisjdstrand: I said as much:  For the multiple entries in read/write so you need to use a regexp with | and quoting/() as needed16:44
jdstrandpedronis: well, that is what I thought until I read your "For the multiple entries in read/write so you need to use a regexp with | and quoting/() as needed." comment16:44
jdstrandwhat did you mean by multiple entries there?16:45
jdstrandfor say, different snap ids?16:45
pedronisjdstrand: the multiple entries in the attribute in the snap.yam plug16:45
pedronisthe rule matches for a list if each entry in the list matches the regexp16:45
pedronisfor a list in the attribute in the plug/slot16:46
jdstrandyou mean that read and write need the | cause they are different16:46
pedronisjdstrand: there's no write here?16:46
jdstrandno16:46
jdstrandbut I'm trying to parse "the multiple entries in the attribute in the snap.yam plug"16:47
pedronisI mean you need  "read": "\\$HOME/\\.gitconfig|\\$HOME/\\.config/git/config" in the rule16:47
jdstrandI get the bit about all the entries in the list need to match the regex16:47
jdstrandpedronis: sure, I get that. I need to fix that16:47
pedronisjdstrand: ok16:48
jdstrandpedronis: but I want to understand when I am supposed to use |16:48
jdstrandoh duh16:48
jdstrandI got a wire crossed. this whole time I was interpreting '|' as a shorthand for alternate constraints. jeez16:49
pedronisnp16:49
jdstrandyou meant in the regex of course16:49
pedronisyes16:49
* jdstrand shakes head16:49
pedronisand the entries refered to the entries in the list value of the plug attribute16:50
pedronisnot rule side entries16:50
jdstrandyes16:50
cachiomvo16:50
jdstrandChipaca: ok, it installs and it should continue to pass automated review16:56
jdstrandpedronis: thank you again. I need to make a small tweak for the alternate constraints bit in the review-tools cause of my misinterpretation of the LP comment, but that's fine16:57
* jdstrand continues to shake head16:57
jdstrandit shouldn't be this hard :)16:57
Chipacajdstrand: huh, it installs here too, now17:01
Chipacai wonder what i'd broken before17:01
Chipacajdstrand: anyway i'm blaming you for it working: thanks!17:02
sil2100mvo: hey! So apparently I don't have the permissions to push to the snapcore/pi-gadget branch still17:03
sil2100mvo: can you add foundations to it?17:03
sil2100mvo: since I'm in the middle of changing the branch ownership back from CanonicalLtd to snapcore17:04
mvosil2100: let me try17:05
mvosil2100: I think I added you now, please check17:06
jdstrandChipaca: what broke was it had the wrond snap decl (see conversation with pedro nis ^)17:06
* Chipaca reads up17:06
jdstrandChipaca: well, you should blame me for it not working and then fixing it with pedro nis help17:06
Chipacajdstrand: tomahto/tomeito17:08
Chipacait works now \o/17:08
Chipacanow i need to figure out why it doesn't build on ppc64el17:08
Chipaca:-P17:08
jdstrandChipaca: heh, well, it is hard for me to accept the gratitue since this is like the 3rd time I got this bit wrong. 4th times the charm?17:09
jdstrandpedronis may have a higher tally. we will be there today, finally! :)17:09
sil2100mvo: yay, works! Thanks! Did you add the foundations group (or whatever that is) or just me?17:10
sil2100Since I guess the more the merrier :)17:10
sil2100mvo: hm, I still don't seem to have full github powers on the branch like on the others17:11
sil2100(like settings etc.)17:12
mvosil2100: the foundations group17:13
mvosil2100: aha, let me see17:13
sil2100(git push worked though)17:13
mvosil2100: try now17:13
mvosil2100: this failure on trusty is mysterious, even the LP generated debdiff shows no packaging changes17:14
sil2100mvo: works now, thanks!17:17
sil2100hmmm17:17
sil2100mvo: let me take a look at trusty as well17:17
* sil2100 checks his trusty schroot17:21
sil2100oh, components mismatch maybe? However, this built fine before17:22
sil2100mvo: so golang-1.6 is in universe while snapd is in main, but the previous version didn't have a problem with that17:23
Chipacasil2100: snapd uses -1.1017:24
mvoChipaca: that 2.3817:24
Chipacaah17:24
Chipacaoh17:24
Chipacauh17:24
Chipacaeh17:24
mvoChipaca: in 2.37.4 we should still be fine .)17:24
mvosil2100: yeah, what can we do? demote snapd to universe?17:24
mupPR pc-amd64-gadget#12 closed: Adding empty configure hook to enable configuration for gadget <Created by kubiko> <Merged by sil2100> <https://github.com/snapcore/pc-amd64-gadget/pull/12>17:27
mupPR pc-amd64-gadget#13 closed: Adding empty configure hook to enable configuration for gadget <Created by kubiko> <Merged by sil2100> <https://github.com/snapcore/pc-amd64-gadget/pull/13>17:27
mvosil2100: I need to run for lunch17:28
* zyga waves from school meeting17:28
mupPR pc-i386-gadget#8 closed: Adding empty configure hook to enable configuration for gadget <Created by kubiko> <Merged by sil2100> <https://github.com/snapcore/pc-i386-gadget/pull/8>17:30
mupPR pc-i386-gadget#9 closed: Adding empty configure hook to enable configuration for gadget <Created by kubiko> <Merged by sil2100> <https://github.com/snapcore/pc-i386-gadget/pull/9>17:30
sil2100mvo: can we actually demote snapd to universe?17:32
sil2100mvo: anyway, first I'd like someone else confirm that's the problem, let me poke someone17:32
sil2100vorlon: maybe you have an idea? Is this the problem? ^17:32
sil2100vorlon: context: snapd in trusty doesn't build at all, dep-waits on packages even though no new dependencies have been added17:33
sil2100vorlon: I was suspecting a component-mismatch here as golang-1.6 is in universe in trusty, but it was building fine in the past17:34
* sil2100 AFK for a bit17:34
Chipacapedronis: I marked #1819427 as invalid, and also marked the forum topic as solved18:03
mupBug #1819427: Disco daily install doens't include the snaps <ubiquity (Ubuntu):Invalid by chipaca> <ubiquity (Ubuntu Disco):Invalid by chipaca> <https://launchpad.net/bugs/1819427>18:03
pedronisthx18:03
vorlonsil2100: demote snapd to universe> ... no?18:07
cachioniemeyer, hey, I have created a small PR on spread https://github.com/snapcore/spread/pull/74 to enable travis18:15
mupPR spread#74: Add .travis.yaml file <Created by sergiocazzolato> <https://github.com/snapcore/spread/pull/74>18:16
cachioit is the initial step18:16
cachioniemeyer, could you please take a look18:16
cachio?18:16
niemeyercachio: That doesn't look very useful :)18:18
cachioniemeyer, I know, it is just to have a .tavis.yaml file18:18
niemeyercachio: Right, that's what I'm talking about18:19
cachioI already have a set of changes to run the tests18:19
kenvandinezyga: i'm having a layouts problem18:19
cachioniemeyer, but I need to start running the builds on travis18:19
niemeyercachio: Sorry, I really don't get it18:19
kenvandinezyga: specifically refreshing from a snap without the layout to  a snap using layouts18:19
kenvandinehttps://paste.ubuntu.com/p/fVp6Tjd5vb/18:19
niemeyercachio: Running "echo" on Travis is not very useful18:19
niemeyercachio: What am I missing?18:20
kenvandinezyga: it seems to only happen if i run the non-layouts revision first18:20
cachioniemeyer, I need a way to see in github the execution of the change18:20
cachioniemeyer, currently it is not running nothing18:20
niemeyercachio: I consider not running nothing a good thing18:21
cachioniemeyer, I already created a change #73 on spread and it didnt trigger the tests18:21
mupPR #73: fix a bug in lightweights that set the wrong type for frameworks found by AllPartBags that were lexicographically greater than the oem part <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/73>18:21
cachioniemeyer, https://github.com/snapcore/spread/pull/73/files18:21
mupPR spread#73: Run tests on travis <Created by sergiocazzolato> <https://github.com/snapcore/spread/pull/73>18:22
cachioniemeyer, how should I do to start running on travis?18:22
cachiodo you need to configure that?18:22
niemeyercachio: Michael's point in that PR is that your change is huge18:23
cachioor I could add the unit tests execution as part of the change https://github.com/snapcore/spread/pull/74 if you think it is good idea18:23
mupPR spread#74: Add .travis.yaml file <Created by sergiocazzolato> <https://github.com/snapcore/spread/pull/74>18:23
niemeyercachio: We don't want to review that18:23
niemeyercachio: Instead, the PR should introduce testing with less boilerplate18:23
niemeyercachio: We already have tests in spread18:23
niemeyercachio: Running those in Travis would be nice, and hopefully not as complex18:24
niemeyercachio: What's the minimum we can do for that?18:24
cachioniemeyer, ok, I can make a PR to run unit tests18:25
cachiothen another to run spread tests18:25
niemeyercachio: We already have tests in there18:25
niemeyercachio: And they are not unittests18:25
niemeyercachio: They are functional tests18:25
kenvandinezyga: i've reproduced that with both stable and edge channels of the core snap18:26
cachioniemeyer, I know, in that case the PR should include to run the spread tests18:26
cachioniemeyer, just that18:26
cachioniemeyer, does it make sense?18:26
niemeyercachio: Yeah, even just one of those would be enough of a PR18:27
cachioniemeyer, great18:27
cachioI'll make that18:27
niemeyerThanks!18:27
cachioyaw18:27
cachioniemeyer, we are going to need a new key to run the tests on google for the travis spread project18:32
niemeyercachio: That's okay.. perhaps first get it working for you, which should work with your key, and once that's happy we can setup something more permanent18:33
cachioniemeyer, I already have that working18:35
cachiobecause I did it as part of the PR 7318:35
mupPR #73: fix a bug in lightweights that set the wrong type for frameworks found by AllPartBags that were lexicographically greater than the oem part <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/73>18:35
cachioI need just to get that part and create a new PR18:36
niemeyercachio: Okay, so submit that alone so we can integrate first, and then submit the PR that enables that to run on Travis18:36
niemeyercachio: and by "that alone" I mean just the changes necessary to make spread tests run on GCE18:36
niemeyercachio: So anyone can fire those in their own environment18:36
cachioniemeyer, great, thanks18:36
cachiosure18:37
mupPR snapcraft#2479 closed: store: support registering to a specific store <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2479>18:46
zygakenvandine: reproduced which issue sir? The one about base snap?19:00
kenvandineno19:00
kenvandinethe layouts issue19:00
kenvandinezyga: https://paste.ubuntu.com/p/fVp6Tjd5vb/19:01
kenvandinegnome-characters in stable doesn't use layouts and in candidate it does19:01
kenvandineif i run gnome-characters from stable once19:01
zygaLet me look19:01
kenvandinethen refresh candidate19:01
kenvandineit blows up on refresh19:01
kenvandinebut it doesn't blow up if i never run it19:02
zygaAhhh19:02
zygaCan you report that please19:02
kenvandineall the steps to reproduce it is in the pastebin :)19:02
kenvandinesure19:02
zygaAnd assign it to me19:02
zygaI will otherwise not track it very well19:02
zygaThank you19:02
zygaI think I know why19:02
kenvandinezyga: what's your LP id?19:09
kenvandineLP search is failing me :)19:10
roadmrkenvandine: https://launchpad.net/~zyga ?19:12
cachioniemeyer, PR ready https://github.com/snapcore/spread/pull/7519:12
mupPR spread#75: Make spread tests run on google backend <Created by sergiocazzolato> <https://github.com/snapcore/spread/pull/75>19:12
kenvandineNo items matched "zyga".19:12
kenvandinebut you are right19:12
kenvandinei can't assign a bug to that though19:12
kenvandinezyga: bug 182010919:13
mupBug #1820109: refresh fails with layouts <snapd:New> <https://launchpad.net/bugs/1820109>19:13
kenvandinezyga: it won't let me assign it to you19:13
roadmrhn the snapd project must have funky bug assignment policies19:15
kenvandineyeah19:15
kenvandinezyga: i'd mark it as critical if i was allowed... we need to update all the seeded snaps to core18 based so we can seed the new content package at the same time we unseed the old one19:16
kenvandineso this is going to block that :/19:16
roadmrkenvandine: apparently it only allows assigning bugs to teams, not specific people19:16
kenvandinei see other bugs assigned to individuals though19:16
roadmrkenvandine: it won't let me select individuals (even me), but see at the top of the assignment window, it says "select a team of which you're a member" or somesuch19:18
kenvandineyeah19:18
kenvandinesaw that19:18
kenvandineso i can't even assign it to the snappy team :/19:18
roadmr:(19:19
mupPR snapd#6401 closed: many: add /v2/model API, `snap remodel` CLI and spread test <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6401>20:05
pedroniskenvandine: I assigned, I don't know if it has a quick/non risky fix, we'll need to see what zyga says20:06
mupPR snapcraft#2502 opened: meta: fix management of snap/local <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2502>20:08
ograhmm, ouch ... core18 misses snapfuse ... so you cant run lxd on top of Ubuntu Core 18 images20:13
ogra(well, you can, but not install snaps in the container)20:14
ograstgraber, pedronis ^^^ is that known ?20:14
jdstrandroadmr: hi! can you add a pull of r1208 to your queue?20:49
jdstrandroadmr: it isn't urgent20:49
roadmrjdstrand: pullity pull coming right up20:50
jdstrandthank you :)20:50
roadmrjdstrand: yep, I don't think we can deploy that before next week but it'll get queued20:50
jdstrandpedronis: fyi, that ^ has the small fix I referred to20:50
Saviqackk: hey, sorry for the very late reply... I saw your ping but missed which channel it was on...21:21
Saviqackk: that would be https://github.com/CanonicalLtd/multipass/issues/678 - it's fixed now in our master, but we've another issue we're fighting with on edge (https://github.com/CanonicalLtd/multipass/issues/677) so it's best to stick with --beta for a bit21:22
stgrabergo get github.com/snapcore/snapd/i18n/xgettext-go: unzip /lxc-ci/build/tmp.GQSoN0Ki3g/go/pkg/mod/cache/download/github.com/snapcore/snapd/@v/v0.0.0-20190314200526-9cca2d5a116a.zip: malformed file path "cmd/snap-confine/spread-tests/distros/debian.": trailing dot in path element21:23
stgraber^ that's go tip failing to "go get" the snapd repo due to something funky going on with unzip21:24

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!