| zyga | Good morning | 05:52 |
|---|---|---|
| mborzecki | morning | 06:05 |
| mup | PR snapd#6611 closed: interfaces/builtin: add add exec "/" to docker-support (for 2.38) <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6611> | 06:58 |
| zyga | Hey mborzecki | 07:08 |
| mborzecki | zyga: hey | 07:08 |
| zyga | https://github.com/systemd/systemd/issues/12018 | 07:09 |
| mvo | hey zyga and mborzecki | 07:10 |
| zyga | Hey mvo :-) | 07:10 |
| mborzecki | zyga: interesting bug report | 07:11 |
| zyga | Systemd ran into the same parsing issue | 07:15 |
| zyga | In that bug report it would really clobber a tmp-foo.mount unit | 07:16 |
| zyga | back in the office | 07:34 |
| * zyga focuses on https://github.com/snapcore/snapd/pull/6575 | 07:35 | |
| mup | PR #6575: cmd/snap-confine: pass sc_invocation instead of numerous args around <Created by zyga> <https://github.com/snapcore/snapd/pull/6575> | 07:35 |
| mborzecki | mvo: when you have a break from backporting systemd patches, could you take a look at https://github.com/snapcore/snapd/pull/6609 ? | 07:35 |
| mup | PR #6609: snap/gadget: introduce volume update info <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6609> | 07:35 |
| zyga | mborzecki: did you see my question about case sensitivity? | 07:38 |
| mborzecki | zyga: yeah, we could probably warn when there's a volume which is case insensitive and more than one 'version' of file is listed in the path | 07:40 |
| zyga | mborzecki: I think we should not warn, we should use case-insensitive matching | 07:47 |
| zyga | do the right thing | 07:47 |
| zyga | mborzecki: and it should be invalid to specifcy case-clashing entries | 07:48 |
| === pstolowski|afk is now known as pstolowski | ||
| pstolowski | morning | 08:05 |
| mvo | hey pstolowski - good morning | 08:08 |
| mborzecki | pstolowski: hey | 08:28 |
| Chipaca | kjackal, zyga: I stopped using OVH over this "we'll call it ubuntu but use a random kernel we found down a ginnel" nonsense | 09:14 |
| mborzecki | damn, that error with removing of snap data directory is annoying | 09:15 |
| Chipaca | mborzecki: and i can't reproduce it on its own :-( | 09:17 |
| mborzecki | Chipaca: since it's so well randomly reproducible, i'm actually thinging about adding a list of files in snap data dir in the error message | 09:17 |
| Chipaca | mborzecki: sgtm | 09:18 |
| Chipaca | mborzecki: find -ls in a debug section? | 09:18 |
| mborzecki | hm or that | 09:18 |
| mborzecki | let me open a PR | 09:19 |
| mup | PR snapd#6615 opened: spread: some debug info to catch /var/snap/.. not being empty <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6615> | 09:22 |
| mborzecki | Chipaca: it's not really reproducing locally either, 40+ loop iterations of install/remove of 2 snaps and still nothing | 09:26 |
| Chipaca | mborzecki: what turns on SPREAD_DEBUG_EACH? | 09:27 |
| mborzecki | -debug-each ? | 09:27 |
| Chipaca | ah, found it | 09:27 |
| Chipaca | SPREAD_DEBUG_EACH: "$(HOST: echo ${SPREAD_DEBUG_EACH:-1})" | 09:28 |
| Chipaca | you can't turn it on, but you can turn it off :-) | 09:28 |
| mborzecki | heh | 09:29 |
| zyga | Chipaca: you can turn it off | 09:53 |
| zyga | I use it all the time | 09:53 |
| zyga | SPREAD_DEBUG_EACH=0 | 09:53 |
| zyga | hello sir :) | 09:54 |
| Chipaca | zyga: that's what i said innit? | 09:54 |
| zyga | ah | 09:54 |
| zyga | I read that backwards, sorry | 09:54 |
| zyga | it's good I got my coffe :) | 09:55 |
| zyga | Chipaca: can you please look at the commit message in https://github.com/snapcore/snapd/pull/6614 | 09:56 |
| mup | PR #6614: cmd/snap-confine: use fixed private tmp directory <Created by zyga> <https://github.com/snapcore/snapd/pull/6614> | 09:56 |
| zyga | Chipaca: if this lands, I'd like to start removing per-snap /tmp data | 09:56 |
| zyga | Chipaca: when we remove a snap | 09:56 |
| zyga | Chipaca: just FYI | 09:56 |
| Chipaca | zyga: i reviewed the whole thing, friday | 09:57 |
| Chipaca | spent some time remembering the semantics of mkdir and mkdirat to make sure it was ok wrt symlink attack | 09:58 |
| Chipaca | zyga: but i then got distracted and didn't +1 or anything | 09:58 |
| Chipaca | zyga: but | 09:59 |
| Chipaca | zyga: what happens if somebody mkdir's the expected directory, and then mkdir's tmp inside it to not be 01777? | 10:00 |
| zyga | Chipaca: we fix it on startup | 10:00 |
| === cpaelzer__ is now known as cpaelzer | ||
| Chipaca | ah, there | 10:01 |
| * Chipaca found it | 10:01 | |
| zyga | Chipaca: we don't fix it if you break it after taht | 10:03 |
| zyga | *that | 10:03 |
| zyga | but that was true before | 10:03 |
| zyga | and it wasn't hidden, just obfuscated | 10:03 |
| zyga | if you are root you can break it | 10:03 |
| zyga | but this is also true now | 10:03 |
| Chipaca | zyga: right, root can do w/e | 10:03 |
| Chipaca | zyga: but i didn't want a random user to mkdir and then have fun deleting other user's stuff | 10:04 |
| Chipaca | but that's fine | 10:04 |
| zyga | yeah, that's prevented now | 10:04 |
| zyga | I have one more aspect of that to fix but this is an unrelated bug related to /tmp | 10:04 |
| mborzecki | Chipaca: https://api.travis-ci.org/v3/job/507758121/log.txt | 10:05 |
| Chipaca | wait what | 10:06 |
| * zyga looks at the same one | 10:06 | |
| Chipaca | that is very much unexpected | 10:06 |
| Chipaca | I expected a random directory | 10:06 |
| Chipaca | not the current symlink! | 10:07 |
| Chipaca | wtf | 10:07 |
| mborzecki | yup | 10:07 |
| Chipaca | - Remove security profile for snap "test-snapd-tools_instance" (6) (cannot find installed snap "test-snapd-tools_instance" at revision 6: missing file /snap/test-snapd-tools_instance/6/meta/snap.yaml) | 10:07 |
| Chipaca | mborzecki: ^ some fuckery going on | 10:07 |
| zyga | Chipaca: I love our test suite | 10:08 |
| zyga | perfect job security | 10:08 |
| Chipaca | waaaaait | 10:10 |
| Chipaca | mborzecki: quick check with you | 10:10 |
| Chipaca | - Remove data for snap "test-snapd-tools_instance" (5) (failed to remove snap "test-snapd-tools" base directory: remove /var/snap/test-snapd-tools: directory not empty) | 10:10 |
| Chipaca | mborzecki: why is test-snapd-tools_instance removal removing /var/snap/test-snapd-tools ? | 10:10 |
| zyga | Chipaca: ooh | 10:13 |
| zyga | feels like incorrect use of snap name vs instance name? | 10:13 |
| Chipaca | zyga: or incorrect determination of hasOtherInstances | 10:14 |
| mborzecki | Chipaca: seen it happen without any extra _instance entries too | 10:14 |
| Chipaca | mborzecki: what does hasOtherInstances() return if you have two instances installed, and remove them both in the same change? | 10:22 |
| * Chipaca ponders | 10:22 | |
| * zyga is in a ethernet cable bonanza | 10:35 | |
| zyga | I can finally fix my messy office wiring | 10:35 |
| Chipaca | zyga: is this the part of bonanza where everything is on fire and you ride away into the sunset? | 10:37 |
| zyga | Chipaca: that is after I plug them :) | 10:38 |
| ogra | given the time it is probably rather the part where the cook comes out and calls for lunch | 10:38 |
| mborzecki | Chipaca: so you're sayng a scenario where both snaps are removed, and at the time hasOtherInstances is run, it returns true for both, but then the directory is left behind? | 11:02 |
| * zyga small break to install new network cables | 11:03 | |
| mborzecki | cables? :P | 11:03 |
| zyga | mborzecki: wifi runs on cables :)" | 11:03 |
| zyga | you don't want to see how it looks like now | 11:03 |
| zyga | 1/3 there, | 11:14 |
| zyga | now the longest one | 11:14 |
| zyga | mborzecki: I'm mainly using ethernet because NAS over wifi is not as fast | 11:15 |
| zyga | mborzecki: my NAS would be noticeably faster if I got the 10Gbit network update now | 11:15 |
| zyga | mborzecki: wifi here is also very crowded and noisy | 11:15 |
| zyga | pstolowski: https://www.apple.com/us/shop/ <- roll your 8ball what the updates are | 11:23 |
| pstolowski | zyga: interesting | 11:23 |
| zyga | pstolowski: that's apple talk for "new products today" | 11:24 |
| pstolowski | uhm | 11:25 |
| mvo | pedronis: any concerns if I chery-pick 6598 into 2.38? I think we talked about it and it was fine but I may misremember (the "set a header when auto-refreshing" change from john | 11:36 |
| pedronis | mvo: it's fine | 11:36 |
| Chipaca | mborzecki: or conversely, where it returns false to both | 11:37 |
| Son_Goku | mborzecki, can we get all the selinux stuff to land for 2.38? | 11:38 |
| mborzecki | Son_Goku: 2.39 | 11:38 |
| Son_Goku | arrrgh | 11:38 |
| Son_Goku | you're killing me here :P | 11:38 |
| mborzecki | Son_Goku: sorry :) | 11:38 |
| Son_Goku | I was hoping to get this in with F30 devel so that the majority of people would be doing reboot upgrades no matter what | 11:39 |
| zyga | mvo: possible spam edit on https://bugs.launchpad.net/arduino-debug/+bug/1791691 | 11:51 |
| mup | Bug #1791691: PATH broken in systemd units <Arduino Debugging Tool:Fix Released> <snapd (Ubuntu):Fix Released> <snapd (Ubuntu Bionic):In Progress> <snapd (Ubuntu Cosmic):Fix Released> <https://launchpad.net/bugs/1791691> | 11:51 |
| * Chipaca disappears in a cloud of lunch | 11:58 | |
| MattJ | Yum | 11:59 |
| mup | PR # closed: snapd#5644, snapd#5822, snapd#5915, snapd#6108, snapd#6177, snapd#6238, snapd#6258, snapd#6325, snapd#6327, snapd#6329, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6404, snapd#6410, snapd#6418, snapd#6436, snapd#6485, snapd#6491, snapd#6502, snapd#6541, snapd#6559, | 12:02 |
| mup | snapd#6564, snapd#6575, snapd#6577, snapd#6583, snapd#6588, snapd#6591, snapd#6594, snapd#6595, snapd#6597, snapd#6599, snapd#6602, snapd#6603, snapd#6604, snapd#6605, snapd#6606, snapd#6607, snapd#6608, snapd#6609, snapd#6610, snapd#6612, snapd#6613, snapd#6614, snapd#6615 | 12:02 |
| mup | PR # opened: snapd#5644, snapd#5822, snapd#5915, snapd#6108, snapd#6177, snapd#6238, snapd#6258, snapd#6325, snapd#6327, snapd#6329, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6404, snapd#6410, snapd#6418, snapd#6436, snapd#6485, snapd#6491, snapd#6502, snapd#6541, snapd#6559, | 12:03 |
| mup | snapd#6564, snapd#6575, snapd#6577, snapd#6583, snapd#6588, snapd#6591, snapd#6594, snapd#6595, snapd#6597, snapd#6599, snapd#6602, snapd#6603, snapd#6604, snapd#6605, snapd#6606, snapd#6607, snapd#6608, snapd#6609, snapd#6610, snapd#6612, snapd#6613, snapd#6614, snapd#6615 | 12:03 |
| * zyga breaks | 12:03 | |
| pstolowski | wow @mup | 12:03 |
| mborzecki | finishing up with an update to the yocto layer | 12:10 |
| mborzecki | hm things were a bit behind | 12:11 |
| zyga | mborzecki: "a bit" | 12:12 |
| zyga | mborzecki: any chance you can use snapd.mK/ | 12:12 |
| mborzecki | zyga: maybe, although the main problem was handling of go in poky, which is fine to 'just' go packages, but little funky when there's go and something else | 12:14 |
| zyga | mmm | 12:14 |
| zyga | re | 12:26 |
| mborzecki | Chipaca: restarted the travis job in #6615, want to get another sample | 13:01 |
| mup | PR #6615: spread: some debug info to catch /var/snap/.. not being empty <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6615> | 13:01 |
| mborzecki | off to pick up the kids | 13:02 |
| === ricab is now known as ricab|lunch | ||
| zyga | brb, daughter is hungry | 13:48 |
| mvo | mborzecki, Chipaca we might be a bit late, meeting overrunning | 14:01 |
| zyga | jdstrand: some low hanging fruit: https://github.com/snapcore/snapd/pull/6607 | 14:39 |
| mup | PR #6607: cmd: typedef mountinfo structures <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6607> | 14:39 |
| jdstrand | zyga: yes it is on my list | 14:39 |
| zyga | thanks! | 14:39 |
| zyga | it's boring, there are some more interesting ones in the pipe :) | 14:39 |
| === epod is now known as luk3yx | ||
| === ricab|lunch is now known as ricab | ||
| mup | PR snapd#6616 opened: [RFC] boot: add flag file "force-kernel-extraction" <Created by mvo5> <https://github.com/snapcore/snapd/pull/6616> | 15:55 |
| pedronis | pstolowski: I did a pass over the timings PR | 15:57 |
| pstolowski | pedronis: k, thanks | 16:10 |
| pstolowski | mvo, pedronis, Chipaca I think my fix for error handling of non-nummeric snapshot IDs in snap snapshots commands broke 'snap saved' (2.37.4 is ok) :( | 16:21 |
| mvo | pstolowski: ok, so we need this for 2.38? | 16:22 |
| pstolowski | mvo: when was 2.38 branched away? | 16:23 |
| pstolowski | my change landed the week after the sprint. let me check | 16:24 |
| mvo | pstolowski: ok | 16:25 |
| mvo | pstolowski: about 2 weeks ago it was branched | 16:25 |
| pstolowski | mvo: ok, confirmed, 2.38 requires a fix | 16:26 |
| mvo | pstolowski: ta | 16:28 |
| mvo | pstolowski: I will wait for 2.38-final then | 16:28 |
| mvo | pstolowski: until that is available | 16:28 |
| Saviq | cachio: hey, could you redo the rawhide image? it's cut to version 30 now so GPG is failing https://travis-ci.org/MirServer/mir/jobs/507765669#L1529 | 16:33 |
| cachio | Saviq, hi, sure | 16:33 |
| Saviq | thanks :) | 16:33 |
| cachio | I'll ping you when it is ready | 16:33 |
| Saviq | alan_g: FYI ↑ | 16:33 |
| cachio | Saviq, np | 16:33 |
| mup | PR snapd#6617 opened: cmd/snap: fix regression of snap saved command <⚠ Critical> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6617> | 17:13 |
| pstolowski | mvo: ^ this fix for master | 17:13 |
| === pstolowski is now known as pstolowski|afk | ||
| cachio | niemeyer, hey, https://github.com/snapcore/spread/pull/75 readu | 17:20 |
| mup | PR spread#75: Make spread tests for spread project run on google backend <Created by sergiocazzolato> <https://github.com/snapcore/spread/pull/75> | 17:20 |
| cachio | ready | 17:20 |
| mup | PR snapcraft#2504 opened: cli: validate plugin schema before provider <Created by cmatsuoka> <https://github.com/snapcore/snapcraft/pull/2504> | 17:31 |
| mup | PR snapcraft#2503 closed: cli: disable raven if not running from package <Created by cmatsuoka> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2503> | 17:40 |
| zyga | re | 17:43 |
| cachio | Saviq, the image is ready | 18:12 |
| cachio | Saviq please tell me if it works for you | 18:12 |
| * cachio afk | 19:47 | |
| mup | PR snapcraft#2505 opened: Test store <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2505> | 23:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!