[03:11] <mup> PR snapd#6632 opened: tests: restore sbuild test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6632>
[05:30] <zyga> Good morning
[06:10] <mborzecki> morning
[06:37] <zyga> o/
[06:37] <zyga> hey mborzecki :)
[06:37] <mborzecki> zyga: hey
[06:38] <mborzecki> love when the PRs are green
[06:39] <zyga> like the smell of fresh coffee in the morning
[06:39] <zyga> I restarted a few PRs last night
[06:50] <mborzecki> all but one of mine are green :)
[06:51] <zyga> https://pact.kadena.io/example/Accounts
[06:52] <zyga> neat stuff
[07:15] <mborzecki> btw. today is the first day of spring for those in the northern part of the globe
[07:15] <zyga> must explain my back pain :/
[07:17] <mborzecki> zyga: what's with the lispy thing you linked?
[07:17] <zyga> it's a formal verification engine that works over the web
[07:17] <zyga> splice an algorithm
[07:17] <zyga> add constraints
[07:17] <zyga> and it formally proves it (or provides a violating input set)
[07:18] <zyga> https://twitter.com/_wjmartino_/status/1105496676754751494 <- example
[07:28]  * zyga goes to the office
[07:28] <zyga> ttys (talk to you soon :)
[08:04] <pstolowski> heyas
[08:05] <mborzecki> pstolowski:  hey
[08:06] <mborzecki> coffee time
[08:13] <zyga> hey pawel :)
[08:16]  * zyga will work on some debugging today
[08:40] <mborzecki> mvo: morning
[08:45] <mvo> hey mborzecki
[08:45] <mvo> mborzecki: did I miss anything ?
[08:45] <mborzecki> mvo: nope
[08:47] <mborzecki> hmm, google:ubuntu-18.04-64:tests/main/desktop-portal-filechooser strikes again?
[08:47] <mvo> booo
[08:47] <mvo> ok
[08:48] <mup> PR snapd#6632 closed: tests: restore sbuild test <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6632>
[09:25]  * zyga looks at https://github.com/snapcore/snapd/pull/6485
[09:25] <mup> PR #6485: interfaces/seccomp: regenerate changed profiles only <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6485>
[09:52] <zyga> mborzecki: reviewed
[09:58] <mborzecki> zyga: thanks
[10:06] <pedronis> zyga: mborzecki: I added a comment there
[10:07] <pedronis> zyga: also shouldn't the system-key mechanism in part prevent trying to use old .bin ?
[10:12] <mborzecki> pedronis: isnt't that in snap?
[10:12] <pedronis> mborzecki: ?
[10:12] <pedronis> it's the wait in snap-confine that zyga mentioned
[10:12] <mborzecki> so there's this mechanism, one in snap-confine that waits for the profile to appear, and then we can fix the PR and use EnsureFileState or similar
[10:13] <mborzecki> pedronis: that's the wait for compiled bpf profile
[10:13] <pedronis> mborzecki: yes, ok, then we agree, and yes, some form of atomic rename, EnsureFIleState would be better
[10:13] <pedronis> for that case
[10:13] <mborzecki> iirc there was another mechanism in snap (?) that checked system-key
[10:14] <pedronis> mborzecki: there's a mechanism that also wait if there's a system-key mismatch I think
[10:14] <pedronis> in snap run
[10:14] <pedronis> yes
[10:14] <pedronis> likely
[10:15] <mborzecki> ok, will push an update, got to figure out the gadget structure overlap first
[10:15] <mborzecki> there's also some weird assumption about offset-write that isn't really clear
[10:15] <pedronis> mborzecki: thx
[10:22] <mvo> mborzecki: I think ubuntu-image also has a readme or some design doc or something that also explains some of this (not sure if that is helpful for your specific case though)
[10:24] <mborzecki> mvo: i think i got it, idk maybe i'm bit too much used to anaconda/mic/wic way of specifying paritions/offsets and have some prior assumptions that don't hold up with u-i and gadget.yaml
[10:25]  * mvo nods
[10:49] <zyga> mborzecki, pedronis: I added some comments there as well
[10:49] <zyga> I think the behavior of snap-run and snap-seccomp is important context for the reader there
[10:50] <Chipaca> watchdog timeout in https://api.travis-ci.org/v3/job/509326704/log.txt
[10:50] <Chipaca> very interesting
[10:51] <zyga> Chipaca: looks like a deadlock?
[10:52] <Chipaca> snapd thinks it's waiting for reboot, system has no inkling of it
[10:54] <Chipaca> but then, because again we don't store the 'needs reboot' flag, snapd rolls back the refresh
[10:58] <pedronis> Chipaca: we should fix that, but if we are waiting for a reboot and there's no reboot something else is also going on
[10:58] <Chipaca> pedronis: yeah, the reboot happens later due to the revert
[10:59] <zyga> what kicks the watchdog timer?
[10:59] <zyga> is that from ensure loops?
[10:59] <zyga> or from a dedicated goroutine?
[10:59] <Chipaca> dunno, things are weird in that log
[11:00] <pedronis> zyga: we have a dedicated goroutine
[11:00] <pedronis> in main
[11:00] <zyga> so that would have to die
[11:00] <zyga> that's odd
[11:00] <Chipaca> dedicated goroutine in cmd/snapd/main.go
[11:04] <Chipaca> well
[11:04] <Chipaca> not too odd
[11:04] <Chipaca> we stop poking the watchdog if the daemon is Dying()
[11:04] <zyga> ahh
[11:05] <Chipaca> and the first thing daemon.Stop does is tomb.Kill
[11:07] <zyga> mvo: 2.38 is on releases
[11:07] <zyga> is that the day we package?
[11:08] <mvo> zyga: we can wait for the beta validation but it should be fine
[11:08] <zyga> ok
[11:08] <zyga> tomorrow then
[11:08] <zyga> thank you :)
[11:08] <zyga> mborzecki: I'll do debian, fedora and suse
[11:08] <mvo> zyga: yeah - or later today, more automation makes it quicker
[11:09] <mborzecki> heh, someone already flagged snapd out of date in aur
[11:50] <Son_Goku> mvo, errm
[11:50] <Son_Goku> I think your releasing automation is broken
[11:50] <Son_Goku> this is the second release I've looked at with a corrupted changelog entry
[11:50] <Son_Goku> https://github.com/snapcore/snapd/commit/7d3222250d98ff1baf8ad4e7df283b40a35d960c
[11:51] <Chipaca> Son_Goku: corrupted how?
[11:51] <Son_Goku> it's missing the parent level "- New upstream release <version>" in the changelog entry
[11:51] <mvo> Son_Goku: uh, sorry :/
[11:52] <Son_Goku> it's alright
[11:52] <Son_Goku> I've been fixing it locally and couldn't get ahold of you to let you know, so that's my bad :(
[11:52] <mvo> Son_Goku: thanks for letting me know now :)
[11:52] <mvo> and sorry again
[11:52] <Son_Goku> I'm looking at the fedora 2.38 update now
[11:53] <mvo> Son_Goku: thank you!
[11:54] <Son_Goku> did we ever deal with the global MongoDB removal thing?
[11:54] <mup> PR snapd#6612 closed: interfaces/builtin: add dev/pts/ptmx access to docker_support <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6612>
[11:54] <Son_Goku> mvo or am I still going to need this? https://src.fedoraproject.org/rpms/snapd/blob/master/f/1001-errtracker-neuter-error-tracker.patch
[11:55] <Chipaca> Son_Goku: why is that needed?
[11:56] <Son_Goku> the mgo golang package requires mongodb itself, and mongodb was removed
[11:56] <Son_Goku> Chipaca: https://src.fedoraproject.org/rpms/snapd/c/e923663082f5ce01052fe6299bbb1e0b6780bfc5?branch=master
[11:56] <Chipaca> ah, i didn't remember the first half of that
[11:56] <Chipaca> that's a bit silly
[11:56] <Chipaca> :-/
[11:56] <Chipaca> maybe we should vendor bson itself, directly
[11:56]  * Son_Goku shrugs
[11:57] <Son_Goku> MongoDB has been removed, effective Fedora 30
[11:57] <Chipaca> that makes me happy, for historical reasons :-)
[11:58] <Chipaca> Son_Goku: how grumpy would fedora be if we vendored bson?
[11:58] <Chipaca> vendored as in pulled it into our tree directly, not via fancy golang vendoring
[11:58] <Son_Goku> actually, it looks like my problem might be solved anyway
[11:58] <Chipaca> oh no
[11:58] <Chipaca> :-)
[11:58] <mup> PR snapd#6633 opened: release: merge 2.38 changelogs back into master <Created by mvo5> <https://github.com/snapcore/snapd/pull/6633>
[11:58] <Son_Goku> it looks like they might have mutated the driver sources so that mongodb isn't pulled in as part of using the sources to build a thing
[11:59] <Chipaca> sweet
[11:59] <Son_Goku> I'll need to test to see if it chokes on itself during the build or not
[11:59] <Son_Goku> if not, then I can drop that patch
[12:05] <zyga> Son_Goku: thank you for looking at the 2.38 update, I was planning on doing that tomorrow but please go ahead :)
[12:05] <Son_Goku> well, I saw the bug report filed by anitya
[12:05] <Son_Goku> (aka release-monitoring.org)
[12:07] <zyga> Son_Goku: I saw it too
[12:08] <mup> PR snapd#6634 opened: snap: add validation of gadget.yaml <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6634>
[12:11] <zyga> the title of the forum topic: https://forum.snapcraft.io/t/layout-magic-collection/10501
[12:11] <zyga> :D
[12:11] <zyga> (I love that people use layouts to do things they could not do before)
[12:15] <Son_Goku> hoooh
[12:15] <Son_Goku> we have some SELinux stuff in 2.38
[12:16] <mborzecki> Son_Goku: some
[12:16] <Son_Goku> none of it is enabled in the spec for 2.38
[12:16] <Son_Goku> so I guess I should leave it be then
[13:36] <mup> PR snapd#6619 closed: partition,bootloader: rename 'partition' package to 'bootloader' <Simple 😃> <Created by bboozzoo> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6619>
[13:56] <mup> PR snapd#6635 opened: client, daemon, store: search by common-id <Created by chipaca> <https://github.com/snapcore/snapd/pull/6635>
[13:57] <Chipaca> cprov: ^ fwiw
[14:02] <Chipaca> zyga: u standup today?
[14:03] <zyga> oh
[14:03] <zyga> sorry
[14:04] <zyga> I muted all notifications
[14:51] <mup> PR snapcraft#2507 opened: build providers: improve handling in snap logic <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2507>
[15:18] <pedronis> pstolowski: what's the status of #6491? is it close to landing?
[15:18] <mup> PR #6491: interfaces: hotplug nested vm test, updated serial-port interface <Hotplug 🔌> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6491>
[15:24] <pstolowski> pedronis: zyga promised to take another look
[15:42] <mborzecki> zyga: added a comment here https://github.com/snapcore/snapd/pull/6485#discussion_r267821309 and in the code
[15:42] <mup> PR #6485: interfaces/seccomp: regenerate changed profiles only <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6485>
[15:44]  * cachio lunch
[16:03] <mup> PR snapcraft#2508 opened: Build provider errors <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2508>
[16:06] <pedronis> zyga: 6575 can be landed
[16:11] <abeato> jdstrand, hey, are you sure that the behaviour re: empty cgroup is not a bug? See my last comment: https://github.com/snapcore/snapd/pull/6623#discussion_r267811338
[16:11] <mup> PR #6623: interfaces/builtin/opengl: allow access to Tegra X1 <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/6623>
[16:19] <pedronis> Chipaca: could you look at #6591 when you have a bit of time
[16:19] <mup> PR #6591: overlord/ifacemgr: basic measurements <Created by stolowski> <https://github.com/snapcore/snapd/pull/6591>
[16:26] <Chipaca> pedronis: ye
[16:27] <pedronis> thx
[16:32] <pedronis> zyga: I did another pass on some of your PRs
[16:32] <zyga> pedronis: thank you!
[16:42] <mvo> 2.38 is in disco!
[16:51] <mup> PR snapd#6609 closed: snap/gadget: introduce volume update info <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6609>
[16:55] <mup> PR snapd#6636 opened: cmd: prevent umask from breaking snap-run chain <Created by zyga> <https://github.com/snapcore/snapd/pull/6636>
[17:02] <zyga> pedronis: any objections to merge https://github.com/snapcore/snapd/pull/6575
[17:02] <mup> PR #6575: cmd/snap-confine: pass sc_invocation instead of numerous args around <Created by zyga> <https://github.com/snapcore/snapd/pull/6575>
[17:02] <pedronis> zyga: no, I actually mentioned in the channel a while ago
[17:03] <zyga> great, sorry I must have missed that
[17:03] <pedronis> mvo: I left an after the fact comment about 6609
[17:03] <mup> PR snapd#6575 closed: cmd/snap-confine: pass sc_invocation instead of numerous args around <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6575>
[17:05] <mvo> pedronis: thanks, looking
[17:07] <mvo> pedronis: uh, thank you for the comment in 6609 - looks like I was too trigger happy
[17:08] <pedronis> mvo: not the end of the world
[17:15] <zyga> pedronis: I updated https://github.com/snapcore/snapd/pull/6597
[17:15] <mup> PR #6597: cmd/snap-update-ns: refactor of profile application (1/N) <Created by zyga> <https://github.com/snapcore/snapd/pull/6597>
[17:15] <zyga> I hope this part is ready now
[17:16] <pedronis> zyga: I'll look in the morning at this point
[17:22] <mup> PR core18#63 closed: [RFC] snapcraft.yaml: add current date to core18 rev <Created by mvo5> <Closed by sil2100> <https://github.com/snapcore/core18/pull/63>
[17:25] <mup> PR core18#121 opened: Make the version number date-based <Created by sil2100> <https://github.com/snapcore/core18/pull/121>
[17:42] <zyga> pedronis: sure, thank you
[17:42]  * zyga EOEs
[17:43] <zyga> have a nice evening everyone
[17:43]  * zyga goes to study
[17:44] <zyga> jdstrand: hello, can you please enqueue https://github.com/snapcore/snapd/pull/6502 -- it is the next feature work I need your review for
[17:44] <mup> PR #6502: dirs,overlord/snapstate: add Soft and Hard refresh checks <Created by zyga> <https://github.com/snapcore/snapd/pull/6502>
[17:53] <jdstrand> zyga: it is already enqueued
[18:01] <Chipaca> EOD from me
[18:13] <mup> PR snapcraft#2507 closed: build providers: improve handling in snap logic <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2507>
[18:13] <mup> PR snapcraft#2508 closed: Build provider errors <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2508>
[18:28] <mup> PR snapcraft#2509 opened: build providers: initial support for LXD <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2509>
[20:40] <mup> PR snapcraft#2510 opened: Release changelog for 3.3 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2510>