| === chihchun_afk is now known as chihchun | ||
| mborzecki | morning | 06:20 |
|---|---|---|
| zyga | Good morning | 07:22 |
| mvo | hey zyga | 07:23 |
| zyga | Hey :-) | 07:27 |
| zyga | Starting later because I started assisting my son to school on a bike | 07:27 |
| zyga | Very nice way to start the day | 07:27 |
| zyga | mvo: I got green on that pwd test I added. I tweaked core in test prepare though | 07:28 |
| zyga | I don’t think it is sufficient for production yet because vanilla core is not right | 07:28 |
| zyga | But it shows promise :-) | 07:28 |
| zyga | I will be in the office soon | 07:29 |
| mvo | zyga: good, is the fix for core18 (git) difficult? | 07:29 |
| zyga | We will see | 07:32 |
| zyga | I have not done that yet | 07:33 |
| mvo | ok | 07:33 |
| mborzecki | mvo: zyga: morning guys | 07:35 |
| mvo | mborzecki: good morning | 07:36 |
| mup | PR snapd#6658 opened: testutil: run mocked commands through shellcheck <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6658> | 07:37 |
| mvo | pedronis: 6628 has two plus - is that something you want to review as well or can we go ahead and merge? | 07:37 |
| mborzecki | fun PR btw ^^^ | 07:37 |
| mborzecki | and super simple too :) | 07:37 |
| zyga | Woooot | 07:38 |
| zyga | Super | 07:38 |
| mborzecki | yeah, some nice things caught too | 07:38 |
| mvo | mborzecki: nice one | 07:38 |
| mborzecki | wonder how udevmon mocking worked without __END__ | 07:38 |
| mborzecki | the impact is small on my mock, but i can look into some caching if needed | 07:39 |
| zyga | mborzecki: reviewed :-) | 07:40 |
| mborzecki | zyga: thanks! | 07:43 |
| pstolowski | morning | 07:58 |
| pstolowski | mborzecki: nice catch with udevmon mock , thanks! | 07:59 |
| mborzecki | pstolowski: hey | 07:59 |
| mvo | hey pstolowski | 08:03 |
| pedronis | mvo: no, I skimmed it originally | 08:32 |
| pedronis | (about 6628) | 08:32 |
| pedronis | and morning | 08:32 |
| pedronis | mvo: I answered in #6404 | 08:34 |
| mup | PR #6404: snapstate: auto transition on experimental.snapd-snap=true <Created by mvo5> <https://github.com/snapcore/snapd/pull/6404> | 08:34 |
| mvo | thanks pedronis | 08:34 |
| mvo | pedronis: I am working on the remodel feedback and get back to this one enext | 08:35 |
| mup | PR snapd#6628 closed: overlord/snapshotstate: support auto flag (automatic snapshots 1/N) <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6628> | 08:36 |
| Chipaca | moin moin | 08:39 |
| Chipaca | ogra: who can best answer https://forum.snapcraft.io/t/question-about-going-to-production/10609 ? | 08:39 |
| ogra | Chipaca, i'll take a look after the meeting | 08:49 |
| ogra | Chipaca, also ... https://forum.snapcraft.io/t/disabling-console-conf-from-gadget-or-core-config-option/4358 | 08:50 |
| pedronis | mborzecki: hi, does your work help with this https://forum.snapcraft.io/t/selinux-blocking-socket-activation-on-fedora/6931/9 or could that be addressed in the context of SELinux new stuff? | 09:06 |
| mborzecki | pedronis: it works with the upcoming selinux changes, i still want to try if there's a workaround for the latest 2.38 that neal relased though | 09:09 |
| pedronis | mborzecki: ok, thanks for the info | 09:09 |
| mborzecki | pedronis: fwiw the selinux clean test has a socket activation check that was added specifically because of this :) | 09:09 |
| pedronis | mborzecki: great :) | 09:09 |
| === chihchun is now known as chihchun_afk | ||
| mborzecki | hmm systemctl 219 on centos exits with 1 when we ask for a property that doesn't exist for a given unit type | 09:42 |
| mborzecki | so snap services output is garbage if there is a socket activated service | 09:43 |
| === chihchun_afk is now known as chihchun | ||
| mborzecki | pstolowski: pushed the updates to #6654 | 09:49 |
| mup | PR #6654: packaging/fedora, tests/upgrade/basic: patch existing mount units with SELinux context on upgrade <SELinux> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6654> | 09:49 |
| pstolowski | mborzecki: thanks, will take a look in a moment | 09:50 |
| pedronis | pstolowski: 6629 just needs two review nows, I don't need to explicitly review it | 10:08 |
| pstolowski | pedronis: ack, thanks | 10:09 |
| zyga | mvo: this is what I meant yesterday https://github.com/snapcore/snapd/pull/6642/commits/758c968ced00023d98da61c457add8c04498781b | 10:35 |
| mup | PR #6642: cmd/snap-confine: prevent cwd restore permission bypass <Created by zyga> <https://github.com/snapcore/snapd/pull/6642> | 10:35 |
| mvo | zyga: ta | 10:36 |
| zyga | mvo: I'm sure it will need more work because we didn't realise it was broken before | 10:36 |
| zyga | but this should now pass | 10:36 |
| zyga | and since it is now tested, we will not see this mistake again | 10:36 |
| zyga | (core18 caveat applies) | 10:36 |
| zyga | (core18 is mostly untested) | 10:37 |
| * mvo nods | 10:41 | |
| mup | PR snapd#6659 opened: snapcraft: build static fontconfig in the snapd snap <Created by mvo5> <https://github.com/snapcore/snapd/pull/6659> | 10:42 |
| mup | PR core#104 opened: snapcraft.yaml: use remote fc-cache-builder <Created by mvo5> <https://github.com/snapcore/core/pull/104> | 10:50 |
| mborzecki | any idea why we prefer to put completion files under /usr/share/bash-completion/completion rather than /etc/bash_completion.d/ ? | 10:57 |
| cjwatson | /etc/bash_completion.d/ is an old compatibility directory | 11:00 |
| cjwatson | and it's not just a matter of location, it's actually handled differently | 11:01 |
| cjwatson | files in the compat directory are all loaded up-front, whereas files in /usr/share/bash-completion/completion/ are loaded dynamically when needed | 11:01 |
| cjwatson | so installing files in the compat directory imposes a cost on every interactive shell (that loads bash-completion, anyway) | 11:02 |
| Facu | Muy buenos días a todos! | 11:03 |
| mborzecki | cjwatson: thanks! | 11:04 |
| cjwatson | np, happened to be reading up about that recently for something else | 11:05 |
| Chipaca | cjwatson: mborzecki: also files in /etc/bash_completion.d are _only_ loaded up front, meaning you get no completion for a snap you install until you start a new (login, some places) shell | 11:06 |
| Chipaca | also the /usr/share path is more cross-distro than the /etc one | 11:07 |
| cjwatson | Yeah, that too | 11:08 |
| Chipaca | mvo: your triage on https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1821956 makes me think you think it's something we should fix | 11:09 |
| mup | Bug #1821956: snapd can't start in WSL (Windows Subsystem for Linux) <snapd (Ubuntu):Triaged> <https://launchpad.net/bugs/1821956> | 11:09 |
| Chipaca | mvo: I thought supporting WSL was a non-goal | 11:09 |
| mborzecki | Chipaca: that would actually be intersting :) | 11:11 |
| Chipaca | mborzecki: would it? | 11:12 |
| Chipaca | no services and no GUIs | 11:12 |
| Chipaca | and no confinement | 11:12 |
| mborzecki | i mean intersting challenge, though feels a bit academic | 11:12 |
| Chipaca | and no squashfs | 11:12 |
| mup | Bug #1821959 changed: File name breaking go modules <snapd:New> <https://launchpad.net/bugs/1821959> | 11:21 |
| Chipaca | mvo: what's 'cmd/snap-confine/spread-tests/distros/debian.' about? (why the ending period?) | 11:21 |
| zyga | Chipaca: that's sid | 11:22 |
| zyga | Chipaca: because no version id | 11:22 |
| Chipaca | i know it's sid | 11:22 |
| zyga | and that is dead | 11:22 |
| zyga | the ending period is because it is id.version_id | 11:22 |
| zyga | mvo: can you please look at https://github.com/snapcore/snapd/pull/6410 again | 11:23 |
| mup | PR #6410: release-tools: add debian-package-builder <Created by zyga> <https://github.com/snapcore/snapd/pull/6410> | 11:23 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/6643 is the fix that was under embargo before, I think we should just land this patch for historical reference and iterate on anything we planned to (e.g. generator) | 11:28 |
| mup | PR #6643: tests: deny ioctl - TIOCSTI with garbage in high bits <Created by zyga> <https://github.com/snapcore/snapd/pull/6643> | 11:28 |
| zyga | I need a 2nd review for https://github.com/snapcore/snapd/pull/6597 | 11:28 |
| mup | PR #6597: cmd/snap-update-ns: refactor of profile application (1/N) <Created by zyga> <https://github.com/snapcore/snapd/pull/6597> | 11:28 |
| zyga | I also need a 2nd review for https://github.com/snapcore/snapd/pull/6502 | 11:29 |
| mup | PR #6502: dirs,overlord/snapstate: add Soft and Hard refresh checks <Created by zyga> <https://github.com/snapcore/snapd/pull/6502> | 11:29 |
| zyga | jdstrand: I need your 3rd review on https://github.com/snapcore/snapd/pull/6605 | 11:31 |
| mup | PR #6605: cmd/libsnap,osutil: fix parsing of mountinfo <Created by zyga> <https://github.com/snapcore/snapd/pull/6605> | 11:31 |
| jdstrand | zyga: it is on my todo. may not happen today, will try to get to it soon | 11:34 |
| zyga | jdstrand: thanks, that's all I need | 11:34 |
| mup | PR snapd#6658 closed: testutil: run mocked commands through shellcheck <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6658> | 12:09 |
| mvo | pedronis: is 6621 something you want to review again? it got two +1 and your naming suggestion is applied | 12:24 |
| pedronis | mvo: I think John preferred it not to land before it's used | 12:25 |
| pedronis | mvo: it's marked blocked | 12:25 |
| * mvo nods | 12:27 | |
| mup | PR snapd#6660 opened: [RFC] cmd/debug: integrate new task timings with "snap debug timings" <Created by stolowski> <https://github.com/snapcore/snapd/pull/6660> | 12:32 |
| pedronis | mvo: I just noticed we have a bunch of places that depend on osutil.CommandFromCore | 12:39 |
| zyga | pedronis: hey, I made some tweaks to https://github.com/snapcore/snapd/pull/6583/files | 12:39 |
| mup | PR #6583: cmd/snap-confine: move ubuntu-core fallback checks <Created by zyga> <https://github.com/snapcore/snapd/pull/6583> | 12:39 |
| zyga | pedronis: I wonder if we could discuss what's wrong in that idea now and see how to move onwards | 12:39 |
| zyga | pedronis: to unblock core18 fixes and core16 transition | 12:39 |
| pedronis | mvo: that doesn't seem to support snapd at all, also I don't remember it, and osutil feels a bit the wrong place for it | 12:39 |
| pstolowski | mvo: hey, can you have another look at https://github.com/snapcore/snapd/pull/6629 ? | 12:40 |
| mup | PR #6629: overlord/snapshotstate: helpers for dealing with snapshot expirations (automatic snapshots 2/N) <Created by stolowski> <https://github.com/snapcore/snapd/pull/6629> | 12:40 |
| * Chipaca lunches | 12:43 | |
| pedronis | zyga: it's better than the last time I looked | 12:46 |
| pedronis | zyga: I don't like _fallback and forcing all the code to use a helper though | 12:47 |
| pedronis | it defeats a bit the original goal of having the struct at all | 12:47 |
| zyga | pedronis: perhaps I can just set "effective" | 12:50 |
| zyga | and always use that | 12:51 |
| pedronis | zyga: I'm making a suggestion | 12:51 |
| zyga | ok | 12:51 |
| === chihchun is now known as chihchun_afk | ||
| * zyga missed the suggestion about "original" field instead | 12:51 | |
| zyga | it would have equivalent semantics I guess | 12:52 |
| mup | PR snapd#6661 opened: data/selinux, tests/main/selinux-clean: fine tune the policy, make sure that no denials are raised <SELinux> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6661> | 12:56 |
| mborzecki | hopefully a final SELinux related PR ^^ | 12:56 |
| pedronis | zyga: I commented in the PR | 12:58 |
| zyga | pedronis: thanks, that looks great | 13:01 |
| pedronis | zyga: btw, relatedly bu drive-by, should classic.c be called distro.c instead ? it doesn't seem to be just about classic | 13:02 |
| sergiusens | Chipaca: hello there, I have a question about this message "Channel latest/stable for lxd is closed; temporarily forwarding to stable.". Is that going to be fixed at any point in time? | 13:02 |
| pedronis | sergiusens: it should have been fixed | 13:03 |
| sergiusens | pedronis: 2.38? candidate I guess? I can switch and verify if so | 13:04 |
| sergiusens | I am currently on 2.37.4+18.04.1 | 13:04 |
| pedronis | sergiusens: yes, 2.38 | 13:06 |
| pedronis | 2.37 doesn't have the new code | 13:06 |
| pedronis | anyway 2.38 will go to stable today | 13:06 |
| zyga | pedronis: yeah, it's an ancient name | 13:10 |
| zyga | pedronis: perhaps it can be folded further into something else | 13:10 |
| pedronis | zyga: lost context, what is an ancient name? | 13:10 |
| zyga | pedronis: classic.c | 13:11 |
| pedronis | ah | 13:11 |
| pedronis | ok | 13:11 |
| pedronis | it doesn't seem to match the content anymore | 13:11 |
| zyga | pedronis: it's from the day when snap-confine was ubuntu-core-launcher, mostly all in one C file | 13:11 |
| zyga | pedronis: and was not very friendly to work with | 13:11 |
| zyga | pedronis: so as first instinct to understand I started to decompose it | 13:11 |
| pedronis | yea, it's fine | 13:12 |
| pedronis | I just noticed given we were looking into it again | 13:12 |
| zyga | that's good, I'm very happy to make changes to it, my main demotivator in the past was that it would require a security review and slow everything down to a crawl | 13:13 |
| mup | PR snapd#6662 opened: overlord/snapstate,snapshotstate: create snapshot automatically on snap removal <Created by stolowski> <https://github.com/snapcore/snapd/pull/6662> | 13:17 |
| === ricab is now known as ricab|lunch | ||
| zyga | pedronis: updated | 13:30 |
| mborzecki | hm travis jobs are progressing rather slow today | 13:42 |
| pedronis | zyga: last pass, couple more comments | 13:42 |
| zyga | I saw, doing now :) | 13:44 |
| mvo | pedronis: thanks, I check commandFromCore | 13:56 |
| mvo | pstolowski: yeah, I have a look | 13:56 |
| pstolowski | ty | 13:57 |
| ondra | cwayne any luck testing that core18 image? shall I rev for you also core16 image with that kernel? | 14:06 |
| cwayne | ondra: so it did boot, but the usb -> eth dongle were using wasnt supported with that kernel | 14:12 |
| ondra | cwayne OK that would be something to ask ppisati if there there is right driver included | 14:12 |
| mup | PR snapcraft#2512 closed: many: better handling of appstream icons <Created by cmatsuoka> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2512> | 14:19 |
| === ricab|lunch is now known as ricab | ||
| zyga | mvo: after the call, can you have a 2nd look at https://github.com/snapcore/snapd/pull/6583 | 14:48 |
| mup | PR #6583: cmd/snap-confine: move ubuntu-core fallback checks <Created by zyga> <https://github.com/snapcore/snapd/pull/6583> | 14:48 |
| * zyga needs to grab some food | 14:50 | |
| mvo | zyga: yes | 14:51 |
| jdstrand | pedronis, niemeyer (cc mvo, joemcmanus, amurray): I wrote https://forum.snapcraft.io/t/phase-1-of-opt-in-per-snap-users-groups-aka-the-daemon-user/10624. I am not currently blocked and have a lot to work on that isn't dependent on that. so, feel free to ponder | 15:01 |
| mvo | jdstrand: thank you | 15:01 |
| pedronis | jdstrand: thanks, I will look at it early next week the latest | 15:20 |
| jdstrand | pedronis: ack. that works well for me. I can go with the 'easiest-to-change-later' option in my coding until then | 15:21 |
| mup | PR core18#123 opened: hooks: remove /etc/apt/sources.list.d/proposed.list <Created by mvo5> <https://github.com/snapcore/core18/pull/123> | 15:24 |
| mup | PR snapd#6655 closed: timings: AddTag helper <Simple 😃> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6655> | 15:30 |
| * cachio afk | 15:37 | |
| pstolowski | can https://github.com/snapcore/snapd/pull/6657 land? | 15:40 |
| mup | PR #6657: tests: enable opensuse 15 and add force-resolution installing packages <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6657> | 15:40 |
| zyga | pstolowski: looking | 15:41 |
| zyga | yes! | 15:41 |
| pstolowski | g8 | 15:41 |
| pstolowski | ty | 15:41 |
| mup | PR snapd#6657 closed: tests: enable opensuse 15 and add force-resolution installing packages <Created by sergiocazzolato> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6657> | 15:42 |
| mup | PR snapd#6663 opened: cmd: make fmt <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6663> | 15:47 |
| * zyga goes for a bike ride | 15:55 | |
| zyga | I'll be back after dark | 15:55 |
| zyga | I have a few PRs that need 2nd review and a few more that just wait for green | 15:55 |
| mup | PR # closed: core-build#11, core-build#22, core-build#26, core-build#37 | 16:01 |
| mup | PR # opened: core-build#11, core-build#22, core-build#26, core-build#37 | 16:02 |
| mup | PR snapd#6664 opened: cmd/snap,client,daemon,store: layout and sanity tweaks for find/search options <Created by pedronis> <https://github.com/snapcore/snapd/pull/6664> | 16:28 |
| === pstolowski is now known as pstolowski|afk | ||
| mup | PR core#38 closed: Add another pi-config option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/38> | 18:30 |
| mup | PR core#83 closed: move most of the ubuntu-core config deb into the snap snap build <Created by mvo5> <https://github.com/snapcore/core/pull/83> | 18:30 |
| mup | PR core#104 closed: snapcraft.yaml: use remote fc-cache-builder <Created by mvo5> <https://github.com/snapcore/core/pull/104> | 18:30 |
| mup | PR core#38 opened: Add another pi-config option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/38> | 18:31 |
| mup | PR core#83 opened: move most of the ubuntu-core config deb into the snap snap build <Created by mvo5> <https://github.com/snapcore/core/pull/83> | 18:31 |
| mup | PR core#104 opened: snapcraft.yaml: use remote fc-cache-builder <Created by mvo5> <https://github.com/snapcore/core/pull/104> | 18:31 |
| cachio | mvo, pedronis 2.38 is stable now | 18:36 |
| cachio | smoke tests have passed | 18:36 |
| mvo | cachio: thank you! | 19:47 |
| cachio | mvo, yaw | 19:47 |
| cachio | mvo, is it ok if I fix https://github.com/snapcore/snapd/pull/6594 ? | 19:50 |
| mup | PR #6594: [RFC] tests: run smoke tests on (almost) pristine systems <Created by mvo5> <https://github.com/snapcore/snapd/pull/6594> | 19:50 |
| mvo | cachio: sure, much appreicated actually | 19:58 |
| ondra | cwayne when I did another run on that 4.15 kernel I saw some usb errors, and USB hub was dead. You better check if usb was working at all, might not have been incompatibility of you usb->eth | 21:09 |
| ondra | you-your | 21:09 |
| * cachio afk | 21:36 | |
| * zyga noticed odd failure to debug tomorrow | 21:36 | |
| zyga | time to get some sleep, good night! | 21:36 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!