=== chihchun_afk is now known as chihchun [06:20] morning [07:22] Good morning [07:23] hey zyga [07:27] Hey :-) [07:27] Starting later because I started assisting my son to school on a bike [07:27] Very nice way to start the day [07:28] mvo: I got green on that pwd test I added. I tweaked core in test prepare though [07:28] I don’t think it is sufficient for production yet because vanilla core is not right [07:28] But it shows promise :-) [07:29] I will be in the office soon [07:29] zyga: good, is the fix for core18 (git) difficult? [07:32] We will see [07:33] I have not done that yet [07:33] ok [07:35] mvo: zyga: morning guys [07:36] mborzecki: good morning [07:37] PR snapd#6658 opened: testutil: run mocked commands through shellcheck [07:37] pedronis: 6628 has two plus - is that something you want to review as well or can we go ahead and merge? [07:37] fun PR btw ^^^ [07:37] and super simple too :) [07:38] Woooot [07:38] Super [07:38] yeah, some nice things caught too [07:38] mborzecki: nice one [07:38] wonder how udevmon mocking worked without __END__ [07:39] the impact is small on my mock, but i can look into some caching if needed [07:40] mborzecki: reviewed :-) [07:43] zyga: thanks! [07:58] morning [07:59] mborzecki: nice catch with udevmon mock , thanks! [07:59] pstolowski: hey [08:03] hey pstolowski [08:32] mvo: no, I skimmed it originally [08:32] (about 6628) [08:32] and morning [08:34] mvo: I answered in #6404 [08:34] PR #6404: snapstate: auto transition on experimental.snapd-snap=true [08:34] thanks pedronis [08:35] pedronis: I am working on the remodel feedback and get back to this one enext [08:36] PR snapd#6628 closed: overlord/snapshotstate: support auto flag (automatic snapshots 1/N) [08:39] moin moin [08:39] ogra: who can best answer https://forum.snapcraft.io/t/question-about-going-to-production/10609 ? [08:49] Chipaca, i'll take a look after the meeting [08:50] Chipaca, also ... https://forum.snapcraft.io/t/disabling-console-conf-from-gadget-or-core-config-option/4358 [09:06] mborzecki: hi, does your work help with this https://forum.snapcraft.io/t/selinux-blocking-socket-activation-on-fedora/6931/9 or could that be addressed in the context of SELinux new stuff? [09:09] pedronis: it works with the upcoming selinux changes, i still want to try if there's a workaround for the latest 2.38 that neal relased though [09:09] mborzecki: ok, thanks for the info [09:09] pedronis: fwiw the selinux clean test has a socket activation check that was added specifically because of this :) [09:09] mborzecki: great :) === chihchun is now known as chihchun_afk [09:42] hmm systemctl 219 on centos exits with 1 when we ask for a property that doesn't exist for a given unit type [09:43] so snap services output is garbage if there is a socket activated service === chihchun_afk is now known as chihchun [09:49] pstolowski: pushed the updates to #6654 [09:49] PR #6654: packaging/fedora, tests/upgrade/basic: patch existing mount units with SELinux context on upgrade [09:50] mborzecki: thanks, will take a look in a moment [10:08] pstolowski: 6629 just needs two review nows, I don't need to explicitly review it [10:09] pedronis: ack, thanks [10:35] mvo: this is what I meant yesterday https://github.com/snapcore/snapd/pull/6642/commits/758c968ced00023d98da61c457add8c04498781b [10:35] PR #6642: cmd/snap-confine: prevent cwd restore permission bypass [10:36] zyga: ta [10:36] mvo: I'm sure it will need more work because we didn't realise it was broken before [10:36] but this should now pass [10:36] and since it is now tested, we will not see this mistake again [10:36] (core18 caveat applies) [10:37] (core18 is mostly untested) [10:41] * mvo nods [10:42] PR snapd#6659 opened: snapcraft: build static fontconfig in the snapd snap [10:50] PR core#104 opened: snapcraft.yaml: use remote fc-cache-builder [10:57] any idea why we prefer to put completion files under /usr/share/bash-completion/completion rather than /etc/bash_completion.d/ ? [11:00] /etc/bash_completion.d/ is an old compatibility directory [11:01] and it's not just a matter of location, it's actually handled differently [11:01] files in the compat directory are all loaded up-front, whereas files in /usr/share/bash-completion/completion/ are loaded dynamically when needed [11:02] so installing files in the compat directory imposes a cost on every interactive shell (that loads bash-completion, anyway) [11:03] Muy buenos días a todos! [11:04] cjwatson: thanks! [11:05] np, happened to be reading up about that recently for something else [11:06] cjwatson: mborzecki: also files in /etc/bash_completion.d are _only_ loaded up front, meaning you get no completion for a snap you install until you start a new (login, some places) shell [11:07] also the /usr/share path is more cross-distro than the /etc one [11:08] Yeah, that too [11:09] mvo: your triage on https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1821956 makes me think you think it's something we should fix [11:09] Bug #1821956: snapd can't start in WSL (Windows Subsystem for Linux) [11:09] mvo: I thought supporting WSL was a non-goal [11:11] Chipaca: that would actually be intersting :) [11:12] mborzecki: would it? [11:12] no services and no GUIs [11:12] and no confinement [11:12] i mean intersting challenge, though feels a bit academic [11:12] and no squashfs [11:21] Bug #1821959 changed: File name breaking go modules [11:21] mvo: what's 'cmd/snap-confine/spread-tests/distros/debian.' about? (why the ending period?) [11:22] Chipaca: that's sid [11:22] Chipaca: because no version id [11:22] i know it's sid [11:22] and that is dead [11:22] the ending period is because it is id.version_id [11:23] mvo: can you please look at https://github.com/snapcore/snapd/pull/6410 again [11:23] PR #6410: release-tools: add debian-package-builder [11:28] mvo: https://github.com/snapcore/snapd/pull/6643 is the fix that was under embargo before, I think we should just land this patch for historical reference and iterate on anything we planned to (e.g. generator) [11:28] PR #6643: tests: deny ioctl - TIOCSTI with garbage in high bits [11:28] I need a 2nd review for https://github.com/snapcore/snapd/pull/6597 [11:28] PR #6597: cmd/snap-update-ns: refactor of profile application (1/N) [11:29] I also need a 2nd review for https://github.com/snapcore/snapd/pull/6502 [11:29] PR #6502: dirs,overlord/snapstate: add Soft and Hard refresh checks [11:31] jdstrand: I need your 3rd review on https://github.com/snapcore/snapd/pull/6605 [11:31] PR #6605: cmd/libsnap,osutil: fix parsing of mountinfo [11:34] zyga: it is on my todo. may not happen today, will try to get to it soon [11:34] jdstrand: thanks, that's all I need [12:09] PR snapd#6658 closed: testutil: run mocked commands through shellcheck [12:24] pedronis: is 6621 something you want to review again? it got two +1 and your naming suggestion is applied [12:25] mvo: I think John preferred it not to land before it's used [12:25] mvo: it's marked blocked [12:27] * mvo nods [12:32] PR snapd#6660 opened: [RFC] cmd/debug: integrate new task timings with "snap debug timings" [12:39] mvo: I just noticed we have a bunch of places that depend on osutil.CommandFromCore [12:39] pedronis: hey, I made some tweaks to https://github.com/snapcore/snapd/pull/6583/files [12:39] PR #6583: cmd/snap-confine: move ubuntu-core fallback checks [12:39] pedronis: I wonder if we could discuss what's wrong in that idea now and see how to move onwards [12:39] pedronis: to unblock core18 fixes and core16 transition [12:39] mvo: that doesn't seem to support snapd at all, also I don't remember it, and osutil feels a bit the wrong place for it [12:40] mvo: hey, can you have another look at https://github.com/snapcore/snapd/pull/6629 ? [12:40] PR #6629: overlord/snapshotstate: helpers for dealing with snapshot expirations (automatic snapshots 2/N) [12:43] * Chipaca lunches [12:46] zyga: it's better than the last time I looked [12:47] zyga: I don't like _fallback and forcing all the code to use a helper though [12:47] it defeats a bit the original goal of having the struct at all [12:50] pedronis: perhaps I can just set "effective" [12:51] and always use that [12:51] zyga: I'm making a suggestion [12:51] ok === chihchun is now known as chihchun_afk [12:51] * zyga missed the suggestion about "original" field instead [12:52] it would have equivalent semantics I guess [12:56] PR snapd#6661 opened: data/selinux, tests/main/selinux-clean: fine tune the policy, make sure that no denials are raised [12:56] hopefully a final SELinux related PR ^^ [12:58] zyga: I commented in the PR [13:01] pedronis: thanks, that looks great [13:02] zyga: btw, relatedly bu drive-by, should classic.c be called distro.c instead ? it doesn't seem to be just about classic [13:02] Chipaca: hello there, I have a question about this message "Channel latest/stable for lxd is closed; temporarily forwarding to stable.". Is that going to be fixed at any point in time? [13:03] sergiusens: it should have been fixed [13:04] pedronis: 2.38? candidate I guess? I can switch and verify if so [13:04] I am currently on 2.37.4+18.04.1 [13:06] sergiusens: yes, 2.38 [13:06] 2.37 doesn't have the new code [13:06] anyway 2.38 will go to stable today [13:10] pedronis: yeah, it's an ancient name [13:10] pedronis: perhaps it can be folded further into something else [13:10] zyga: lost context, what is an ancient name? [13:11] pedronis: classic.c [13:11] ah [13:11] ok [13:11] it doesn't seem to match the content anymore [13:11] pedronis: it's from the day when snap-confine was ubuntu-core-launcher, mostly all in one C file [13:11] pedronis: and was not very friendly to work with [13:11] pedronis: so as first instinct to understand I started to decompose it [13:12] yea, it's fine [13:12] I just noticed given we were looking into it again [13:13] that's good, I'm very happy to make changes to it, my main demotivator in the past was that it would require a security review and slow everything down to a crawl [13:17] PR snapd#6662 opened: overlord/snapstate,snapshotstate: create snapshot automatically on snap removal === ricab is now known as ricab|lunch [13:30] pedronis: updated [13:42] hm travis jobs are progressing rather slow today [13:42] zyga: last pass, couple more comments [13:44] I saw, doing now :) [13:56] pedronis: thanks, I check commandFromCore [13:56] pstolowski: yeah, I have a look [13:57] ty [14:06] cwayne any luck testing that core18 image? shall I rev for you also core16 image with that kernel? [14:12] ondra: so it did boot, but the usb -> eth dongle were using wasnt supported with that kernel [14:12] cwayne OK that would be something to ask ppisati if there there is right driver included [14:19] PR snapcraft#2512 closed: many: better handling of appstream icons === ricab|lunch is now known as ricab [14:48] mvo: after the call, can you have a 2nd look at https://github.com/snapcore/snapd/pull/6583 [14:48] PR #6583: cmd/snap-confine: move ubuntu-core fallback checks [14:50] * zyga needs to grab some food [14:51] zyga: yes [15:01] pedronis, niemeyer (cc mvo, joemcmanus, amurray): I wrote https://forum.snapcraft.io/t/phase-1-of-opt-in-per-snap-users-groups-aka-the-daemon-user/10624. I am not currently blocked and have a lot to work on that isn't dependent on that. so, feel free to ponder [15:01] jdstrand: thank you [15:20] jdstrand: thanks, I will look at it early next week the latest [15:21] pedronis: ack. that works well for me. I can go with the 'easiest-to-change-later' option in my coding until then [15:24] PR core18#123 opened: hooks: remove /etc/apt/sources.list.d/proposed.list [15:30] PR snapd#6655 closed: timings: AddTag helper [15:37] * cachio afk [15:40] can https://github.com/snapcore/snapd/pull/6657 land? [15:40] PR #6657: tests: enable opensuse 15 and add force-resolution installing packages [15:41] pstolowski: looking [15:41] yes! [15:41] g8 [15:41] ty [15:42] PR snapd#6657 closed: tests: enable opensuse 15 and add force-resolution installing packages [15:47] PR snapd#6663 opened: cmd: make fmt [15:55] * zyga goes for a bike ride [15:55] I'll be back after dark [15:55] I have a few PRs that need 2nd review and a few more that just wait for green [16:01] PR # closed: core-build#11, core-build#22, core-build#26, core-build#37 [16:02] PR # opened: core-build#11, core-build#22, core-build#26, core-build#37 [16:28] PR snapd#6664 opened: cmd/snap,client,daemon,store: layout and sanity tweaks for find/search options === pstolowski is now known as pstolowski|afk [18:30] PR core#38 closed: Add another pi-config option [18:30] PR core#83 closed: move most of the ubuntu-core config deb into the snap snap build [18:30] PR core#104 closed: snapcraft.yaml: use remote fc-cache-builder [18:31] PR core#38 opened: Add another pi-config option [18:31] PR core#83 opened: move most of the ubuntu-core config deb into the snap snap build [18:31] PR core#104 opened: snapcraft.yaml: use remote fc-cache-builder [18:36] mvo, pedronis 2.38 is stable now [18:36] smoke tests have passed [19:47] cachio: thank you! [19:47] mvo, yaw [19:50] mvo, is it ok if I fix https://github.com/snapcore/snapd/pull/6594 ? [19:50] PR #6594: [RFC] tests: run smoke tests on (almost) pristine systems [19:58] cachio: sure, much appreicated actually [21:09] cwayne when I did another run on that 4.15 kernel I saw some usb errors, and USB hub was dead. You better check if usb was working at all, might not have been incompatibility of you usb->eth [21:09] you-your [21:36] * cachio afk [21:36] * zyga noticed odd failure to debug tomorrow [21:36] time to get some sleep, good night!