| === chihchun is now known as chihchun_afk | ||
| === epod is now known as luk3yx | ||
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| mborzecki | morning | 05:11 |
|---|---|---|
| zyga | Hi | 05:26 |
| mborzecki | zyga: hey | 05:26 |
| zyga | How are you? | 05:27 |
| mborzecki | zyga: are we goign to be equally unlucky today? i've restarted some travis jobs yesterday evening, and all are red :/ | 05:27 |
| zyga | Whaaat | 05:28 |
| zyga | Why? | 05:28 |
| zyga | What is failing? | 05:28 |
| mborzecki | zyga: one failed with prepare image, another in go-build:s390x, the last one probably maanged to hit some mirror sync | 05:29 |
| zyga | Eh | 05:30 |
| zyga | Assorted bad luck | 05:30 |
| mborzecki | zyga: prepare-image was probably some issue fetching snaps from the store | 05:30 |
| zyga | Iām with the dog, outside | 05:30 |
| mborzecki | and the 4th job got 502 when pulling gopkg.in/yaml.v2 :P | 05:31 |
| zyga | Is the store wonky today? | 05:31 |
| mborzecki | feels like i should play some euro jackpot today | 05:31 |
| zyga | Haha | 05:32 |
| zyga | Nice | 05:33 |
| zyga | Yesterday I learned that apple support should be split in two | 05:33 |
| mborzecki | is #6667 waiting for something else? | 05:33 |
| mup | PR #6667: tests: enable tests that write /etc/{hostname,timezone} on core18 <Created by mvo5> <https://github.com/snapcore/snapd/pull/6667> | 05:33 |
| mborzecki | zyga: sup and port? | 05:34 |
| zyga | 90% of the people came with a shattered phone | 05:34 |
| zyga | That took forever | 05:34 |
| zyga | Looking at 6667 | 05:34 |
| mborzecki | zyga: many people are clumsy then :) | 05:34 |
| zyga | Hmm | 05:35 |
| zyga | Maybe ok to land? | 05:35 |
| mborzecki | #6659 can probably land too | 05:35 |
| mup | PR #6659: snapcraft: build static fontconfig in the snapd snap <Created by mvo5> <https://github.com/snapcore/snapd/pull/6659> | 05:35 |
| zyga | Mvo will be around soon | 05:35 |
| zyga | Yes | 05:35 |
| zyga | +1 there | 05:35 |
| mborzecki | there will be a followup but somewhere else in the code | 05:36 |
| zyga | re | 05:45 |
| zyga | back in the office | 05:45 |
| mup | PR snapd#6502 closed: dirs,overlord/snapstate: add Soft and Hard refresh checks <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6502> | 05:46 |
| zyga | eh, I feel even more sick than yesterday now | 05:47 |
| zyga | mborzecki: can you please review https://github.com/snapcore/snapd/pull/6643 | 05:48 |
| mup | PR #6643: tests: deny ioctl - TIOCSTI with garbage in high bits <Created by zyga> <https://github.com/snapcore/snapd/pull/6643> | 05:48 |
| zyga | it's something that should have landed weeks ago but was under embargo | 05:48 |
| zyga | hello mvo | 05:48 |
| mvo | zyga: good morning | 05:51 |
| mborzecki | mvo: hey | 05:51 |
| mvo | zyga: how are you? how is the testing situation? | 05:51 |
| mvo | hey mborzecki | 05:51 |
| mvo | mborzecki: anything on the suspected memleak? | 05:52 |
| zyga | mvo: I have a running nose and something in my lungs :/ I probably will skip japanese classes today | 05:52 |
| mborzecki | mvo: no, Chipaca asked some questions in the LP bug | 05:52 |
| zyga | mvo: tests are grim, failing on assorted collection of random annoyances | 05:52 |
| zyga | from network to more network to random stuff | 05:52 |
| mvo | zyga: :( | 05:53 |
| mvo | zyga: I saw that archive.u.c had some issues last evening | 05:53 |
| mvo | mborzecki: cool, keen to learn what john figured out, I will check the bug | 05:53 |
| mborzecki | zyga: mvo: do you use auditd and ausearch on ubuntu? | 06:03 |
| zyga | no | 06:03 |
| zyga | well | 06:03 |
| zyga | auditd maybe | 06:03 |
| zyga | but not ausearch | 06:03 |
| mborzecki | ha | 06:06 |
| mborzecki | ok | 06:06 |
| mborzecki | so ausearch does not properly report denials from apparmor on arch, thought that ubuntu may carry some patches that fix that, but apparently not, doesn't work on ubuntu either | 06:07 |
| mborzecki | so only uses has extra patches to fix that | 06:07 |
| mborzecki | Malformed event skipped, rc=9. type=AVC msg=audit(1554271576.256:61): apparmor="DENIED" operation="open" profile="snap.hello-world.sh" name="/home/guest/" pid=13765 comm="bash" requested_mask="r" denied_mask="r" fsuid=1000 ouid=1000 | 06:07 |
| mborzecki | that's what I see on ubuntu (and arch for that matter too) when runnig ausearch -m AVC --debug | 06:07 |
| mborzecki | just ausearch -m AVC shows <no matches> | 06:07 |
| mborzecki | i suggested name tweaks in #6656 but i'm not sure it's worth risking another travis run at this point, maybe we should just land it | 06:10 |
| mup | PR #6656: tests: split travis spread execution in 2 jobs for ubuntu and non ubuntu systems <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6656> | 06:10 |
| mup | PR snapd#6674 closed: tests: use apt via eatmydata <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6674> | 06:11 |
| mborzecki | hm https://bugs.launchpad.net/ubuntu/+source/audit/+bug/1117804 | 06:15 |
| mup | Bug #1117804: ausearch doesn't show AppArmor denial messages <apparmor> <AppArmor:Confirmed> <audit (Ubuntu):Confirmed> <linux (Ubuntu):Incomplete> <https://launchpad.net/bugs/1117804> | 06:15 |
| zyga | 2014 | 06:16 |
| mborzecki | zyga: yeah, suse carries a patch that was submitted upstream, but then the discussion went to apparmor not using some common audit ids and thus being wrongly interpreted in userspace or sth | 06:16 |
| mborzecki | zyga: oh, and suse patch just works aroudn that in the userspace parser :P | 06:17 |
| zyga | kernel stuff is hard | 06:17 |
| mup | PR snapd#6672 closed: metautil, snap: extract yaml value normalization to a helper package <Simple š> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6672> | 06:20 |
| mborzecki | ehh, opensuse this time: Some of the repositories have not been refreshed because of an error. | 06:21 |
| mborzecki | mvo: zyga: what about #6677, do we want to keep golang.org/x/sys/unix pinned? | 06:22 |
| mup | PR #6677: vendor: pin golang.org/x/sys/unix to a revision before SYS_CLOCK_GETTIME on OSX <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6677> | 06:22 |
| mvo | mborzecki: now that things are fixed again upstream I would say we don't need to pin until the next issue like this? the risk of pinning is that stay behind forever and don't get e.g. security fixes | 06:23 |
| zyga | mborzecki: I would unpin it | 06:34 |
| mborzecki | mvo: zyga: ack, closed the PR | 06:36 |
| zyga | because this gives us error visibility at the cost of ... well ... errors | 06:36 |
| mup | PR snapd#6677 closed: vendor: pin golang.org/x/sys/unix to a revision before SYS_CLOCK_GETTIME on OSX <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/6677> | 06:36 |
| mvo | thanks mborzecki | 06:39 |
| * zyga prepares the next refresh app awareness batch | 06:53 | |
| zyga | not a big one, but functional one | 06:53 |
| pedronis | mvo: hi, need to decided what to do with #6659, follow up needs to be tracked, and #6667 is green | 06:56 |
| mup | PR #6659: snapcraft: build static fontconfig in the snapd snap <Created by mvo5> <https://github.com/snapcore/snapd/pull/6659> | 06:56 |
| mup | PR #6667: tests: enable tests that write /etc/{hostname,timezone} on core18 <Created by mvo5> <https://github.com/snapcore/snapd/pull/6667> | 06:56 |
| pstolowski|afk | morning | 07:08 |
| === pstolowski|afk is now known as pstolowski | ||
| zyga | hey pedronis, hey pawel | 07:17 |
| mborzecki | pstolowski: pedronis: hello guys | 07:18 |
| pstolowski | pedronis: hey, #6665 has 2 +1s; would you like to take a look or can it land? | 07:26 |
| mup | PR #6665: overlord/ifacestate: implement String() method of HotplugDeviceInfo for better logs/messages <Hotplug š> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6665> | 07:26 |
| pedronis | pstolowski: I need to take a look | 07:27 |
| pstolowski | k | 07:29 |
| pedronis | pstolowski: we don't use "<...>" style of representation anywhere so far | 07:29 |
| pedronis | so I need to think a bit actually | 07:29 |
| pstolowski | pedronis: ok; i think it'd make sense to somehow wrap this representation up as it's a bit long | 07:30 |
| pedronis | pstolowski: yes, they are bit long; too long? | 07:31 |
| pstolowski | pedronis: maybe; maybe vendor/model should be omitted | 07:33 |
| pedronis | pstolowski: well model seems important, are vendor usually that long? | 07:34 |
| mup | PR core18#125 closed: hooks: create snapd directory skeleton <Created by zyga> <Merged by sil2100> <https://github.com/snapcore/core18/pull/125> | 07:38 |
| pstolowski | pedronis: not really; but models can be long, three examples from my VM: | 07:38 |
| pstolowski | ES1371/ES1373 / Creative Labs CT2518 (Audio PCI 64V/128/5200 / Creative CT4810/CT5803/CT5806 [Sound Blaster PCI]) | 07:38 |
| pstolowski | 82545EM Gigabit Ethernet Controller (Copper) (PRO/1000 MT Single Port Adapter) | 07:38 |
| pstolowski | 53c1030 PCI-X Fusion-MPT Dual Ultra320 SCSI (LSI Logic Parallel SCSI Controller) | 07:38 |
| pedronis | pstolowski: so model usually contains also the vendor name? | 07:39 |
| pstolowski | pedronis: it seems so, we could get rid of vendor | 07:40 |
| zyga | pedronis: usually the rules are: there are no rules :) | 07:40 |
| pedronis | zyga: that's fine, we still need to do something reasonable and consistent with the rest of our code | 07:41 |
| zyga | I totally agree | 07:41 |
| pedronis | that PR is not there yet from my POV | 07:42 |
| zyga | I think, while this may be odd, that a lookaside table (in the store perhaps) may be the best outcome | 07:42 |
| zyga | for real usability | 07:42 |
| pedronis | that is over ambitious considering were we are now :) | 07:43 |
| zyga | is it? we can just reply with what is in the usb database already | 07:44 |
| zyga | and we can fix ugly things one-by-one as encountered | 07:44 |
| pedronis | zyga: ? | 07:44 |
| zyga | I mean, it's not out of reach | 07:44 |
| pedronis | zyga: what are you proposing? (I'm missing something here, given that you mentioned the store) | 07:45 |
| pedronis | zyga: I notice that you gave +1 to that PR without further comments | 07:45 |
| zyga | pedronis: that using a simple solution now (no transformations) and planning to use the store for nice descriptions should be done | 07:45 |
| pedronis | pstolowski: anyway the closest thing we have to this sort of display problem atm is this: https://github.com/snapcore/snapd/blob/master/asserts/asserts.go#L196 (though assertions are much more structured than what we have here) | 07:47 |
| pstolowski | zyga: #6605 has conflicts | 07:53 |
| mup | PR #6605: cmd/libsnap,osutil: fix parsing of mountinfo <Created by zyga> <https://github.com/snapcore/snapd/pull/6605> | 07:53 |
| pstolowski | pedronis: yes, in fact i was looking at assertions for inspiration ;) | 07:54 |
| mborzecki | pstolowski: you could skip serial for sure | 07:54 |
| mborzecki | devpath can be quite long usually since, but devname is preferred anyway | 07:55 |
| zyga | pstolowski: I know, waiting for a review from Jamie though | 07:56 |
| pedronis | he said he should be back reviewing things, now that he draft the daemon user stuff | 07:57 |
| pedronis | *drafted | 07:57 |
| mborzecki | heh fedora 30 beta released, fedora repos back to the usual not-responding-when-release mode | 07:58 |
| pstolowski | :) | 08:02 |
| mwhudson | we just get that when we release kernels | 08:34 |
| mup | PR snapd#6682 opened: snap, gadget: move gadget read/validation into separate package, tweak naming <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6682> | 08:53 |
| mborzecki | pedronis: mvo: gadget package split ^^ | 08:56 |
| mvo | mborzecki: nice, I have a look | 08:56 |
| mborzecki | mvo: twekaed the naming too, so snap.GadgetSize is now gadget.Size and such | 08:56 |
| mborzecki | aaand damn go 1.9 fmt | 08:57 |
| mvo | mborzecki: nice | 09:00 |
| mborzecki | hope this lands soon | 09:03 |
| mvo | mborzecki: yeah, it will be a massive source of conflicts, right? | 09:03 |
| mborzecki | mvo: yeah | 09:03 |
| mborzecki | mvo: merging or rebasing changes on top is super annoying | 09:04 |
| pedronis | pstolowski: some comments in 6665, happy to get feedback back on what I propose | 09:05 |
| === chihchun is now known as chihchun_afk | ||
| mup | PR core18#123 closed: hooks: remove /etc/apt/sources.list.d/proposed.list <Created by mvo5> <Merged by sil2100> <https://github.com/snapcore/core18/pull/123> | 09:18 |
| pstolowski | pedronis: thanks | 09:19 |
| zyga | mvo: now that https://github.com/snapcore/core18/pull/125 is merged, how soon can we get core18 build? | 09:24 |
| mup | PR core18#125: hooks: create snapd directory skeleton <Created by zyga> <Merged by sil2100> <https://github.com/snapcore/core18/pull/125> | 09:24 |
| pedronis | that reminds me, is there a deep reason why we kept firstboot in snapd.dirs, is not used anymore since long time | 09:26 |
| mvo | zyga: let me see | 09:27 |
| mvo | pedronis: that sound like an oversight (90% confident) | 09:27 |
| mvo | zyga: I triggered a new core18 build, should be ready in ~30min or so (depending on the buildds) | 09:38 |
| zyga | super, thanks! | 09:38 |
| pedronis | mborzecki: assuming all the renames are relatively obvious I don't need to review 6682 | 09:39 |
| === ricab is now known as ricab|bbl | ||
| mup | PR snapd#6436 closed: interfaces: add system-backup interface <ā Blocked> <Created by jdstrand> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/6436> | 09:44 |
| pedronis | mvo: I did another pass on some of the remodel PRs, the main one needs 2nd reviews | 09:44 |
| mborzecki | pedronis: ack | 09:45 |
| mborzecki | https://github.com/snapcore/snapd/pull/6656 is green, are we moving forward with the plan to split the travis jobs to ubuntu and non-ubuntu? | 09:46 |
| mup | PR #6656: tests: split travis spread execution in 2 jobs for ubuntu and non ubuntu systems <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6656> | 09:46 |
| pedronis | mborzecki: sounds best to re-discuss it quickly at today standup | 09:47 |
| mborzecki | pedronis: ok | 09:47 |
| pedronis | mvo: any reasons not to merge #6667 ? | 09:47 |
| mup | PR #6667: tests: enable tests that write /etc/{hostname,timezone} on core18 <Created by mvo5> <https://github.com/snapcore/snapd/pull/6667> | 09:47 |
| === chihchun_afk is now known as chihchun | ||
| pstolowski | zyga: added a few comments to #6643 | 09:52 |
| mup | PR #6643: tests: deny ioctl - TIOCSTI with garbage in high bits <Created by zyga> <https://github.com/snapcore/snapd/pull/6643> | 09:52 |
| mvo | pedronis: the SRU is not out yet officially, we just have the fixes in the ppa | 09:56 |
| mup | PR snapd#6654 closed: packaging/fedora, tests/upgrade/basic: patch existing mount units with SELinux context on upgrade <SELinux> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6654> | 10:06 |
| pedronis | mvo: so verifications will fail in some cases? | 10:07 |
| pedronis | mvo: should it be marked blocked then? | 10:07 |
| mvo | pedronis: I think so, let me do that and add a small explaination | 10:11 |
| pedronis | pstolowski: I reivewed #6660 | 10:17 |
| mup | PR #6660: cmd/debug: integrate new task timings with "snap debug timings" <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6660> | 10:17 |
| mvo | sil2100: re 121 for core18 - I'm on it, I think I know what is going on | 10:20 |
| Chipaca | hmm, hmm | 10:24 |
| Chipaca | mborzecki: this maybeShellcheck has broken a lot of tests here | 10:24 |
| Chipaca | grmbl grmbl | 10:24 |
| pstolowski | pedronis: ty | 10:25 |
| mborzecki | Chipaca: which tests? | 10:28 |
| Chipaca | mborzecki: the unit tests | 10:29 |
| mborzecki | Chipaca: master seems fine | 10:30 |
| Chipaca | mborzecki: this is on master | 10:30 |
| Chipaca | mborzecki: pastebinning in a bit | 10:31 |
| mborzecki | Chipaca: hm all fine here | 10:31 |
| Chipaca | mborzecki: is your shellcheck from the snap | 10:31 |
| mborzecki | Chipaca: no, let me try that | 10:31 |
| Chipaca | mborzecki: http://paste.ubuntu.com/p/9R5g6QFTtd/ | 10:32 |
| mborzecki | Chipaca: see the same here | 10:34 |
| mborzecki | haha, it's /tmp | 10:34 |
| Chipaca | you done fucked up, son | 10:34 |
| Chipaca | :-) | 10:34 |
| mborzecki | shellcheck from snap cannot access that probably | 10:34 |
| mborzecki | because it gets a private tmp | 10:34 |
| mborzecki | hmm hmm, not sure there's a workaround for that, unless shellcheck becomes classic | 10:36 |
| mborzecki | or check uses a different tmp directory | 10:37 |
| Chipaca | mborzecki: you've got the script | 10:38 |
| Chipaca | mborzecki: why not just feed it to shellcheck | 10:38 |
| mborzecki | Chipaca: ah right, that's another option all right | 10:38 |
| mborzecki | Chipaca: fix coming up | 10:50 |
| mup | PR snapd#6683 opened: testutil: make mocked command work with shellcheck from snaps <Simple š> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6683> | 10:56 |
| mborzecki | Chipaca: ^^ can you do the honors? | 10:56 |
| Chipaca | mborzecki: for extra fun, go could be running from a snap as well :-) | 10:57 |
| mborzecki | Chipaca: all on ubuntu core :P | 10:57 |
| Chipaca | well, no, because go is classic | 10:57 |
| mborzecki | ah, right | 10:57 |
| pstolowski | pedronis: ok to drop serial in #6665 ? | 10:59 |
| mup | PR #6665: overlord/ifacestate: implement String() method of HotplugDeviceInfo for better logs/messages <Hotplug š> <ā Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6665> | 10:59 |
| mborzecki | Chipaca: could have made it more fancy, like os.Open(), io.Copy(), but meh | 11:00 |
| Chipaca | mborzecki: i thought the same on reading it | 11:00 |
| pedronis | pstolowski: is it useful or not? | 11:00 |
| pedronis | pstolowski: how long do they tend to be? | 11:00 |
| pstolowski | pedronis: only if you have more instances of same device i suppose, to somehow distinguish them | 11:01 |
| pedronis | pstolowski: yea, as I said we could truncate them | 11:01 |
| pedronis | but I'm not sure how long they tend to be | 11:01 |
| mborzecki | back to zyga's PR | 11:02 |
| mvo | sergiusens: ideas about lp 1822988 would be great | 11:04 |
| mvo | sil2100: -^ | 11:04 |
| pedronis | pstolowski: my current feeling it to leave it, not do truncating yet, and see how it works out in practice | 11:10 |
| pedronis | pstolowski: we also need to deal with the fact that hotplug keys are long/unwieldy of their own | 11:11 |
| pstolowski | pedronis: ok, will only truncate model/vendor | 11:13 |
| pedronis | pstolowski: but as you said, it seems we should indeed swap SHORT and non-SHORT for serial, I mean prefer SHORT if it exists | 11:13 |
| pedronis | for this use | 11:13 |
| pstolowski | pedronis: yes | 11:13 |
| === ricab|bbl is now known as ricab | ||
| mborzecki | pstolowski: can you take a look at #6682? | 11:28 |
| mup | PR #6682: snap, gadget: move gadget read/validation into separate package, tweak naming <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6682> | 11:28 |
| pstolowski | mborzecki: yes! | 11:29 |
| mborzecki | pstolowski: thanks! | 11:29 |
| === chihchun is now known as chihchun_afk | ||
| pstolowski | pedronis: updated #6665 | 11:39 |
| mup | PR #6665: overlord/ifacestate: implement String() method of HotplugDeviceInfo for better logs/messages <Hotplug š> <ā Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6665> | 11:39 |
| mvo | 6577 needs a second review | 11:43 |
| mup | PR snapd#6683 closed: testutil: make mocked command work with shellcheck from snaps <Simple š> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6683> | 11:44 |
| * Chipaca ā lunch | 11:44 | |
| zyga | Chipaca: I would love your review of 6684 | 11:45 |
| mup | PR snapd#6684 opened: overlord,tests: perform soft refresh check in doInstall <Created by zyga> <https://github.com/snapcore/snapd/pull/6684> | 11:45 |
| Chipaca | zyga: ack | 11:45 |
| zyga | it's deceptively short :) | 11:45 |
| zyga | and works in spread | 11:45 |
| vidal72[m] | is there a way to list snaps that use core18? | 11:51 |
| Chipaca | zyga: +1, with a silly suggestion you can ignore | 11:52 |
| Chipaca | vidal72[m]: installed ones? | 11:52 |
| zyga | Chipaca: wow, that's quick :) | 11:53 |
| jdstrand | mborzecki: re ausearch, I can't remember otoh, but either jjohansen1, ChrisCoulson or tyhicks would have more info on ausearch and apparmor | 11:53 |
| zyga | so... I need a 2nd review :) | 11:53 |
| * cachio afk | 11:54 | |
| jdstrand | mborzecki: ah yes, I see now in backscroll you found the bug and extra context | 11:54 |
| vidal72[m] | Chipaca: no, those avalaible on store | 11:55 |
| Chipaca | vidal72[m]: no | 11:55 |
| vidal72[m] | :( | 11:55 |
| jdstrand | zyga: if that 2nd review was for me, please remember I was asked to focus on something ahead of all others, a queue formed and I will get through it. I promise | 11:55 |
| zyga | jdstrand: no no :) | 11:55 |
| jdstrand | ok :) | 11:56 |
| zyga | jdstrand: there are lots of people who can review that | 11:56 |
| zyga | and it's not security oriented | 11:56 |
| Chipaca | vidal72[m]: why do you care? | 11:56 |
| jdstrand | I thought this was a 6605 reminder :) | 11:56 |
| mborzecki | jdstrand: yeah, it seems the bug got deprioritized, which is ok, there's workarounds | 11:56 |
| jdstrand | see, it is so much in the queue I typed that from memory :) | 11:56 |
| jdstrand | I'm currently a bit stretched thin. joe is trying to help with that | 11:58 |
| jdstrand | mborzecki: you could ask the priority in #apparmor on OFTC. ChrisCoulson was assigned that at one point, but, yes, it got deprioritzed for various reasons | 11:59 |
| vidal72[m] | Chipaca: I don't want to install ones using older base | 12:00 |
| Chipaca | vidal72[m]: why? | 12:00 |
| mborzecki | zyga: nice review from opensuse again, pretty thorough | 12:01 |
| mborzecki | anyone wants to take a look at #6661? | 12:03 |
| mup | PR #6661: data/selinux, tests/main/selinux-clean: fine tune the policy, make sure that no denials are raised <SELinux> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6661> | 12:03 |
| vidal72[m] | Chipaca: they are built without additional compiler hardening | 12:03 |
| mborzecki | hopefully that's the last one in the selinux series | 12:03 |
| Chipaca | vidal72[m]: what? | 12:03 |
| pstolowski | zyga: i raised one general question to #6643 ; my mistake for not adding that to review summary, it's kinda easy to miss and github makes it annoying to answer this kind of comments (no Reply underneath) | 12:07 |
| mup | PR #6643: tests: deny ioctl - TIOCSTI with garbage in high bits <Created by zyga> <https://github.com/snapcore/snapd/pull/6643> | 12:07 |
| zyga | mvo: I'm not feeling very well and I'd like to take the 2nd half of the day off | 12:07 |
| zyga | mvo: my highlights for the day are https://github.com/snapcore/snapd/pull/6684 which gives us the first part of working refresh app awareness | 12:08 |
| mup | PR #6684: overlord,tests: perform soft refresh check in doInstall <Created by zyga> <https://github.com/snapcore/snapd/pull/6684> | 12:08 |
| zyga | mvo: and the suse review from https://bugzilla.suse.com/show_bug.cgi?id=1127366 | 12:08 |
| zyga | mvo: both will need more work as you can suspect | 12:08 |
| vidal72[m] | Chipaca: https://wiki.ubuntu.com/Security/Features | 12:09 |
| mborzecki | pstolowski: whdyt about https://github.com/snapcore/snapd/pull/6682#discussion_r271708445 ? | 12:10 |
| mup | PR #6682: snap, gadget: move gadget read/validation into separate package, tweak naming <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6682> | 12:10 |
| vidal72[m] | Chipaca: some mitigations are enabled only since bionic | 12:10 |
| mborzecki | pstolowski: the catch is that we'll probably end up extracting snaps (instead of mounting them) like ubuntu-image does once we start to lear how to assemble an image | 12:11 |
| vidal72[m] | Chipaca: https://forum.snapcraft.io/t/build-snaps-with-hardened-toolchain-by-default/5444 | 12:11 |
| Chipaca | vidal72[m]: gotcha | 12:12 |
| Chipaca | vidal72[m]: 'snap info --verbose' will tell you the base of the most-stable channel of a snap | 12:13 |
| Chipaca | for arbitrary value of most-stable (but it's usually what you want) | 12:13 |
| vidal72[m] | ok, thx | 12:13 |
| Chipaca | vidal72[m]: otherwise, e.g., curl -s -H Snap-Device-Series:16 'https://api.snapcraft.io/v2/snaps/info/gnome-calculator?fields=base' | jq -r '.["channel-map"][] | .channel.name + "/" + .channel.architecture + ": " + .base' | 12:15 |
| pstolowski | mborzecki: works for me | 12:20 |
| pstolowski | mborzecki: perhaps mvo can vote as well | 12:21 |
| === chihchun_afk is now known as chihchun | ||
| pedronis | zyga: what's the status of #6583 ? | 12:52 |
| mup | PR #6583: cmd/snap-confine: move ubuntu-core fallback checks <Created by zyga> <https://github.com/snapcore/snapd/pull/6583> | 12:52 |
| zyga | I think it needs a 2nd review and I just kicked tests that may acutally pass now | 12:53 |
| zyga | mvo: ^ can you finish your review there please | 12:53 |
| * zyga is skipping the standup and officially EODing now | 13:00 | |
| mvo | thanks for the update zyga, enjoy eod | 13:00 |
| zyga | thanks (cough, literally) | 13:01 |
| === ricab is now known as ricab|lunch | ||
| mvo | zyga: in this case, get well! | 13:05 |
| mup | PR snapd#6656 closed: tests: split travis spread execution in 2 jobs for ubuntu and non ubuntu systems <Created by sergiocazzolato> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6656> | 13:12 |
| sergiusens | mvo: let me take a look | 13:21 |
| mvo | sergiusens: thank you! | 13:26 |
| sergiusens | mvo: commented on bug and PR | 13:28 |
| mvo | sergiusens: yay, thank you - I think scriptlet is what we will do \o/ | 13:29 |
| mvo | sergiusens: we really just need control over the ENV and that gives it | 13:29 |
| mup | PR snapd#6682 closed: snap, gadget: move gadget read/validation into separate package, tweak naming <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6682> | 13:32 |
| mborzecki | sil2100: do you prefer a force push to https://github.com/CanonicalLtd/ubuntu-image/pull/168 or another commit on top of the current one? | 13:41 |
| mup | PR CanonicalLtd/ubuntu-image#168: ubuntu_image: parser improvements <Created by bboozzoo> <https://github.com/CanonicalLtd/ubuntu-image/pull/168> | 13:41 |
| mup | PR # closed: core-build#11, core-build#22, core-build#26, core-build#37 | 14:09 |
| mup | PR # opened: core-build#11, core-build#22, core-build#26, core-build#37 | 14:10 |
| === ricab|lunch is now known as ricab | ||
| === chihchun is now known as chihchun_afk | ||
| sergiusens | mvo: hey, here's more context on why I want the "second part" https://forum.snapcraft.io/t/snap-try-messaging-and-user-experience/10667/2 | 15:30 |
| kyrofa | I have a user tracking the stable channel, but is months out of date. `snap changes` shows nothing. Manual refreshes work. Does this ring any bells? | 15:33 |
| === chihchun_afk is now known as chihchun | ||
| pedronis | Chipaca: you should probably look at #6679 (at least the daemon bits), there are some questions for you there | 15:43 |
| mup | PR #6679: many: implement user removal <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/6679> | 15:43 |
| pedronis | cmatsuoka: I did a pass on ^ as well | 15:44 |
| cmatsuoka | pedronis: thanks samuele, I'll provide a commit addressing those issues | 15:47 |
| ijohnson | kyrofa: are they using a brand store, such as on a dell gateway for example? | 15:51 |
| kyrofa | ijohnson, I don't believe so, no | 15:53 |
| kyrofa | Otherwise refresh control, you're thinking? | 15:53 |
| ijohnson | yeah I had a similar issue recently with a user trying to install a snap on a dell gateway and the snap was gated (because of refresh-control in the default dell brand store) and that particular snap update had not been verified yet | 15:55 |
| pedronis | jdstrand: hi, I added one more snapd PR to your queue, I think you have 3 now, plus something landed I think where you were asked for a post-review today | 15:56 |
| * cachio lunch | 15:57 | |
| === pstolowski is now known as pstolowski|afk | ||
| jdstrand | pedronis: ack, yep. I'm going to go through various store requests, emails then circle back around to reviews | 17:46 |
| cachio | mvo, https://travis-ci.org/snapcore/spread-cron/builds/515129348 | 17:53 |
| cachio | mvo, I saw that error on revert test | 17:53 |
| cachio | mvo, perhaps the trace helps to understand | 17:54 |
| cachio | mvo, https://travis-ci.org/snapcore/spread-cron/builds/515129348#L2201 | 17:56 |
| mvo | cachio: thanks, looking in a bit | 18:01 |
| cachio | niemeyer, hey, when you have time could you please take a look to https://github.com/snapcore/spread/pull/75 ? | 18:45 |
| cachio | thanks | 18:45 |
| mup | PR spread#75: Make spread tests for spread project run on google backend <Created by sergiocazzolato> <https://github.com/snapcore/spread/pull/75> | 18:45 |
| Wimpress | Snapcraft Live starts in a few minutes - https://twitter.com/snapcraftio/status/1113512766889963522 | 18:46 |
| * cachio afk | 19:04 | |
| mup | PR snapd#6685 opened: image: prefer local for snapd/core snaps <Created by mvo5> <https://github.com/snapcore/snapd/pull/6685> | 19:12 |
| Chipaca | zyga: gif is pronounced with the g as in gnat, the i as in suit, and the f as the second one in fifth | 19:12 |
| zyga | Chipaca: isn't gif the endless topic of discussion on how to pronounce it? :-) | 19:13 |
| Chipaca | zyga: yes :-) | 19:21 |
| mup | PR snapd#6686 opened: testutil: fix MockCmd for shellcheck 0.5 <Created by mvo5> <https://github.com/snapcore/snapd/pull/6686> | 19:25 |
| niemeyer | cachio: Need to finish something else before coming back into it, but it's on my list for after that | 19:42 |
| cachio | niemeyer, np | 20:08 |
| cachio | niemeyer, thankd | 20:36 |
| cachio | niemeyer, thanks | 20:36 |
| mup | PR snapcraft#2520 opened: snap: set core as a base <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2520> | 23:09 |
| mup | PR snapcraft#2521 opened: cli: cleanup environment detection <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2521> | 23:24 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!