mwhudsonanyone around who wants to talk about https://github.com/snapcore/snapd/pull/670000:56
mupPR #6700: packaging: disable -buildmode=pie to fix memory issue on armhf <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6700>00:56
zygagood morning06:00
zygamwhudson: hey06:00
zygamwhudson: I think that's mborzecki and mvo06:00
zygamborzecki: did you see the feedback on https://github.com/snapcore/snapd/pull/670006:01
mupPR #6700: packaging: disable -buildmode=pie to fix memory issue on armhf <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6700>06:01
mborzeckizyga: hi, yeah, i've seen it, i think maybe we should hold the pr for a bit and wait for the feedback about kernel patches06:09
zygapedronis: https://github.com/snapcore/snapd/pull/6642 is green and has +2, do you want to review it or can I merge it?06:10
mupPR #6642: cmd/snap-confine: prevent cwd restore permission bypass <Created by zyga> <https://github.com/snapcore/snapd/pull/6642>06:10
zygamborzecki: https://eventhorizontelescope.org/blog/media-advisory-first-results-event-horizon-telescope-be-presented-april-10th <- something to look at later today06:17
mborzeckizyga: interesting, thanks!06:28
zygagood morning mvo06:31
zygamvo: some feedback on https://github.com/snapcore/snapd/pull/670006:32
mupPR #6700: packaging: disable -buildmode=pie to fix memory issue on armhf <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6700>06:32
mvohey zyga06:32
mvozyga: looking06:33
* zyga tries to control his tabs-as-backlog disease 06:35
mborzeckimvo: hey06:40
mvozyga: I replied, I guess we may need a HO with michael and alex06:54
=== pstolowski|afk is now known as pstolowski
zygamvo: there is also a response by seth arnold on the bug report07:03
zygahello pstolowski07:03
mborzeckipstolowski: hey07:04
mvozyga: thanks, reading this as well07:06
mvozyga: I can understand their reaction07:06
mvozyga: *but* we are in a different situation - if we break devices because of -buildmode=pie its *our* head not theirs07:06
zygawell, good luck with that07:06
zygaarguably they are saying that there are other solutions07:07
mvozyga: yes, to me this is about risks. a) risk of random bug because -buildmode=pie is hardly tested and barely supported upstream  b) risk of not having buildmode=pie preventing a security issue - at this point risk(a) > risk(b) to me07:08
mvozyga: maybe I'm just grumpy this morning07:09
mvozyga: I will definitely think about it07:09
pedronismvo: notice that we don't have a regression test in that PR07:09
pedronispie is only a part  of picture, what the go allocator does is also part of the picture07:09
mvozyga: and we should talk about it (either in a HO or in the standup)07:09
mvopedronis: yes07:09
pedronisI marked it blocked for now07:11
mvopedronis: what do you have in mind for such a test? in a sense the entire testsuite is a regression test. if we have a 32bit system with a 4.4 kernel that does not have the two patches mentioned in the LP bugreport then the testsuite will not survive 5s. so in a sense we have a regression test. or do you think we need soemthing that tests that we really don't have -buildmode=pie?07:11
mborzeckianyways, it was fun debugging that issue :) wish we had perf on the device, then maybe we could finger point the exact line where mmap2 failed07:12
pedronismvo: but that test will never be run again07:12
pedronisin the suite07:12
pedronisunless we add such a device in the lab07:13
pedronisor fake the sitution in the suite somewhere07:13
mvopedronis: maybe a HO? I may be too slow this morning07:13
* zyga notices more BPF love https://lwn.net/Articles/785263/07:14
mvopedronis: not sure I understand the suggestion/question07:14
pedronismvo: I can undo  those changes and nothing will turn red07:14
* zyga would love to listen in on the call 07:14
mvopedronis: right, so we want a test that checks if "-buildmode=pie" is really *not* used07:14
zygaif pedronis and mvo will HO please indicate so07:15
pedronismvo: we can test that but is kind of shallow07:15
mvozyga: sure thing - maybe its not needed - probably better if not or I will just rant07:15
pedronisbecause as I said pie is only one part of the problem07:15
mvopedronis: correct07:15
mvopedronis: ok, maybe a HO afterall? I think this is complex (or might become complex)07:16
* pedronis needs to have breakfast first07:16
zygahttps://meet.google.com/gik-uony-oni?authuser=0 <- in case anyone want to meet07:16
pedroniszyga: ^07:17
zygaack, I saw07:17
mvopedronis: just ping us when you are ready and no worries :) maybe I'm less grumpy by hte time you had breakfast07:17
zygamvo: join, you can vent any frustration ahead of the discussion :)07:17
mvozyga: haaha07:18
zygamvo: mic is not allowed07:19
zygaI can hear you though07:19
zygamvo: my 2fa device07:20
zygano microphone found07:20
zygahold on :D07:20
zygamvo: I'm a perfect listener today07:21
zygaglib or glibc07:21
=== chihchun_afk is now known as chihchun
pstolowskiChipaca: hey, any thoughts on https://github.com/snapcore/snapd/pull/6698#discussion_r273011330 ?08:01
mupPR #6698: overlord/ifacestate: introduce HotplugKey type use short key in change summaries <Created by stolowski> <https://github.com/snapcore/snapd/pull/6698>08:01
Chipacapstolowski: hm?08:03
Chipacapstolowski: why is client/ caring about the length of it?08:03
pstolowskiChipaca: re zyga's question08:03
Chipacare zyga's question, if it's going to get shortened, yes08:04
=== chihchun is now known as chihchun_afk
pstolowskiChipaca: (the unicode thing)08:04
pstolowskiChipaca: ok. it's cosmetics. thanks08:04
Chipacapstolowski: but08:04
pstolowskii knew there will be "but" ;)08:04
zygabut then you have to handle dumb terminals08:05
pstolowskizyga: ok, no point in doing this then08:05
=== chihchun_afk is now known as chihchun
Chipacamy 'but' was going to be: if you want it to be <12, then it's not str[:12]+"…" (nor str[:12] + "...")08:06
Chipacaassuming str starts out as ascii, if len(12) you want str[:11]+"…", or str[:9]+"..."08:07
Chipacaif you don't know if str is ascii, then none of those slices are going to be ok08:08
pstolowskiChipaca: it's ascii only, it's for sha256 checksum string08:10
Chipacaah, then it's fixed length!08:10
Chipacapstolowski: what we've done elsewhere to handle that is just "%.7s…"08:14
pstolowskiChipaca: ah, indeed08:14
Chipacapstolowski: in o/sh/backend08:14
Chipacazyga does have a point about dumb terminals, but for … we don't worry too much (it's supported on the default framebuffer font, and if it's not supported the resulting rhombus is not too hard to figure out)08:18
zyga+1 Chipaca08:22
mupPR snapd#6577 closed: many: make Remodel() download everything first before installing <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6577>08:29
mvopedronis: I also updated the two followups08:30
pedronispstolowski: I'm not sure I need to review 6698, if we switched … though, we should do it also for the vendor ?08:46
pstolowskipedronis: yes, i did it for vendor in same PR08:50
pstolowskipedronis: and np, i will ask around for 2nd review08:51
pstolowskimborzecki: hey, do you have a moment to review #6698?09:06
mupPR #6698: overlord/ifacestate: introduce HotplugKey type use short key in change summaries <Created by stolowski> <https://github.com/snapcore/snapd/pull/6698>09:06
mborzeckipstolowski: sure, in a bit, looking at the LK pr now09:07
=== chihchun is now known as chihchun_afk
mborzeckineed a 2nd review on #6692, it's super simple, just a cleanup10:24
mupPR #6692: interfaces: cleanup internal tool lookup in system-key <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6692>10:24
mborzeckistepping out for a bit, teachers' strike is still on but i need to take the kids to some extra classes in robotics :)10:37
=== ricab is now known as ricab|bbl
mupPR snapd#6698 closed: overlord/ifacestate: introduce HotplugKey type use short key in change summaries <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6698>11:32
mborzeckizyga: idk if you've seen this: https://forum.snapcraft.io/t/compatibility-issues-running-snaps-under-fedora-29/10402/711:41
mborzeckii'm updating my fedora vm now11:41
mborzeckizyga: obviously none of that happens in a vm :/11:51
mborzeckizyga: https://forum.snapcraft.io/t/compatibility-issues-running-snaps-under-fedora-29/10402/12 some logs here too13:10
mborzeckilooks like snap-device-helper cannot be executed?13:11
mborzeckizyga: ha, i can reproduce with 2.38 on fedora13:13
zygamborzecki: i have not seen this yet13:25
mborzeckizyga: i cannot reproduce it with other snaps i tried where i've seen snap-device-helper being invoked too13:26
zygaI know this bug13:26
zygalibexec vs lib13:27
mborzeckizyga: but other snaps on fedora also invoke /usr/lib/snapd/snap-device-helper and it works13:27
zygait's more complex than that13:28
zygathere are two consumers13:29
zygaone on the inside of the ns and one on the outside13:29
=== chihchun_afk is now known as chihchun
mborzeckizyga: https://paste.ubuntu.com/p/NTNMJFkkdq/ hahaha13:41
mborzeckizyga: ehh, so fedora patches their snap-device-helper to use #!/usr/bin/sh13:44
mborzeckizyga: and with base specified, we take host's libexecdir into snap mount ns right?13:44
mupPR snapcraft#2530 opened: Patchelf test branch <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2530>13:44
zygaback at the office14:02
zygamborzecki: I responded on the forum14:05
zygamborzecki: right14:05
zygawe knew about this for a while :/14:05
zygamborzecki: correct14:05
zygamborzecki: it's all broken because of complexity14:05
zygait's hard to reason about anythiign14:05
zygaand many things have to be ultra portable in consequence14:06
mborzeckizyga: still, intersting why they end up using /usr/bin/sh, probably some flatpak/ostree requirement14:06
mborzeckizyga: oh, and where that happens, i don't see anyting obvious in rpm build log14:06
zygamborzecki: it's an automatic change14:07
zygamborzecki: merged usr probably14:08
zygamborzecki: I reported it when it broke spread tests14:08
zygamborzecki: our spread tests take the incorrect assumption that a locally built snapd can work in re-exection context and can be injected into core snaps14:09
mborzeckizyga: hm maybe we should just have a symlink /usr/bin/sh -> /bin/sh in core1814:10
zygano no no14:10
zygaI mean14:10
zygaI don't care about symlinks14:10
zygawe need to fix the complexity aspect14:10
zygaand clearly indicate in each executable where it is expected to run14:10
zygaas a quick fix I would rewrite snap-device-helper in C14:10
mborzeckizyga: there was a pr from jamesh to rewrite it in go iirc14:11
zygaI would prefer C to speed up startup time14:11
zygait's quite expensive already14:11
mborzeckizyga: we could probably keep it within ~1M range with go14:12
zygait doesn't need to be in go, really14:12
zygawe need to rethink14:12
zygaperhaps it is obsolete entirely14:12
zygamborzecki: it's the fact that it is  invoked numerous times that bugs me14:12
zygaon app startup14:12
mborzeckiright, but it should be cached after first call14:13
zygabut starting a 1MB executable is not free14:13
zygaanyway, I don't see the point for go there14:13
zygaor the need for the executable if we do things right14:13
mborzeckiand we could write it in minimal go, like print() instead of fmt.*14:13
* zyga is not conviniced by any of that 14:13
mborzeckianyways, looks like we need to address this soon-ish14:14
zygalow-cost fix is to change fedora  package to undo  the interpreter change14:15
zygathen I would like to rip it out of snap-confine exec path14:15
zygathen the path doesn't  matter anymore14:15
mborzeckizyga: provided there isn't some made up policy that disallows that :P14:15
zygalastly I would remove the executable entirely14:15
zygaby changing how snapd uses it14:16
zygamborzecki: we can talk tomorrow14:19
popeyzyga: something appears to have broken gl in 19.0414:38
popeysnap install godot --classic, works on 18.04, 18.10, not on 19.0414:38
popeyWe had this with 18.10 iirc, is there some hard-wired path that's changed again?14:38
* zyga doesn't know and remarks that the gl solution is a hack that outgrew its usefulness vs cost14:41
zygamvo: did you see https://errors.ubuntu.com/problem/5e58e04cdc647a1fd50f71f02724dd0b5b8c1f4b14:41
zygapopey: please report a bug with hardware details14:41
mvozyga:  I did see it14:43
zygapopey: we still hope to start gl work this cycle but it's not something to be finished yet14:43
zygamvo: any ideas? go's backtraces are useless14:43
mvozyga: I did not really dive into it, sorry, I suspect correction14:43
zyga        err.data = 0x20 <error: Cannot access memory at address 0x20>14:44
mvozyga: corruption14:44
mvozyga: sorry14:44
zyga#3  0x0000563c3ac477a7 in github.com/snapcore/snapd/systemd.SdNotify (notifyState=..., ~r1=...) at /build/snapd-DbAuQM/snapd-2.38+18.04/_build/src/github.com/snapcore/snapd/systemd/sdnotify.go:5114:44
zygaseems like when we try to talk to systemd something goes south14:45
* mvo nods14:45
popeyzyga: https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/182416814:46
mupBug #1824168: classic opengl application on 19.04 fail to find gl drivers <amd64> <apport-bug> <disco> <snapd (Ubuntu):New> <https://launchpad.net/bugs/1824168>14:46
zygapopey: I don't have the hardware to debug this14:47
zygapopey: but I believe it  is the switch to libgl14:47
zygathat is out of sync with 16.04 based solution currently present14:47
popeyyou might be able to debug in virtualbox14:47
zygapopey: how?14:47
popeyrun 19.04 in virtualbox and install the snap inside it14:48
popey(which also fails)14:48
popeybut it works on 18.04 and 18.10 in virtualbox on the same host14:48
zygapopey: understood14:48
mupPR snapd#6706 opened: ubuntu: disable -buildmode=pie on armhf to fix memory issue <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/6706>14:55
=== ricab|bbl is now known as ricab
zygapopey: https://twitter.com/zygoon/status/111599393492742144015:04
* cachio lunch15:15
tomwardillzyga: I've got a GTX 96015:17
tomwardillcurrently running 19.04 pre-release15:18
zygatomwardill: and proprietary drivers?15:19
tomwardillrelease 390, according to software center15:20
zygatomwardill: can you pastebin lsmod, dpkg -S nvdia-* (not sure what the package names are); run a steam game and while it is running cat /proc/pid-of-game/maps15:20
tomwardillwill report back in a few minutes :)15:20
zygatomwardill: thank you, that will allow me to collect this kind of stuff into a script later15:20
zygasure, thank you!15:20
zygatomwardill: also, if you have any, run a non-trivial non-steam game15:21
tomwardillwill factorio do?15:22
zygatomwardill: via strace -ff  -o15:22
zygaI suspect so :)15:22
zygaand also collect the log, it may be heavier though15:22
zygatomwardill: do you know how to reach me via email?15:22
tomwardillI can look you up in the directory :)15:22
zygatomwardill: perhaps attach to https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/182416815:25
zygamore useful this way15:25
mupBug #1824168: classic opengl application on 19.04 fail to find gl drivers <amd64> <apport-bug> <disco> <snapd (Ubuntu):New> <https://launchpad.net/bugs/1824168>15:25
zygaI need to go AFK, running for classes15:26
tomwardillzyga: added files to the bug15:41
Chipacazyga: can a snap that exposes a content interface itself have apps?16:00
mupPR snapd#6707 opened: overlord: factor out mocking of device service and gadget w. prepare-device for registration tests  <Created by pedronis> <https://github.com/snapcore/snapd/pull/6707>16:22
=== pstolowski is now known as pstolowski|afk
cachiomvo: hey, ubuntu-core snap is being use currently?16:37
cachioChipaca:  Chipaca: There is an issue when we install with --dangerous, which is that it is not resuming a .partial file for hte base snap and it is affecting the core18 tests when we run install_local xxxx16:37
cachioChipaca: any idea if it is working as designed or it is a bug?16:38
Chipacacachio: what does a partial have to do with --dangerous?16:38
Chipaca.partial files are from the store16:38
cachioChipaca: I implemented a new mechanism to speedup the installation of snaps on out test suite16:44
cachioChipaca: so the idea is to download a snap and leave it in /var/lib/snapd/snaps as a .partial16:45
Chipacacachio: right16:45
Chipacacachio: but that only works for snaps that you download16:45
Chipacacachio: install_local doesn't look at .partials16:45
cachioso in ubuntu core 1816:45
ChipacaI mean, literally, the code that checks .partial is in store/, it never reaches that for InstallPath16:45
cachioI install jq16:45
cachioand it uses the core_*.snap.partial16:46
cachiowhich is the base16:46
cachiobut if I do snap install test-snapd-tools --dangerous16:46
cachioit is not resuming the .partial for core16:46
cachioso it downloads core16:46
Chipacaoh, no i got it16:47
Chipacathat sounds like a bug16:47
cachioahh, ok16:47
cachioit should resume ritght?16:47
cachiodo you want a forum post, a lp bug?16:48
cachionothing :)16:48
cachioChipaca: https://travis-ci.org/snapcore/spread-cron/builds/518148049#L210816:49
cachioinitially I saw that just running locally16:49
cachiobut now I also see errors on the boards which run in the lab16:50
Chipacacachio: lp bug16:50
cachioChipaca: nice, thanks16:50
* cachio akf16:57
* cachio afk16:57
pedroniszyga: 6642 can land17:15
zygapedronis: ack, thank you. I’ll land it now18:47
Chipacazyga: can a snap that exposes a content interface itself have apps?18:47
zygaChipaca: technically yes18:48
mupPR snapd#6642 closed: cmd/snap-confine: prevent cwd restore permission bypass <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6642>18:48
zygaE.g. a hypothetical Java JRE snap18:49
zygaChipaca: though today I don’t know of any that do18:49
zygaI’m on a bus so please forgive my inconsistent response speed18:49
Chipacazyga: does a snap that uses a content interface need to specify a default provider?18:49
zygaChipaca: I believe it may but does not have to. I would have to consult specifications to see if this is required18:50
Chipacazyga: np18:51
Chipacazyga: does a content interface exposed by a snap and used by another get connected when you install one of the two and have the other one installed?18:52
zygaAssuming the connection is not ambiguous18:52
zygaI don’t believe we changed that yet18:52
Chipacazyga: ambiguous as in have more than one snap expose the same one?18:52
zygaWe discussed having hints about the number of accepted connections that might allow an app to, for example, connect all plugins18:53
zygaAmbiguous as in having more than one connection candidate available18:53
zygaWhat are you looking at Chipaca?18:54
Chipacazyga: some weird integration req's; i'll cc you in18:54
zygaThank you sir!18:55
jdstrandniemeyer: hey, not a bug deal, but it seems the forum checkbox plugin thing went away again (ie, I can't see it in https://forum.snapcraft.io/t/manual-review-for-squaremetrics-ble-scanner/10836/2)19:23
Chipacajdstrand: note the forum is now in IS's hands19:31
jdstrandChipaca: oh, I did not know that19:39
jdstrandChipaca: does that mean RT?19:39
Chipacajdstrand: probably19:41
om26er85come on19:46
om26erHi! How can I make my snap be able to read a config file from ~/my_config.yaml ?19:48
om26erMy software reads its runtime configuration from that file, So basically a user can just open that file, edit it and then run my snap19:49
cachioom26er: hi, you need to use the home interface for that19:51
om26erhmm, I do have home interface connected apparently, but $HOME seems to resolve to $SNAP_USER_COMMON still, what am I missing ?19:55
cachioom26er: which error do you see when you try to access the config file?19:58
om26ercachio my snap is not able to see that file because it expands $HOME to /home/om26er/snap/surc/14 instead of /home/om26er20:03
Chipacaom26er: it's not SNAP_USER_COMMON, but yes20:03
Chipacathat's expected20:03
Chipacaom26er: if you need to get actual HOME, you'll need to use look it up20:04
cachioChipaca: https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/182423020:05
mupBug #1824230: Download not resumed for base snap when using "snap install --dangerous" <snapd (Ubuntu):New> <https://launchpad.net/bugs/1824230>20:05
om26erChipaca hmm, like checking if /home/$USER/my_file.yaml exists and reading that ?20:05
Chipacaom26er: or https://github.com/chipaca/icdiff/blob/master/snap/snapcraft.yaml#L7320:05
om26er^ that's intelligent though I'll find a somewhat similar solution that doesn't require me to stage a new package in my snap20:09
Chipacaom26er: what package does that require you to stage?20:10
Chipacaom26er: (it uses nothing that's not in core)20:10
om26ergit-icdiff ?20:10
Chipacaom26er: that's the snap that's used on20:11
Chipacaom26er: that sed line adds a perl command at the top of the script20:11
Chipacaom26er: the perl command is the one you might want20:11
Chipacaom26er: i.e. HOME=$(perl -we "print((getpwuid $>)[7])")20:12
om26erChipaca sorry, I misunderstood that, seems it just work :)20:12
Chipacano problem20:12
mupPR snapcraft#2531 opened: snap: revert to patchelf 0.9 with local patches <Created by cmatsuoka> <https://github.com/snapcore/snapcraft/pull/2531>20:12
om26erthanks Chipaca20:12
zygaChipaca: can I land https://github.com/snapcore/snapd/pull/6690 ?20:15
mupPR #6690: overlord/snapstate: inhibit refresh for up to a week <Created by zyga> <https://github.com/snapcore/snapd/pull/6690>20:15
Chipacazyga: you can land _everything_20:15
zygathat's very encouraging20:15
zygalanding then :)20:15
mupPR snapd#6690 closed: overlord/snapstate: inhibit refresh for up to a week <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6690>20:15
Chipacazyga: the one i'd asked you to hold, i'd tagged with blocked, and then removed the tag when it was done20:16
Chipacazyga: what roadmr said20:16
zygaChipaca: woot20:16
zygaI'm off to watch black hole stuff with my kids20:16
zygawe have to watch it in spanish because that's the best intersection of comprehension and quality :D20:17
Chipacazyga: https://xkcd.com/2135/20:22
zygathat's great20:23
zygait's really difficult to talk about the scale of that thing using human scales20:23
Chipacayeah, my scales only go up to about 120kg20:23
zygaand the author is wrong here20:24
zygathe event horizon is much smaller than the black ring20:24
zygaer, black hole inside the ring20:24
zygaso voyager woud be surely "past" it in this sense20:24
zygaanyway, very exciting times to live :)20:25
Chipacazyga: also, https://www.youtube.com/watch?v=zUyH3XhpLTo20:29
ahasenackhm, hi, I just got this error in a script that installs snapd, and then a snap: https://pastebin.ubuntu.com/p/VHpxMY9grP/21:34
ahasenackis it because it was too fast? Is there a way to tell when snapd is ready?21:35
ijohnsonahasenack: try using `snap wait system seed.loaded`21:36
ahasenackthat seems to have helped21:39
mupBug #1824240 opened: snapd can't be purged with latest AWS Xenial AMI <Snappy:New> <https://launchpad.net/bugs/1824240>21:46
mupBug #1824240 changed: snapd can't be purged with latest AWS Xenial AMI <Snappy:New> <https://launchpad.net/bugs/1824240>21:52
mupPR snapcraft#2531 closed: snap: revert to patchelf 0.9 with local patches <Created by cmatsuoka> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2531>21:58
sergiusenscmatsuoka: just manually tested the new edge using 0.9+snapcraft, seems like we are back in business22:31
* cachio afk22:44
mupPR snapcraft#2530 closed: Patchelf test branch <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/2530>23:07
=== chihchun is now known as chihchun_afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!