=== Eickmeyer[m] is now known as eickmeyer[m]
=== eickmeyer[m] is now known as Eickmeyer[m]
=== Eickmeyer[m] is now known as eickmeyer[m]
=== eickmeyer[m] is now known as Eickmeyer[m]
cpaelzersmb: rbasak: hi - about open-vm-tools I might miss some of your conversation :-/04:57
cpaelzeryes normally those things should have ADT tests for dkms (which just is a install)04:57
cpaelzerwhen I picked up open-vm-tools we realized differently thou, this particular DKMS module had plenty of problems and wasn't needed04:58
cpaelzerthere is a successor in the upstream kernel for the vmxnet2 module04:58
cpaelzerso later versions removed it anyway04:58
cpaelzerdropped in 2:10.2.0-1 which due to the backporting of new versions should mean Xenial and later04:59
cpaelzeryep, the bug report is using a new kernel and NOT the updated package 2:10.2.0-3~ubuntu0.16.04.104:59
cpaelzerlet me answer there and close it as invalid05:00
cpaelzerwe didn't try to fix the further past e.g. didn't touch trusty05:00
cpaelzerIf you want we could add an adt test to the trusty package as lessons learned05:01
cpaelzeranswered the bug05:07
cpaelzerklebers: ^^ FYI05:10
smbcpaelzer, Ah that kind of explains why the ADT testing in Xenial does not care. And thus it did not raise any flags going forward. That bug report was pretty old too. If I remember that right about a year07:07
cpaelzeryep smb07:12
jackpot51Hello! I am looking to get a hardware quirk patch into the Ubuntu 18.04 HWE and 19.04 kernels. Here is the patch: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/182755516:07
ubot5`Ubuntu bug 1827555 in linux (Ubuntu) "[ALSA] [PATCH] Headset fixup for System76 Gazelle (gaze14)" [Undecided,New]16:07
sforsheejackpot51: looks like there's a few things you need to do16:44
jackpot51What's that?16:44
sforsheethe bug description needs to have sru justification added, see https://wiki.ubuntu.com/StableReleaseUpdates16:45
jackpot51Ok, will do16:45
sforsheethe patch description itself needs to have a short description added, and since it doesn't look like it's upstream it should start with "UBUNTU: SAUCE: "16:45
sforsheethough you should also consider upstreaming the patch if possible16:46
sforsheealso please wrap the text in the commit message16:46
sforsheeand add a buglink and send to the kernel-team mailing list as described here: https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat16:46
jackpot51Will do. I sent it upstream as well and will link to the upstream commit when it lands16:48
sforsheejackpot51: I assume you have also already tested the patch, if so it would be helpful if you stated as much on the bug16:48
sforsheeperfect, thanks!16:48
jackpot51I updated the description, how does it look?16:48
sforsheethat's great16:49
jackpot51I updated the patch file, does it look better now?16:50
sforsheejackpot51: much closer, it will still need the buglink and to have the summary prefixed with "UBUNTU: SAUCE: "17:03
sforsheewhich indicates that it's a patch that isn't from upstream17:04
jackpot51Ok, I get it now17:06
jackpot51sforshee: how does this look? https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1827555/+attachment/5261314/+files/system76_gaze14.patch17:08
ubot5`Ubuntu bug 1827555 in linux-hwe (Ubuntu) "[ALSA] [PATCH] Headset fixup for System76 Gazelle (gaze14)" [Undecided,Confirmed]17:08
sforsheejackpot51: almost. The subject should be rearranged slightly - "Subject: UBUNTU: SAUCE: [ALSA] Headset fixup for System76 Gazelle (gaze14)"17:10
sforshee[PATCH] gets added when you send it17:10
sforsheeand the buglink should be:17:10
sforsheeBugLink: https://bugs.launchpad.net/bugs/182755517:11
ubot5`Ubuntu bug 1827555 in linux-hwe (Ubuntu) "[ALSA] [PATCH] Headset fixup for System76 Gazelle (gaze14)" [Undecided,Confirmed]17:11
sforsheethen it should be fine17:11
jackpot51Ok, great! https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1827555/+attachment/5261315/+files/system76_gaze14.patch17:12
ubot5`Ubuntu bug 1827555 in linux-hwe (Ubuntu) "[ALSA] [PATCH] Headset fixup for System76 Gazelle (gaze14)" [Undecided,Confirmed]17:12
sforsheelooks good!17:13
jackpot51Awesome! I will definitely have it formatted this way next time!17:13
sforsheethat all looks good to me17:14
sforsheejackpot51: remember when you send the subject should specify the series you want the patch applied for17:15
sforsheehere's a recent example: https://lists.ubuntu.com/archives/kernel-team/2019-May/100512.html17:15
jackpot51Ok, I will do that17:16
=== tomreyn_ is now known as tomreyn

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!