[04:57] <cpaelzer> smb: rbasak: hi - about open-vm-tools I might miss some of your conversation :-/
[04:57] <cpaelzer> yes normally those things should have ADT tests for dkms (which just is a install)
[04:58] <cpaelzer> when I picked up open-vm-tools we realized differently thou, this particular DKMS module had plenty of problems and wasn't needed
[04:58] <cpaelzer> there is a successor in the upstream kernel for the vmxnet2 module
[04:58] <cpaelzer> so later versions removed it anyway
[04:59] <cpaelzer> dropped in 2:10.2.0-1 which due to the backporting of new versions should mean Xenial and later
[04:59] <cpaelzer> yep, the bug report is using a new kernel and NOT the updated package 2:10.2.0-3~ubuntu0.16.04.1
[05:00] <cpaelzer> let me answer there and close it as invalid
[05:00] <cpaelzer> we didn't try to fix the further past e.g. didn't touch trusty
[05:01] <cpaelzer> If you want we could add an adt test to the trusty package as lessons learned
[05:07] <cpaelzer> answered the bug
[05:10] <cpaelzer> klebers: ^^ FYI
[07:07] <smb> cpaelzer, Ah that kind of explains why the ADT testing in Xenial does not care. And thus it did not raise any flags going forward. That bug report was pretty old too. If I remember that right about a year
[07:12] <cpaelzer> yep smb
[16:07] <jackpot51> Hello! I am looking to get a hardware quirk patch into the Ubuntu 18.04 HWE and 19.04 kernels. Here is the patch: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1827555
[16:07] <ubot5`> Ubuntu bug 1827555 in linux (Ubuntu) "[ALSA] [PATCH] Headset fixup for System76 Gazelle (gaze14)" [Undecided,New]
[16:44] <sforshee> jackpot51: looks like there's a few things you need to do
[16:44] <jackpot51> What's that?
[16:45] <sforshee> the bug description needs to have sru justification added, see https://wiki.ubuntu.com/StableReleaseUpdates
[16:45] <jackpot51> Ok, will do
[16:45] <sforshee> the patch description itself needs to have a short description added, and since it doesn't look like it's upstream it should start with "UBUNTU: SAUCE: "
[16:46] <sforshee> though you should also consider upstreaming the patch if possible
[16:46] <sforshee> also please wrap the text in the commit message
[16:46] <sforshee> and add a buglink and send to the kernel-team mailing list as described here: https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat
[16:48] <jackpot51> Will do. I sent it upstream as well and will link to the upstream commit when it lands
[16:48] <sforshee> jackpot51: I assume you have also already tested the patch, if so it would be helpful if you stated as much on the bug
[16:48] <sforshee> perfect, thanks!
[16:48] <jackpot51> I updated the description, how does it look?
[16:49] <sforshee> that's great
[16:50] <jackpot51> I updated the patch file, does it look better now?
[17:03] <sforshee> jackpot51: much closer, it will still need the buglink and to have the summary prefixed with "UBUNTU: SAUCE: "
[17:04] <sforshee> which indicates that it's a patch that isn't from upstream
[17:06] <jackpot51> Ok, I get it now
[17:08] <jackpot51> sforshee: how does this look? https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1827555/+attachment/5261314/+files/system76_gaze14.patch
[17:08] <ubot5`> Ubuntu bug 1827555 in linux-hwe (Ubuntu) "[ALSA] [PATCH] Headset fixup for System76 Gazelle (gaze14)" [Undecided,Confirmed]
[17:10] <sforshee> jackpot51: almost. The subject should be rearranged slightly - "Subject: UBUNTU: SAUCE: [ALSA] Headset fixup for System76 Gazelle (gaze14)"
[17:10] <sforshee> [PATCH] gets added when you send it
[17:10] <sforshee> and the buglink should be:
[17:11] <sforshee> BugLink: https://bugs.launchpad.net/bugs/1827555
[17:11] <ubot5`> Ubuntu bug 1827555 in linux-hwe (Ubuntu) "[ALSA] [PATCH] Headset fixup for System76 Gazelle (gaze14)" [Undecided,Confirmed]
[17:11] <sforshee> then it should be fine
[17:12] <jackpot51> Ok, great! https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1827555/+attachment/5261315/+files/system76_gaze14.patch
[17:12] <ubot5`> Ubuntu bug 1827555 in linux-hwe (Ubuntu) "[ALSA] [PATCH] Headset fixup for System76 Gazelle (gaze14)" [Undecided,Confirmed]
[17:13] <sforshee> looks good!
[17:13] <jackpot51> Awesome! I will definitely have it formatted this way next time!
[17:14] <sforshee> that all looks good to me
[17:15] <sforshee> jackpot51: remember when you send the subject should specify the series you want the patch applied for
[17:15] <sforshee> here's a recent example: https://lists.ubuntu.com/archives/kernel-team/2019-May/100512.html
[17:16] <jackpot51> Ok, I will do that