/srv/irclogs.ubuntu.com/2019/05/16/#snappy.txt

=== harrisj_ is now known as harrisj
mborzeckimorning05:06
zygaGood morning05:13
mborzeckibrb, new kernel05:18
mborzeckiand back05:20
mborzeckizyga: hey05:20
zygamborzecki: :)05:39
mupPR snapd#6866 closed: cmd/snap-update-ns: allow changing mount propagation <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6866>06:15
zygaI need a 2nd review for https://github.com/snapcore/snapd/pull/685606:16
mupPR #6856: cmd/snap-update-ns: add tests for executeMountProfileUpdate <Created by zyga> <https://github.com/snapcore/snapd/pull/6856>06:16
zygamborzecki: (thank you for the first one)06:16
mborzeckizyga: added a 2.39 label to #6866, or maybe mvo prefers cherry picks06:25
mupPR #6866: cmd/snap-update-ns: allow changing mount propagation <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6866>06:25
* zyga goes through reviews06:25
zygamborzecki: oh, good thinkink, thank you06:25
zygathinking*06:25
mborzeckizyga: if you discuss that with mvo, there's 3 PRs that landed and are tagged for 39.106:26
zygamborzecki: I'll bring it up, he just went to fetch Samuele06:26
mborzeckididn't we use to have cloud init in ubuntu core images?07:00
pstolowskimorning07:03
mborzeckipstolowski: hey07:03
mupPR snapd#6872 opened: many: backport fixes to 2.39 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6872>07:22
=== alan_g_ is now known as alan_g
zygamborzecki: woot, thank you for the backport07:36
zygamborzecki: I will push the fix as soon as we're out of the plenary review cycle07:36
zygamborzecki: we have cloud init in core and core1807:36
mborzeckizyga: idk, somehow it does not set up the system on boot07:39
mupPR snapcraft#2565 closed: requirements: update to requests-toolbelt 0.8.0 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2565>07:40
mborzeckizyga: regular cloud images have a bunch of cloud-init services, i don't see anything in core18 image though07:41
zygamborzecki: hmmmm, that's odd07:46
zyganot sure about services but there *should* be some cloud-init for setting up core images in cloud07:46
mborzeckizyga: there are units in /lib/systemd/system but they have not been loaded by systemd for some reason07:48
zygamborzecki: presets?07:50
zygamaybe something changed?07:50
mborzeckizyga: omg, is the virtio support in the kernel, i added cloud init data disk with if=virtio even though had the main image with if=ide :/07:53
mborzeckizyga: so it never got 'found' by systemd and cloud init did not start07:53
zygaI have a feeling we found this before07:53
zygamissing virtio module in core?07:53
zyga(kernel)07:53
mborzeckizyga: still a mystery why sytemctl list-units --all did not show cloud init services07:53
pstolowskidegville: hey, wdyt about changing the help message per zyga's suggestion to https://github.com/snapcore/snapd/pull/6870 ?08:02
mupPR #6870: cmd/snap, api, snapstate: implement "snap remove --purge" <Created by stolowski> <https://github.com/snapcore/snapd/pull/6870>08:02
zygamborzecki: does systemctl cat show anything?08:05
Chipacapstolowski: Refrain from creating the automatic snapshot?08:06
Chipacapstolowski: i thought that might be less clear, but then i see zyga himself suggested it08:06
degvillepstolowski: I agree with zyga actually. 'Don't' seems a little informal and maybe not as immediately clear.08:09
pstolowskidegville: great, ty08:09
Chipacazyga: hey08:16
Chipacazyga: https://forum.snapcraft.io/t/different-seccomp-behaviors-on-amd64-and-pi2-armhf/11370 might be of interest to you08:16
zygaChipaca: hey, thank you, looking now08:50
Chipacazyga: a libseccomp bug? surely you jest09:03
zygaChipaca: not sure but perhaps, perhaps an outcome of the old vs new seccomp stack09:03
zygabut I'm just hand-waving, I need to look for real with hw to test09:04
cwaynezyga: if only there were a way to reserve a pi2.. :)09:07
zygacwayne: yeah, sadly there's no way ;-)09:10
zyga(my vpn creds are back home)09:10
zygabut hardware is not the problem, trying to avoid spending too much time during plenary on non-plenary work09:10
mupPR snapcraft#2566 opened: kernel plugin: correctly download the os.snap <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2566>09:20
dot-tobiasgreyback / alan_g: I opened this GH issue re: mir-kiosk startup splash a while ago, short feedback highly appreciated :) https://github.com/MirServer/mir-kiosk/issues/1509:20
greybackdot-tobias: gosh sorry, I never noticed that. I'm not sure the splash animation can be disabled by a config, alan_g will know more09:23
alan_gIn a meeting. I'll respond on the issue asap.09:23
Chipacamborzecki: could you include #6851 in #6872 ?09:28
mupPR #6851: cmd/snap: mangle descriptions that have indent > terminal width <Simple ๐Ÿ˜ƒ> <โš  Critical> <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6851>09:28
mupPR #6872: many: backport fixes to 2.39 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6872>09:28
mborzeckiChipaca: sure, let me pick that09:28
Chipacamborzecki: and #6853 might also be worthy ( pstolowski ?)09:28
mupPR #6853: interfaces: special-case "snapd" in sanitizeSlotReservedForOS* helperโ€ฆ <Simple ๐Ÿ˜ƒ> <โš  Critical> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6853>09:28
Chipacaor is that #684409:29
mupPR #6844: interfaces: special-case "snapd" in sanitizeSlotReservedForOS* helpers <Simple ๐Ÿ˜ƒ> <Squash-merge> <โš  Critical> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6844>09:29
Chipacaanyway, one of those two should probably be in :)09:29
Chipacapstolowski knows more09:29
pstolowskiChipaca: https://github.com/snapcore/snapd/pull/6853 was merged to 2.39 branch already09:31
mupPR #6853: interfaces: special-case "snapd" in sanitizeSlotReservedForOS* helperโ€ฆ <Simple ๐Ÿ˜ƒ> <โš  Critical> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6853>09:31
pstolowskiif that was the question09:31
Chipaca๐Ÿ‘09:31
* zyga needs more tests09:32
zyga(we require more spread tests)09:32
mupPR snapd#6873 opened: gadget: improve device lookup, add helper for mount point lookup <Gadget update> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6873>09:32
mborzeckiChipaca: #6851 is already included, it probably landed sometime between pre and final09:36
mupPR #6851: cmd/snap: mangle descriptions that have indent > terminal width <Simple ๐Ÿ˜ƒ> <โš  Critical> <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6851>09:36
Chipacamborzecki: thank you09:37
mborzeckigadget/device_test.go:325:35: undefined: strings.ReplaceAll waaat?09:38
Chipacamborzecki: strings.Replace(old, new, -1) is ReplaceAll09:44
Chipacamborzecki: too much python over the weekend09:44
Chipacaor something09:44
Chipacastrings.Replace(s, old, new, -1) actually09:44
mborzeckiChipaca: https://godoc.org/strings#ReplaceAll really wish they had a tag with a version this was added in09:45
Chipacamborzecki: or maybe you're getting confused with regexp, which does have a ReplaceAll09:45
Chipacamborzecki: they do09:45
Chipacamborzecki: they've just not used it on that :-|09:45
mborzeckiChipaca: i must be hitting those that don't have the tag then :P09:46
Chipacamborzecki: https://golang.org/pkg/strings/#ReplaceAll09:46
Chipacamborzecki: note the right hand side09:46
mborzeckiChipaca: aaa09:46
Chipacamborzecki: bbbb09:47
* Chipaca wins09:47
mborzeckiChipaca: still, 1.12 :(09:47
Chipacathe -1 thing isn't that terrible :)09:47
Chipacai mean, replaceall is literally09:48
Chipacafunc ReplaceAll(s, old, new string) string {09:48
Chipacareturn Replace(s, old, new, -1)09:48
Chipaca}09:48
Chipacaanyhoo, coffee break time09:48
mborzeckicoffee sounds about right09:48
Chipacaikr09:49
pstolowskigrr this must be the worst May for years, the weather has been terrible so far10:02
pstolowskino signs of summer whatsoever10:03
zygaI'm still working on the bugfix for propagation, tests pass as root, fail as  user,  need to investigate more10:05
* pstolowski lunch10:26
Chipacapstolowski: https://imgur.com/a/8mufe7k10:41
mupPR snapd#6862 closed: overlord/hookstate: don't run handler unless hooksup.Always <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6862>11:25
Chipaca#6848 ready for reviews11:26
mupPR #6848: introduce healthstate, run check-health post-(install/refresh/try/revert) <Created by chipaca> <https://github.com/snapcore/snapd/pull/6848>11:26
Chipacaat 800 lines, not for the faint of heart11:26
Chipaca(but a lot of those lines are mechanical test changes)11:26
Chipacain that, https://github.com/snapcore/snapd/pull/6848/files#diff-81e36f58e21bdcdeb85d468298d9b17eR93 is for roadmr11:28
mupPR #6848: introduce healthstate, run check-health post-(install/refresh/try/revert) <Created by chipaca> <https://github.com/snapcore/snapd/pull/6848>11:28
roadmrthanks :)11:28
roadmrthat is awesome, Chipaca hehe thanks11:28
pstolowskire11:57
pstolowskiChipaca: i'm envy11:57
mborzeckioff to pick up the kids12:09
cachiomborzecki, hey12:14
mupPR core#38 closed: Add another pi-config option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/38>12:16
mupPR core#83 closed: move most of the ubuntu-core config deb into the snap snap build <Created by mvo5> <https://github.com/snapcore/core/pull/83>12:16
mupPR core#104 closed: snapcraft.yaml: use remote fc-cache-builder <Created by mvo5> <https://github.com/snapcore/core/pull/104>12:16
mupPR core#38 opened: Add another pi-config option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/38>12:17
mupPR core#83 opened: move most of the ubuntu-core config deb into the snap snap build <Created by mvo5> <https://github.com/snapcore/core/pull/83>12:17
mupPR core#104 opened: snapcraft.yaml: use remote fc-cache-builder <Created by mvo5> <https://github.com/snapcore/core/pull/104>12:17
zygare12:19
zygamborzecki: funny thing, my fix makes the root user ok but there's still a bug if you run as test user12:23
zygamborzecki: I'm debugging why, updated the test suite to check it (that's how I found it)12:23
zygaChipaca: can you do 2nd review on https://github.com/snapcore/snapd/pull/685612:26
zygait's just more tests12:27
mupPR #6856: cmd/snap-update-ns: add tests for executeMountProfileUpdate <Created by zyga> <https://github.com/snapcore/snapd/pull/6856>12:27
mupPR # closed: core-build#11, core-build#22, core-build#26, core-build#37, core-build#3812:27
mupPR # opened: core-build#11, core-build#22, core-build#26, core-build#37, core-build#3812:28
=== ricab is now known as ricab|lunch
pstolowskicachio: hey, how can i run the test from #6859 ?12:53
mupPR #6859: tests: new hotplug test executed on ubuntu core  <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6859>12:53
mupPR snapd#6856 closed: cmd/snap-update-ns: add tests for executeMountProfileUpdate <Created by zyga> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6856>12:55
zygamborzecki: thanks!12:56
zygawoot, I have very little after that, let me see12:56
cachiopstolowski, no yet, I'll try now to register again my key and see if it works12:57
mborzeckizyga: nsswitch.conf is a symlink to /etc/authselect/nsswitch.conf now13:37
zygafun13:37
zygaI really really know we need to start over with empty /etc13:37
zygathis is not something we can fix easily13:37
zygamborzecki: can you report the bug with a good explanation13:38
zygaI will discuss locally and we can plan for actions next week13:38
zygait sucks that F30 is just broken :/13:38
mborzeckizyga: w8, it was like that in 29 too13:38
zygawhaaat?13:38
mborzeckizyga: f30: https://paste.ubuntu.com/p/drHz7js6Q5/ running hello-world snap13:39
zygafuuuuuk13:40
zygacan you report that as critical please13:40
zygawe can discuss options13:40
zygafun week13:40
mborzeckilet me check if that's new in 2.39 though13:40
zygamborzecki: I think I understand the  bug (older bug) better now13:40
zygaif you have some time today I can show you in a call13:41
zygafor some brainstorming13:41
mborzeckizyga: standup?13:41
zygamborzecki: and if you can, please  send one patch13:41
zygamborzecki: don't mount over /etc symlinks13:41
zyganot a security defennse13:41
zygajust as OMG BROKEN13:41
zygamborzecki: joining13:41
cachiozyga, https://paste.ubuntu.com/p/5fx9fbKMbH/13:52
cachiothis is the output for findmnt -o+PROPAGATION13:52
cachioperhaps it helps13:52
=== ricab|lunch is now known as ricab
mupPR pc-amd64-gadget#10 closed: Add mmx64.efi (MokManager) to support mokutil <Created by tsunghanliu> <https://github.com/snapcore/pc-amd64-gadget/pull/10>14:07
mupPR pc-amd64-gadget#11 closed: Add mmx64.efi (MokManager) to support mokutil <Created by tsunghanliu> <https://github.com/snapcore/pc-amd64-gadget/pull/11>14:07
mupPR pc-amd64-gadget#10 opened: Add mmx64.efi (MokManager) to support mokutil <Created by tsunghanliu> <https://github.com/snapcore/pc-amd64-gadget/pull/10>14:08
mupPR pc-amd64-gadget#11 opened: Add mmx64.efi (MokManager) to support mokutil <Created by tsunghanliu> <https://github.com/snapcore/pc-amd64-gadget/pull/11>14:08
cachiomborzecki, this is the error on the selinux-clean test on fedora 30 https://paste.ubuntu.com/p/PGG4JyXWgN/14:23
cachiois it the same you saw14:23
cachio?14:23
mupPR snapcraft#2566 closed: kernel plugin: correctly download the os.snap <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2566>14:24
mborzeckicachio: yes14:24
mborzeckicachio: unsquashfs is somethign we can fix, nsswitch.conf requires a fix elsewhere14:24
cachioso, should we skip that test while the fix is in progress?14:25
cachioor it is better to fix it before starting the test for fedora 3014:26
cachiosergiusens, hey, which is the best way to delete my default key using snapcraft14:28
cachio?14:28
zygamborzecki: intermediate path is symlink14:30
zygaNot the final name14:30
zygaWe have better mount code in go14:31
mborzeckizyga: i was checking the wrong end :/14:35
zygamborzecki: both ends matter14:40
mborzeckizyga: https://github.com/snapcore/snapd/pull/687414:52
mupPR #6874: cmd/snap-confine: do not mount over non files/directories <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6874>14:52
mborzeckicachio: this should fix part of the problem ^^14:52
zygalooking14:52
mupPR snapd#6874 opened: cmd/snap-confine: do not mount over non files/directories <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6874>14:52
zygamborzecki: can you do a small tweak14:53
cachiomborzecki, great news!!14:53
zygaif anything fails -> die  (unless ENOENT)14:53
zygaif lstat works -> remember mode14:53
zygathen mode must match (REG or DIR)14:53
zygathen mount14:53
zygaon unexpected failure die14:53
zygaon expected mismatch log14:54
zygamborzecki: does that make sense?14:55
Chipacamborzecki: https://play.golang.org/p/qwiysalqvq116:01
=== pstolowski is now known as pstolowski|afk
* zyga explores and explores...16:41
cachiosergiusens, kyrofa, hey, any idea of this https://paste.ubuntu.com/p/PmBdZ7QzkH/16:50
cachiopstolowski|afk, hey, still trying to fix the issue I have with my keys, I'll try to push the last fix for tomorrow, sorry for the delay17:20
cachioChipaca, hey, sorry for the delay, I updated the PR 661818:07
mupPR #6618: tests: validates snapd from ppa <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6618>18:07
Chipacacachio: ack. I'll take a look later tonight18:07
Chipacagoing to have dinner and walk the dog, now18:08
cachioChipaca, thanks18:08
cachiohehe, I forget it is so late in uk18:08
cachioChipaca, do you know how to do snap sign with a key which is not hte default?18:13
cachioChipaca, found that18:15

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!