[05:06] <mborzecki> morning
[05:13] <zyga> Good morning
[05:18] <mborzecki> brb, new kernel
[05:20] <mborzecki> and back
[05:20] <mborzecki> zyga: hey
[05:39] <zyga> mborzecki: :)
[06:15] <mup> PR snapd#6866 closed: cmd/snap-update-ns: allow changing mount propagation <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6866>
[06:16] <zyga> I need a 2nd review for https://github.com/snapcore/snapd/pull/6856
[06:16] <mup> PR #6856: cmd/snap-update-ns: add tests for executeMountProfileUpdate <Created by zyga> <https://github.com/snapcore/snapd/pull/6856>
[06:16] <zyga> mborzecki: (thank you for the first one)
[06:25] <mborzecki> zyga: added a 2.39 label to #6866, or maybe mvo prefers cherry picks
[06:25] <mup> PR #6866: cmd/snap-update-ns: allow changing mount propagation <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6866>
[06:25]  * zyga goes through reviews
[06:25] <zyga> mborzecki: oh, good thinkink, thank you
[06:25] <zyga> thinking*
[06:26] <mborzecki> zyga: if you discuss that with mvo, there's 3 PRs that landed and are tagged for 39.1
[06:26] <zyga> mborzecki: I'll bring it up, he just went to fetch Samuele
[07:00] <mborzecki> didn't we use to have cloud init in ubuntu core images?
[07:03] <pstolowski> morning
[07:03] <mborzecki> pstolowski: hey
[07:22] <mup> PR snapd#6872 opened: many: backport fixes to 2.39 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6872>
[07:36] <zyga> mborzecki: woot, thank you for the backport
[07:36] <zyga> mborzecki: I will push the fix as soon as we're out of the plenary review cycle
[07:36] <zyga> mborzecki: we have cloud init in core and core18
[07:39] <mborzecki> zyga: idk, somehow it does not set up the system on boot
[07:40] <mup> PR snapcraft#2565 closed: requirements: update to requests-toolbelt 0.8.0 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2565>
[07:41] <mborzecki> zyga: regular cloud images have a bunch of cloud-init services, i don't see anything in core18 image though
[07:46] <zyga> mborzecki: hmmmm, that's odd
[07:46] <zyga> not sure about services but there *should* be some cloud-init for setting up core images in cloud
[07:48] <mborzecki> zyga: there are units in /lib/systemd/system but they have not been loaded by systemd for some reason
[07:50] <zyga> mborzecki: presets?
[07:50] <zyga> maybe something changed?
[07:53] <mborzecki> zyga: omg, is the virtio support in the kernel, i added cloud init data disk with if=virtio even though had the main image with if=ide :/
[07:53] <mborzecki> zyga: so it never got 'found' by systemd and cloud init did not start
[07:53] <zyga> I have a feeling we found this before
[07:53] <zyga> missing virtio module in core?
[07:53] <zyga> (kernel)
[07:53] <mborzecki> zyga: still a mystery why sytemctl list-units --all did not show cloud init services
[08:02] <pstolowski> degville: hey, wdyt about changing the help message per zyga's suggestion to https://github.com/snapcore/snapd/pull/6870 ?
[08:02] <mup> PR #6870: cmd/snap, api, snapstate: implement "snap remove --purge" <Created by stolowski> <https://github.com/snapcore/snapd/pull/6870>
[08:05] <zyga> mborzecki: does systemctl cat show anything?
[08:06] <Chipaca> pstolowski: Refrain from creating the automatic snapshot?
[08:06] <Chipaca> pstolowski: i thought that might be less clear, but then i see zyga himself suggested it
[08:09] <degville> pstolowski: I agree with zyga actually. 'Don't' seems a little informal and maybe not as immediately clear.
[08:09] <pstolowski> degville: great, ty
[08:16] <Chipaca> zyga: hey
[08:16] <Chipaca> zyga: https://forum.snapcraft.io/t/different-seccomp-behaviors-on-amd64-and-pi2-armhf/11370 might be of interest to you
[08:50] <zyga> Chipaca: hey, thank you, looking now
[09:03] <Chipaca> zyga: a libseccomp bug? surely you jest
[09:03] <zyga> Chipaca: not sure but perhaps, perhaps an outcome of the old vs new seccomp stack
[09:04] <zyga> but I'm just hand-waving, I need to look for real with hw to test
[09:07] <cwayne> zyga: if only there were a way to reserve a pi2.. :)
[09:10] <zyga> cwayne: yeah, sadly there's no way ;-)
[09:10] <zyga> (my vpn creds are back home)
[09:10] <zyga> but hardware is not the problem, trying to avoid spending too much time during plenary on non-plenary work
[09:20] <mup> PR snapcraft#2566 opened: kernel plugin: correctly download the os.snap <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2566>
[09:20] <dot-tobias> greyback / alan_g: I opened this GH issue re: mir-kiosk startup splash a while ago, short feedback highly appreciated :) https://github.com/MirServer/mir-kiosk/issues/15
[09:23] <greyback> dot-tobias: gosh sorry, I never noticed that. I'm not sure the splash animation can be disabled by a config, alan_g will know more
[09:23] <alan_g> In a meeting. I'll respond on the issue asap.
[09:28] <Chipaca> mborzecki: could you include #6851 in #6872 ?
[09:28] <mup> PR #6851: cmd/snap: mangle descriptions that have indent > terminal width <Simple 😃> <⚠ Critical> <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6851>
[09:28] <mup> PR #6872: many: backport fixes to 2.39 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6872>
[09:28] <mborzecki> Chipaca: sure, let me pick that
[09:28] <Chipaca> mborzecki: and #6853 might also be worthy ( pstolowski ?)
[09:28] <mup> PR #6853: interfaces: special-case "snapd" in sanitizeSlotReservedForOS* helper… <Simple 😃> <⚠ Critical> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6853>
[09:29] <Chipaca> or is that #6844
[09:29] <mup> PR #6844: interfaces: special-case "snapd" in sanitizeSlotReservedForOS* helpers <Simple 😃> <Squash-merge> <⚠ Critical> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6844>
[09:29] <Chipaca> anyway, one of those two should probably be in :)
[09:29] <Chipaca> pstolowski knows more
[09:31] <pstolowski> Chipaca: https://github.com/snapcore/snapd/pull/6853 was merged to 2.39 branch already
[09:31] <mup> PR #6853: interfaces: special-case "snapd" in sanitizeSlotReservedForOS* helper… <Simple 😃> <⚠ Critical> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6853>
[09:31] <pstolowski> if that was the question
[09:31] <Chipaca> 👍
[09:32]  * zyga needs more tests
[09:32] <zyga> (we require more spread tests)
[09:32] <mup> PR snapd#6873 opened: gadget: improve device lookup, add helper for mount point lookup <Gadget update> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6873>
[09:36] <mborzecki> Chipaca: #6851 is already included, it probably landed sometime between pre and final
[09:36] <mup> PR #6851: cmd/snap: mangle descriptions that have indent > terminal width <Simple 😃> <⚠ Critical> <Created by chipaca> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6851>
[09:37] <Chipaca> mborzecki: thank you
[09:38] <mborzecki> gadget/device_test.go:325:35: undefined: strings.ReplaceAll waaat?
[09:44] <Chipaca> mborzecki: strings.Replace(old, new, -1) is ReplaceAll
[09:44] <Chipaca> mborzecki: too much python over the weekend
[09:44] <Chipaca> or something
[09:44] <Chipaca> strings.Replace(s, old, new, -1) actually
[09:45] <mborzecki> Chipaca: https://godoc.org/strings#ReplaceAll really wish they had a tag with a version this was added in
[09:45] <Chipaca> mborzecki: or maybe you're getting confused with regexp, which does have a ReplaceAll
[09:45] <Chipaca> mborzecki: they do
[09:45] <Chipaca> mborzecki: they've just not used it on that :-|
[09:46] <mborzecki> Chipaca: i must be hitting those that don't have the tag then :P
[09:46] <Chipaca> mborzecki: https://golang.org/pkg/strings/#ReplaceAll
[09:46] <Chipaca> mborzecki: note the right hand side
[09:46] <mborzecki> Chipaca: aaa
[09:47] <Chipaca> mborzecki: bbbb
[09:47]  * Chipaca wins
[09:47] <mborzecki> Chipaca: still, 1.12 :(
[09:47] <Chipaca> the -1 thing isn't that terrible :)
[09:48] <Chipaca> i mean, replaceall is literally
[09:48] <Chipaca> func ReplaceAll(s, old, new string) string {
[09:48] <Chipaca> 	return Replace(s, old, new, -1)
[09:48] <Chipaca> }
[09:48] <Chipaca> anyhoo, coffee break time
[09:48] <mborzecki> coffee sounds about right
[09:49] <Chipaca> ikr
[10:02] <pstolowski> grr this must be the worst May for years, the weather has been terrible so far
[10:03] <pstolowski> no signs of summer whatsoever
[10:05] <zyga> I'm still working on the bugfix for propagation, tests pass as root, fail as  user,  need to investigate more
[10:26]  * pstolowski lunch
[10:41] <Chipaca> pstolowski: https://imgur.com/a/8mufe7k
[11:25] <mup> PR snapd#6862 closed: overlord/hookstate: don't run handler unless hooksup.Always <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6862>
[11:26] <Chipaca> #6848 ready for reviews
[11:26] <mup> PR #6848: introduce healthstate, run check-health post-(install/refresh/try/revert) <Created by chipaca> <https://github.com/snapcore/snapd/pull/6848>
[11:26] <Chipaca> at 800 lines, not for the faint of heart
[11:26] <Chipaca> (but a lot of those lines are mechanical test changes)
[11:28] <Chipaca> in that, https://github.com/snapcore/snapd/pull/6848/files#diff-81e36f58e21bdcdeb85d468298d9b17eR93 is for roadmr
[11:28] <mup> PR #6848: introduce healthstate, run check-health post-(install/refresh/try/revert) <Created by chipaca> <https://github.com/snapcore/snapd/pull/6848>
[11:28] <roadmr> thanks :)
[11:28] <roadmr> that is awesome, Chipaca hehe thanks
[11:57] <pstolowski> re
[11:57] <pstolowski> Chipaca: i'm envy
[12:09] <mborzecki> off to pick up the kids
[12:14] <cachio> mborzecki, hey
[12:16] <mup> PR core#38 closed: Add another pi-config option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/38>
[12:16] <mup> PR core#83 closed: move most of the ubuntu-core config deb into the snap snap build <Created by mvo5> <https://github.com/snapcore/core/pull/83>
[12:16] <mup> PR core#104 closed: snapcraft.yaml: use remote fc-cache-builder <Created by mvo5> <https://github.com/snapcore/core/pull/104>
[12:17] <mup> PR core#38 opened: Add another pi-config option <Created by sergey-borovkov> <https://github.com/snapcore/core/pull/38>
[12:17] <mup> PR core#83 opened: move most of the ubuntu-core config deb into the snap snap build <Created by mvo5> <https://github.com/snapcore/core/pull/83>
[12:17] <mup> PR core#104 opened: snapcraft.yaml: use remote fc-cache-builder <Created by mvo5> <https://github.com/snapcore/core/pull/104>
[12:19] <zyga> re
[12:23] <zyga> mborzecki: funny thing, my fix makes the root user ok but there's still a bug if you run as test user
[12:23] <zyga> mborzecki: I'm debugging why, updated the test suite to check it (that's how I found it)
[12:26] <zyga> Chipaca: can you do 2nd review on https://github.com/snapcore/snapd/pull/6856
[12:27] <zyga> it's just more tests
[12:27] <mup> PR #6856: cmd/snap-update-ns: add tests for executeMountProfileUpdate <Created by zyga> <https://github.com/snapcore/snapd/pull/6856>
[12:27] <mup> PR # closed: core-build#11, core-build#22, core-build#26, core-build#37, core-build#38
[12:28] <mup> PR # opened: core-build#11, core-build#22, core-build#26, core-build#37, core-build#38
[12:53] <pstolowski> cachio: hey, how can i run the test from #6859 ?
[12:53] <mup> PR #6859: tests: new hotplug test executed on ubuntu core  <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6859>
[12:55] <mup> PR snapd#6856 closed: cmd/snap-update-ns: add tests for executeMountProfileUpdate <Created by zyga> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6856>
[12:56] <zyga> mborzecki: thanks!
[12:56] <zyga> woot, I have very little after that, let me see
[12:57] <cachio> pstolowski, no yet, I'll try now to register again my key and see if it works
[13:37] <mborzecki> zyga: nsswitch.conf is a symlink to /etc/authselect/nsswitch.conf now
[13:37] <zyga> fun
[13:37] <zyga> I really really know we need to start over with empty /etc
[13:37] <zyga> this is not something we can fix easily
[13:38] <zyga> mborzecki: can you report the bug with a good explanation
[13:38] <zyga> I will discuss locally and we can plan for actions next week
[13:38] <zyga> it sucks that F30 is just broken :/
[13:38] <mborzecki> zyga: w8, it was like that in 29 too
[13:38] <zyga> whaaat?
[13:39] <mborzecki> zyga: f30: https://paste.ubuntu.com/p/drHz7js6Q5/ running hello-world snap
[13:40] <zyga> fuuuuuk
[13:40] <zyga> can you report that as critical please
[13:40] <zyga> we can discuss options
[13:40] <zyga> fun week
[13:40] <mborzecki> let me check if that's new in 2.39 though
[13:40] <zyga> mborzecki: I think I understand the  bug (older bug) better now
[13:41] <zyga> if you have some time today I can show you in a call
[13:41] <zyga> for some brainstorming
[13:41] <mborzecki> zyga: standup?
[13:41] <zyga> mborzecki: and if you can, please  send one patch
[13:41] <zyga> mborzecki: don't mount over /etc symlinks
[13:41] <zyga> not a security defennse
[13:41] <zyga> just as OMG BROKEN
[13:41] <zyga> mborzecki: joining
[13:52] <cachio> zyga, https://paste.ubuntu.com/p/5fx9fbKMbH/
[13:52] <cachio> this is the output for findmnt -o+PROPAGATION
[13:52] <cachio> perhaps it helps
[14:07] <mup> PR pc-amd64-gadget#10 closed: Add mmx64.efi (MokManager) to support mokutil <Created by tsunghanliu> <https://github.com/snapcore/pc-amd64-gadget/pull/10>
[14:07] <mup> PR pc-amd64-gadget#11 closed: Add mmx64.efi (MokManager) to support mokutil <Created by tsunghanliu> <https://github.com/snapcore/pc-amd64-gadget/pull/11>
[14:08] <mup> PR pc-amd64-gadget#10 opened: Add mmx64.efi (MokManager) to support mokutil <Created by tsunghanliu> <https://github.com/snapcore/pc-amd64-gadget/pull/10>
[14:08] <mup> PR pc-amd64-gadget#11 opened: Add mmx64.efi (MokManager) to support mokutil <Created by tsunghanliu> <https://github.com/snapcore/pc-amd64-gadget/pull/11>
[14:23] <cachio> mborzecki, this is the error on the selinux-clean test on fedora 30 https://paste.ubuntu.com/p/PGG4JyXWgN/
[14:23] <cachio> is it the same you saw
[14:23] <cachio> ?
[14:24] <mup> PR snapcraft#2566 closed: kernel plugin: correctly download the os.snap <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2566>
[14:24] <mborzecki> cachio: yes
[14:24] <mborzecki> cachio: unsquashfs is somethign we can fix, nsswitch.conf requires a fix elsewhere
[14:25] <cachio> so, should we skip that test while the fix is in progress?
[14:26] <cachio> or it is better to fix it before starting the test for fedora 30
[14:28] <cachio> sergiusens, hey, which is the best way to delete my default key using snapcraft
[14:28] <cachio> ?
[14:30] <zyga> mborzecki: intermediate path is symlink
[14:30] <zyga> Not the final name
[14:31] <zyga> We have better mount code in go
[14:35] <mborzecki> zyga: i was checking the wrong end :/
[14:40] <zyga> mborzecki: both ends matter
[14:52] <mborzecki> zyga: https://github.com/snapcore/snapd/pull/6874
[14:52] <mup> PR #6874: cmd/snap-confine: do not mount over non files/directories <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6874>
[14:52] <mborzecki> cachio: this should fix part of the problem ^^
[14:52] <zyga> looking
[14:52] <mup> PR snapd#6874 opened: cmd/snap-confine: do not mount over non files/directories <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6874>
[14:53] <zyga> mborzecki: can you do a small tweak
[14:53] <cachio> mborzecki, great news!!
[14:53] <zyga> if anything fails -> die  (unless ENOENT)
[14:53] <zyga> if lstat works -> remember mode
[14:53] <zyga> then mode must match (REG or DIR)
[14:53] <zyga> then mount
[14:53] <zyga> on unexpected failure die
[14:54] <zyga> on expected mismatch log
[14:55] <zyga> mborzecki: does that make sense?
[16:01] <Chipaca> mborzecki: https://play.golang.org/p/qwiysalqvq1
[16:41]  * zyga explores and explores...
[16:50] <cachio> sergiusens, kyrofa, hey, any idea of this https://paste.ubuntu.com/p/PmBdZ7QzkH/
[17:20] <cachio> pstolowski|afk, hey, still trying to fix the issue I have with my keys, I'll try to push the last fix for tomorrow, sorry for the delay
[18:07] <cachio> Chipaca, hey, sorry for the delay, I updated the PR 6618
[18:07] <mup> PR #6618: tests: validates snapd from ppa <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6618>
[18:07] <Chipaca> cachio: ack. I'll take a look later tonight
[18:08] <Chipaca> going to have dinner and walk the dog, now
[18:08] <cachio> Chipaca, thanks
[18:08] <cachio> hehe, I forget it is so late in uk
[18:13] <cachio> Chipaca, do you know how to do snap sign with a key which is not hte default?
[18:15] <cachio> Chipaca, found that