[02:26] <mup> Issue core18#128 opened: Having issues installing core18 <Created by D3faIt> <https://github.com/snapcore/core18/issue/128>
[03:03] <mup> Issue core18#128 closed: Having issues installing core18 <Created by D3faIt> <Closed by D3faIt> <https://github.com/snapcore/core18/issue/128>
[05:23] <zyga> Hello
[05:23] <mborzecki> morning
[05:50] <zyga> hey mborzecki
[05:50]  * zyga tries to wrap up propagation bug
[05:50] <mborzecki> zyga: hey
[05:50] <zyga> tests now pass, I'm still adding some more checks though
[05:51] <zyga> and I have a lot of unit tests to adjust for extra calls
[05:53] <mborzecki> zyga: i poked a bit around /etc/nsswitch.conf on fedora, vanilla 29 image starts with a symlink, but after dnf upgrade /etc/nsswitch.conf becomes a file, probably some scriptlet broke it
[05:53] <zyga> mborzecki: ah, I wonder if it's a design or bug
[05:54] <zyga> mborzecki: perhaps worth reporting a bug to ask the question
[05:59] <mborzecki> zyga: looks like a bug/issue about authselect which is not installed in cloud images, so never gets to run and update nsswitch.conf to be a symlink
[06:00] <mborzecki> zyga: found this: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G564T2VXADHS557BOT5L5K42SSF4QSIE/ and https://bugzilla.redhat.com/show_bug.cgi?id=1622272#c8
[06:00] <mborzecki> looks like some monkey business to me
[06:00] <zyga> yeah
[06:02] <mborzecki> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/PNKKVG3K6WAU42CCPVIEV6LZY7PWUG4P/
[06:04] <mborzecki> meh, installed authselect, ran authselect select --force sssd and it errors out :/
[06:05] <mborzecki> nvm, looks like this is fixed in f30, f29 will eol in a couple of months anyway
[06:15] <zyga> yeah, at least that's good
[06:15] <zyga> thanks for chasing this
[06:15]  * zyga writes docs for test tool helper
[06:27] <mborzecki> one more tweak for selinux policy for f30
[06:27] <mborzecki> guess i'll never stop finding search on dir class confusing :/
[06:33] <zyga> mborzecki: you should do talks on selinux
[06:33] <mborzecki> zyga: i'm far from competent in this
[06:53] <zyga> breakfast
[06:59] <pstolowski> mornings
[07:01] <zyga> hey pawel
[07:01] <mup> PR snapd#6881 opened: data/selinux: allow snap-confine to do search on snappy_var_t directories <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6881>
[07:02] <mborzecki> pstolowski: hey
[07:11] <zyga> mborzecki: last bit in this tool is renumbering for deterministic test
[07:11] <zyga> mborzecki: some heavy lifting from that old tool
[08:00] <zyga> ok, I think the tool is ready now
[08:09] <zyga> mborzecki: mountinfo-tool https://www.irccloud.com/pastebin/N5yQNZPX/
[08:11] <mup> PR snapd#6803 closed: daemon, o/snapstate, store: support for installing from cohorts <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6803>
[08:12] <mup> PR snapd#6703 closed: tests: add deferred actions <⛔ Blocked> <Created by zyga> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/6703>
[08:12] <Chipaca> bongiorno, principesse e principi!
[08:13]  * Chipaca wonders if italian has "inclusive language" for plurals
[08:16] <mvo> hey Chipaca
[08:16] <Chipaca> mvo: 'sup
[08:18] <pedronis> mborzecki: #6874 was merged but at least jdstrand should have looked at it
[08:18] <mup> PR #6874: cmd/snap-confine: do not mount over non files/directories <Created by bboozzoo> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6874>
[08:19] <pedronis> mvo: ^
[08:19] <mborzecki> pedronis: looks like cachio merged it yesterday, i'll ping jdstrand to have a look still
[08:19] <mvo> pedronis: good morning! I was looking over the spike trello cards this morning
[08:19] <mvo> pedronis: yeah, we need to ask jamie to double check it
[08:19] <mvo> pedronis: and tried to flesh things out a little bit
[08:20] <pedronis> mvo: maybe we need to tell cachio not to merge snap-confine/snap-update-ns stuff
[08:20] <mvo> pedronis: while doing so I was stumbling on snap-verify and poked around a bit, it seems like we need something like assertstate.Batch just without the ties to the state, does that sound right? or do you have something else in mind for that?
[08:20] <mvo> pedronis: yeah, I think that is a good idea
[08:21] <mborzecki> my bad, should have added a blocked label or sth
[08:21] <pedronis> it's a judgement call, just don't think he is worth having everybody be able to do that
[08:23] <pedronis> mvo: yes, Batch could be useful, it depends what the api is though
[08:25] <mvo> pedronis: yeah, it requires refactor because assertstate only exposes a RODatabase so we have to have a custom save function at least. anyway, I can poke around a bit but if you have a firm plan already I can also leave it alone, it seems nice and tracktable though :)
[08:25] <pedronis> mvo: please leave it alone,  I don't think is a good use of your time, and a script that does exit 0 should unblock you
[08:26] <mvo> pedronis: heh, I can do that
[08:26] <pedronis> mvo: yes, Batch is in assertstate, I don't think we need that, a Fetcher is enough
[08:27] <pedronis> but anyway
[08:27] <mvo> ok
[08:28] <pedronis> mvo: I think we need to understand what we should verify, before writing the tool
[08:28] <pedronis> with relates more to the rest of the initramfs
[08:28] <pedronis> s/with/which/
[08:29]  * mvo nods
[08:31] <pedronis> mvo: my biggest worry is that we will need to verify the kernel also on the run path
[08:31] <pedronis> I mean worry related to the tool
[08:32] <mvo> pedronis: verify the running kernel?
[08:32] <pedronis> maybe
[08:32] <pedronis> maybe not, we need to think
[08:33] <mvo> pedronis: hm, interessting. you need to tell me more when we have high bandwidth time in a HO
[08:50]  * zyga -> quick coffee
[08:54] <mup> PR snapd#6882 opened: cmd: add snap-verify stub binary (UC20) <Created by mvo5> <https://github.com/snapcore/snapd/pull/6882>
[09:01] <Chipaca> pedronis: where is this meeting?
[09:01] <pedronis> Chipaca: added a HO now
[09:35] <Chipaca> pedronis: https://forum.snapcraft.io/t/downloading-snaps-via-snapd/11449
[09:35] <Chipaca> pedronis: maybe point igor at that (dunno his nick)
[09:50] <zyga> mvo: reviewed 6882
[09:51] <mvo> ta
[10:14] <zyga> ok, *really* time for that coffee
[10:45] <mborzecki> pstolowski: can you take a quick look at https://github.com/snapcore/snapd/pull/6881 ?
[10:45] <mup> PR #6881: data/selinux: allow snap-confine to do search on snappy_var_t directories <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6881>
[11:00] <mup> PR snapd#6881 closed: data/selinux: allow snap-confine to do search on snappy_var_t directories <Created by bboozzoo> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6881>
[11:01] <mborzecki> pstolowski: thanks!
[11:01] <pstolowski> np
[11:15] <cachio> pstolowski, hey, #6859 is ready I think
[11:15] <mup> PR #6859: tests: new hotplug test executed on ubuntu core  <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6859>
[11:16] <cachio> pstolowski, hold on, I just read the comments you did
[11:16] <pstolowski> cachio: great! does it pass on both cores?
[11:16]  * zyga runs spread for propagation test!
[11:16] <zyga> (so so so close now)
[11:16] <cachio> pstolowski, yes
[11:17] <pstolowski> cachio: awesome! thank you
[11:17] <cachio> pstolowski, for a following PR I'll reuse the tests parts
[11:17] <cachio> pstolowski, but I would keep it working first so then I can work on sharing test code
[11:17] <pstolowski> cachio: yes, sounds good, let's land it and do a followup
[11:17] <cachio> between tets
[11:18] <cachio> pstolowski, nice
[11:18] <pstolowski> cachio: i'll take a look today
[11:26] <ackk> hi, is there any way to have snapcraft pull in a deb from a specific URL as stage-packages ?
[11:28] <ackk> (or have it pulled from a repo)
[11:29] <Chipaca> pedronis: my changes to the 'snap info' will probably conflict with the pr that depends on it (that i'd made to depend to avoid conflicts.... augh) but i think it's a lot nicer now
[11:43] <sergiusens> morning, question about 2.39, when is it out?
[11:53] <pedronis> sergiusens: should go out today , cc mvo
[12:02] <mvo> pedronis, sergiusens correct
[12:04]  * zyga afk for errand 
[12:08] <pedronis> Chipaca: #6816 needs master merged, and has some conflicts right now
[12:08] <mup> PR #6816: daemon, overlord: support for cohort-key in refresh and switch <Created by chipaca> <https://github.com/snapcore/snapd/pull/6816>
[12:16] <Chipaca> pedronis: will do
[12:16]  * Chipaca finishing lunch
[12:16] <pedronis> thx
[12:38] <zyga> re
[12:41] <pedronis> not sure, don't know what they scheduled over the standup
[12:51] <zyga> mborzecki: snapd tests now pass :-)
[12:51] <zyga> mborzecki: also in spread
[12:51] <zyga> I will run them on more systems and start to trim crap out of that branch for proposal
[12:57] <mup> Issue core18#129 opened: Multiarch isn't working <Created by xordspar0> <https://github.com/snapcore/core18/issue/129>
[12:59] <pedronis> Chipaca: did a pass over #6564
[12:59] <mup> PR #6564: cmd/snap, tests: refactor info to unify handling of 'direct' snaps <Created by chipaca> <https://github.com/snapcore/snapd/pull/6564>
[13:00] <Chipaca> pedronis: thx
[13:31] <zyga> is the standup over?
[13:31] <mborzecki> zyga: yes
[13:31] <zyga> ok
[13:35] <mup> Issue # closed: core18#56, core18#86, core18#89, core18#117, core18#129
[13:35] <mup> PR # closed: core18#43, core18#72, core18#90, core18#98, core18#122, core18#126, core18#127
[13:36] <mup> Issue # opened: core18#56, core18#86, core18#89, core18#117, core18#129
[13:36] <mup> PR # opened: core18#43, core18#72, core18#90, core18#98, core18#122, core18#126, core18#127
[13:37] <mup> PR snapd#6867 closed: gadget: offset-write: fix validation, calculate absolute position <Gadget update> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6867>
[13:38]  * zyga lunch break
[13:38] <zyga> starving!
[13:39] <zyga> mborzecki: lol, the branch has fixed one known test that just shows how layouts are broken in one case :)
[13:45] <cachio> mborzecki, m
[13:45] <cachio> https://travis-ci.org/snapcore/snapd/jobs/535240901
[13:45] <cachio> thanks for the help on that one
[13:46] <mborzecki> cachio: yay!
[13:46] <mborzecki> cachio: land it while it's green :)
[14:02] <cachio> mborzecki, done
[14:02] <mup> PR snapd#6860 closed: tests: running tests on fedora 30 <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6860>
[14:36] <mvo> kenvandine: I updated bug 1825883 - its in 2.39
[14:36] <mup> Bug #1825883: stale copy of plug and slot attributes is kept in connection state <snapd:In Progress by zyga> <https://launchpad.net/bugs/1825883>
[14:37] <kenvandine> mvo: great, thanks!
[14:49] <pedronis> Chipaca: oops, I was almost forgetting, this is my PR that changes the signatures of the users methods: https://github.com/snapcore/snapd/pull/6834
[14:49] <mup> PR #6834: daemon: pass the model to the create known user helpers (instead of full Overlord) <Remodel :train:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/6834>
[14:49] <pedronis> Chipaca: as I said maybe it's easier if you just incorporate that change in the refactor
[14:49] <pedronis> your are doing
[14:50] <Chipaca> looks like it :-|
[14:50] <Chipaca> need to wrap up the info one :)
[14:51] <mup> PR snapcraft#2568 opened: docs: consolidate on a simple HACKING.md <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2568>
[14:52] <pedronis> Chipaca: no hurry, it's orthogonal to my other open PRs, I'm not blocked on it (I think)
[14:54] <zyga> snap-confine has elevated permissions and is not confined but should be. Refusing to continue to avoid permission escalation attacks
[14:54] <zyga> hmmm
[14:59] <zyga> mvo: found a small bug in core18
[14:59] <zyga> mvo: there's no profile for /usr/lib/snapd/snap-confine
[14:59] <zyga> look at this plese
[14:59] <zyga> *please
[14:59] <zyga> https://www.irccloud.com/pastebin/MnHLkuvk/
[15:00] <zyga> I think we don't notice because spread tests run as root
[15:00] <mvo> zyga: ok, after the meeting (we have now)
[15:00] <zyga> oh
[15:00] <zyga> joining
[15:01] <pedronis> that should be written by snapd, no?
[15:01] <pedronis> it shouldn't be in the core18 itself
[15:20] <mup> PR snapd#6859 closed: tests: new hotplug test executed on ubuntu core  <Created by sergiocazzolato> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/6859>
[15:22]  * cachio lunch
[15:24] <pstolowski> cachio: i've merged your nested tests PR
[15:25] <mup> PR # closed: snapd#5644, snapd#5822, snapd#5915, snapd#6108, snapd#6258, snapd#6325, snapd#6327, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6404, snapd#6436, snapd#6541, snapd#6564, snapd#6588, snapd#6648, snapd#6666, snapd#6680, snapd#6681, snapd#6691, snapd#6695, snapd#6697,
[15:25] <mup> snapd#6705, snapd#6708, snapd#6714, snapd#6721, snapd#6734, snapd#6750, snapd#6759, snapd#6760, snapd#6767, snapd#6804, snapd#6805, snapd#6816, snapd#6825, snapd#6834, snapd#6835,
[15:25] <mup> snapd#6836, snapd#6838, snapd#6839, snapd#6841, snapd#6848, snapd#6855, snapd#6870, snapd#6871, snapd#6875, snapd#6876, snapd#6878, snapd#6879, snapd#6880, snapd#6882
[15:26] <mup> PR # opened: snapd#5644, snapd#5822, snapd#5915, snapd#6108, snapd#6258, snapd#6325, snapd#6327, snapd#6341, snapd#6347, snapd#6360, snapd#6367, snapd#6404, snapd#6436, snapd#6541, snapd#6564, snapd#6588, snapd#6648, snapd#6666, snapd#6680, snapd#6681, snapd#6691, snapd#6695, snapd#6697,
[15:26] <mup> snapd#6705, snapd#6708, snapd#6714, snapd#6721, snapd#6734, snapd#6750, snapd#6759, snapd#6760, snapd#6767, snapd#6804, snapd#6805, snapd#6816, snapd#6825, snapd#6834, snapd#6835,
[15:26] <mup> snapd#6836, snapd#6838, snapd#6839, snapd#6841, snapd#6848, snapd#6855, snapd#6870, snapd#6871, snapd#6875, snapd#6876, snapd#6878, snapd#6879, snapd#6880, snapd#6882
[15:33] <pstolowski> pedronis_: your suggestion re RemoveFlags & flags.go on https://github.com/snapcore/snapd/pull/6870 was to simply move RemoveFlags there (or to extend Flags and not introduce RemoveFlags)?
[15:33] <mup> PR #6870: cmd/snap, api, snapstate: implement "snap remove --purge" <Created by stolowski> <https://github.com/snapcore/snapd/pull/6870>
[15:36] <pstolowski> degville: hey, any thoughts on https://github.com/snapcore/snapd/pull/6870#discussion_r285659028 ?
[15:36] <mup> PR #6870: cmd/snap, api, snapstate: implement "snap remove --purge" <Created by stolowski> <https://github.com/snapcore/snapd/pull/6870>
[15:38] <pedronis> pstolowski: to move it there, but as I said I would like Chipaca's input on some of my remarks
[15:43] <pstolowski> ack
[15:54] <pedronis> Chipaca: I asked your 2nd opinion on a couple of things in #6870 from pstolowski
[15:54] <mup> PR #6870: cmd/snap, api, snapstate: implement "snap remove --purge" <Created by stolowski> <https://github.com/snapcore/snapd/pull/6870>
[15:54]  * Chipaca looks
[15:55] <degville> pstolowski: looking...
[15:58] <pedronis> Chipaca: made a small comment about the building of infoWriter discussion in 6564
[16:02] <Chipaca> hah, degville just snuck in as i was writing it :-D
[16:02] <Chipaca> degville: wdyt of the 'save' comment (now sitting below yours)?
[16:03] <degville> Chipaca: It's a really good point. I think you're right.
[16:04] <degville> (about saving. I like the idea of using consistent verbs too).
[16:04] <pstolowski> Chipaca, degville thanks for comments; Chipaca, are you suggesting to simply reuse Flags (rather than just move RemoveFlags?)
[16:06] <Chipaca> pstolowski: yes
[16:07] <pstolowski> k
[16:07] <Chipaca> pstolowski: dunno if pedronis agrees tho :-)
[16:08] <pedronis> Chipaca: pstolowski: I don't
[16:08] <pedronis> what other flags do they share?
[16:10] <pedronis> if it needed to go into SnapSetup there would be a point, but that's not the case afaiu
[16:10] <pstolowski> none. Flags seems to install related
[16:10] <Chipaca> instlal/refresh/etc
[16:11] <Chipaca> I don't mind if it's separate :)
[16:11] <Chipaca> (there is ForSnapSetup that zeros out unwanted flags for snap setup fwiw)
[16:11] <pedronis> I know
[16:11] <pedronis> though is often forgotten
[16:11] <Chipaca> yes :-|
[16:11] <pedronis> pstolowski: my feeling right now is to keep it but move close to the function
[16:11] <pedronis> right now is miles away
[16:12] <pedronis> afair
[16:13] <pstolowski> pedronis: done
[16:15] <pedronis> pstolowski: thx
[16:19] <Chipaca> hah, finding bugs by writing tests
[16:19] <Chipaca> a novel endeavour
[16:19] <pedronis> Chipaca: where? :)
[16:19] <Chipaca> pedronis: maybePrintStandaloneVersion
[16:19] <Chipaca> when no version in the snap file
[16:20] <Chipaca> would produce bad yaml
[16:20] <pedronis> ah
[16:20] <Chipaca> not an easy path to hit as a versionless snap is invalid
[16:20] <Chipaca> but, hey :)
[16:20] <pedronis> :)
[16:20] <pedronis> robustness in depth
[16:20] <pedronis> or something
[16:31] <mvo> pedronis, cmatsuoka, zyga I updated the gadget PR with most^Wsome^Wmost(?) things we discussed
[16:31] <zyga> mvo: ack, thank you!
[17:15] <Chipaca> pedronis: so many unit tests it's almost embarrassing
[17:15]  * Chipaca EODs
[17:16] <Chipaca> mvo: silly and low priority reminder about sprint approvals (just so they don't pile up on you :-p)
[17:16]  * Chipaca again pretends to EOD
[17:27] <mup> Issue core18#129 closed: Multiarch isn't working <Created by xordspar0> <Closed by xordspar0> <https://github.com/snapcore/core18/issue/129>
[17:46] <mup> PR snapd#6883 opened: tests: fix how strings are matched on auto-refresh-retry test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6883>
[18:36]  * zyga is back home :-)
[18:39] <zyga> tomorrow morning will be busy :)
[19:11] <mup> PR snapd#6870 closed: cmd/snap, api, snapstate: implement "snap remove --purge" <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/6870>
[21:11]  * cachio afk
[21:46] <mup> PR snapcraft#2569 opened: lifecycle: warn about bases <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2569>