/srv/irclogs.ubuntu.com/2019/05/23/#snappy.txt

mborzeckimorning05:27
mborzeckikernel update, rebooting, brb05:38
mborzeckiaand back05:40
zygaHey :-)05:45
zygamborzecki: solved that issue last night05:45
mborzeckizyga: hey05:45
zygaI’ll eat dry and update the pr05:45
mborzeckizyga: oh, solved mine too, i can create bootable images now  :)05:45
zygas/dry/sth/05:46
zygaSounds like a good day indeed05:48
zygaWhat was the issue?05:48
mborzeckizyga: the raw structure writer was dumping image content at a start offset that was within a complete volume, but since i'm constructing an image of each partition separately, i need to apply a bias to have the structure start at 0 offset05:52
mborzeckinow i need to figure out where the hell grubenv comes from in ubuntu-image05:54
mvomborzecki: the grubenv comes from `snap prepare-image`06:02
mborzeckimvo: hi, and thanks for the tip06:02
mvomborzecki: yw and hi as well06:03
mupPR snapd#6893 opened: gadget: helper for shifting structure start position <Gadget update> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6893>06:26
zygaback in the office :)06:39
zygamvo: hey, I nailed that bug last night06:40
zygaI need to make two small modifications to the fix PR and it's going to be green :)06:40
zygaone is just shell quoting and another is reduction of a test that was really measuring the bug to begin with06:40
zygaonce I realised the test was buggy it was all obvious :)06:40
zygamvo: I also got a much nicer approach to defer, but separated out into its own branch06:42
zygait is much nicer than the v106:42
zygaI'll get to it now :)06:42
zygahey pedronis06:42
mvozyga: nice!06:46
mvohey pedronis06:46
mvozyga: looking forward to it06:46
pedronismvo: hi06:46
=== pstolowski|afk is now known as pstolowski
pstolowskimorning07:01
mborzeckipstolowski: pedronis: hey07:02
amurrayis build.snapcraft.io a bit flaky at the moment? I can't seem to add a new repo (it just keeps spinning...)07:03
pedronispstolowski: hi, what are you working on ATM ?07:29
pstolowskipedronis: hi, a small followup for snap debug timings output, then a small bugfix for them, then i'll move onto preventing nulls (with a forum topic at the same time)07:31
pedronispstolowski: I thought a bit further about the latter,  we should chat before we go there, also as we discussed it's probably 2.41 material07:32
pedronispstolowski: mvo: should we try to get "base: none" support sooner instead07:32
pstolowskipedronis: there are two small issues with ensure timings, so perhaps we can discuss them + null at the same time07:33
pedronispstolowski: we can chat in 30 mins if you want07:36
pedronis~3007:36
pstolowskipedronis: ok07:37
mborzeckihmm shellcheck got an update apparently07:48
mvomborzecki: is it breaking our stuff?07:49
mborzeckimvo: https://paste.ubuntu.com/p/Ztb7rqnzXP/07:50
zygamvo: hey, I'd love a review of https://github.com/snapcore/snapd/pull/688807:51
mupPR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>07:51
zygait's a pre-req for the test for the propagation bug07:51
mborzeckimvo: https://github.com/koalaman/shellcheck/wiki/SC225107:51
mvomborzecki: uh, thats pedantic07:52
mvomborzecki: let me read this but I'm not sure I like it07:52
mvomborzecki: eh07:53
mvomborzecki: if I'm reading this correctly our tests have some big holes?!?07:53
* mvo looks closer07:53
mborzeckimvo: heh, yeah, not sure i understand the issue here, trying it out locally07:54
mvomborzecki: yeah07:54
mvomborzecki: https://paste.ubuntu.com/p/rtzBmt5Btf/07:54
mvomborzecki: this looks like either ! true or ! false trigger an errexit07:55
zygamborzecki: interesting, shell is a valley of landmines!07:56
mvozyga: its getting worse and worse07:56
zygamvo: fun07:56
zygayeah07:56
mvozyga: I mean, the more I learn the more I despair about all the corners one need to know07:56
zygait's all terrible07:56
zygamvo: right?07:56
mborzeckimvo: don't trigger errexit you mean, right?07:56
zygaI wish someone wrote a sane-sh07:56
mvozyga: also - I swear I saw this a gazillon of times in various scripts07:56
zygayeah07:57
zygamvo: we should donate to shellcheck07:57
pedronisso yes, our tests are full of this, fun, not07:57
mvomborzecki: yeah, it seems like !true !false !whatever, nothing triggers an exit07:57
mvopedronis: /o\07:57
mborzeckimvo: yup :/ ehh07:57
mvozyga: totally, at least we need to sent him some "you are a hero" mail or something07:57
mborzeckimvo: at least it's good shellcheck flags that07:57
zygazyga@yantra:~/go/lnx-src/github.com/snapcore/snapd> git grep '!' -- */task.yaml | wc -l07:58
zyga49007:58
zygaoh my07:58
zygamborzecki: which version of shellcheck is that?07:58
mborzeckizyga: snap info shellcheck, look at edge07:58
zygazyga@yantra:~/go/lnx-src/github.com/snapcore/snapd> git grep '!' -- '*.sh' | wc -l07:58
zyga12907:58
mborzeckibtw. it's also published as a snap by the author :P07:59
mvomborzecki: yes07:59
pedronismvo: anyway trying here their correct doesn't work either07:59
pedronismaybe I'm just confused07:59
mvozyga: if this guy is on twitter we should sent some hearts, I'm sure email will just get into his spam folder07:59
mvopedronis: same here, how strange08:01
mborzeckiwe do ! foo, because we expect foo to fail, so if it doesn't fail, the test should err out i.e. errexit should get triggerred08:02
zygaperhaps "correct" is just about telling shellcheck that is what you mean08:02
zygain all cases ! true doesn't exit08:02
pedronisno, the wiki says, it will errexit08:02
pedronisbut doesn't08:02
mborzeckimaybe a different shell?08:03
mvoI tried bash and dash08:03
zygaI tried bash 3.2.57 (macos) and 5.0.7 (linux)08:04
zygasame lack of result08:04
mvohey Chipaca08:04
zygahey chihchun08:04
zygaI meant Chipaca08:05
mvoChipaca: great timing, we have shell fun again08:05
mborzeckiChipaca: https://github.com/koalaman/shellcheck/wiki/SC225108:05
pedronisdeep shell fun08:05
pedronispstolowski: want to chat now?08:05
zygapedronis: let me abberviate that to "deep sh"08:05
pstolowskipedronis: yep, 1 minute08:05
zygamvo: strawman: uses python for tests08:06
mborzeckimvo: fwiw ! true without {} doesn't work as expected either08:06
zygamvo: with that magic module that puts all shell commands as python functions08:06
zygamvo: via import magic08:06
* zyga looks08:06
mborzeckizyga: sounds like you worked with bitbake :P08:06
Chipacamborzecki: mvo: nice08:07
zygaoooh08:07
zygagithub now supports security patches08:07
Chipacaso I've got bugs in my head, and we've got bugs in our code08:07
Chipacazyga: oh?08:07
mborzeckiChipaca: so, the trick is finding a short form that actually works, bc one they say is correct does not seem to work08:08
zygaI think I misread, security *bugs*08:08
zygahttps://twitter.com/github/status/113147084851324928008:08
mvoChipaca: did you say "bugs on my head" ?08:08
zygamborzecki: I have an idea08:08
zygamborzecki: give me a sec08:08
zygamborzecki: and it ties into a super nice idea (famous last words) that I had in my last branch08:08
zygamborzecki: to put new things on $PATH for testing08:08
zygamborzecki: we can write "not ..." command08:08
Chipacamvo: in08:08
zygathat just runs the rest in shell and negates the result08:08
pedronispstolowski: I'm in the standup08:08
* zyga does so quickly08:09
pstolowskipedronis: ok coming08:09
mvozyga: oh, thats an interessting idea08:09
zygamvo: right?08:09
zygamvo: give me 308:09
mborzeckihack spread and make it define NOT08:09
mborzeckimvo: ( ! true )08:11
mvoaha!08:11
mvomborzecki: funny, the linked stackoverflow mentions ()08:11
mborzeckiha!08:12
mvomborzecki: so probably worth a bugreport/patch08:12
mborzeckishould have done the reading08:12
mvomborzecki: to the shellcheck guy, least we can do08:12
mvonah, reading is overrated08:12
mborzeckimvo: fwiw ( ! true ) isn't flagged08:15
zygamvo: https://github.com/snapcore/snapd/pull/689408:16
mupPR #6894: tests: add "not" command as replacement for "!" in tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6894>08:16
mupPR snapd#6894 opened: tests: add "not" command as replacement for "!" in tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6894>08:16
zygamborzecki: ^08:16
Chipacaum08:17
Chipacazyga: didn't you mean to put bin in the path08:17
zygaChipaca: didn't I put it?08:17
Chipacazyga: and the binary in the bin08:17
Chipacazyga: so the binary is in the path08:17
Chipaca?08:17
zygadoh08:17
zygahaha08:17
zygaI see08:17
Chipacazyga: you even wrote a .keep file to keep the empty directory08:18
Chipacazyga: i think you need more coffee08:18
zygaChipaca: I'm having some now :D08:18
zygaI recycled the bin idea from an earlier branch08:18
zygafixed now08:18
Chipacahave of your neurons are all "whee" and the other half are all "g'waymnsfifCOMFYfmsmwm"08:18
Chipacahalf*08:19
zygaChipaca: I'm tempted to add tests/lib/man to MANPATH and write a man page now08:19
zygashould I?08:19
zygamvo: if you like this idea (about not replacing !) I can adjust tests08:19
Chipacazyga: no08:19
Chipacazyga: (i don't really mind but nobody's gonna read it)08:20
zygamvo: perhaps we should invite shellcheck developer to a sprint sometime, he might be a good voice in the haskel community08:20
zygaChipaca: I'd read it in --debug08:20
Chipacazyga: have it look out for -h/--help then?08:21
Chipacazyga: but seems silly08:21
Chipacazyga: this is how /bin/true is not an empty file08:21
Chipacaor was it /bin/false08:21
zygaChipaca: let's fix the tests story first08:21
Chipacaanyway :)08:21
zygathen I can play on this later :)08:22
mvozyga: I like the PR, unless pedronis disagrees I think we should use this approach and replace all our "! foo" with "not foo" or "assert_fail" or "assertFail foo" ?08:22
zygamvo: I agree08:22
Chipaca/bin/true could be just an empty executable file and instead is a 27k dynamic binary, and it's all zyga's fault08:22
zygamvo: I'd go with "not foo" first08:23
zyganot assert anything08:23
zygaas we really are asserting each line08:23
zygabecause of the set -e08:23
mvoso quicl poll on the name: "not", "assert_false", "assertFalse" ?08:23
zygamvo: we may also see bugs uncovered08:23
zygamvo: it should be "not" because of what I said08:23
mvozyga: oh yes08:23
zygaand plays nice with the language, python and readability08:23
zygaunless it starts to look ugly in tests08:24
zygabut let's see how it works out08:24
zygamvo: I'll start attacking shell tests now08:24
mvozyga: sounds good, *if* there is a discussion about the naming we can easily sed the name again08:25
zygamvo: sounds good08:25
zygamvo: even inside the patch ):08:25
zyga:-)08:25
* zyga is on it08:25
mvohaha, true08:25
Eighth_Doctorzyga, mborzecki08:27
Eighth_Doctorhave you guys tried the new snapd updates for fedora and el7?08:27
zygano, not lately, I just updated my F29 machine to usable status08:28
mborzeckiEighth_Doctor: posted karma already, did you push any new updates?08:28
Eighth_Doctorno08:28
Eighth_Doctorit's the 2.39 update with the selinux stuff08:28
mborzeckimvo: reported https://github.com/koalaman/shellcheck/issues/158808:30
mborzeckiEighth_Doctor: https://bodhi.fedoraproject.org/updates/FEDORA-2019-57826cb704#comment-944246 btw there's a systemd issue that also works better after a reboot08:32
mborzeckizyga: do you think you could try the update in an actual workstation install?08:32
mvomborzecki: ta08:33
zygamborzecki: yeah, on F3008:33
Eighth_Doctormborzecki: I've marked the update as one that requires a reboot08:33
pedroniszyga: mvo: given the spike and everything not sure zyga should work on this, can we put somebody else on it08:35
zygapedronis: it's done now, just running tests08:35
pedroniszyga: done, as in you adjusted all tests?08:35
zygayes08:36
pedronisok, if some fail you probably pass it along to somebody else though08:36
zygayeah08:37
zygarunning now, fingers crossed08:37
zygaI want, at least, the spread-shellcheck test to pass08:38
mvopedronis: agreed, we also need to finish the mount bug, iirc there are some loose ends here too. lets give the other parts to someone else08:39
mborzeckiEighth_Doctor: other than that the updates seemed to work fine :P now that we also have f30 under spread it should be even better08:39
mborzeckiEighth_Doctor: think you might be interested in this one: https://github.com/snapcore/snapd/pull/687408:40
mupPR #6874: cmd/snap-confine: do not mount over non files/directories <Created by bboozzoo> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6874>08:40
mupPR snapd#6895 opened: cmd/snap-confine, data/selinux: cherry pick Fedora 30 fixes to 2.39 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6895>08:48
mborzeckihm should probably cherry-pick f30 for spread too08:49
mupPR snapd#6880 closed: daemon: refactor user ops to api_users <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6880>08:54
zygamvo: how does https://github.com/snapcore/snapd/pull/6894 look?08:57
mupPR #6894: tests: add "not" command as replacement for "!" in tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6894>08:57
zygamvo: this is now shellcheck clean08:59
zygamvo: I'm running a pass of main/regression to see if something explodes08:59
zygabut I will open the PR for review soon08:59
mvozyga: looking09:00
mvozyga: yeah, looks sensible09:03
zygaupdated the comment in the PR09:03
mupPR snapd#6896 opened: cmd/snap: tweak the output of snap debug timings --ensure= <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6896>09:06
zygatests are looking good so far09:09
mvozyga: great, once that is ready please go back to the mount bug, its the last piece missing for 2.39.109:17
zygamvo: mount bug is ready, it's just blocked by spread here09:17
zygabut sure09:17
mvozyga: blocked by spread in the sense that tests are unstable?09:17
zygaby spread-shellcheck specifically ;)09:18
zygamvo: let's do this:09:18
zygaactually09:18
* zyga checks first09:18
mvozyga: hm, that seems silly, lets move to shellcheck from stable then for now09:18
zygamy understanding is that master is red due to the shellcheck issue09:18
zygalet's fix shellcheck in master09:18
mvo  stable:    v0.6.0                2019-01-11 (329) 3MB -09:18
mvoI think we should (temporarily) switch to shellcheck/stable09:18
mvoand then move back to edge with the fix09:19
zygaland the test tool from https://github.com/snapcore/snapd/pull/6888 (I can make it so that it doesn't conflict with the "not" branch)09:19
mupPR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>09:19
zygamvo: and then I can just propose the mount propagation PR and start working on intramfs09:19
mvozyga: ok, that sounds like a plan - 1. move to shellcheck stable so that we can land things again, 2  we need reviews for 6888 3. propose the mount fix (even with 6888 not fully reviewed). sounds sensible?09:21
zygayep09:21
zyga+109:21
mvota09:22
mupPR snapd#6897 opened: tests/unit/spread-shellcheck: temporary workaround for SC2251 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6897>09:23
mborzeckimvo: zyga: ^^09:24
zygathanks09:24
zygamborzecki: can you look at https://github.com/snapcore/snapd/pull/688809:33
mupPR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>09:33
zygait's not small but it's a test tool09:33
mborzeckizyga: looking09:33
zygathx09:33
mupPR snapd#6898 opened: make snapstate.Update take *RevisionOptions instead of chan, rev <Created by chipaca> <https://github.com/snapcore/snapd/pull/6898>09:48
mupPR snapd#6816 closed: daemon, overlord: support for cohort-key in refresh and switch <Created by chipaca> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/6816>09:54
zygasome bad news, for perfect support NOT would need to be a function like MATCH10:08
zygapipe expressions also need to be adjusted10:08
zygafrom10:08
zyga! echo foo bar | grep foo10:08
ubottuzyga: I am only a bot, please don't think I'm intelligent :)10:08
zygato echo foo bar | not grep foo10:09
zygatravis is pretty slow today10:09
zygaI'll start working on initrd while we wait10:09
mupPR core-build#39 opened: tests: fix RuntimeWarning coroutine was never awaited <Created by zyga> <https://github.com/snapcore/core-build/pull/39>10:16
pedroniszyga: mmh, sounds like it needs more attention10:25
zygapedronis: yeah, I've dropped it for now10:25
zygapedronis: I will look in the evening, it's not hard, just tedious to look at 16 tests that fail10:26
zygapedronis: and to move the not around10:26
zygacmatsuoka, mvo: could you please look at https://github.com/snapcore/core-build/pull/3910:26
mupPR core-build#39: tests: fix RuntimeWarning coroutine was never awaited <Created by zyga> <https://github.com/snapcore/core-build/pull/39>10:26
zygamborzecki: shellcheck branch switch failed on portal :/10:27
mborzeckizyga: heh10:27
zygaand auto refresh retry10:27
* mborzecki is not surprised10:27
zygamborzecki: how about https://github.com/snapcore/snapd/pull/6888 ?10:30
mupPR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>10:30
mborzeckizyga: just clicked send10:31
zygamborzecki: repleid10:33
zyga*replied10:33
zygaoddly everything is "outdated" in your review10:33
zygadid you start it a while ago before I git mv'd files10:33
zyga?10:33
mborzeckizyga: hmm maybe10:40
mborzeckizyga: what i tought about with device being tuple: http://paste.ubuntu.com/p/78j96hf84m/10:40
zygamborzecki: mmmm, I see10:42
zygamborzecki: I would have used nametuple for that10:42
zygamborzecki: but I wanted to align more closely with C where that's a single variable10:42
mborzeckizyga: or that, don't know if it's worth the change though10:42
cachiomvo, hey10:43
Chipacamborzecki: zyga: what was the consensus wrt ! ?10:58
mborzeckiChipaca: switched to --stable for now, zyga opened a PR with `not` helper10:58
Chipacamborzecki: is that on master?10:58
mborzeckiChipaca: neither is, https://github.com/snapcore/snapd/pull/6897 https://github.com/snapcore/snapd/pull/689410:59
mupPR #6897: tests/unit/spread-shellcheck: temporary workaround for SC2251 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6897>10:59
mupPR #6894: tests: add "not" command as replacement for "!" in tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6894>10:59
Chipacaack11:00
mborzeckiChipaca: oh and opened an issue https://github.com/koalaman/shellcheck/issues/158811:00
Chipacamborzecki: 'temporary workaround fo SCP 2251' (http://www.scp-wiki.net/scp-2251)11:01
cjwatsonoh god must not get sucked in11:03
* Chipaca updates his nerdsniping score11:03
* zyga has a great moment by reading a particular man page!!!11:08
mvozyga: tell us more11:18
zygamvo: haha, nothing special really, just mkfs.ext4 can copy data into the filesystem in one go11:19
zygaso no root required :)11:19
mvozyga: yeah, ubuntu-image is doing this11:21
mvozyga: its pretty cool11:21
Chipacazyga: i think that's what mborzecki was using fakeroot for11:24
mupPR snapd#6899 opened: image: make prepare-image recovery-system aware <Created by mvo5> <https://github.com/snapcore/snapd/pull/6899>11:24
mborzeckiyup, otherwise it ends up owned by whoever ran mkfs.*11:24
mborzeckifakeroot mkfs.ext4 <random-opts> -d <contents>11:25
mborzeckiwish mkfs.vfat supported that too :/11:25
zygamborzecki: dostools can copy files in and out11:28
mborzeckizyga: and that's what i'm using11:29
mborzeckizyga: what i meant is to mkfs.vfat have -d <contents> to popualte fs with some contents, instead of mcopy -i <image> -s <path> ::11:29
zygayeah11:30
pstolowskipedronis: re base:none, we have code right now that installs "snapd" in prereq if core/snapd is not installed (for interfaces to work). should we keep doing this when installing a snap with base:none and there is nothing else in the system?11:31
pedronispstolowski: yes11:31
pstolowskik11:32
cachiomvo, I just updated the #688311:33
mupPR #6883: tests: fix how strings are matched on auto-refresh-retry test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6883>11:33
pedronismborzecki: I made a pass over #6871, couple of comments11:35
mupPR #6871: gadget: raw/bare structure writer and updater <Gadget update> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6871>11:35
mborzeckipedronis: thanks!11:36
mupPR snapd#6897 closed: tests/unit/spread-shellcheck: temporary workaround for SC2251 <Created by bboozzoo> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6897>11:47
* Chipaca lunches11:47
mborzeckimvo: can you cherry-pick 6897 to 2.39?11:52
mborzeckioff to pick up the kids12:04
zygamvo: can you review https://github.com/snapcore/snapd/pull/688812:10
mupPR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>12:10
cachiozyga, about the mountinfo-tool, it is really nice12:28
cachiozyga, but I think that should be better if the test checks more stuff, I mean using the tool we check mount info on the system12:29
cachiozyga, perhaps it could be a following PR12:29
cachioalso I can do it for sure12:29
zygacachio: do you mean the spread test?12:32
cachiozyga, yes12:32
zygacachio: yeah, it's just a start, I plan to work on it some more12:32
cachiozyga, nice, thanks12:32
mupPR snapd#6900 opened: [RFC] snapstate: support base = "none" <Created by stolowski> <https://github.com/snapcore/snapd/pull/6900>12:45
zygapstolowski: reviewed12:47
pstolowskity12:48
=== ricab is now known as ricab|lunch
Chipacamborzecki: when we started using shellcheck from snap it was only in edge fwiw13:28
mborzeckiChipaca: quite probable :) glad it has stable now too13:29
* zyga runs for lunch13:37
Chipaca#6898 is now green. It's a pure refactor, and has one +1. Is that landable? :)13:49
mupPR #6898: many: make snapstate.Update take *RevisionOptions instead of chan, rev <Created by chipaca> <https://github.com/snapcore/snapd/pull/6898>13:49
zygasummer storms :)14:00
zygaChipaca: looking14:01
zygaChipaca: any chance of nil pointer breaking somewhere?14:04
zygaChipaca: or are all ingress paths defending against thatA?14:04
zygaChipaca: I also see the amend flag has moved from updateInfoOpts to just a flags argument14:06
zygaChipaca: I guess it looks ok,14:06
pedroniszyga: Flags always had Amend14:06
pedronisit has not moved14:06
zygayes, but the way it was conveyed to a piece of code has changed so it effectively "moved" to a different argument14:07
zygaChipaca: it's slightly odd that RevisionOptions starts with channel and only then goes to revision but that's cosmetics14:07
pedronisit's just carried along a bit differently at that point14:07
zygaright, I think it looks good14:07
zygaChipaca: merge away :)14:07
pedronisChipaca: ah, RevisionOptions merits a doc comment14:08
pedronisI didn't notice but zyga comment about the order of things inside (which is correct) made me think that maybe it needs one for real14:09
pedronisChipaca: made a comment14:11
Chipacapedronis: i'll add a comment in the switch followup if that's a'ight14:12
pedronisChipaca: yes, that's fine14:12
mupPR snapd#6898 closed: many: make snapstate.Update take *RevisionOptions instead of chan, rev <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6898>14:13
mupPR snapd#6901 opened: overlord/snapstate, daemon: snapstate.Switch now takes a RevisionOption <Created by chipaca> <https://github.com/snapcore/snapd/pull/6901>14:16
Chipacasuper simple followup ^ :-)14:16
=== ricab|lunch is now known as ricab
pedroniscachio: what's the status of #6541 ?14:27
mupPR #6541: tests: change how xdg-desktop-portal is prepared and restored for desktop-portal-* tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6541>14:27
mupPR snapd#6902 opened: spread.yaml: make HOST: usage shellcheck-clean <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6902>14:28
cachiopedronis, it needs reviews14:29
cachioI addressed all the comments14:29
mupPR snapd#6903 opened: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>14:34
zygamvo: ^ two last prereqs14:35
cachiozyga, Chipaca could you please take a look to #654114:35
mupPR #6541: tests: change how xdg-desktop-portal is prepared and restored for desktop-portal-* tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6541>14:35
zygayep14:36
mupPR snapd#6888 closed: tests: add mountinfo-tool <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6888>14:44
Chipacacachio: looking14:44
Chipacacachio: did you do address maciej's comment?14:46
zygaChipaca: looking now14:49
Chipacazyga: wrt pointer, it's checked on ingress (first few lines of update and switch)14:52
zyga+114:53
Chipacazyga: and even there it's just as a kindness to the tests14:53
zygathanks14:53
Chipacaas all actual code is passing the thing in one way or another14:53
zygaI wish golang had null type safety14:54
cachioChipaca, I tested that and that was not the solution14:57
Chipacacachio: you should probably reply to him then :-/14:57
Chipacazyga: it does!14:57
Chipacazyga: sometimes :-p14:57
zygahmm, I misunderstood the comment and the code then14:57
zygaI assumed the pgrep check and the unmount was that14:57
cachioChipaca, I think  I did but in irc or during a standup14:57
cachioChipaca, I'll add a comment there too14:58
zygacachio: yeah, please explain to mborzecki in the PR first14:58
Chipacazyga: sorry i was being obtuse. a nil thing that is an interface and a nil thing that is a concrete pointer can be different in awkward ways.14:58
zygayeah14:58
zygaI was mainly looking for type safety of:14:58
zygavar foo *Foo14:58
zygafoo.a = "baz" # should fail to compile14:59
zygaif foo != nil { foo.a = "baz" } # should compile14:59
Chipacazyga: it's funny because it's got something like that for optimizations (branch elimination?), but not as part of the language15:03
zygayeah15:03
Chipaca"funny"15:03
zygait'd be a breaking change now15:03
zygabut I really miss it15:03
zygajava's null was equally painful15:03
zygaI'm happy that some newer languages can be nil/null safe15:04
zyga(mainly by not having null)15:04
zygamostly15:04
mupPR core-build#39 closed: tests: fix RuntimeWarning coroutine was never awaited <Created by zyga> <Merged by zyga> <https://github.com/snapcore/core-build/pull/39>15:05
* pedronis mostly eows15:15
mvozyga: thanks, was in a meeting (and will be in one again shortly) will try to look in a wee bit15:16
zygathx15:17
zygamvo: https://github.com/snapcore/snapd/pull/690215:17
mupPR #6902: spread.yaml: make HOST: usage shellcheck-clean <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6902>15:17
zygahttps://github.com/snapcore/snapd/pull/690315:17
mupPR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>15:18
zygamvo: and lastly https://github.com/snapcore/snapd/pull/6891  but i will rewrite commit message15:18
mupPR #6891: many: make new mount points MS_SHARED <Created by zyga> <https://github.com/snapcore/snapd/pull/6891>15:18
zygabrb15:18
mupPR snapd#6904 opened: timings: always store ensure timings as long as they have an associated change <Created by stolowski> <https://github.com/snapcore/snapd/pull/6904>15:45
* zyga finally had lunch15:54
zyganow dinner really15:54
zyga*starving*15:54
zygare16:03
* cachio lunch16:04
=== pstolowski is now known as pstolowski|afk
zygaChipaca: around?16:22
zygamvo: around?16:22
zygajdstrand: FYI https://github.com/snapcore/snapd/pull/689116:28
mupPR #6891: many: make per-snap mount namespace MS_SHARED <Created by zyga> <https://github.com/snapcore/snapd/pull/6891>16:28
zygajdstrand: review appreciated, we'd like to land this in .116:28
zygajdstrand: I will open the PR for real as soon as prerequites land16:28
jdstrandhey, it is on the list16:28
zygathanks!16:29
zygait's not a big one but it's a big change16:29
mupPR snapd#6901 closed: overlord/snapstate, daemon: snapstate.Switch now takes a RevisionOption <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6901>16:53
mupPR snapd#6905 opened: daemon, overlord/snapstate: give RevisionOptions a CohortKey <Created by chipaca> <https://github.com/snapcore/snapd/pull/6905>17:08
* Chipaca EODs17:08
* cachio afk18:42
mupPR snapd#6902 closed: spread.yaml: make HOST: usage shellcheck-clean <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6902>19:55
mupPR snapd#6906 opened: cmd/snap-update-ns: rename ctx to upCtx <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6906>20:02
jdstrandzyga: fyi, I commented on https://github.com/snapcore/snapd/pull/6891 (and I'm heading out now)20:26
mupPR #6891: many: make per-snap mount namespace MS_SHARED <Created by zyga> <https://github.com/snapcore/snapd/pull/6891>20:26
zygajdstrand: thank you very much20:50

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!