[05:27] <mborzecki> morning
[05:38] <mborzecki> kernel update, rebooting, brb
[05:40] <mborzecki> aand back
[05:45] <zyga> Hey :-)
[05:45] <zyga> mborzecki: solved that issue last night
[05:45] <mborzecki> zyga: hey
[05:45] <zyga> I’ll eat dry and update the pr
[05:45] <mborzecki> zyga: oh, solved mine too, i can create bootable images now  :)
[05:46] <zyga> s/dry/sth/
[05:48] <zyga> Sounds like a good day indeed
[05:48] <zyga> What was the issue?
[05:52] <mborzecki> zyga: the raw structure writer was dumping image content at a start offset that was within a complete volume, but since i'm constructing an image of each partition separately, i need to apply a bias to have the structure start at 0 offset
[05:54] <mborzecki> now i need to figure out where the hell grubenv comes from in ubuntu-image
[06:02] <mvo> mborzecki: the grubenv comes from `snap prepare-image`
[06:02] <mborzecki> mvo: hi, and thanks for the tip
[06:03] <mvo> mborzecki: yw and hi as well
[06:26] <mup> PR snapd#6893 opened: gadget: helper for shifting structure start position <Gadget update> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6893>
[06:39] <zyga> back in the office :)
[06:40] <zyga> mvo: hey, I nailed that bug last night
[06:40] <zyga> I need to make two small modifications to the fix PR and it's going to be green :)
[06:40] <zyga> one is just shell quoting and another is reduction of a test that was really measuring the bug to begin with
[06:40] <zyga> once I realised the test was buggy it was all obvious :)
[06:42] <zyga> mvo: I also got a much nicer approach to defer, but separated out into its own branch
[06:42] <zyga> it is much nicer than the v1
[06:42] <zyga> I'll get to it now :)
[06:42] <zyga> hey pedronis
[06:46] <mvo> zyga: nice!
[06:46] <mvo> hey pedronis
[06:46] <mvo> zyga: looking forward to it
[06:46] <pedronis> mvo: hi
[07:01] <pstolowski> morning
[07:02] <mborzecki> pstolowski: pedronis: hey
[07:03] <amurray> is build.snapcraft.io a bit flaky at the moment? I can't seem to add a new repo (it just keeps spinning...)
[07:29] <pedronis> pstolowski: hi, what are you working on ATM ?
[07:31] <pstolowski> pedronis: hi, a small followup for snap debug timings output, then a small bugfix for them, then i'll move onto preventing nulls (with a forum topic at the same time)
[07:32] <pedronis> pstolowski: I thought a bit further about the latter,  we should chat before we go there, also as we discussed it's probably 2.41 material
[07:32] <pedronis> pstolowski: mvo: should we try to get "base: none" support sooner instead
[07:33] <pstolowski> pedronis: there are two small issues with ensure timings, so perhaps we can discuss them + null at the same time
[07:36] <pedronis> pstolowski: we can chat in 30 mins if you want
[07:36] <pedronis> ~30
[07:37] <pstolowski> pedronis: ok
[07:48] <mborzecki> hmm shellcheck got an update apparently
[07:49] <mvo> mborzecki: is it breaking our stuff?
[07:50] <mborzecki> mvo: https://paste.ubuntu.com/p/Ztb7rqnzXP/
[07:51] <zyga> mvo: hey, I'd love a review of https://github.com/snapcore/snapd/pull/6888
[07:51] <mup> PR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>
[07:51] <zyga> it's a pre-req for the test for the propagation bug
[07:51] <mborzecki> mvo: https://github.com/koalaman/shellcheck/wiki/SC2251
[07:52] <mvo> mborzecki: uh, thats pedantic
[07:52] <mvo> mborzecki: let me read this but I'm not sure I like it
[07:53] <mvo> mborzecki: eh
[07:53] <mvo> mborzecki: if I'm reading this correctly our tests have some big holes?!?
[07:53]  * mvo looks closer
[07:54] <mborzecki> mvo: heh, yeah, not sure i understand the issue here, trying it out locally
[07:54] <mvo> mborzecki: yeah
[07:54] <mvo> mborzecki: https://paste.ubuntu.com/p/rtzBmt5Btf/
[07:55] <mvo> mborzecki: this looks like either ! true or ! false trigger an errexit
[07:56] <zyga> mborzecki: interesting, shell is a valley of landmines!
[07:56] <mvo> zyga: its getting worse and worse
[07:56] <zyga> mvo: fun
[07:56] <zyga> yeah
[07:56] <mvo> zyga: I mean, the more I learn the more I despair about all the corners one need to know
[07:56] <zyga> it's all terrible
[07:56] <zyga> mvo: right?
[07:56] <mborzecki> mvo: don't trigger errexit you mean, right?
[07:56] <zyga> I wish someone wrote a sane-sh
[07:56] <mvo> zyga: also - I swear I saw this a gazillon of times in various scripts
[07:57] <zyga> yeah
[07:57] <zyga> mvo: we should donate to shellcheck
[07:57] <pedronis> so yes, our tests are full of this, fun, not
[07:57] <mvo> mborzecki: yeah, it seems like !true !false !whatever, nothing triggers an exit
[07:57] <mvo> pedronis: /o\
[07:57] <mborzecki> mvo: yup :/ ehh
[07:57] <mvo> zyga: totally, at least we need to sent him some "you are a hero" mail or something
[07:57] <mborzecki> mvo: at least it's good shellcheck flags that
[07:58] <zyga> zyga@yantra:~/go/lnx-src/github.com/snapcore/snapd> git grep '!' -- */task.yaml | wc -l
[07:58] <zyga> 490
[07:58] <zyga> oh my
[07:58] <zyga> mborzecki: which version of shellcheck is that?
[07:58] <mborzecki> zyga: snap info shellcheck, look at edge
[07:58] <zyga> zyga@yantra:~/go/lnx-src/github.com/snapcore/snapd> git grep '!' -- '*.sh' | wc -l
[07:58] <zyga> 129
[07:59] <mborzecki> btw. it's also published as a snap by the author :P
[07:59] <mvo> mborzecki: yes
[07:59] <pedronis> mvo: anyway trying here their correct doesn't work either
[07:59] <pedronis> maybe I'm just confused
[07:59] <mvo> zyga: if this guy is on twitter we should sent some hearts, I'm sure email will just get into his spam folder
[08:01] <mvo> pedronis: same here, how strange
[08:02] <mborzecki> we do ! foo, because we expect foo to fail, so if it doesn't fail, the test should err out i.e. errexit should get triggerred
[08:02] <zyga> perhaps "correct" is just about telling shellcheck that is what you mean
[08:02] <zyga> in all cases ! true doesn't exit
[08:02] <pedronis> no, the wiki says, it will errexit
[08:02] <pedronis> but doesn't
[08:03] <mborzecki> maybe a different shell?
[08:03] <mvo> I tried bash and dash
[08:04] <zyga> I tried bash 3.2.57 (macos) and 5.0.7 (linux)
[08:04] <zyga> same lack of result
[08:04] <mvo> hey Chipaca
[08:04] <zyga> hey chihchun
[08:05] <zyga> I meant Chipaca
[08:05] <mvo> Chipaca: great timing, we have shell fun again
[08:05] <mborzecki> Chipaca: https://github.com/koalaman/shellcheck/wiki/SC2251
[08:05] <pedronis> deep shell fun
[08:05] <pedronis> pstolowski: want to chat now?
[08:05] <zyga> pedronis: let me abberviate that to "deep sh"
[08:05] <pstolowski> pedronis: yep, 1 minute
[08:06] <zyga> mvo: strawman: uses python for tests
[08:06] <mborzecki> mvo: fwiw ! true without {} doesn't work as expected either
[08:06] <zyga> mvo: with that magic module that puts all shell commands as python functions
[08:06] <zyga> mvo: via import magic
[08:06]  * zyga looks
[08:06] <mborzecki> zyga: sounds like you worked with bitbake :P
[08:07] <Chipaca> mborzecki: mvo: nice
[08:07] <zyga> oooh
[08:07] <zyga> github now supports security patches
[08:07] <Chipaca> so I've got bugs in my head, and we've got bugs in our code
[08:07] <Chipaca> zyga: oh?
[08:08] <mborzecki> Chipaca: so, the trick is finding a short form that actually works, bc one they say is correct does not seem to work
[08:08] <zyga> I think I misread, security *bugs*
[08:08] <zyga> https://twitter.com/github/status/1131470848513249280
[08:08] <mvo> Chipaca: did you say "bugs on my head" ?
[08:08] <zyga> mborzecki: I have an idea
[08:08] <zyga> mborzecki: give me a sec
[08:08] <zyga> mborzecki: and it ties into a super nice idea (famous last words) that I had in my last branch
[08:08] <zyga> mborzecki: to put new things on $PATH for testing
[08:08] <zyga> mborzecki: we can write "not ..." command
[08:08] <Chipaca> mvo: in
[08:08] <zyga> that just runs the rest in shell and negates the result
[08:08] <pedronis> pstolowski: I'm in the standup
[08:09]  * zyga does so quickly
[08:09] <pstolowski> pedronis: ok coming
[08:09] <mvo> zyga: oh, thats an interessting idea
[08:09] <zyga> mvo: right?
[08:09] <zyga> mvo: give me 3
[08:09] <mborzecki> hack spread and make it define NOT
[08:11] <mborzecki> mvo: ( ! true )
[08:11] <mvo> aha!
[08:11] <mvo> mborzecki: funny, the linked stackoverflow mentions ()
[08:12] <mborzecki> ha!
[08:12] <mvo> mborzecki: so probably worth a bugreport/patch
[08:12] <mborzecki> should have done the reading
[08:12] <mvo> mborzecki: to the shellcheck guy, least we can do
[08:12] <mvo> nah, reading is overrated
[08:15] <mborzecki> mvo: fwiw ( ! true ) isn't flagged
[08:16] <zyga> mvo: https://github.com/snapcore/snapd/pull/6894
[08:16] <mup> PR #6894: tests: add "not" command as replacement for "!" in tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6894>
[08:16] <mup> PR snapd#6894 opened: tests: add "not" command as replacement for "!" in tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6894>
[08:16] <zyga> mborzecki: ^
[08:17] <Chipaca> um
[08:17] <Chipaca> zyga: didn't you mean to put bin in the path
[08:17] <zyga> Chipaca: didn't I put it?
[08:17] <Chipaca> zyga: and the binary in the bin
[08:17] <Chipaca> zyga: so the binary is in the path
[08:17] <Chipaca> ?
[08:17] <zyga> doh
[08:17] <zyga> haha
[08:17] <zyga> I see
[08:18] <Chipaca> zyga: you even wrote a .keep file to keep the empty directory
[08:18] <Chipaca> zyga: i think you need more coffee
[08:18] <zyga> Chipaca: I'm having some now :D
[08:18] <zyga> I recycled the bin idea from an earlier branch
[08:18] <zyga> fixed now
[08:18] <Chipaca> have of your neurons are all "whee" and the other half are all "g'waymnsfifCOMFYfmsmwm"
[08:19] <Chipaca> half*
[08:19] <zyga> Chipaca: I'm tempted to add tests/lib/man to MANPATH and write a man page now
[08:19] <zyga> should I?
[08:19] <zyga> mvo: if you like this idea (about not replacing !) I can adjust tests
[08:19] <Chipaca> zyga: no
[08:20] <Chipaca> zyga: (i don't really mind but nobody's gonna read it)
[08:20] <zyga> mvo: perhaps we should invite shellcheck developer to a sprint sometime, he might be a good voice in the haskel community
[08:20] <zyga> Chipaca: I'd read it in --debug
[08:21] <Chipaca> zyga: have it look out for -h/--help then?
[08:21] <Chipaca> zyga: but seems silly
[08:21] <Chipaca> zyga: this is how /bin/true is not an empty file
[08:21] <Chipaca> or was it /bin/false
[08:21] <zyga> Chipaca: let's fix the tests story first
[08:21] <Chipaca> anyway :)
[08:22] <zyga> then I can play on this later :)
[08:22] <mvo> zyga: I like the PR, unless pedronis disagrees I think we should use this approach and replace all our "! foo" with "not foo" or "assert_fail" or "assertFail foo" ?
[08:22] <zyga> mvo: I agree
[08:22] <Chipaca> /bin/true could be just an empty executable file and instead is a 27k dynamic binary, and it's all zyga's fault
[08:23] <zyga> mvo: I'd go with "not foo" first
[08:23] <zyga> not assert anything
[08:23] <zyga> as we really are asserting each line
[08:23] <zyga> because of the set -e
[08:23] <mvo> so quicl poll on the name: "not", "assert_false", "assertFalse" ?
[08:23] <zyga> mvo: we may also see bugs uncovered
[08:23] <zyga> mvo: it should be "not" because of what I said
[08:23] <mvo> zyga: oh yes
[08:23] <zyga> and plays nice with the language, python and readability
[08:24] <zyga> unless it starts to look ugly in tests
[08:24] <zyga> but let's see how it works out
[08:24] <zyga> mvo: I'll start attacking shell tests now
[08:25] <mvo> zyga: sounds good, *if* there is a discussion about the naming we can easily sed the name again
[08:25] <zyga> mvo: sounds good
[08:25] <zyga> mvo: even inside the patch ):
[08:25] <zyga> :-)
[08:25]  * zyga is on it
[08:25] <mvo> haha, true
[08:27] <Eighth_Doctor> zyga, mborzecki
[08:27] <Eighth_Doctor> have you guys tried the new snapd updates for fedora and el7?
[08:28] <zyga> no, not lately, I just updated my F29 machine to usable status
[08:28] <mborzecki> Eighth_Doctor: posted karma already, did you push any new updates?
[08:28] <Eighth_Doctor> no
[08:28] <Eighth_Doctor> it's the 2.39 update with the selinux stuff
[08:30] <mborzecki> mvo: reported https://github.com/koalaman/shellcheck/issues/1588
[08:32] <mborzecki> Eighth_Doctor: https://bodhi.fedoraproject.org/updates/FEDORA-2019-57826cb704#comment-944246 btw there's a systemd issue that also works better after a reboot
[08:32] <mborzecki> zyga: do you think you could try the update in an actual workstation install?
[08:33] <mvo> mborzecki: ta
[08:33] <zyga> mborzecki: yeah, on F30
[08:33] <Eighth_Doctor> mborzecki: I've marked the update as one that requires a reboot
[08:35] <pedronis> zyga: mvo: given the spike and everything not sure zyga should work on this, can we put somebody else on it
[08:35] <zyga> pedronis: it's done now, just running tests
[08:35] <pedronis> zyga: done, as in you adjusted all tests?
[08:36] <zyga> yes
[08:36] <pedronis> ok, if some fail you probably pass it along to somebody else though
[08:37] <zyga> yeah
[08:37] <zyga> running now, fingers crossed
[08:38] <zyga> I want, at least, the spread-shellcheck test to pass
[08:39] <mvo> pedronis: agreed, we also need to finish the mount bug, iirc there are some loose ends here too. lets give the other parts to someone else
[08:39] <mborzecki> Eighth_Doctor: other than that the updates seemed to work fine :P now that we also have f30 under spread it should be even better
[08:40] <mborzecki> Eighth_Doctor: think you might be interested in this one: https://github.com/snapcore/snapd/pull/6874
[08:40] <mup> PR #6874: cmd/snap-confine: do not mount over non files/directories <Created by bboozzoo> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6874>
[08:48] <mup> PR snapd#6895 opened: cmd/snap-confine, data/selinux: cherry pick Fedora 30 fixes to 2.39 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6895>
[08:49] <mborzecki> hm should probably cherry-pick f30 for spread too
[08:54] <mup> PR snapd#6880 closed: daemon: refactor user ops to api_users <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6880>
[08:57] <zyga> mvo: how does https://github.com/snapcore/snapd/pull/6894 look?
[08:57] <mup> PR #6894: tests: add "not" command as replacement for "!" in tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6894>
[08:59] <zyga> mvo: this is now shellcheck clean
[08:59] <zyga> mvo: I'm running a pass of main/regression to see if something explodes
[08:59] <zyga> but I will open the PR for review soon
[09:00] <mvo> zyga: looking
[09:03] <mvo> zyga: yeah, looks sensible
[09:03] <zyga> updated the comment in the PR
[09:06] <mup> PR snapd#6896 opened: cmd/snap: tweak the output of snap debug timings --ensure= <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/6896>
[09:09] <zyga> tests are looking good so far
[09:17] <mvo> zyga: great, once that is ready please go back to the mount bug, its the last piece missing for 2.39.1
[09:17] <zyga> mvo: mount bug is ready, it's just blocked by spread here
[09:17] <zyga> but sure
[09:17] <mvo> zyga: blocked by spread in the sense that tests are unstable?
[09:18] <zyga> by spread-shellcheck specifically ;)
[09:18] <zyga> mvo: let's do this:
[09:18] <zyga> actually
[09:18]  * zyga checks first
[09:18] <mvo> zyga: hm, that seems silly, lets move to shellcheck from stable then for now
[09:18] <zyga> my understanding is that master is red due to the shellcheck issue
[09:18] <zyga> let's fix shellcheck in master
[09:18] <mvo>   stable:    v0.6.0                2019-01-11 (329) 3MB -
[09:18] <mvo> I think we should (temporarily) switch to shellcheck/stable
[09:19] <mvo> and then move back to edge with the fix
[09:19] <zyga> land the test tool from https://github.com/snapcore/snapd/pull/6888 (I can make it so that it doesn't conflict with the "not" branch)
[09:19] <mup> PR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>
[09:19] <zyga> mvo: and then I can just propose the mount propagation PR and start working on intramfs
[09:21] <mvo> zyga: ok, that sounds like a plan - 1. move to shellcheck stable so that we can land things again, 2  we need reviews for 6888 3. propose the mount fix (even with 6888 not fully reviewed). sounds sensible?
[09:21] <zyga> yep
[09:21] <zyga> +1
[09:22] <mvo> ta
[09:23] <mup> PR snapd#6897 opened: tests/unit/spread-shellcheck: temporary workaround for SC2251 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6897>
[09:24] <mborzecki> mvo: zyga: ^^
[09:24] <zyga> thanks
[09:33] <zyga> mborzecki: can you look at https://github.com/snapcore/snapd/pull/6888
[09:33] <mup> PR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>
[09:33] <zyga> it's not small but it's a test tool
[09:33] <mborzecki> zyga: looking
[09:33] <zyga> thx
[09:48] <mup> PR snapd#6898 opened: make snapstate.Update take *RevisionOptions instead of chan, rev <Created by chipaca> <https://github.com/snapcore/snapd/pull/6898>
[09:54] <mup> PR snapd#6816 closed: daemon, overlord: support for cohort-key in refresh and switch <Created by chipaca> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/6816>
[10:08] <zyga> some bad news, for perfect support NOT would need to be a function like MATCH
[10:08] <zyga> pipe expressions also need to be adjusted
[10:08] <zyga> from
[10:08] <zyga> ! echo foo bar | grep foo
[10:09] <zyga> to echo foo bar | not grep foo
[10:09] <zyga> travis is pretty slow today
[10:09] <zyga> I'll start working on initrd while we wait
[10:16] <mup> PR core-build#39 opened: tests: fix RuntimeWarning coroutine was never awaited <Created by zyga> <https://github.com/snapcore/core-build/pull/39>
[10:25] <pedronis> zyga: mmh, sounds like it needs more attention
[10:25] <zyga> pedronis: yeah, I've dropped it for now
[10:26] <zyga> pedronis: I will look in the evening, it's not hard, just tedious to look at 16 tests that fail
[10:26] <zyga> pedronis: and to move the not around
[10:26] <zyga> cmatsuoka, mvo: could you please look at https://github.com/snapcore/core-build/pull/39
[10:26] <mup> PR core-build#39: tests: fix RuntimeWarning coroutine was never awaited <Created by zyga> <https://github.com/snapcore/core-build/pull/39>
[10:27] <zyga> mborzecki: shellcheck branch switch failed on portal :/
[10:27] <mborzecki> zyga: heh
[10:27] <zyga> and auto refresh retry
[10:27]  * mborzecki is not surprised
[10:30] <zyga> mborzecki: how about https://github.com/snapcore/snapd/pull/6888 ?
[10:30] <mup> PR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>
[10:31] <mborzecki> zyga: just clicked send
[10:33] <zyga> mborzecki: repleid
[10:33] <zyga> *replied
[10:33] <zyga> oddly everything is "outdated" in your review
[10:33] <zyga> did you start it a while ago before I git mv'd files
[10:33] <zyga> ?
[10:40] <mborzecki> zyga: hmm maybe
[10:40] <mborzecki> zyga: what i tought about with device being tuple: http://paste.ubuntu.com/p/78j96hf84m/
[10:42] <zyga> mborzecki: mmmm, I see
[10:42] <zyga> mborzecki: I would have used nametuple for that
[10:42] <zyga> mborzecki: but I wanted to align more closely with C where that's a single variable
[10:42] <mborzecki> zyga: or that, don't know if it's worth the change though
[10:43] <cachio> mvo, hey
[10:58] <Chipaca> mborzecki: zyga: what was the consensus wrt ! ?
[10:58] <mborzecki> Chipaca: switched to --stable for now, zyga opened a PR with `not` helper
[10:58] <Chipaca> mborzecki: is that on master?
[10:59] <mborzecki> Chipaca: neither is, https://github.com/snapcore/snapd/pull/6897 https://github.com/snapcore/snapd/pull/6894
[10:59] <mup> PR #6897: tests/unit/spread-shellcheck: temporary workaround for SC2251 <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6897>
[10:59] <mup> PR #6894: tests: add "not" command as replacement for "!" in tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6894>
[11:00] <Chipaca> ack
[11:00] <mborzecki> Chipaca: oh and opened an issue https://github.com/koalaman/shellcheck/issues/1588
[11:01] <Chipaca> mborzecki: 'temporary workaround fo SCP 2251' (http://www.scp-wiki.net/scp-2251)
[11:03] <cjwatson> oh god must not get sucked in
[11:03]  * Chipaca updates his nerdsniping score
[11:08]  * zyga has a great moment by reading a particular man page!!!
[11:18] <mvo> zyga: tell us more
[11:19] <zyga> mvo: haha, nothing special really, just mkfs.ext4 can copy data into the filesystem in one go
[11:19] <zyga> so no root required :)
[11:21] <mvo> zyga: yeah, ubuntu-image is doing this
[11:21] <mvo> zyga: its pretty cool
[11:24] <Chipaca> zyga: i think that's what mborzecki was using fakeroot for
[11:24] <mup> PR snapd#6899 opened: image: make prepare-image recovery-system aware <Created by mvo5> <https://github.com/snapcore/snapd/pull/6899>
[11:24] <mborzecki> yup, otherwise it ends up owned by whoever ran mkfs.*
[11:25] <mborzecki> fakeroot mkfs.ext4 <random-opts> -d <contents>
[11:25] <mborzecki> wish mkfs.vfat supported that too :/
[11:28] <zyga> mborzecki: dostools can copy files in and out
[11:29] <mborzecki> zyga: and that's what i'm using
[11:29] <mborzecki> zyga: what i meant is to mkfs.vfat have -d <contents> to popualte fs with some contents, instead of mcopy -i <image> -s <path> ::
[11:30] <zyga> yeah
[11:31] <pstolowski> pedronis: re base:none, we have code right now that installs "snapd" in prereq if core/snapd is not installed (for interfaces to work). should we keep doing this when installing a snap with base:none and there is nothing else in the system?
[11:31] <pedronis> pstolowski: yes
[11:32] <pstolowski> k
[11:33] <cachio> mvo, I just updated the #6883
[11:33] <mup> PR #6883: tests: fix how strings are matched on auto-refresh-retry test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6883>
[11:35] <pedronis> mborzecki: I made a pass over #6871, couple of comments
[11:35] <mup> PR #6871: gadget: raw/bare structure writer and updater <Gadget update> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6871>
[11:36] <mborzecki> pedronis: thanks!
[11:47] <mup> PR snapd#6897 closed: tests/unit/spread-shellcheck: temporary workaround for SC2251 <Created by bboozzoo> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6897>
[11:47]  * Chipaca lunches
[11:52] <mborzecki> mvo: can you cherry-pick 6897 to 2.39?
[12:04] <mborzecki> off to pick up the kids
[12:10] <zyga> mvo: can you review https://github.com/snapcore/snapd/pull/6888
[12:10] <mup> PR #6888: tests: add mountinfo-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/6888>
[12:28] <cachio> zyga, about the mountinfo-tool, it is really nice
[12:29] <cachio> zyga, but I think that should be better if the test checks more stuff, I mean using the tool we check mount info on the system
[12:29] <cachio> zyga, perhaps it could be a following PR
[12:29] <cachio> also I can do it for sure
[12:32] <zyga> cachio: do you mean the spread test?
[12:32] <cachio> zyga, yes
[12:32] <zyga> cachio: yeah, it's just a start, I plan to work on it some more
[12:32] <cachio> zyga, nice, thanks
[12:45] <mup> PR snapd#6900 opened: [RFC] snapstate: support base = "none" <Created by stolowski> <https://github.com/snapcore/snapd/pull/6900>
[12:47] <zyga> pstolowski: reviewed
[12:48] <pstolowski> ty
[13:28] <Chipaca> mborzecki: when we started using shellcheck from snap it was only in edge fwiw
[13:29] <mborzecki> Chipaca: quite probable :) glad it has stable now too
[13:37]  * zyga runs for lunch
[13:49] <Chipaca> #6898 is now green. It's a pure refactor, and has one +1. Is that landable? :)
[13:49] <mup> PR #6898: many: make snapstate.Update take *RevisionOptions instead of chan, rev <Created by chipaca> <https://github.com/snapcore/snapd/pull/6898>
[14:00] <zyga> summer storms :)
[14:01] <zyga> Chipaca: looking
[14:04] <zyga> Chipaca: any chance of nil pointer breaking somewhere?
[14:04] <zyga> Chipaca: or are all ingress paths defending against thatA?
[14:06] <zyga> Chipaca: I also see the amend flag has moved from updateInfoOpts to just a flags argument
[14:06] <zyga> Chipaca: I guess it looks ok,
[14:06] <pedronis> zyga: Flags always had Amend
[14:06] <pedronis> it has not moved
[14:07] <zyga> yes, but the way it was conveyed to a piece of code has changed so it effectively "moved" to a different argument
[14:07] <zyga> Chipaca: it's slightly odd that RevisionOptions starts with channel and only then goes to revision but that's cosmetics
[14:07] <pedronis> it's just carried along a bit differently at that point
[14:07] <zyga> right, I think it looks good
[14:07] <zyga> Chipaca: merge away :)
[14:08] <pedronis> Chipaca: ah, RevisionOptions merits a doc comment
[14:09] <pedronis> I didn't notice but zyga comment about the order of things inside (which is correct) made me think that maybe it needs one for real
[14:11] <pedronis> Chipaca: made a comment
[14:12] <Chipaca> pedronis: i'll add a comment in the switch followup if that's a'ight
[14:12] <pedronis> Chipaca: yes, that's fine
[14:13] <mup> PR snapd#6898 closed: many: make snapstate.Update take *RevisionOptions instead of chan, rev <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6898>
[14:16] <mup> PR snapd#6901 opened: overlord/snapstate, daemon: snapstate.Switch now takes a RevisionOption <Created by chipaca> <https://github.com/snapcore/snapd/pull/6901>
[14:16] <Chipaca> super simple followup ^ :-)
[14:27] <pedronis> cachio: what's the status of #6541 ?
[14:27] <mup> PR #6541: tests: change how xdg-desktop-portal is prepared and restored for desktop-portal-* tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6541>
[14:28] <mup> PR snapd#6902 opened: spread.yaml: make HOST: usage shellcheck-clean <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6902>
[14:29] <cachio> pedronis, it needs reviews
[14:29] <cachio> I addressed all the comments
[14:34] <mup> PR snapd#6903 opened: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>
[14:35] <zyga> mvo: ^ two last prereqs
[14:35] <cachio> zyga, Chipaca could you please take a look to #6541
[14:35] <mup> PR #6541: tests: change how xdg-desktop-portal is prepared and restored for desktop-portal-* tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/6541>
[14:36] <zyga> yep
[14:44] <mup> PR snapd#6888 closed: tests: add mountinfo-tool <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6888>
[14:44] <Chipaca> cachio: looking
[14:46] <Chipaca> cachio: did you do address maciej's comment?
[14:49] <zyga> Chipaca: looking now
[14:52] <Chipaca> zyga: wrt pointer, it's checked on ingress (first few lines of update and switch)
[14:53] <zyga> +1
[14:53] <Chipaca> zyga: and even there it's just as a kindness to the tests
[14:53] <zyga> thanks
[14:53] <Chipaca> as all actual code is passing the thing in one way or another
[14:54] <zyga> I wish golang had null type safety
[14:57] <cachio> Chipaca, I tested that and that was not the solution
[14:57] <Chipaca> cachio: you should probably reply to him then :-/
[14:57] <Chipaca> zyga: it does!
[14:57] <Chipaca> zyga: sometimes :-p
[14:57] <zyga> hmm, I misunderstood the comment and the code then
[14:57] <zyga> I assumed the pgrep check and the unmount was that
[14:57] <cachio> Chipaca, I think  I did but in irc or during a standup
[14:58] <cachio> Chipaca, I'll add a comment there too
[14:58] <zyga> cachio: yeah, please explain to mborzecki in the PR first
[14:58] <Chipaca> zyga: sorry i was being obtuse. a nil thing that is an interface and a nil thing that is a concrete pointer can be different in awkward ways.
[14:58] <zyga> yeah
[14:58] <zyga> I was mainly looking for type safety of:
[14:58] <zyga> var foo *Foo
[14:59] <zyga> foo.a = "baz" # should fail to compile
[14:59] <zyga> if foo != nil { foo.a = "baz" } # should compile
[15:03] <Chipaca> zyga: it's funny because it's got something like that for optimizations (branch elimination?), but not as part of the language
[15:03] <zyga> yeah
[15:03] <Chipaca> "funny"
[15:03] <zyga> it'd be a breaking change now
[15:03] <zyga> but I really miss it
[15:03] <zyga> java's null was equally painful
[15:04] <zyga> I'm happy that some newer languages can be nil/null safe
[15:04] <zyga> (mainly by not having null)
[15:04] <zyga> mostly
[15:05] <mup> PR core-build#39 closed: tests: fix RuntimeWarning coroutine was never awaited <Created by zyga> <Merged by zyga> <https://github.com/snapcore/core-build/pull/39>
[15:15]  * pedronis mostly eows
[15:16] <mvo> zyga: thanks, was in a meeting (and will be in one again shortly) will try to look in a wee bit
[15:17] <zyga> thx
[15:17] <zyga> mvo: https://github.com/snapcore/snapd/pull/6902
[15:17] <mup> PR #6902: spread.yaml: make HOST: usage shellcheck-clean <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6902>
[15:17] <zyga> https://github.com/snapcore/snapd/pull/6903
[15:18] <mup> PR #6903: spread-shellcheck: add support for variants and environment <Created by zyga> <https://github.com/snapcore/snapd/pull/6903>
[15:18] <zyga> mvo: and lastly https://github.com/snapcore/snapd/pull/6891  but i will rewrite commit message
[15:18] <mup> PR #6891: many: make new mount points MS_SHARED <Created by zyga> <https://github.com/snapcore/snapd/pull/6891>
[15:18] <zyga> brb
[15:45] <mup> PR snapd#6904 opened: timings: always store ensure timings as long as they have an associated change <Created by stolowski> <https://github.com/snapcore/snapd/pull/6904>
[15:54]  * zyga finally had lunch
[15:54] <zyga> now dinner really
[15:54] <zyga> *starving*
[16:03] <zyga> re
[16:04]  * cachio lunch
[16:22] <zyga> Chipaca: around?
[16:22] <zyga> mvo: around?
[16:28] <zyga> jdstrand: FYI https://github.com/snapcore/snapd/pull/6891
[16:28] <mup> PR #6891: many: make per-snap mount namespace MS_SHARED <Created by zyga> <https://github.com/snapcore/snapd/pull/6891>
[16:28] <zyga> jdstrand: review appreciated, we'd like to land this in .1
[16:28] <zyga> jdstrand: I will open the PR for real as soon as prerequites land
[16:28] <jdstrand> hey, it is on the list
[16:29] <zyga> thanks!
[16:29] <zyga> it's not a big one but it's a big change
[16:53] <mup> PR snapd#6901 closed: overlord/snapstate, daemon: snapstate.Switch now takes a RevisionOption <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6901>
[17:08] <mup> PR snapd#6905 opened: daemon, overlord/snapstate: give RevisionOptions a CohortKey <Created by chipaca> <https://github.com/snapcore/snapd/pull/6905>
[17:08]  * Chipaca EODs
[18:42]  * cachio afk
[19:55] <mup> PR snapd#6902 closed: spread.yaml: make HOST: usage shellcheck-clean <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6902>
[20:02] <mup> PR snapd#6906 opened: cmd/snap-update-ns: rename ctx to upCtx <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/6906>
[20:26] <jdstrand> zyga: fyi, I commented on https://github.com/snapcore/snapd/pull/6891 (and I'm heading out now)
[20:26] <mup> PR #6891: many: make per-snap mount namespace MS_SHARED <Created by zyga> <https://github.com/snapcore/snapd/pull/6891>
[20:50] <zyga> jdstrand: thank you very much