| mborzecki | morning | 05:13 |
|---|---|---|
| zyga | Hey mborzecki | 05:17 |
| zyga | https://github.com/snapcore/snapd/pull/6937 | 05:17 |
| zyga | From last evening | 05:17 |
| mup | PR #6937: cmd/snap-update-ns: detach unused mount points <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/6937> | 05:17 |
| mborzecki | hmhm what's that? :) | 05:17 |
| zyga | Embarrassment | 05:18 |
| zyga | jamesh: ^ if you can, can you have a look as well please? | 05:20 |
| zyga | I’m sleepy, will start late | 06:01 |
| jamesh | zyga: will do. | 06:16 |
| zyga | Thank you :-) | 06:30 |
| mborzecki | zyga: reviewed, each time i look at this i actually have to go and take a look at the rest of the code around s-u-n | 06:38 |
| mborzecki | zyga: can you take a look at #6929 ? | 06:52 |
| mup | PR #6929: gadget: record gadget root directory used during positioning <Gadget update> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6929> | 06:52 |
| zyga | mborzecki: sure, back in 5 minutes | 06:54 |
| zyga | man, my timing sucks | 07:15 |
| zyga | back now | 07:15 |
| zyga | going to review | 07:15 |
| zyga | mborzecki: as for sun, do you have any ideas on how to make things clearer? | 07:17 |
| zyga | mborzecki: +1 | 07:18 |
| zyga | I think you can merge that as is | 07:18 |
| zyga | eh, retry branch is red | 07:20 |
| mborzecki | zyga: retry the retry branch? :) | 07:50 |
| zyga | no, it's really broken | 07:50 |
| zyga | maybe pstolowski will have some ideas | 07:51 |
| zyga | it feels like chasing a rabbit now | 07:51 |
| pstolowski | zyga: it has always been whack-a-mole thing | 07:52 |
| zyga | now it's whack some more or disable tests :/ | 07:52 |
| pstolowski | zyga: i can look at this later/monday (i'm going to take half-day off today) | 07:52 |
| zyga | thanks! | 07:53 |
| pstolowski | i don't expect this to be a quick fix, it's always painful | 07:53 |
| zyga | hey Chipaca | 08:11 |
| Chipaca | zyga: hiya :) | 08:11 |
| zyga | Chipaca: wanna do a 2nd review https://github.com/snapcore/snapd/pull/6937 ? | 08:13 |
| mup | PR #6937: cmd/snap-update-ns: detach unused mount points <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/6937> | 08:13 |
| zyga | pretty short | 08:13 |
| mborzecki | Chipaca: morning sir! | 08:14 |
| Chipaca | switched over to firefox last night, looking good so far | 08:16 |
| zyga | Chipaca: from chrome? | 08:16 |
| Chipaca | yes | 08:16 |
| zyga | Chipaca: I play with firefox once in a while, it's pretty speedy! | 08:16 |
| Chipaca | only issue is with passwords that didn't auto-migrate | 08:16 |
| zyga | it's always surprising when I open it | 08:16 |
| zyga | ouch | 08:16 |
| Chipaca | but passwords.google.com to the rescue :-) | 08:16 |
| zyga | yeah, using safari on ios and macos makes me want to keep using them over other browsers | 08:17 |
| zyga | I'd switch easier if firefox integrated with the system keyring | 08:17 |
| zyga | and apparently it has a separate one :/ | 08:17 |
| Chipaca | and with that i discovered parts of aws leaking into amazon.com | 08:17 |
| Chipaca | (if you go to amazon.co.uk (or .com)'s "your account" → "login & security", the MFA it asks for is your _AWS_ MFA, which is separate from your amazon.co{m,.uk} MFA | 08:18 |
| Chipaca | ) | 08:18 |
| Chipaca | and, guess who still had their old phone and address in AWS (because I haven't used it since I moved)? | 08:19 |
| Chipaca | fun night | 08:19 |
| Chipaca | anyway, firefox is nice, and the whole "yeah we're breaking the good ad blockers, but hey at least we're dropping text adds altogether" google thing was too far | 08:20 |
| Chipaca | ads* | 08:20 |
| pstolowski | hey Chipaca | 08:38 |
| pstolowski | Chipaca: also switched to firefox from chrome recently | 08:39 |
| Chipaca | we should move our standup away from hangouts :-) | 08:39 |
| zyga | I need reviews for bugfixes: https://github.com/snapcore/snapd/pull/6937 and https://github.com/snapcore/snapd/pull/6891 | 08:40 |
| mup | PR #6937: cmd/snap-update-ns: detach unused mount points <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/6937> | 08:40 |
| mup | PR #6891: many: make per-snap mount namespace MS_SHARED <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/6891> | 08:40 |
| Chipaca | zyga: “To counter that, the writable mimic | 08:46 |
| Chipaca | construction code in snap-update-ns switched the stash mount point to | 08:46 |
| Chipaca | recursively private, so that prior semantics is retained.” | 08:46 |
| Chipaca | zyga: is that "switched" actually a "switches"? | 08:47 |
| Chipaca | (i have not looked at the code -- i'm asking if i should expect to find that switch in this pr) | 08:47 |
| Chipaca | ((and if not in this pr, where?)) | 08:47 |
| Chipaca | mborzecki: i wonder what "armound" comes from | 09:05 |
| Chipaca | amount maybe? | 09:05 |
| mborzecki | Chipaca: probably closest hamming distance | 09:06 |
| Chipaca | mborzecki: want to change the suggestion to an actual suggestion so we can commit it? or should I :) | 09:06 |
| mborzecki | Chipaca: go ahead :P | 09:08 |
| Chipaca | would be nice to know which syscalls are the problematic ones | 09:09 |
| Chipaca | so we can fix them in go itself =) | 09:09 |
| Chipaca | huh, i don't have permission to commit my suggestions | 09:11 |
| Chipaca | mborzecki: can you batch up the two suggestions and try to commit them? | 09:11 |
| Chipaca | (the other one is a trivial it's → its) | 09:12 |
| mborzecki | Chipaca: sure, let me see | 09:12 |
| Chipaca | taw | 09:13 |
| mborzecki | and pushed | 09:15 |
| Chipaca | taw² | 09:15 |
| mborzecki | funny git push is ok, but commiting on review page is not, though supposedly it's the same user attempting the action | 09:16 |
| Chipaca | ah, i was wondering :-) | 09:17 |
| mborzecki | Chipaca: can you take a look at #6929 ? | 09:27 |
| mup | PR #6929: gadget: record gadget root directory used during positioning <Gadget update> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/6929> | 09:27 |
| Chipaca | mborzecki: yes | 09:29 |
| mborzecki | Chipaca: thanks! | 09:30 |
| Chipaca | editing distance is fun and i hate you for sending me down that fun rabbit hole | 09:32 |
| Chipaca | amount is editing distance 3, and there are several words closer | 09:32 |
| Chipaca | actually, just two: around and arround are distance 1. Nothing at distance 2. | 09:33 |
| mborzecki | Chipaca: arround? | 09:35 |
| Chipaca | using the british-english-insane wordlist, yes | 09:35 |
| mborzecki | Chipaca: not aground? | 09:36 |
| Chipaca | strangely no | 09:37 |
| Chipaca | but my code might be buggy | 09:37 |
| Chipaca | :) | 09:37 |
| Chipaca | that should be there with edit distance 2 though | 09:37 |
| Chipaca | hmm | 09:37 |
| * Chipaca closs the file and walks away | 09:37 | |
| pstolowski | zyga: i'll be able to reproduce retry issue even without your PR when using unshared network ns? | 09:45 |
| mup | PR snapd#6929 closed: gadget: record gadget root directory used during positioning <Gadget update> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/6929> | 09:45 |
| Chipaca | mborzecki: ineed i was stomping on distance n things with distance m>n things when they were the same but found later | 09:50 |
| Chipaca | mborzecki: https://paste.ubuntu.com/p/bMZDf67zHy/ | 09:50 |
| * Chipaca now yes deletes the file | 09:50 | |
| mborzecki | Chipaca: haha :) feel genuinely sorry for triggering this | 09:51 |
| Chipaca | :) | 09:51 |
| zyga | pstolowski: re, partially, there are different failures with and without the patch | 09:55 |
| zyga | pstolowski: but yeah, just look at what the spread test does | 09:55 |
| pstolowski | zyga: ack, i've just reproduced httputil failure | 09:55 |
| zyga | Chipaca: I meant that the code that does handle the mimic now uses private sharing | 09:55 |
| Chipaca | zyga: where 'now' means 'as of this PR'? | 09:56 |
| zyga | yes | 09:56 |
| zyga | mborzecki: can you complete your review of https://github.com/snapcore/snapd/pull/6937 -- not sure if I need to change anything or just merge it | 10:04 |
| mup | PR #6937: cmd/snap-update-ns: detach unused mount points <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/6937> | 10:04 |
| Chipaca | zyga: if a struct holds a pointer, copying the struct will copy the same pointer | 10:15 |
| zyga | I know that, | 10:17 |
| zyga | I was explaining why I change the options array | 10:17 |
| Chipaca | zyga: wrt the commit message, if you change "the writable mimic construction code in snap-update-ns switched [...]" to "this change switches the writable mimic code [...]", it becomes clearer | 10:17 |
| zyga | +1 | 10:17 |
| zyga | done | 10:19 |
| mup | PR snapd#6937 closed: cmd/snap-update-ns: detach unused mount points <Bug> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/6937> | 10:32 |
| pstolowski | can we land https://github.com/snapcore/snapd/pull/6933 per my comment there? would be great to have it in edge after the weekend | 10:34 |
| mup | PR #6933: [RFC] snapd: ensure GOMAXPROCS is at least 2 <Created by mvo5> <https://github.com/snapcore/snapd/pull/6933> | 10:34 |
| mup | PR snapd#6933 closed: [RFC] snapd: ensure GOMAXPROCS is at least 2 <Created by mvo5> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/6933> | 10:42 |
| zyga | +1 | 10:48 |
| * Chipaca takes a break | 11:02 | |
| pstolowski | i'm off for today, have a great weekend guys, see you! | 11:16 |
| zyga | pstolowski: bye! | 11:19 |
| cachio | pstolowski, enjoy your weekend | 11:58 |
| === epod is now known as luk3yx | ||
| === davdunc_ is now known as davdunc | ||
| === sdrobertw_ is now known as sdrobertw | ||
| === JamieBennett_ is now known as JamieBennett | ||
| === kalikiana_ is now known as kalikiana | ||
| === Lukewh_ is now known as Lukewh | ||
| === jamespage_ is now known as jamespage | ||
| === benoitc_ is now known as benoitc | ||
| === nottrobin_ is now known as nottrobin | ||
| === joc__ is now known as joc | ||
| === pstolowski_ is now known as pstolowski | ||
| === moul_ is now known as moul | ||
| === coreycb_ is now known as coreycb | ||
| === davecore_ is now known as davecore | ||
| === AndyWojo_ is now known as AndyWojo | ||
| === ricab is now known as ricab|lunch | ||
| Wimpress | Snapcraft Live starts is a few minutes - https://www.youtube.com/watch?v=oR3XLnhypts | 12:55 |
| === Greyztar- is now known as Greyztar | ||
| === ricab|lunch is now known as ricab | ||
| zyga | /me lunch | 13:56 |
| * cachio lunch | 15:04 | |
| * zyga had a glass of wine and is very dizzy now | 15:06 | |
| Paddy_NI | Hello I wonder if it would be difficult to Snap "peerflix"? I mean to try this now but was just curious if I might be biting off more than I can chew? | 17:55 |
| Paddy_NI | I made a fork of "peerflix" here https://github.com/Paddy-NI/peerflix | 17:55 |
| Paddy_NI | I also want to snap "mps-youtube" | 17:55 |
| Paddy_NI | I have often found mps-youtube to only work if both it and youtube-dl are installed using "pip3". If you have installed youtube-dl via apt then it tends to break mps-youtube. | 17:57 |
| Chipaca | Paddy_NI: ooh, nice. If you're doing that, you could also patch libncurses to work with the mouse wheel :-) | 18:01 |
| Chipaca | (the one in ubuntu still doesn't) | 18:01 |
| Chipaca | anyway, EOW for me | 18:02 |
| Chipaca | 👋 | 18:02 |
| * cachio afk | 18:18 | |
| Paddy_NI | I am trying to snap "peerflix" which succeeds of course when using "devmode" however when I switched to "strict" and snap installed it with "dangerous" it poops itself. Here is the output from "snappy-debug.security scanlog" https://paste.ubuntu.com/p/KhSdP2Bsp6/ | 19:04 |
| Paddy_NI | Hey popey it would be lovely if you shared your bashrc with us not locals sometime so we could all look at the precious things of the shop! | 19:36 |
| cmatsuoka | \o/ writable on tmpfs runs up to console-conf! | 20:36 |
| cmatsuoka | (of course console-conf won't do much without a real on-disk writable -- but that's the next step) | 20:37 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!