| mborzecki | morning | 05:01 |
|---|---|---|
| mborzecki | mup_ needs a little nudge | 05:31 |
| zyga | hey | 06:25 |
| zyga | mborzecki: mvo is offline | 06:25 |
| zyga | mborzecki: he asked to relay to the team | 06:25 |
| zyga | mborzecki: over weekend I noticed master is broken | 06:25 |
| zyga | mborzecki: ineffectual assignment in shlex.go | 06:25 |
| zyga | mborzecki: I'll start around ~10 today, moving downtown to work from a cafeteria, it's super hot in the office today, I have no AC here | 06:26 |
| mborzecki | zyga: hey, there's a PR fixing this up already | 06:27 |
| zyga | mborzecki: super, looking | 06:27 |
| zyga | mborzecki: let's land it and notify chipaca when he's around | 06:27 |
| mborzecki | zyga: ok | 06:28 |
| zyga | mborzecki: can you please review https://github.com/snapcore/snapd/pull/6940 -- I will need it today | 06:28 |
| zyga | it's just python compatibility for mountinfo-tool | 06:28 |
| mborzecki | zyga: ack, looking | 06:29 |
| zyga | I didn't commit that because I'm not quite sure where to put it | 06:29 |
| zyga | but I have a makefile there that does | 06:29 |
| zyga | black, flak8, mypy -2 and mypy checks | 06:29 |
| zyga | (and shellcheck on the shell script) | 06:29 |
| zyga | and this is 100% green | 06:29 |
| mborzecki | heh | 06:31 |
| mborzecki | need more python linters | 06:31 |
| mborzecki | zyga: that's because of 14.04 right? | 06:33 |
| zyga | not even that | 06:33 |
| zyga | it's mainly because we need 2.7 for places like amazon | 06:33 |
| zyga | on the upside, now it's compatible with everything | 06:33 |
| mborzecki | zyga: yeah, but the looks of it :/ | 06:34 |
| zyga | mborzecki: it's not too bad | 06:34 |
| zyga | mborzecki: I actually think that function signatures are nicer when they are on the following line | 06:34 |
| zyga | only python byte/unicode quirks are ugly IMO | 06:34 |
| zyga | ok | 06:35 |
| zyga | packing up and going | 06:35 |
| mborzecki | zyga: let's agree to disagree :) | 06:35 |
| zyga | this office is nice but during summer time it's an oven :) | 06:35 |
| zyga | mborzecki: don't get me wrong | 06:36 |
| zyga | mborzecki: I'd love not to have to do this :D | 06:36 |
| zyga | mborzecki: the details we can have opinions on that diverge | 06:36 |
| mborzecki | zyga: makes me wonder, how people actually get python3 on centos | 06:37 |
| mborzecki | zyga: i see 3.6 in epel :) | 06:37 |
| zyga | maybe EPEL | 06:37 |
| mborzecki | on rh it's probably software collections | 06:38 |
| mborzecki | zyga: so centos has python34 & python36 from epel, amzn2 has python 3.7 directly from their repos :P | 06:40 |
| zyga | mborzecki: the tool required 3.6 before this patch | 06:40 |
| mborzecki | zyga: right, so there's a quesion of 14.04 then | 06:41 |
| zyga | mborzecki: hmm? | 06:57 |
| zyga | mborzecki: it works on 14.04, I think | 06:58 |
| zyga | I think it passed all spread locally | 06:58 |
| pstolowski | morning | 07:06 |
| zyga | good morning pawel | 07:07 |
| * zyga commutes to work for a change :) | 07:07 | |
| mborzecki | pstolowski: hey | 07:14 |
| mborzecki | looks like it's going to be quite warm today | 07:17 |
| mborzecki | mvo: hey | 07:32 |
| zyga | Hey mbo | 07:36 |
| zyga | mvo: | 07:36 |
| zyga | Working from afar today? | 07:36 |
| zyga | okay, arrived and setting up for work | 07:45 |
| zyga | ah --version changed across python versions | 07:49 |
| zyga | drat :) | 07:49 |
| mvo | thanks for merging 6928 mborzecki | 07:54 |
| mvo | is mup down? | 07:54 |
| mvo | mup_: hello, how are you today? | 07:54 |
| mborzecki | mvo: yup, it is | 07:54 |
| zyga | mvo: mup is off today :) | 07:54 |
| * dot-tobias says hi | 07:55 | |
| mborzecki | mvo: probably since friday, iirc there was a split during the day | 07:55 |
| mvo | hey dot-tobias | 07:55 |
| mvo | mborzecki: I cherry picked the ppc build fixes to 2.39 now (just fyi) | 07:56 |
| mborzecki | mvo: can you cherry pick ineffassign fix too? | 07:56 |
| mvo | mborzecki: sure, what pr number is/was that? | 07:56 |
| mborzecki | mvo: it's 8d883ae66 | 07:56 |
| mvo | ta | 07:56 |
| zyga | mvo: lets bump delta ref to 2.39.1 | 07:57 |
| mvo | mborzecki: thanks for this one! was it needed because of a new go vet? | 07:57 |
| mborzecki | mvo: recent changes in ineffassign | 07:57 |
| * mvo nods | 07:58 | |
| mborzecki | mvo: this commit https://github.com/gordonklaus/ineffassign/commit/8863c8f9d746c0e28d65c1bc46c8d3aa8ab1ee82 :) | 07:58 |
| mvo | mborzecki: nice! and nice^2 for tracking the exact change down | 07:59 |
| pstolowski | mvo: i've made the measurement before- and after- maxprocs patch, see comments below https://github.com/snapcore/snapd/pull/6933 ; unfortunately no improvement | 07:59 |
| pstolowski | mvo: and hi btw :) | 07:59 |
| mvo | pstolowski: goooood morning :) | 07:59 |
| mvo | pstolowski: you rock! | 08:00 |
| mvo | pstolowski: thank you so much, let me look at the data | 08:00 |
| mvo | pstolowski: is there a tl;dr ? | 08:00 |
| mvo | pstolowski: aha, looks like zero effect ? | 08:00 |
| pstolowski | mvo: yep, random fluctuations, nothing more | 08:01 |
| mborzecki | mvo: pstolowski: wonder if there'd be an observable change in reaching seeded target | 08:01 |
| mvo | pstolowski: a shame - oh well | 08:02 |
| mvo | pstolowski: what cmdline did you use to limit the cpu? | 08:02 |
| pstolowski | mvo: setenv snappy_cmdline net.ifnames=0 init=/lib/systemd/systemd ro panic=-1 fixrtc maxcpus=1 | 08:04 |
| pstolowski | mvo: followed by saveenv | 08:04 |
| pstolowski | mvo: verified with lscpu afterwards | 08:04 |
| mvo | pstolowski: cool, thanks! | 08:08 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/6937/files | 08:09 |
| * Chipaca goes for more coffee | 08:24 | |
| pstolowski | mvo: https://github.com/snapcore/snapd/pull/6925 can land? | 10:53 |
| * zyga breaks for lunch | 10:56 | |
| zyga | Setting in | 11:37 |
| cmatsuoka | mvo, pedronis, zyga: spike successfully installs using writable on tmpfs | 11:47 |
| zyga | cmatsuoka: hey | 11:49 |
| zyga | cmatsuoka: that's cool :) | 11:49 |
| zyga | cmatsuoka: I'm progressing towards go-only initrd that can hand off to existing stack | 11:50 |
| * cmatsuoka notices he can't read IRC and code at the same time, he just typed "build_zyga" as a function name | 11:50 | |
| zyga | hahaha | 11:51 |
| zyga | make -j 2 | 11:51 |
| cmatsuoka | zyga: nice! I ported writable preparation steps from shell script to go for the spike and sometimes it's a bit annoying | 11:52 |
| cmatsuoka | I just exec.Command().Run() in some places just to keep things going | 11:52 |
| cmatsuoka | with proper infrastructure it will be much nicer | 11:53 |
| zyga | +1 | 11:54 |
| zyga | that's good for the spike IMO | 11:54 |
| cmatsuoka | there are a number of hacks there that must be solved in a better way, such as console-conf telling snapd that it's done | 11:58 |
| cmatsuoka | and when I request a reboot it takes a really long time to reboot | 11:59 |
| mborzecki | off to pick up the kids | 12:05 |
| === ricab is now known as ricab|lunch | ||
| mvo | cmatsuoka: awesome! | 12:27 |
| ackk | hi, I'm trying to get chrony to work in a snap, I added the time-control interface, but getting a permission denied from adjtimex | 13:15 |
| ackk | I'm getting no denials in logs | 13:18 |
| === ricab|lunch is now known as ricab | ||
| cmatsuoka | mvo: we were previously injecting stuff into kernel initramfs, I'm now injecting into core and adding a custom snapd from my writable-ramdisk branch | 13:38 |
| cmatsuoka | also core-build from writable-ramdisk branch | 13:39 |
| mvo | cmatsuoka: so core-build is the branch I need to look at? | 13:40 |
| cmatsuoka | you need the writable-ramdisk branch in spike-tools, core-build and snapd | 13:41 |
| cmatsuoka | all of them are in github.com/cmatsuoka | 13:42 |
| * mvo looks | 13:44 | |
| cmatsuoka | mvo: hmm, and I think I broke something because I can't log into the installed system anymore | 13:48 |
| * cmatsuoka investigates | 13:49 | |
| mvo | ok | 13:50 |
| pstolowski | #6935 needs 2nd review | 13:53 |
| ackk | mvo, hi, any idea off the top of your head for the issue above? | 13:53 |
| Chipaca | pstolowski: if you have a chance, can you give #6905 a look to see if your LGTM still stands? (and make it an actual +1) | 13:54 |
| pstolowski | Chipaca: ok | 13:54 |
| mvo | ackk: just read it, let me think for a minute | 13:54 |
| * zyga goes to find some shade | 13:55 | |
| mvo | ackk: it sounds like its a missing syscall in the interface, let me look at the code | 13:55 |
| ackk | mvo, thanks | 13:56 |
| ackk | mvo, I have a simple snap which shows the issue, if it could be useful | 13:58 |
| mvo | ackk: see #6943 | 14:00 |
| ackk | mvo, that doesn't seem like an LP bug# :) | 14:01 |
| ackk | oh you mean https://github.com/snapcore/snapd/pull/6943 | 14:02 |
| ackk | mvo, thanks! | 14:02 |
| mvo | ackk: yes, sorry, usually mup expands this but it seems to be off today :P | 14:04 |
| ackk | heh | 14:04 |
| mvo | ackk: lets see if this is enough, if you need more just let me know, hopefully will land in edge soon | 14:04 |
| ackk | mvo, how do I get that ? via a PPA? | 14:04 |
| ackk | (once it lands of course) | 14:05 |
| mvo | ackk: snap install --edge core (or snapd if you use that already) should be enough | 14:06 |
| mvo | ackk: once you are happy you can always "snap refresh --beta core" (or snapd) (or candidate/stable) to get off edge of course | 14:06 |
| ackk | mvo, cool, thanks | 14:08 |
| Chipaca | pstolowski: does my review make sense? | 14:29 |
| cmatsuoka | mvo: during the spike it could be good to add systemd.debug-shell=1 to the gadget grubenv as well | 14:30 |
| pstolowski | Chipaca: absolutely, thank you! | 14:30 |
| pedronis | Chipaca: thx for looking at that | 14:32 |
| mvo | cmatsuoka: yeah, I think so | 15:01 |
| * cachio lunch | 15:42 | |
| === pstolowski is now known as pstolowski|afk | ||
| zyga | back in the office | 16:37 |
| zyga | sorry for the lag, had dinner too | 16:37 |
| cmatsuoka | mvo: I'm fixing seed installation on the real writable | 17:07 |
| === Greyztar- is now known as Greyztar | ||
| jdstrand | zyga: hey, do you know who was working on '(cannot find required base "core")'? I thought that was supposed to be fixed in 2.39, but I'm seeing it | 18:14 |
| * jdstrand has core installed | 18:14 | |
| zyga | jdstrand: I think eventually that was mvo | 18:14 |
| zyga | how about .1? | 18:14 |
| zyga | oh | 18:14 |
| zyga | hmmm | 18:14 |
| jdstrand | snap version says 2.39 | 18:15 |
| jdstrand | $ snap list core | 18:15 |
| jdstrand | Name Version Rev Tracking Publisher Notes | 18:15 |
| jdstrand | core 16-2.39 6964 stable canonical✓ core | 18:15 |
| jdstrand | $ sudo snap refresh review-tools | 18:15 |
| jdstrand | error: cannot perform the following tasks: | 18:15 |
| jdstrand | - Mount snap "review-tools" (857) (cannot find required base "core") | 18:15 |
| jdstrand | huh | 18:17 |
| jdstrand | so, 847 doesn't have 'base: core', but 857 does have 'base: core' | 18:17 |
| jdstrand | hmmm, remove and install, same thing | 18:23 |
| zyga | jdstrand: hmmm | 18:27 |
| zyga | jdstrand: can you report it please, I'll check it out tomorrowm orning | 18:27 |
| jdstrand | zyga (cc pedronis): https://forum.snapcraft.io/t/cannot-find-required-base-core-when-installing-refreshing-when-using-base-core/11641 | 18:44 |
| jdstrand | zyga: fyi, I refreshed to --beta (2.39.1) and it was the same thing | 18:45 |
| jdstrand | sergiusens[m]: fyi ^ (not sure if you have anything to add to that, so just fyi) | 18:46 |
| jdstrand | sergiusens[m]: hi btw :) | 18:47 |
| sergiusens | hi jdstrand | 18:54 |
| sergiusens | jdstrand: answered on the post | 18:55 |
| jdstrand | sergiusens: thanks! trying that. is that true for snaps that use 'base: core18' too? | 19:01 |
| === valentind_ is now known as valentind | ||
| jdstrand | zyga: fyi, nm, sergiusens fixed it for me (see forum) | 19:20 |
| sergiusens | jdstrand: yes, it is true for core18 as well, let me see if I can find the launchpad bug for this | 19:35 |
| jdstrand | sergiusens: interesting. I have some core18 snaps and didn't see this before | 19:37 |
| * jdstrand fixes those | 19:37 | |
| ijohnson_ | hey jdstrand do you think we can merge https://github.com/snapcore/snapd/pull/6805 or do we need to fix that erroneous test? | 20:09 |
| jdstrand | ijohnson_: I'm not comfortable doing that. I recommend clicking through to the failing job and doing 'Restart job' until it passes | 20:15 |
| jdstrand | ijohnson_: if that doesn't work after a few times, ping mvo or cachio or someone for assistance (they may have insight on the failing test that I don't) | 20:16 |
| ijohnson_ | okay, well I don't have permission to restart the jobs, do you have permissions to restart the tests on that PR? | 20:21 |
| ijohnson_ | jdstrand: ^ | 20:21 |
| jdstrand | I do | 20:21 |
| jdstrand | let me do it | 20:21 |
| jdstrand | ok, done. I'll keep an eye on it | 20:22 |
| ijohnson_ | ack, thanks | 20:22 |
| === Greyztar- is now known as Greyztar | ||
| * cachio afk | 21:01 | |
| ijohnson_ | hey jdstrand it looks like those tests passed, do you still want another review before merging? | 21:06 |
| jdstrand | ijohnson_: there need to be two approvals | 21:07 |
| jdstrand | needs* | 21:07 |
| ijohnson_ | ah okay wasn't aware of that, I will ping someone else tomorrow morning | 21:07 |
| ijohnson_ | thanks! | 21:07 |
| Pharaoh_Atem | zyga, looks like we have a problem... https://bugzilla.redhat.com/show_bug.cgi?id=1716397 | 21:27 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!