[07:01] <marcustomlinson> morning
[07:02] <duflu> Morning marcustomlinson
[07:03] <marcustomlinson> duflu: hey, how are you?
[07:03] <duflu> marcustomlinson, going well. You?
[07:03] <marcustomlinson> pretty good today thanks :)
[07:03] <marcustomlinson> relaxing weekend
[07:48] <willcooke> morning all
[07:51] <duflu> Morning willcooke
[07:52] <duflu> I suspect "all" is few
[07:53] <marcustomlinson> morning willcooke
[07:56] <willcooke> hi duflu marcustomlinson
[07:56] <willcooke> yeah, lots of public hols today
[07:57] <Trevinho> morning from Italy!
[07:58] <willcooke> Hi Trevinho, not on holiday today as well?
[07:59] <duflu> Hi Trevinho. Thanks for landing things... some of it was past a year old :/
[08:01] <duflu> As luck would have it I was thinking about those last night. I must have sensed you
[08:01] <Laney> yo
[08:01] <duflu> Hi Laney
[08:02] <marcustomlinson> hey Trevinho and Laney
[08:03] <Trevinho> willcooke: no, no... in-da-house
[08:03] <Trevinho> duflu: np
[08:03] <Trevinho> and hi duflu, marcustomlinson and Laney
[08:04] <Laney> o m g
[08:04] <Laney> moin duflu marcustomlinson Trevinho
[08:05] <duflu> Trevinho, do the other residents remember you?
[08:05] <duflu> :)
[08:07] <Trevinho> duflu: no, we did presentations before xD
[08:21] <Laney> Trevinho: what's the next travel plan?
[08:26] <GunnarHj> Good morning, Laney! Time to talk about https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409 ? As a first step I'd like to know if the approach is reasonable.
[08:29] <Trevinho> Laney: calm a bit... then Sardinia and some more southern italy. As I've to show the best to Dayana :-)
[08:30] <Laney> :>
[08:32] <Laney> GunnarHj: what is initial setup doing when it runs?
[08:32] <Laney> isn't it putting things in KEY_INPUT_SOURCES ?
[08:33] <GunnarHj> Laney: Not on Ubuntu, AFAIK.
[08:33] <GunnarHj> Laney: And it doesn't run when you "Try Ubuntu".
[08:34] <Laney> I'm thinking that it looks weird to test for how something was done rather than what it did
[08:34] <Laney> and the previous code looks (to me) like it did the latter
[08:35] <GunnarHj> Laney: The idea is to make sure that the function runs 1. when you "Try Ubuntu" and 2. at first login. The file in ~/.config comes in hande to achieve that.
[08:36] <GunnarHj> s/hande/handy
[08:37] <Laney> so what you're doing is running that add_ibus thing even when there are some input sources already defined
[08:37] <Laney> on the first login and the live session
[08:37] <GunnarHj> Laney: Yes.
[08:38] <Laney> do we know what it's set up with and in what way it's not sufficient?
[08:38] <Laney> how is that set up? casper/
[08:38] <Laney> ?
[08:40] <GunnarHj> Laney: I don't much about the code involved in the installer. One weird thing is that it behaves differently if you launch "Try Ubuntu" from the Ubiquity welcome screen compared to when you "Try Ubuntu before installing" from the isolinux menu. The bug is only present for the former case.
[08:43] <GunnarHj> Laney: But keyboard configuration in general is a can of worms. My hope is that we can make this attempt to at least make sure that an IBus method is present for Chinese, Japanese, etc. live sessions.
[08:48] <Laney> GunnarHj: What do you think about checking if it's maybe_convert_old_settings() grabbing it from somewhere? I can see references to the (old?) org.gnome.libgnomekbd.keyboard schema in casper and ubiquity, at least.
[08:48] <Laney> I'd be happier if we knew why it was getting set up wrongly, and ideally if we could fix that place directly
[08:49] <Laney> I guess it'd be possible to add some debugging into that function to see what it's doing
[08:52] <GunnarHj> Laney: One question is what's the most right or wrong way wrt the XKB layouts. But isn't answering that question beyond the scope of the bug, which is only about a missing IBus method?
[08:53] <Laney> I'm trying to identify why the existing call to add_ibus_sources_from_locale() isn't happening - presumably because the 'old' settings are being set up
[08:53] <Laney> If that's true, then it might be the right fix to have maybe_convert_old_settings() call add_ibus_sources_from_locale()
[08:55] <Laney> maybe_convert_old_settings() makes a stamp file so it only runs one time
[08:57] <GunnarHj> Laney: But why would maybe_convert_old_settings() run when you "Try Ubuntu" from the Welcome screen but not from the isolunux menu?
[08:58] <Laney> I can guess
[08:58] <Laney> The "Try Ubuntu" screen runs a desktop environment to show you the GUI
[08:58] <Laney> as part of that it starts up a few g-s-d bits
[08:58] <Laney> Guess is that this causes the stamp file to be created (because it runs that function), and it's not run a second time when you click "Try Ubuntu" to start GNOME Shell
[08:59] <Laney> second guess would be that something actually does directly set up the input sources
[09:00] <GunnarHj> Laney: My hope was to avoid to dig too deep into this. :)
[09:01] <GunnarHj> Laney: Especially since I don't know how you test things involving the installer.
[09:02] <Laney> Try moving add_ibus_sources_from_locale() into maybe_convert_old_settings() and see what happens
[09:02] <Laney> oh, how did you test this then?
[09:04] <GunnarHj> Laney: I have tested on an existing install, and kind of simulating first Chinese/Japanese logins. But that kind of test could well be done if I move the call into maybe_convert_old_settings().
[09:04]  * Laney nods
[09:05] <Laney> Make sure it goes towards the end of the function, so all the other bits get run too and it respects the stamp file
[09:05] <GunnarHj> Laney: Ok. Didn't notice the stamp file before. Will probably do so now.
[09:07] <Laney> 👍
[09:08]  * Laney needs to go back to juju land for a bit now
[09:08] <GunnarHj> Laney: Thanks for input!
[17:11] <willcooke> night all