[00:54] <wxl> @tsimonq2: think that's sufficient for an SRU? https://bugs.launchpad.net/ubuntu/+source/libfm-qt/+bug/1825587
[00:54] <ubot93> Ubottu bug 1825587 in libfm-qt (Ubuntu Disco) "non-existent temporary desktop file appears on desktop" [High, Triaged]
[00:55] <lubot> <tsimonq2> Maybe a little more verbose on Regression Potential, otherwise LGTM
[00:55] <wxl> i'm not sure what else to say frankly
[00:55] <wxl> i've stared at the diff long enough for it to be meaningless XD
[00:55] <lubot> <tsimonq2> Ok XD
[00:55] <lubot> <tsimonq2> Then JFDI
[00:56] <wxl> there's some license stuff
[00:56] <lubot> <tsimonq2> Oh, so one thing to keep in mind
[00:56] <wxl> a build depends change, though very minor
[00:56] <lubot> <tsimonq2> Any unrelated changes will be heavily scrutinized
[00:56] <lubot> <tsimonq2> All changes made must be necessary
[00:57] <wxl> a removal of a unnecessary depends
[00:57] <lubot> <tsimonq2> To fix the bug, of course
[00:57] <wxl> a description extension
[00:57] <wxl> some super trivial change to the install that doesn't even seem to have an effect (they included white space and moved the position of one of the lines)
[00:58] <wxl> beyond that are some patches:
[00:58] <wxl>  * the fix we need
[00:58] <lubot> <tsimonq2> Again, any change unrelated to fixing the bug will be scrutinized and very likely rejected
[00:58] <wxl>  * license header fix
[00:58] <wxl>  * a fix related to smb recursive copying
[00:59] <wxl>  * glib recusive moving error
[00:59] <wxl> so i thought it might be wise to include all that.. alf suggested it. TJ- kind of agreed too, at least from a maintenence perspective
[00:59] <wxl> if i don't then i run into the question of, as i said before, what version to give it
[01:00] <wxl> i guess 0.14.1-0ubuntu3 (disco's on 0ubuntu2)
[01:00] <wxl> so what i'm hearing you say is i shouldn't?
[01:01] <lubot> <tsimonq2> Make sure that every single other change is accounted for in the SRU bug desc. It's not my rules, they're just really strict about it. :)
[01:01] <lubot> <tsimonq2> You can have other changes, but every single other change MUST be suitable for an SRU
[01:02] <lubot> <tsimonq2> If you have questions about the specific process, I'd ask rbasak / bdmurray / infinity but for the most part, follow that rule and you'll be fine
[01:02] <lubot> <tsimonq2> Some SRUers tend to be more strict than others, however, the stricter ones tend to teach you a lot more.
[01:02] <wxl> k
[01:39] <wxl> how's that @tsimonq2 ? https://bugs.launchpad.net/ubuntu/+source/libfm-qt/+bug/1825587
[01:39] <ubot93> Ubottu bug 1825587 in libfm-qt (Ubuntu Disco) "non-existent temporary desktop file appears on desktop" [High, Triaged]
[01:40] <lubot> <tsimonq2> Run it by the SRU team. +0
[01:40] <wxl> you're nop fun
[01:40] <lubot> <tsimonq2> Or just upload it and see XD
=== guiver_d is now known as guiverc
[18:28] <wxl[m]> The crap storm about thirty two bit continues https://mobile.twitter.com/Plagman2/status/1142262103106973698
[20:13] <lubot> <tsimonq2> Congratulations to @JyotiGomes for becoming an official member of the Lubuntu project!
[20:16] <lubot> <kc2bez> Fantastic news! Congratulations @JyotiGomes
[20:18] <lubot> <aptghetto> @JyotiGomes Congrats