[07:00] -queuebot:#ubuntu-release- New binary: linux-signed-azure [amd64] (xenial-proposed/main) [4.15.0-1049.54] (kernel)
[07:17] -queuebot:#ubuntu-release- New: accepted linux-signed-azure [amd64] (xenial-proposed) [4.15.0-1049.54]
[09:23] -queuebot:#ubuntu-release- Unapproved: ceph (disco-proposed/main) [13.2.4+dfsg1-0ubuntu2 => 13.2.6-0ubuntu0.19.04.1] (desktop-core, ubuntu-server)
[09:24] -queuebot:#ubuntu-release- Unapproved: ceph (cosmic-proposed/main) [13.2.4+dfsg1-0ubuntu0.18.10.1 => 13.2.6-0ubuntu0.18.10.1] (desktop-core, ubuntu-server)
[09:29] -queuebot:#ubuntu-release- Unapproved: neutron-fwaas (cosmic-proposed/main) [1:13.0.1-0ubuntu1 => 1:13.0.1-0ubuntu1.1] (openstack, ubuntu-server)
[09:29] -queuebot:#ubuntu-release- Unapproved: neutron-fwaas (disco-proposed/main) [1:14.0.0-0ubuntu1 => 1:14.0.0-0ubuntu1.1] (openstack, ubuntu-server)
[10:08] -queuebot:#ubuntu-release- Unapproved: lighttpd (bionic-proposed/universe) [1.4.45-1ubuntu3 => 1.4.45-1ubuntu3.18.04] (no packageset) (sync)
[10:15] -queuebot:#ubuntu-release- Unapproved: systemd (bionic-proposed/main) [237-3ubuntu10.23 => 237-3ubuntu10.24] (core)
[10:16] <rbasak> bdmurray, RAOF: ^ I'm just looking at lighttpd, as it's regression-update (complete HTTPS breakage with new OpenSSL AIUI)
[10:20] <rbalint> RAOF, bdmurray: please accept the systemd to bionic in your sru cycles, the fix was already in -proposed once, it just got overwritten by an other upload
[10:21] <rbalint> rbasak, if you feel like looking at systemd, too, that would be appreciated :-)
[10:21] <rbalint> (i'm preparing the xenial fix, too)
[10:23] -queuebot:#ubuntu-release- Unapproved: accepted lighttpd [sync] (bionic-proposed) [1.4.45-1ubuntu3.18.04]
[10:23] -queuebot:#ubuntu-release- Unapproved: accepted lighttpd [source] (cosmic-proposed) [1.4.45-1ubuntu3.18.10]
[10:24] <rbasak> rbalint: this one isn't regression-update I don't think?
[10:25] <rbasak> I really need to get back to what I was doing ;-/
[10:30] -queuebot:#ubuntu-release- Unapproved: qtbase-opensource-src (disco-proposed/universe) [5.12.2+dfsg-4ubuntu1 => 5.12.2+dfsg-4ubuntu1.1] (kubuntu, qt5)
[10:32] <rbalint> rbasak, np, i thought you are just having some sru fun :-)
=== TJ_Remix is now known as TJ-
[10:43] <xnox> rbasak:  bdmurray: well "not complete" just tlsv1.3 connections =)
[10:43] <xnox> rbasak:  and thanks
[10:45] <rbasak> xnox: all current browsers though, presumably?
[10:45] <xnox> rbasak:  aha
[10:45] <rbasak> xnox: thank you for the prompt fix :)
[10:46] <rbasak> xnox: does this one need a skipping of the ageing period too?
[10:46] <xnox> rbasak:  let me verify it first out of the archive.
[10:46] <xnox> rbasak:  and yeah, i think so.
[10:46] <rbasak> OK
[10:46] <rbasak> Maybe bdmurray could provide a third review/opinion on that when he gets in
[13:24] -queuebot:#ubuntu-release- Unapproved: friendly-recovery (disco-proposed/main) [0.2.39 => 0.2.39ubuntu0.19.04.1] (core)
[13:24] -queuebot:#ubuntu-release- Unapproved: friendly-recovery (xenial-proposed/main) [0.2.31ubuntu2 => 0.2.31ubuntu2.1] (core)
[13:25] -queuebot:#ubuntu-release- Unapproved: friendly-recovery (bionic-proposed/main) [0.2.38ubuntu1 => 0.2.38ubuntu1.1] (core)
[13:25] -queuebot:#ubuntu-release- Unapproved: friendly-recovery (cosmic-proposed/main) [0.2.39 => 0.2.39ubuntu0.18.10.1] (core)
[14:00] -queuebot:#ubuntu-release- New binary: linux-signed-azure [amd64] (cosmic-proposed/main) [4.18.0-1023.24] (kernel)
[14:01] -queuebot:#ubuntu-release- New binary: linux-signed-hwe [amd64] (xenial-proposed/main) [4.15.0-54.58~16.04.1] (kernel)
[14:01] -queuebot:#ubuntu-release- New binary: linux-signed-hwe [ppc64el] (xenial-proposed/main) [4.15.0-54.58~16.04.1] (kernel)
[14:02] -queuebot:#ubuntu-release- New: accepted linux-signed-azure [amd64] (cosmic-proposed) [4.18.0-1023.24]
[14:02] -queuebot:#ubuntu-release- New: accepted linux-signed-hwe [ppc64el] (xenial-proposed) [4.15.0-54.58~16.04.1]
[14:02] -queuebot:#ubuntu-release- New: accepted linux-signed-hwe [amd64] (xenial-proposed) [4.15.0-54.58~16.04.1]
[14:56] -queuebot:#ubuntu-release- New binary: linux-signed-gcp [amd64] (disco-proposed/main) [5.0.0-1010.10] (core, kernel)
[15:05] <ddstreet> rbalint i noticed your patch for lp #1771858, i wonder if i should just add that and re-upload, since my systemd in xenial-unapproved has been there almost a month
[15:05] <ubot5> Launchpad bug 1771858 in snapd (Ubuntu) "/snap/bin not in default PATH for units, snapd should ship system-environment-generators to inject /snap/bin into $PATH" [Critical,Confirmed] https://launchpad.net/bugs/1771858
[15:17] <rbalint> ddstreet, i'm waiting for review from xnox, but i'd be ok with that
[15:17] <rbalint> ddstreet, why is is sitting there for so long?
[15:17] <ddstreet> rbalint i have no idea why it's been in unapproved queue for a month
[15:17] <rbalint> ddstreet, i also checked the packaging repo, but found no pending new commit for upload
[15:18] <rbalint> ddstreet, well i poke sru vanguards every day when i have something in :-)
[15:19] <ddstreet> yeah...i have been discouraged from doing that for my stuff
[15:19] <ddstreet> so...
[15:19] <ddstreet> it waits for a month :)
[15:24] <rbalint> ddstreet, also could you please use the packaging repo, too, and file mps?
[15:24] <ddstreet> rbalint my problem is it's not based on git ubuntu
[15:24] <ddstreet> so it's a real pain to use
[15:25] <ddstreet> and what's file mps?
[15:25] <rbalint> ddstreet, file merge proposals
[15:25] <ddstreet> ah mp the 'file' part confused me
[15:26] <rbalint> ddstreet, 'git ubuntu' does not support multiple commits between package updates, thus is is only good for importing archive state then preparing uploads in one shot
[15:27] <rbalint> ddstreet, not for preparing uploads together
[15:27] <ddstreet> well that's not really true, you can stage as many separate commits on top of the git-ubuntu repo as you like
[15:27] <ddstreet> then just rebase after it's released
[15:27] <ddstreet> that's what i do
[15:27] <rbalint> ddstreet, i use it as a reference, but prepare uploads on top of the packaging repo
[15:28] <rbalint> ddstreet, how do you review and merge them to the team repo?
[15:28] <ddstreet> you mean the ubuntu-core-dev repo?  i don't, that has to be merged from the released package
[15:29] <ddstreet> i asked xnox about the u-c-d systemd repo and he suggested i just ignore it
[15:29] <ddstreet> so i do
[15:29] <rbalint> well, that's an interesting position
[15:30] <vorlon> rbalint: last I checked, said repo is also currently out of date for eoan
[15:30] <rbalint> xnox, if you want people to ignore the packaging repo whey do you list it in debian/control?
[15:30] <vorlon> which annoyed me
[15:30] <ddstreet> i'm not sure that having both the git-ubuntu repo, and a separate special repo with different history, is a good thing
[15:30] <rbalint> vorlon, because people just upload
[15:31] <vorlon> rbalint: when I looked, the people was xnox
[15:31] <rbalint> vorlon, he may have had unpushed changes
[15:31] <vorlon> rbalint: yes, e.g. the entire ubuntu-eoan branch which does not exist in the repo
[15:31] <vorlon> :)
[15:32] <marcustomlinson> vorlon: remember that libreoffice bionic sru you pushed back because of an incorrect -v option? Could you approve it now/soon? Pretty pleeeease :)
[15:33] <vorlon> marcustomlinson: I do remember it but don't remember what release it was in
[15:33] <vorlon> bionic?
[15:33] <marcustomlinson> yeah
[15:33] <rbalint> vorlon, i see eoan in the repo https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/+git/systemd/+ref/ubuntu-eoan
[15:33] <vorlon> 3 weeks have passed since? sorry about that
[15:34] <marcustomlinson> vorlon: I don't like being a nag :P
[15:34] <vorlon> marcustomlinson: I had meant to do it soon after, but hit EOD before getting to it
[15:35] <vorlon> rbalint: hmm something's very strange here then, I don't see it with a git remote update
[15:35] <rbalint> vorlon, 'git fetch --all' ?
[15:36] <vorlon> rbalint: oh, that's not the remote I'm using, hmm, did this change?
[15:36] <rbalint> vorlon, if you disclose your current remote i can tell :-)
[15:37] <vorlon> rbalint: my previous remote was git+ssh://git.launchpad.net/~ubuntu-core-dev/+git/systemd
[15:40] <rbalint> vorlon, it seems it moved but you can find the current in Vcs-Git
[15:40] -queuebot:#ubuntu-release- Unapproved: accepted libreoffice [source] (bionic-proposed) [1:6.0.7-0ubuntu0.18.04.7]
[15:41] <vorlon> rbalint: yeah, confirmed
[15:41] <rbalint> vorlon, lp terribly overcomplicated git repository naming and that does not help
[15:41] <vorlon> rbalint: the uris were so similar my eyes skipped over when reading
[15:45] <rbalint> vorlon, in the sru process imo it would be beneficial to check if the changes in unapproved are present in the packaging repository if there is any repo
[15:47] <rbalint> ddstreet, xnox ack-ed my xenial change out of band, feel free to include it in your upload
[15:47] <vorlon> rbalint: I'm not signing up to implement this, or to require additional round trips through the queue in the event that Vcs-* in an SRU contains stale data (and even in this example, systemd gets it wrong because the Vcs-Git doesn't say which is the correct branch).  But anybody could run their own checker against the SRU queue and yell at uploaders :)
[15:50] <rbalint> vorlon, Vcs-Git: https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd -b ubuntu-bionic
[15:50] <vorlon> like so, yes
[15:50] <vorlon> is currently wrong in eoan
[15:51] <rbalint> vorlon, if there is no interest in making having the commits in the repo there is no point in having repos
[15:51] <rbalint> vorlon, because every core dev can happily ignore it
[15:55] <vorlon> rbalint: I am interested, but reject the idea that SRU team be responsible for enforcing this
[15:56] <vorlon> because compliance today is so terrible, including on devel series, and with my SRU team hat on I don't agree to accept the additional workload
[15:56] <rbalint> vorlon, should not they vote or something?
[15:56] <vorlon> I'm happy to put it on the SRU team agenda
[15:57] <vorlon> (done, on agenda for next meeting)
[15:58] <tsimonq2> Well, this could be solved once git-ubuntu has imported all of the repositories and the workflow is moving along with that. pull-lp-source could then yell about that. However, that day is not today.
[15:58] <vorlon> rbalint: next meeting is in 3 weeks, so feel free to not block on SRU team doing this work ;)
[16:00] <rbalint> tsimonq2, it could be solved without git-ubuntu importing anything
[16:01] <tsimonq2> rbalint: Are you proposing a solution that does not require as much manual work as previously implied? :)
[16:03] <rbalint> tsimonq2, Debian has an implementation that works ok https://qa.debian.org/cgi-bin/vcswatch?package=wireshark
[16:03] <rbalint> tsimonq2, i'm not proposing inventing anything
[16:03] <tsimonq2> rbalint: Ahh.
[16:04] <rbasak> rbalint: what I'd like, in the long term, is to add checks for this kind of thing to "git ubuntu lint", and have a bot run that on MPs. Then it'd be minimal effort on both contributors and reviewers. I don't think it's worth imposing further checks now, until something like that is ready.
[16:05] <rbalint> rbasak, having a bot linting .changes in the quenue seem to be a better direction
[16:05] <rbasak> rbalint: example: submit an MP against the systemd git-ubuntu branches, and a bot will relay the lint warning that Vcs-Git appears to be valid, but the MP isn't against that branch.
[16:06] <marcustomlinson> vorlon: just checking you're aware of a libreoffice-l10n package in the queue too?
[16:06] <vorlon> marcustomlinson: I thought I had already accepted the -l10n one last time around
[16:06] <rbalint> rbasak, this is not the problem
[16:06] <vorlon> marcustomlinson: ok reviewing that also, thanks for pointing it out
[16:06] <marcustomlinson> that was the problematic one
[16:07] <rbalint> rbasak, also mps across not official packaging repos is fine
[16:07] <bdmurray> xnox: Were you looking for a "speedy delivery" of lighttpd to -updates?
[16:07] <rbasak> bdmurray: I believe he did, yes, based on earlier conversation here
[16:07] <rbasak> 11:46 <xnox> rbasak:  and yeah, i think so.
[16:07] <rbasak> In response to
[16:07] <rbasak> 11:46 <rbasak> xnox: does this one need a skipping of the ageing period too?
[16:07] <rbalint> rbasak, if there is an mp against the wrong branch it is usually pretty easy to spot
[16:08] <rbalint> rbasak, since the diff is very different
[16:08] <rbasak> rbalint: by "wrong branch" I meant "against git-ubuntu pkg/ubuntu/<foo>-devel" instead of "~ubuntu-core-dev/ubuntu/+source/systemd ubuntu-bionic"
[16:08] <rbasak> That's a case where the diff would be identical.
[16:15] <xnox> bdmurray:  yes can publish lighttpd. i prepared & verfied the sru; rbasak did the code review. i think we should publish the sru, last time i looked there was adt regressions (i retried them) and so far there were no comments from not-me that the update works.
[16:16] <xnox> bdmurray:  well, it's green in bionic now, still one regression in cosmic
[16:17] <rbasak> Perhaps we could wait for one person affected to confirm that the fix works?
[16:17] <bdmurray> xnox, rbasak: the "codepath appears to still be the same-ish" didn't fill me with confidence. You two think its good?
[16:17] <rbasak> bdmurray: the patch looked sane to me, but I didn't code-review in further detail than just examining the diff.
[16:18] <rbasak> I didn't examine to consider edge cases, for example.
[16:18] -queuebot:#ubuntu-release- Unapproved: accepted libreoffice-l10n [source] (bionic-proposed) [1:6.0.7-0ubuntu0.18.04.7]
[16:18] -queuebot:#ubuntu-release- New: accepted linux-signed-gcp [amd64] (disco-proposed) [5.0.0-1010.10]
[16:22] <bdmurray> I'll plan on releasing it later during the day to give some time for more feedback.
[16:31] -queuebot:#ubuntu-release- Unapproved: golang-google-grpc (disco-proposed/universe) [1.6.0-3ubuntu0.19.04.1 => 1.6.0-3ubuntu0.19.04.2] (ubuntu-mate)
[16:34] <tsimonq2> sil2100: ^ you were working on this at one point, sponsored.
[16:38] <xnox> bdmurray:  green in both bionic and cosmic
[16:44] -queuebot:#ubuntu-release- Unapproved: kylin-nm (disco-proposed/universe) [1.0.0-1 => 1.0.0-1ubuntu0.1] (ubuntukylin)
[17:03] -queuebot:#ubuntu-release- Unapproved: rpi.gpio (bionic-proposed/universe) [0.6.3-1ubuntu4 => 0.6.5-1ubuntu0.18.04.1] (no packageset)
[17:38] -queuebot:#ubuntu-release- New binary: linux-signed [amd64] (xenial-proposed/main) [4.4.0-154.181] (core, kernel)
[18:15] -queuebot:#ubuntu-release- Packageset: 73 entries have been added or removed
[18:25] <bdmurray> The release upload queues have a lot of pending diffs, is there something going on with Launchpad?
=== dannf` is now known as dannf
[20:00] -queuebot:#ubuntu-release- New: accepted linux-signed [amd64] (xenial-proposed) [4.4.0-154.181]
[20:58] -queuebot:#ubuntu-release- Unapproved: gnome-settings-daemon (bionic-proposed/main) [3.28.1-0ubuntu1.2 => 3.28.1-0ubuntu1.3] (ubuntu-desktop)
[20:59] -queuebot:#ubuntu-release- Unapproved: livecd-rootfs (xenial-proposed/main) [2.408.49 => 2.408.50] (desktop-core)
[21:00] -queuebot:#ubuntu-release- New binary: linux-signed-azure [amd64] (bionic-proposed/main) [4.18.0-1023.24~18.04.1] (kernel)
[21:01] <cjwatson> bdmurray: the diff queue got stuck on Friday; we unstuck it this morning but it has a huge backlog as a result, which it is continuing to work through
[21:02] <bdmurray> cjwatson: got it, thanks!
[21:02] -queuebot:#ubuntu-release- New: accepted linux-signed-azure [amd64] (bionic-proposed) [4.18.0-1023.24~18.04.1]
[21:02] <cjwatson> I'm afraid I can't easily tell exactly how long the backlog is (need better metrics there), only that it's successfully processing jobs at the moment
[21:18]  * rbasak plugs "git ubuntu queue sync", which for packages in main, allows for "git log -p -1" for a queue diff :)
[21:22] -queuebot:#ubuntu-release- New binary: linux-signed-gcp [amd64] (cosmic-proposed/main) [4.18.0-1015.16] (kernel)
[21:25] -queuebot:#ubuntu-release- New: accepted linux-signed-gcp [amd64] (cosmic-proposed) [4.18.0-1015.16]
[21:53] -queuebot:#ubuntu-release- New binary: linux-signed-gcp [amd64] (xenial-proposed/main) [4.15.0-1036.38~16.04.1] (kernel)
[21:54] -queuebot:#ubuntu-release- New binary: linux-signed-oracle [amd64] (xenial-proposed/main) [4.15.0-1017.19~16.04.2] (kernel)
[21:56] -queuebot:#ubuntu-release- Unapproved: accepted livecd-rootfs [source] (xenial-proposed) [2.408.50]
[21:57] -queuebot:#ubuntu-release- New: accepted linux-signed-gcp [amd64] (xenial-proposed) [4.15.0-1036.38~16.04.1]
[21:57] -queuebot:#ubuntu-release- New: accepted linux-signed-oracle [amd64] (xenial-proposed) [4.15.0-1017.19~16.04.2]
[22:04] -queuebot:#ubuntu-release- Unapproved: accepted gnome-settings-daemon [source] (disco-proposed) [3.32.1-0ubuntu1]
[22:08] -queuebot:#ubuntu-release- New binary: linux-signed-azure [amd64] (disco-proposed/main) [5.0.0-1010.10] (core, kernel)
[22:08] -queuebot:#ubuntu-release- New: accepted linux-signed-azure [amd64] (disco-proposed) [5.0.0-1010.10]
[23:36] -queuebot:#ubuntu-release- Unapproved: accepted neutron [source] (cosmic-proposed) [2:13.0.3-0ubuntu2]
[23:48] -queuebot:#ubuntu-release- Unapproved: accepted systemd [source] (bionic-proposed) [237-3ubuntu10.24]