=== pleia2_ is now known as pleia2
[05:34] <mborzecki> morning
[06:13] <mborzecki> https://github.com/snapcore/snapd/pull/6992 needs a 2nd review and can land
=== morphis16 is now known as morphis
[06:54] <zyga> good morning
[06:54] <zyga> coffee and work
[07:01] <mborzecki> zyga: https://github.com/snapcore/snapd/pull/6992 just needs a 2nd review and we can land it
[07:01] <mborzecki> should be easy, just some test cleanup
=== pstolowski|afk is now known as pstolowski
[07:04] <pstolowski> morning
[07:10] <mborzecki> pstolowski: hey
[07:10] <pstolowski> +1
[07:15] <mborzecki> yay
[07:27] <zyga> mborzecki: looking
[07:27] <zyga> hey pawel :)
[07:27] <zyga> 9:30
[07:27] <zyga> better than yesterday
[07:27] <zyga> 26C and looking great
[07:29] <mborzecki> zyga: nice
[07:30] <mborzecki> zyga: sorry to keep poking you :) https://github.com/snapcore/snapd/pull/6922
[07:30] <zyga> doing now
[07:32] <mborzecki> anyone managed to order pi4 4GB variant?
[07:38] <zyga> mborzecki: I was considering
[07:38] <zyga> but
[07:38] <zyga> mborzecki: here I can get the es keyboard layout (I wanted the desktop kit)
[07:39] <zyga> mborzecki: in poland I can get the .pl keyboard layout
[07:39] <zyga> mborzecki: in both cases I'd have to wait up to a month
[07:39] <zyga> mborzecki: apart from micro-hdmi (WHY!?!) it is ok
[07:39] <zyga> mborzecki: I'd prefer to have 3 usb-c instead
[07:39] <zyga> nobody loves micro hdmi cables
[07:40] <zyga> mborzecki: reviewing, should be done soon
[07:40] <mborzecki> zyga: i checked a couple of places but sold out
[07:40] <zyga> mborzecki: yeah
[07:40] <zyga> they flew from the shelves
[07:40] <zyga> just wait, GBP/PLN is favourable :)
[07:43] <mborzecki> zyga: maybe availability was like amd's vega cards ;)
[07:49] <zyga> mborzecki: at this price point they will fly off any store
[07:50] <zyga> mborzecki: I read a funny tweet yesterday, cannot remember it exactly but it roughly read "how many people will buy it just to put it on the shelf next to older pi's, also unused'
[07:51] <pstolowski> heh, was considering it a few days ago (botland.com.pl). out of stock already
[07:53] <zyga> pstolowski: preorder, they are the only official reseller
[07:53] <zyga> pstolowski: others buy from them
=== abeato_ is now known as abeato
[08:40] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/6922#pullrequestreview-255050272
[08:41] <zyga> mborzecki: I'll task switch to work on the feedback from both you and jstrand
[08:41] <zyga> I think this will land today
[08:42] <mborzecki> zyga: ok, great
[08:44] <mborzecki> zyga: i think i'll leave a todo about preserving file permissions, osutil.CopyFile can do that but in a funny way by calling cp, and while it's ok for a scenario when you build an image, it feels fragile when you update :/
[08:44] <zyga> mborzecki: I think it's not needed now but it'd be worth making this explicit (as in, this is not supported and is documented as such)
[08:45] <mborzecki> zyga: mhm, sounds fair
[08:47] <zyga> mborzecki, pstolowski: desktop set or just bare pi4? (hard questions)
[08:49] <mborzecki> zyga: i'll try getting the regular one, the keyboard/mouse look like toys tbh
[08:50] <zyga> yeah but OMG shiny :)
[08:50] <pstolowski> zyga: bare
[08:50] <mborzecki> zyga: and the desktop set is what $100+? :P
[08:51] <zyga> it's not much, case + psu
[08:51] <zyga> + cables you'd otherwise how to source separately (2$ a piece)
[08:51] <zyga> + keyboard / mouse (with only one usb port)
[09:05] <Chipaca> xnox: 00-ꜱɴᴀᴘᴅ-ᴄᴏɴꜰɪɢ.ʏᴀᴍʟ
[09:11] <valentind> zyga, It is not straight forward to bind mount /usr from the snap application. Snapd bind mounts several things within /usr, but it does it before the layout binding. So those paths disappear. I would need to make a script to generate all the paths to mount in order not to mount over those paths.
[09:11] <zyga> valentind: yeah, mounting all of usr is tricky :/
[09:11] <zyga> valentind: can you help me understand why you'd need that?
[09:12] <zyga> valentind: I assumed that the freedesktop runtime would be much like flatpak runtime model
[09:12] <zyga> valentind: with / being a full read only image (mostly)
[09:12] <zyga> valentind: and /app being the application image
[09:12] <zyga> valentind: with extra places for writable data
[09:12] <valentind> Yes.
[09:12] <zyga> valentind: in this model, can you not keep the runtime as the base snap, with /usr and all the other suspects as-is
[09:12] <valentind> Well, if we cannot run commands from /usr/bin it is annoying.
[09:13] <zyga> valentind: perhaps that's what we should fix, we could change snapd to generate different apparmor template for if the base snap is the freedesktop runtime
[09:13] <valentind> I could also just mount /usr/bin from the app with the files copied from the runtime.
[09:13] <valentind> zyga, Yes, this is what I would like.
[09:13] <valentind> But I do not know how much time it would take to get there.
[09:14] <zyga> valentind: perhaps not that much, can you tell me if what you are missing is simply
[09:14] <zyga> (in apparmor terms)
[09:14] <valentind> I do not mind providing a apparmor template for freedesktop sdk, this is fine.
[09:14] <zyga>  /usr/bin/** ixr,
[09:14] <zyga> perhaps coupled with something similar for /usr/lib
[09:15] <valentind> This would be enough I think.
[09:15] <zyga> I think we can do that then, is there a thread I can reference in the pull request?
[09:15] <valentind> I think we need run only for ld.so, and it is already there.
[09:15] <zyga> valentind: can you make that modification locally?
[09:15] <valentind> Libraries do not need execution otherwise. Just that the dynamic loader can be executed.
[09:15] <valentind> Sure, I can do that.
[09:16] <zyga> valentind: you can install a snap, edit /var/lib/snapd/apparmor/profiles/snap.$SNAP_NAME.$APP_NAME, reload that using apparmor_parser -r /path/to/profile and see if that fixes it
[09:16] <zyga> valentind: once you have the set of changes I can make a quick PR
[09:16] <zyga> thank you!
[09:18] <valentind> Ah libexec as well
[09:18] <zyga> I'm sure there's a small list you can find by iterating
[09:18] <xnox> Chipaca:  ship it!
[09:18] <xnox> Chipaca:  i should totally do that somewhere sometime, as the defualt filename.
[09:20] <valentind> zyga, yes that works. I will check a bit more to see what makes sense to add.
[09:20] <zyga> thanks!
[09:20] <Chipaca> xnox: that's the output of 'unifonter -k k 00-snapd-config.yaml' fwiw
[09:25] <zyga> brb, short walk to the library
[09:25] <zyga> (free wifi, ac and super quiet)
[09:42] <zyga> re
[09:42] <zyga> I forgot how nice this place was
[09:43] <valentind> zyga, I have found few other places than /usr/bin/ and /usr/libexec/ where there are binaries. But I think I will change freedesktop sdk to move them to libexec. Not sure why they are there.
[09:52] <zyga> valentind: what kind of executables were those?
[09:52] <valentind> It is in the library directory.
[09:52] <valentind> They look like libexec things.
[09:57] <zyga> valentind: in /usr/lib?
[09:57] <zyga> valentind: I think it's okay to add to the template instead of changing the base snap too much
[09:57] <valentind> OK, then.
[09:59] <valentind> So yes, {,/usr}/bin/* {,/usr}/libexec/** and {,/usr}/lib/**. Should I make a mr? Or will you take care of that?
[10:04] <zyga> valentind: I can do that
[10:04] <zyga> valentind: I have some ideas where that should be
[10:04] <valentind> OK Great.
[10:31] <Chipaca> could I have a second review of a very very simple but important pr, #7040 ?
[10:31] <Chipaca> https://github.com/snapcore/snapd/pull/7040/files
[10:39] <mborzecki> Chipaca: do you know if we're doing another . release?
[10:45] <zyga> mborzecki: can you do another pass over infofile subset of https://github.com/snapcore/snapd/pull/7026/files
[10:45] <zyga> mborzecki: I will address the remaining comments now
[10:47] <mborzecki> zyga: sure
[10:50] <zyga> I need to take a break, the library is closing soon
[10:50] <zyga> see you soon
[11:06] <wieczorek1990> Can I get any love in the reviews? https://snapcraft.io/gitl
[12:00] <mborzecki> zyga: added some comments about new info scanner
[12:06] <zyga> Thanks
[12:06] <zyga> Resuming work now
[12:09] <wieczorek1990> How often are review-tools updated?
[12:21] <zyga> wieczorek1990: on demand, I think
[12:34] <mborzecki> wieczorek1990: jdstrand likely knows best
[12:37] <zyga> brb for lunch
[12:38] <zyga> wieczorek1990: or roadmr also knows AFAIK
[12:49] <wieczorek1990> mborzecki: jdstrand told me to wait :)
[12:54] <jdstrand> wieczorek1990: the review-tools are updated. roadmr is getting them to production as we speak. it should be soon
[12:54] <wieczorek1990> cool
=== ricab is now known as ricab|lunch
[13:01] <zyga> mborzecki: trying to join standup
[13:23] <jdstrand> wieczorek1990: it seems likes you may have auto-uploads setup for gitl? if so, you may want to pause them for the next day or so until they start passing automated review
[13:24] <wieczorek1990> just let me find that option :)
[13:25] <wieczorek1990> jdstrand: removed from the build list
[13:25] <jdstrand> wieczorek1990: I'll ping you when the tools are in proc then
[13:26] <wieczorek1990> jdstrand: thanks
[13:51] <dot-tobias> Ping kyrofa / sergiusens: https://forum.snapcraft.io/t/cmake-part-with-build-snaps-gets-mangled-include-parameters/ → any quick hint what's going wrong here?
[13:52] <ogra> dot-tobias, what did you break again ?
[13:52] <ogra> :)
[13:55] <dot-tobias> ogra: Just one of my user-errors again, I hope 😄
[13:55] <dot-tobias> Holding It Wrong™
[13:56] <ogra> must be the heat
[13:56] <dot-tobias> most definitely
=== ricab|lunch is now known as ricab
[14:37] <jdstrand> wieczorek1990: ah, the update is in prod now and gitl passes automated reviews :) (see r141). all the other revisions are now being scanned and passing (up to r147 now)
[15:01] <zyga> jdstrand: hello, I sent several updates to https://github.com/snapcore/snapd/pull/7026 -- could you do another pass please
[15:01] <zyga> jdstrand: I'm still doing a few changes to the comments as you suggested but the "essence" of the changes are good now IMO
[15:19] <jdstrand> zyga: ok
[15:34]  * zyga moved closer to home 
[15:38] <jdstrand> Saviq: is is possible to adjust the mirror when using snapcraft with multipass? (maybe that is a question for sergiusens... hi to both of you!)
[15:38] <jdstrand> I'd like to use something other than archive.ubuntu.com
[15:39] <Saviq> jdstrand: not easily with snapcraft, no - it doesn't give you a way to modify the cloud-init
[15:39] <Saviq> today, only option would be to `snapcraft pull` a part, then get into the instance and switch the mirror
[15:40] <Saviq> long-term, we're working on configurable cloud-init defaults in Multipass, which could help with this (although snapcraft provides a cloud-init, I wonder if we should mess with it…)
[15:40] <Saviq> jdstrand: one way or another, yes I'd say it's a sergiusens question :)
[15:41] <Saviq> b/c I'd rather see snapcraft allowing you to specify a mirror rather than you hacking the instances under its feet :)
[15:41] <Saviq> there's also an option of a snapcraft plugin…
[15:42] <Saviq> but you'd need to modify each snapcraft.yaml to make it use the plugni
[15:42] <Saviq> so yeah, I really think this kind of thing would be a snapcraft one :)
[15:45] <ogra> jdstrand, you can easily do that by adding an extra part to your snapcraft.yaml that calls add-apt-repository ... i.e. pilibs here adds a PPA (but any proper deb archive should actually work here), pistream (the part afterwards) then uses a package from there (libraspberrypi-bin) https://github.com/ogra1/picamera-streaming-demo/blob/master/snap/snapcraft.yaml#L37
[15:46] <ogra> that way should work in any build env (multipass, launchpad buildd etc)
[15:48] <ackk> hi, is it possible for a snap to know if it's installed with --devmode?
[15:51] <Chipaca> ackk: what for?
[15:51] <ackk> Chipaca, basically conditional logic in hooks as you can do stuff like chown if in devmode
[15:52] <ogra> given that devmode isnt something you should/would use permanently you should really not do any permanent hacks in your hooks for it
[15:54] <Chipaca> ackk: if you really really need to do this, try snap list $SNAP_INSTANCE_NAME
[15:54] <Chipaca> ackk: if you can do that, you're in devmode*
[15:54] <Chipaca> * or you have snapd-control
[15:55] <ackk> Chipaca, ah, interesting trick :)
[15:55] <ackk> Chipaca, thanks
[15:56] <Chipaca> actually it works also if you have snapd-control :)
[15:56] <Chipaca> because you can't run snap :)
[15:56] <ackk> heh, cool
=== pstolowski is now known as pstolowski|afk
[16:42]  * zyga -> nap
[16:42] <zyga> zzzz
[17:04] <wieczorek1990> https://www.irccloud.com/pastebin/3kyusPpM/
[17:04] <wieczorek1990> So, I've been trying to enable aliases in gitl run using snap, and I'm kind of blocked. Getting this error:
[17:04] <wieczorek1990> error: could not lock file /home/luke/.gitconfig: Permission denied
[17:04] <wieczorek1990> Thought there won't be errors after adding the personal-files interface
[17:04] <wieczorek1990> Here's my snapcraft.yaml: https://github.com/wieczorek1990/gitl/blob/master/snap/snapcraft.yaml
[17:04] <wieczorek1990> Here's the function in git causing problems: https://github.com/git/git/blob/ab15ad1a3b4b04a29415aef8c9afa2f64fc194a2/lockfile.c#L73
[17:04] <wieczorek1990> Any hints?
[17:07] <wieczorek1990> Other thing is that normal aliases don't work, they exit with a message like this:
[17:07] <wieczorek1990> expansion of alias 's' failed: 'status' is not a git command
[17:07] <wieczorek1990> but they work if written as "s = !git status", strange
[17:08] <ogra> did you actually connect the interface ? it surely doesnt automatically connect
[17:09] <wieczorek1990> it's there when I run `snap connections gitl`
[17:10] <ogra> and connected ?
[17:10] <ogra> (did you explicitly run snap connect for it after install)
[17:10] <wieczorek1990> No, I ran install from the store
[17:11] <ogra> yeah, that wont connec it
[17:11] <ogra> you need to explicitly run snap connect <snapname>:<plug>
[17:11] <ogra> (i never used personal-files so i dont know where to you need to connect)
[17:14] <wieczorek1990> connecting did not change a thing
[17:24] <wieczorek1990> Did not expect so much work for deploying app with snap :)
[17:29] <ogra> well, the good thing about snap packaging is that once you figured it out you usually do not need to touch it again
[17:53] <zyga> store is somewhat red
[17:54] <zyga> https://www.irccloud.com/pastebin/YI8ilsRW/
[17:54] <zyga> noise][: ^ https://status.snapcraft.io/ is green, should I see anything ?
[17:56] <noise][> nothing alerting but let me take a look
[17:59] <zyga> it's not all the stuff I do but I've restarted tests over small one-off failures a few times
[18:01] <Paddy_NI> Will the "Gnome Software" ever be gaining support for displaying markdown read from a snap apps description properly?
[18:01] <noise][> zyga: we are seeing some elevated err rates, coinciding with a deploy, investigating and will update status page in a minute
[18:02] <Paddy_NI> Ascii cast and video support would also be awesome
[18:02] <zyga> as always, thank you for keeping the store running :)
[18:13] <noise][> zyga: all fixed now, was 1 bad unit in a pool, monitoring caught it but as a low-prio so nobody had looked at it right away
[18:13] <noise][> we will fix that as well :)
[19:04] <zyga> noise][: super, thank you
=== harrisj_ is now known as harrisj
[20:13] <jdstrand> Saviq: ack, thanks
[20:14] <jdstrand> ogra: thanks. the thing is I want to change the mirror (not a ppa) only for local builds, not LP builds
[20:17] <zyga> jdstrand: https://github.com/snapcore/snapd/pull/7026 is green
[20:17] <zyga> I have some more tests piled up but I'll wait for your review first
[20:17] <zyga> jdstrand: the only significant change I'd like to introduce is to allow to define a memory cap so that unbound input cannot happen
[20:25] <jdstrand> zyga: is that in a subsequent PR or this one?
[21:41] <zyga> jdstrand: perhaps subsequent since this is green now
[21:42] <zyga> jdstrand: or either if you'd like to see that earlier
[21:42] <zyga> jdstrand: I'm mainly trying to be practical and land it soon
[21:43] <jdstrand> zyga: I'd prefer to review 7026 if you're done with it. I think that improvement could come in a subsequent PR (we do control the file after all, so I consider this landable without it (sans my 2nd review))
[21:43] <zyga> jdstrand: +1
[21:43] <zyga> jdstrand: I'm happy with that
[21:44] <jdstrand> zyga: put another way, I didn't want to review it and then have you add more :)
[21:44] <zyga> sure
[21:44] <jdstrand> if we could avoid it (can't always)
[21:44] <jdstrand> ok, so I'll take a look at it after a couple things. might be tomorrow morning
[21:45] <zyga> thank you, I'm heading to bed anywa
[21:45] <zyga> I'll work with maciej to get it re-reviewed
[21:45] <zyga> hopefully it could land tomorrow
[21:45] <jdstrand> zyga: good night! :)
[21:45] <zyga> good night :)