[13:46] <Goneri> hey! could you take a look at: https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/368507
[14:17] <Goneri> and https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/365641 too
[18:30] <FIux> they didn't have ahosman, call me flux'=D
[20:59] <samgilson> hey blackboxsw , did any more conflicts come up in my MP? Just checking in cause I know the next release is coming on Monday.
[21:00] <blackboxsw> samgilson: thanks for the ping. nothing in my mind, I think it looks good and works well. I'll click  approve here, I was waiting to chat with the other upstream devs on Monday to confirm we can pull that into 19.2 release
[21:01] <samgilson> okay perfect! thanks so much for everything.
[21:01] <blackboxsw> samgilson: that MP is marked work in progress. Do you have anything else that you have yet to push?
[21:01] <blackboxsw> if not, I'll set it back to 'Needs review'
[21:01] <samgilson> blackboxsw No I don't have anything left on my side to push.
[21:02] <blackboxsw> ok marking it to make sure we review it before 19.2
[21:02] <blackboxsw> Expectation is Tuesday EOD
[21:02]  * blackboxsw needs to  fix the topic
[21:03] <blackboxsw> marked approved on my side
[21:04] <blackboxsw> will land the branch monday if no other concerns
[21:05] <Odd_Bloke> blackboxsw: Are you not landing it because you want a second review?  If so, gimme a pointer. :)
[21:07] <blackboxsw> Odd_Bloke: excellent, I just wanted a secondary review on that. I covered functionality pretty well there, and I feel like it is in pretty good shape for functionality that is not-risky to cloud-init default logic paths.https://code.launchpad.net/~samgilson/cloud-init/+git/cloud-init/+merge/368943
[21:08] <blackboxsw> new subcommand == low risk in my mind, just wanted to run it by you gents too to see if there was something significant that I missed.
[21:08] <Odd_Bloke> Yeah, I haven't reviewed it fully, but worst case scenario this new command doesn't work.
[21:09] <blackboxsw> Odd_Bloke: right. leaving it unusable for getting 'metrics' for some corner cases.
[21:09] <blackboxsw> but not related to cloud-init config,setup, deployment
[21:10] <Odd_Bloke> But it wouldn't be a regression, right?
[21:10] <blackboxsw> correct
[21:10] <blackboxsw> no regression potentiall
[21:10] <blackboxsw> completely new feature
[21:28] <Odd_Bloke> samgilson: blackboxsw: I haven't done a full review (as my plane meal is being served right now), but I did have some comments that I've posted up.
[21:31] <samgilson87> my client just crashed, but thank you Odd_Bloke, I'll go through those now.
[21:53] <samgilson87> Odd_Bloke I agree with all your changes you put forth and pushed them up to the mp.
[21:56] <Odd_Bloke> samgilson87: Thanks!  Apologies, I wasn't clear, but I did intend my docstring comment to apply to all of the docstrings that could use some extra whitespace.
[21:56] <Odd_Bloke> But once that's done, I think we can land this.
[22:01] <samgilson87> oh okay! I'll propagate that to all the docstrings then re-push
[22:02] <Odd_Bloke> Thank you!
[22:07] <samgilson87> alright, just pushed up those changes.