| tribaal | rharper: addressed doc comments. Thanks for your review. Not sure if I should switch the branch back to "needs review" however? I'll let you do that if necessary (I have lower connectivity this week - I'm abroad). | 08:24 |
|---|---|---|
| rharper | tribaal: replied; we mark branches WIP to avoid re-reviewing something that's pending; so if you've pushed changes up, you can always switch state to Needs Review | 14:25 |
| AnhVoMSFT | rharper what is the best way to update commit's author name without code change? If I do a git rebase -i will launchpad pick it up? | 16:51 |
| AnhVoMSFT | thanks - just updated the author for the MP https://code.launchpad.net/~vtqanh/cloud-init/+git/cloud-init/+merge/369785 | 18:19 |
| rharper | AnhVoMSFT: thanks | 19:25 |
| rharper | Odd_Bloke: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/370213 | 19:25 |
| Odd_Bloke | rharper: +1 on that MP; I couldn't look at test results because I don't have VPN creds on this laptop. | 19:42 |
| rharper | Odd_Bloke: cool, I'm fixing pycodestyle | 19:42 |
| rharper | but otherwise I think it's good to go | 19:42 |
| rharper | unittest verifies the fix | 19:42 |
| Odd_Bloke | Yep, +1 on whatever change you have to make. | 19:42 |
| rharper | cool | 19:43 |
| rharper | thanks | 19:43 |
| Odd_Bloke | rharper: +1 on ephemeral DHCP, want me to Approved it? | 21:44 |
| Odd_Bloke | rharper: I realised you're AFK ATM, so I Approved it. | 22:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!