| anastasiamac | a trivial review plz - https://github.com/juju/juju/pull/10445 | 06:16 |
|---|---|---|
| manadart | Need a review for adding space ID to juju/description: https://github.com/juju/description/pull/56 | 09:28 |
| hpidcock | anastasiamac: looking | 22:29 |
| hpidcock | anastasiamac: LGTM just two small changes please. | 22:41 |
| hpidcock | manadart: LGTM one non-critical comment. | 23:00 |
| anastasiamac | hpidcock: thnx i'll look but it was literary just movinf existing code into callable funcs | 23:01 |
| hpidcock | the comments were on new code from what I could see in the diff. | 23:02 |
| hpidcock | maybe changes from another PR, since we have such a huge backlog | 23:03 |
| anastasiamac | hpidcock: no, all good.. english is improtant and ur commented on my msg modification and var name.. good calls both | 23:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!