| anastasiamac | kelvinliu_: could u PTAL https://github.com/juju/juju/pull/10447 | 01:10 |
|---|---|---|
| anastasiamac | double plz :) | 01:10 |
| kelvinliu_ | yep looking | 01:14 |
| anastasiamac | kelvinliu_: \o/ | 01:14 |
| anastasiamac | kelvinliu_: thnx for review. I've modified upload slightly - if there is no remote cloud, we guide users to add it instead of trying to upload and err... happy with the modification? :D | 03:32 |
| anastasiamac | kelvinliu_: nm | 03:55 |
| manadart | Thanks hpidcock. | 04:01 |
| hpidcock | Np | 04:02 |
| anastasiamac | manadart: the funny thing about .maasrc is that maas team don't have quick reference to its format either :) m waiting for them to find it... :D | 04:03 |
| manadart | anastasiamac: They dev in LP too, which doesn't have the search convenience of GitHub. Could always pull it down I guess... | 04:05 |
| kelvinliu_ | anastasiamac: sorry, just back from lunch. looks good to me. thx | 04:16 |
| anastasiamac | \o/ | 04:17 |
| anastasiamac | a simple, trivial review plz :D https://github.com/juju/juju/pull/10448 | 04:28 |
| hpidcock | anastasiamac: looking | 05:23 |
| hpidcock | anastasiamac: looks great. weird it's formatted as yaml since I'd expect it to be formatted nicer for help output, but it's not json so there is that. | 05:50 |
| hpidcock | I like that it's there though, nice to know what the config I can specify actually is haha | 05:51 |
| === Spads_ is now known as Spads | ||
| stickupkid | hml, Approved https://github.com/juju/juju/pull/10444#pullrequestreview-264229467 | 13:59 |
| hml | stickupkid: ta | 14:00 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!