/srv/irclogs.ubuntu.com/2019/07/24/#snappy.txt

mupPR snapcraft#2638 closed: remote-build rebased on 3.7 <Created by cjp256> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/2638>01:45
=== ogra is now known as Guest89124
mupPR snapd#7149 opened: cmd: add snap model command; daemon: add /v2/model, /v2/model/serial REST APIs <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7149>04:44
=== morphis5 is now known as morphis
mborzeckimorning05:16
mborzeckizyga: mount-ns test failed in pedronis' #7147, i've restarted the job, but in case you want to inspect the log it's here: https://paste.ubuntu.com/p/VYHQhc6zhQ/05:49
mupPR #7147: client,cmd/snap: stop depending on status/status-code in the JSON responses in client <Created by pedronis> <https://github.com/snapcore/snapd/pull/7147>05:49
mborzeckirawhide daily cloud compose doesn't even boot on GCE :/06:14
mborzeckizyga: nvm, i looked at the log and it's /run/netns leaking which should already be fixed in master06:24
zygagood morning06:34
zygamborzecki: I saw a failure last night, something leaks another mounted core06:34
zygalooking at the log now06:35
zygamborzecki: hmm, odd, it is netns06:35
zygaI'll look06:35
mborzeckizyga: btw. that's how rawhide compose boots on GCE: https://paste.ubuntu.com/p/kKMwb6zgFW/06:35
zygamborzecki: quickly :D06:36
mborzeckizyga: haha06:36
zygaI have an idea on how to find broken tests06:41
zygaBut let me get coffee first06:41
zygaWe can use something like HOST.txt to ensure the mount table is not corrupted at each step06:44
zygaI wish diff had a โ€œfirst like differenceโ€ more06:44
zygamode*06:44
* zyga runs a quick test to look for leaky netns06:58
zygahey pedronis, mvo07:02
pedroniszyga: here mount-ns failed: https://api.travis-ci.org/v3/job/562563021/log.txt  need to merge master?07:06
mvohey zyga07:06
zygapedronis: I'm debugging that, I assumed master _was_ merged and that some other test is leaking netns07:06
zygapedronis: which PR is this?07:06
zygapedronis: (that as in I got pinged by mborzecki earlier today and I'm running a scan of all the tests for netns leaking)07:07
pedroniscompletely innocent one, the ones that does make(chan error, 1)07:07
zygaah, I remember it07:07
zygagive me 30 minutes please07:07
pedroniswe have various red (many for different reasons)07:09
zygabrb07:12
zygare07:17
zygahmm, I ran a pass through all tests on Xenial, nothing leaked netns07:45
* zyga checks the logic07:45
zygapedronis: your PR must have the netns unmount patch landed before the mount-ns test landed07:45
zygaso I must be missing something07:46
pedronisI can try to merge master in it again, if that might help07:46
pedroniszyga: another one failed on mount-ns07:47
pedronishttps://api.travis-ci.org/v3/job/562748283/log.txt07:47
pedronisalso recent07:48
zygaoh, that's odd07:49
zygasomething remounted /dev/pts07:49
zygadifferent mode, different gid07:50
zygaoh boy :)07:50
zygaour tests are doing interesting stuff07:50
pedronisI know snap-confine does things with dev/pts07:51
pedronisI don't see it mentioned in the yaml07:51
zyganot on the host07:51
zygathis is the HOST filesystem07:51
zyganothing should change that07:52
mvozyga: 7148 also fails in mount-s07:52
mvozyga: mount-ns with the unified cgroup being "nsdelegate"07:53
zygahmmm, perhaps I should switch it to manual07:53
zygait seems there are lot of tests that leak here and there07:53
zygaand running the test dozens of times before was not enough07:53
zygaideally I'd run a sequence of (a, mount-ns) for a in all tests07:53
mvoand fails on ubuntu-core-16 with a bigger diff07:53
pedronisyea, seems premature to have it on07:54
zygahttps://github.com/snapcore/snapd/pull/715007:57
mupPR #7150: tests: switch mount-ns test to manual <Created by zyga> <https://github.com/snapcore/snapd/pull/7150>07:57
zygaplease merge it07:57
mupPR snapd#7150 opened: tests: switch mount-ns test to manual <Created by zyga> <https://github.com/snapcore/snapd/pull/7150>07:58
mborzeckiat least it's good that we're catching things08:02
ogramvo, pedronis do we have a way to use the force-reboot in snapd for non-snap upgrades ... it just struck me that we allow "snap set system someconfigtxt-option foo" on RPi which should theoretically always use a reboot to make the bootloader config change active08:04
pedronisogra: only upgrades of core or kernels reboot atm08:05
mborzeckijdstrand: worked on the idea from your blog post about preparing images for local spread, came up with this cloud init config https://gist.github.com/bboozzoo/f14302d4fc3418200fe28a2d547d378008:05
ograright, but is it a function that could easily be used here ?08:05
pedronisnot without some thinking/design08:05
pedronisit strange to schedule a reboot from just a set08:06
ograah. k08:06
ograsure, but in this case it is a bootloader config you are changing08:06
zygamvo: you mentioned that Sergio had a branch of spread that can run a sequence without randomised fuss?08:07
pedroniszyga: yes, he spoke about it, you probably can ask him were it lives, don't know if there's PR08:08
pedronisor it's just local to him08:08
Chipacamvo: gentle reminder about #714208:31
mupPR #7142: boot, o/snapst, o/devicest: limit knowledge of boot vars to boot <Created by chipaca> <https://github.com/snapcore/snapd/pull/7142>08:31
Chipacaubuntulog2: ubuntulog3: WAT08:31
zygajamesh: ack, I'll look08:31
mborzeckizyga: finally running the whole suite locally with fedora rawhide image08:31
jameshthanks08:31
zygajamesh: thank you :)08:31
jameshzyga: I've updated the icon theme PR now that EnsureTreeState is merged.  Once it passes CI, it is probably ready for a real review.08:32
zygajamesh: super08:32
zygamvo: https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=snapd :-(08:32
pedronisjamesh: thanks08:33
zygajamesh: I see what happened there, it's my fault, sorry; I'll re-trigger it after the new test is disabled08:33
zygatwo more buggy tests found08:37
mupPR snapd#7151 opened: tests: remove local revision of core <Created by zyga> <https://github.com/snapcore/snapd/pull/7151>08:45
mupPR snapd#7152 opened: tests: unmount leftover /run/netns <Created by zyga> <https://github.com/snapcore/snapd/pull/7152>08:45
zygaChipaca, pedronis: ^ those are the two leakers08:46
* zyga looks for more08:47
mborzeckiehh, why does spread not include -smp <some-reasonable-number> in qemu command line08:59
zygamborzecki: I patched my local build but yeah09:01
zygamborzecki: also "kvm" is a debian specific thing, I don't have it on suse09:01
mborzeckizyga: heh, have a wrapper :P09:01
mupPR snapd#7150 closed: tests: switch mount-ns test to manual <Created by zyga> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/7150>09:55
mupPR snapd#7153 opened: gadget: select the right updater for given structure <Gadget update> <Simple ๐Ÿ˜ƒ> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7153>10:01
zygaChipaca: https://github.com/snapcore/snapd/pull/7151/files updated10:04
mupPR #7151: tests: remove local revision of core <Created by zyga> <https://github.com/snapcore/snapd/pull/7151>10:04
zygafound two more leaky tests10:05
Chipacazyga: what happens if you force the mount-ns test to run after everything else?10:10
zygaChipaca: how do I force it?10:10
zygaChipaca: I didn't try but I'm working around the issue by running a variant of that test in prepare/restore logic10:10
zygait triggers instantly on flaky tests10:10
zygaI'm expanding how much I measure so that I can fix issues one by one rather than see a wall of tests to look at10:11
Chipacazyga: priority: 1 or something?10:11
zygaChipaca: uh?10:11
Chipacaah10:11
zygano idea10:11
Chipacazyga: priority: -10010:11
Chipacazyga: default priority is 010:11
Chipacazyga: bigger numbers โ†’ runs earlier10:11
zygaI can try10:11
Chipacazyga: negative numbers are supported10:11
zygathanks for the idea :)10:12
Chipacathis is backwards from what i'd expect of a priority, but it's documented :-)10:12
Chipacazyga: https://github.com/snapcore/spread/#ordering-tasks10:12
mupPR snapd#7154 opened: packaging/debian-sid: merge debian upload changes back into master <Created by mvo5> <https://github.com/snapcore/snapd/pull/7154>10:16
mupPR snapcraft#2637 closed: unit tests: make lifecycle tests more robust <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2637>10:28
mupPR snapd#7152 closed: tests: unmount leftover /run/netns <Created by zyga> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7152>10:30
mupPR snapcraft#2539 closed: errors: Add InvalidAppCommand errors for non-existent and not-found <Created by clobrano> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2539>10:31
clobrano\0/10:32
mborzeckihm gadget updates is down to 2-3 patches at most now (not counting snap-image)11:07
mupPR snapd#7155 opened: tests: remove locally installed core in more tests <Created by zyga> <https://github.com/snapcore/snapd/pull/7155>11:09
mborzeckipedronis: https://github.com/snapcore/snapd/pull/7147 is green, merge?11:15
mupPR #7147: client,cmd/snap: stop depending on status/status-code in the JSON responses in client <Created by pedronis> <https://github.com/snapcore/snapd/pull/7147>11:15
pedronismborzecki: yes, please11:16
mupPR snapd#7147 closed: client,cmd/snap: stop depending on status/status-code in the JSON responses in client <Created by pedronis> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7147>11:16
pedronisthx11:25
Chipaca1hr18min travis run11:26
Chipacago, worker, go!11:26
* Chipaca โ‡ lunch11:26
mborzeckianyone seen this? https://paste.ubuntu.com/p/4KyGXgvXpy/ initialize-device failing on f31 in some weird way12:06
ograwhy would f31 (assuming classic) do initialize-device at all ?12:08
pedronisogra: ?12:08
ograisnt that a core thing ?12:09
pedronisno, it's classic too12:09
ograoh, i'm mixing it up ...12:09
ograsorry12:09
pedronisboth seeding and registration exist both on classic and core12:09
ograyeah12:10
zygamborzecki, pedronis: is that sensitive to gpg on the system?12:13
mupPR snapcraft#2639 opened: deprecations: add deprecation notice for version-script (dn10) <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2639>12:13
pedroniszyga: no, we don't use gpg on prod system, only the development tooling12:14
pedronisuses it12:14
pedroniswe use ssh-keygen though12:14
pedronisI think12:14
zygaaha12:15
pedronisa 2nd review of #7128 would be great (it's small but might need somebody that looked at remodeling code before)12:17
mupPR #7128: overlord: DeviceCtx must find the remodel context for a remodel change <Remodel :train:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/7128>12:17
mupPR # closed: snapd#7142, snapd#7143, snapd#7145, snapd#714812:24
mupPR snapcraft#2640 opened: cli: improve help for push-metadata <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2640>12:31
mupPR snapcraft#2641 opened: ant plugin: correct default channel and improve help <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2641>12:34
ijohnsonpedronis: thanks for the review on 714912:53
=== alan_g_ is now known as alan_g
ijohnsonpedronis: do you have any recommendations on how to test actually remodelling? is there an easy way to do so on classic, or should I build my own core image with a self signed model assertion and then update the model assertion?12:54
pedronisijohnson: it's complicated in both cases, we don't let remodel devices that don't have a serial12:55
pedroniswell that might be overstating it, but interesting kind of remodeling probably don't work or shouldn't without a serial12:57
pedronisijohnson: btw regarding output of snap commands, Chipaca is probably the best person to discuss things with13:01
pedronis(related to my yaml-like output comments)13:01
ijohnsonack, thanks13:01
jdstrandmvo: hey, could you (assign someone to?) respond to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=93281513:04
jdstrandnot sure why buster wasn't updated for a newer snapd 2.38 and don't know the plans, otherwise I would've13:04
jdstrands/a newer/the newer/13:04
Chipacamvo: btw, wdyt? https://bugs.launchpad.net/snapd/+bug/183746013:09
Chipacamvo: (post-standup)13:09
mupBug #1837460: snap refresh slows down computer dramatically <snapd:New> <https://launchpad.net/bugs/1837460>13:09
jdstrandackk: I haven't circled back around to https://launchpad.net/bugs/1831473, but should today13:11
mupBug #1831473: Can't run /usr/bin/systemd-detect-virt from inside snap <maas> <snapd:New for jdstrand> <https://launchpad.net/bugs/1831473>13:12
ackkjdstrand, hi, thanks!13:12
ackkjdstrand, btw is there a way to strace a process run from a "snap run --shell" ?13:13
ackkjdstrand, I've resorted to creating a shell script that basically prints the pid, calls "read" and then execs the actual command, so I can attach with strace, but it's a bit cluncky :)13:13
Chipacaackk: no13:19
Chipacaackk: because by the time you're in the shell inside you can't strace13:19
mupPR snapd#7154 closed: packaging/debian-sid: merge debian upload changes back into master <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7154>13:26
mvojdstrand: I uploaded 2.40 to unstable now13:41
mvojdstrand: but that does not help, does it?13:41
mvoChipaca: oh, interessting13:42
mupPR snapd#7156 opened: packaging/debian: use correct version for apparmor Depends <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7156>13:42
mupPR snapd#7156 closed: packaging/debian: use correct version for apparmor Depends <Created by jdstrand> <Closed by jdstrand> <https://github.com/snapcore/snapd/pull/7156>13:47
jdstrandmvo: it doesn't help buster, no13:51
mupPR snapd#7157 opened: packaging/debian-sid: use correct apparmor Depends for Debian <Simple ๐Ÿ˜ƒ> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7157>13:51
jdstrandmvo: fyi, https://github.com/snapcore/snapd/pull/715713:51
mupPR #7157: packaging/debian-sid: use correct apparmor Depends for Debian <Simple ๐Ÿ˜ƒ> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/7157>13:51
zygabrb13:51
jdstrandmvo: (unrelated to that Debian bug. just something I noticed was incorrect13:52
jdstrand)13:52
mvojdstrand: nice13:52
cachiozyga to use the spread I sent you just use13:53
cachiodo -> spread -order <test list>13:54
cachiothis will execute the tests following the order in the order list13:54
cachioalso you should use -workers 113:54
cachiothis will make to use 1 worker so you don't need to update hte spread.yaml13:55
cachioplease, tell me if you have any problem13:55
ackkChipaca, I see so I guess the script trick is the only way13:59
zygare14:07
zygacachio: thanks! is your patch close to being merged usptream?14:07
cachiozyga, no14:07
zygaoh, why not?14:08
cachiozyga, need reviews14:08
cachiothere are 2 PR related to this14:08
zygaunderstood14:08
cachio1 for the order14:08
cachio1 for setting the number of workers14:08
cachioalso you can use -show-output if you want to see the output on real time14:09
cachiozyga, once we are able to run spread tests on google on any PR it will be really easy to add tests for all these features and make sure they work well14:10
zygacachio: ping us for reviews14:11
zygaI'm sure both me and mborzecki would happily review that14:11
cachiozyga, ok, once I add the tests for validating those features I'll ping you for a review for sure14:12
cachiomvo, any news about the spread tests on gce?14:12
cachiois the key enabled?14:12
* zyga takes a break while tests run14:22
mupPR snapd#7088 closed: tests: manually stop the gvfsd-metadata process <Created by sergiocazzolato> <Closed by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7088>14:25
mborzeckizyga: running test 72/35314:28
zyga7/35014:31
ogra=0.0214:34
mupPR snapd#7146 closed: UC20: cmd/snap-verify: sketch of snap-verify <Created by pedronis> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/7146>15:17
mupPR snapd#7146 opened: UC20: cmd/snap-verify: sketch of snap-verify <Created by pedronis> <https://github.com/snapcore/snapd/pull/7146>15:23
Chipacadid we ever get back to #667915:24
Chipaca?15:24
mupPR #6679: many: implement user removal <Created by cmatsuoka> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/6679>15:24
mupPR snapd#7158 opened: tests: part5 making tests work on ubuntu-core-18 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7158>15:29
* cachio lunch15:30
ograARGH !15:48
ograso multipass eats 100% CPU after a reboot of my laptop ... since i dont use it anyway (i did a few times though and there are a few GB of images apparently) i thought i'D remove it ...15:48
ograogra@acheron:~$ snap remove multipass15:49
ograSave data of snap "multipass" in automatic snapshot set #1                                                    \error: cannot perform the following tasks:15:49
ogra- Save data of snap "multipass" in automatic snapshot set #1 (tar failed: context canceled)15:49
ograogra@acheron:~$ snap remove --purge multipass15:49
ograerror: unknown flag `purge'15:49
ogra(indeed i ctrl-C'ed the first command)15:49
ograhow do i proceed to get it gone ?15:49
cmatsuokaChipaca: not yet, it was preempted by core2016:09
ijohnsonogra: refresh core snap to edge16:10
ijohnsonthen you have --purge16:10
ijohnsonotherwise you can set the core config option to never save snapshots16:10
ijohnsonsnap set system snapshots.automatic.retention=no16:11
ograijohnson, ah, thanks ...16:13
* ogra does the latter16:14
* zyga runs some more tests with more checks 16:25
* zyga is upset a bit 17:11
zygachecking again17:11
mupPR snapcraft#2642 opened: remote-build: detect early build errors <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2642>17:11
zygayess17:59
zygafinally17:59
mupPR snapd#7157 closed: packaging/debian-sid: use correct apparmor Depends for Debian <Simple ๐Ÿ˜ƒ> <Created by jdstrand> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7157>18:00
zygamborzecki: making good progress here :)18:40
zygamborzecki: cannot wait to see this pass everything18:41
mborzeckizyga: hm? hm?18:41
zygamborzecki: iterating on the dirty test detector, got it in the right spot now, fixing tests as I go :)18:41
zygamborzecki: even the diff it produces is super readable18:41
mborzeckizyga: aah18:41
mborzeckizyga: btw. looking at spread logs, lxd seems to have problems with cgroupsv218:42
zygamborzecki: would be worth asking stgraber18:43
mborzeckizyga: https://paste.ubuntu.com/p/Cz7qszmxPD/18:44
zygaIO error18:45
zygacould be anything18:45
zygabut yeah, worth looking18:45
cachiozyga, hey, do you know any way to do iptables on core?18:52
cachiois there a snap for that?18:52
zygacachio: I don't know, perhap with one of the newer tools18:52
zygabut I haven't used any for a very long time18:52
zyganftables? not sure18:53
cachiozyga, I'll try that18:54
cachiothanks18:54
mupPR snapcraft#2641 closed: ant plugin: correct default channel and improve help <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2641>18:59
mvocyphermox:  quick question about "semaphoreci", I pushed pr#93 to netplan but it needs a new build-dependency - can I add this somehow myself (i.e. is there something equivalent to .travis.yml)20:00
mupPR snapcraft#2640 closed: cli: improve help for push-metadata <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2640>20:17
zyga419/42620:50
zygaall passed20:50
* zyga tweaks the detector to be more strict and re-runs20:54
zygaI think now all tests are 100% good in not leaking mounts20:54
zygabut we'll see20:54
mupPR snapd#7159 opened: tests: add functions to make an abstraction for the snaps <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7159>21:21
mupPR snapcraft#2643 opened: project, cli: clean up snap asset messages <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2643>22:51

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!