| wallyworld | kelvinliu: hpidcock: did you guys have time to talk now? or when would be convenient? | 04:32 |
|---|---|---|
| hpidcock | free now | 04:32 |
| wallyworld | ok, let's join standup | 04:33 |
| kelvinliu | yep, just finished lunch | 04:36 |
| hpidcock | wallyworld: https://github.com/juju/cmd/pull/63 the PR I was mentioning in our meeting, so whenever you feel like looking at a PR | 07:23 |
| achilleasa | jam: I discovered a small bug in my bundle-split implementation. Can you please take a look at https://github.com/juju/charm/pull/286? | 09:13 |
| jam | achilleasa: in your example, 'wordpress' is nested under mysql, what does that actually mean? | 09:15 |
| jam | achilleasa: is it just a typo in the example? | 09:15 |
| achilleasa | jam: ah crap. sorry, bad copy paste; should be a sibling of mysql | 09:15 |
| jam | achilleasa: right so the issue is that a sibling that didn't otherwise need anything would cause us to retain the key but it shows up as a 'delete' | 09:18 |
| achilleasa | jam: exactly | 09:19 |
| achilleasa | Looks like omitempty does not properly translate to individual map values | 09:19 |
| jam | achilleasa: why use '== true' isn't that implied by just '&& value' ? | 09:20 |
| achilleasa | jam: oops, you are right! Let me fix that | 09:21 |
| achilleasa | jam: btw, since you are checking this PR would you mind also taking a quick look at one more charm-related? https://github.com/juju/charm/pull/287 | 09:25 |
| stickupkid | CR any body : https://github.com/juju/python-libjuju/pull/326 | 10:51 |
| stickupkid | This pylibjuju change doesn't require the writing of the definitions, but I suspect consuming does :| | 10:52 |
| achilleasa | jam: I have addressed your question for 286; can you take a look? | 11:28 |
| jam | achilleasa: so what I don't understand is why "dropping" the object is accomplished by setting it | 11:33 |
| jam | achilleasa: I would have thought we would call Delete or *not* called Set to copy the value | 11:33 |
| achilleasa | jam: ah. The reflect package does not provide the means to delete keys from a map. The way to delete things off a map (I have added a comment to the overlay code about this peculiarity) is to set the key to an 'empty' reflect.Value | 11:34 |
| achilleasa | s/empty/zero/ | 11:36 |
| jam | lgtm | 11:37 |
| === narindergupta is now known as narinderguptamac | ||
| wallyworld | babbageclunk: did you have time to talk about app relation data? | 22:37 |
| babbageclunk | sure sure | 22:37 |
| babbageclunk | wallyworld: in standup? | 22:38 |
| thumper | I need some review on this https://github.com/juju/juju/pull/10463 | 23:37 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!