[03:21] <mup> PR snapcraft#2642 closed: remote-build: detect early build errors <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2642>
[05:20] <mborzecki> morning
[05:50] <zyga> Hey mborzecki
[05:50] <mborzecki> zyga: hey hey
[05:51] <zyga> Check out https://github.com/snapcore/snapd/pull/7172
[05:51] <zyga> Magic :-)
[05:51] <mup> PR #7172: tests: work around classic snap affecting the host <Created by zyga> <https://github.com/snapcore/snapd/pull/7172>
[05:51] <mborzecki> zyga: looking
[05:56] <zyga> Interesting behavior
[05:59] <mborzecki> zyga: it'd be nice to pinpoint the reason
[05:59] <zyga> As soon as I get to the office
[06:00] <zyga> I spoke with Jamie and we have some ideas
[06:16] <zyga> hmmm
[06:16] <zyga> "newinstance" literally does nothing at all
[06:17] <zyga> eedf265aa003b4781de24cfed40a655a664457e6
[06:17] <zyga> devpts: Make each mount of devpts an independent filesystem.
[06:17] <zyga> this option is from 2016
[06:17] <zyga> it seems that before devpts was really magically shared no matter where it is mounted
[06:19] <zyga> mborzecki: so the working theory is gone
[06:20] <mborzecki> zyga: hah :P
[06:24] <zyga> mborzecki: something like this:
[06:24] <zyga> https://www.irccloud.com/pastebin/JdL7fdQS/
[06:27] <mborzecki> zyga: we know it'll happen each time you run classic snap though? so it might be better to error when it does not, in case it's a regression or sth
[06:27] <zyga> so you want more tests to fail? :)
[06:28] <zyga> I'm happy if whoever fixes this adjusts workaround
[06:34] <mborzecki> zyga: more like a failure accounted for :P but not a blocker
[06:34] <mborzecki> zyga: let me +1 it
[06:34] <zyga> I'm testing the change
[06:34] <zyga> hey mvo
[06:35] <zyga> mborzecki: I'll likely fix the original issue and adjust this test if that makes you feel better
[06:35] <mborzecki> zyga: so classic snap mounts it's own devpts then?
[06:36] <zyga> mborzecki: don't even get me started, that code is horrid
[06:36] <zyga> yes
[06:36] <zyga> let me show you
[06:36] <mvo> zyga: hey, good morning
[06:36] <mborzecki> haha
[06:36] <mvo> and hey mborzecki
[06:36] <zyga> https://github.com/snapcore/classic-snap/blob/master/bin/classic#L67
[06:37] <mborzecki> feel sorry for whoever will have to explain all meanings of classic
[06:37] <zyga> mborzecki: it uses systemd-run
[06:37] <zyga> mborzecki: so, presumably, that's running on the host, right?
[06:37] <zyga> it's a init-spawned service?
[06:37] <zyga> mborzecki: what is curious
[06:38] <zyga> if you experiment on your machine
[06:38] <zyga> is that there's only one /dev/pts mounted
[06:38] <zyga> it seems that whatever the kernel did affects the existing /dev/pts, not a newly mounted one
[06:38] <zyga> it's not a new mount, it seems
[06:39] <mborzecki> zyga: --scope makes the process a child of systemd-run
[06:40] <zyga> mborzecki: do you know if systemd-run does reparenting to the initial mount namespace?
[06:40] <zyga> I'll experiment some more in a moment, just need to get breakfast and take the dog out
[06:40] <zyga> mborzecki: classic is not loved much, though
[06:40] <zyga> that script cries for fixes
[06:40] <zyga> even shellcheck pass
[06:42] <mborzecki> zyga: perhaps if it's a normal unit, it wouldn't make sense with --scope
[06:43] <zyga> mborzecki: pushed a small update
[06:43] <zyga> mvo: wanna review this craze?
[06:44] <mvo> zyga: sure
[06:45] <zyga> https://github.com/snapcore/snapd/pull/7172
[06:45] <mup> PR #7172: tests: work around classic snap affecting the host <Created by zyga> <https://github.com/snapcore/snapd/pull/7172>
[06:45] <zyga> thank you!
[06:45] <mborzecki> mvo: morning :)
[06:50] <zyga> mborzecki: on the up side, we now found this :)
[06:50] <zyga> I have more coming, core is a bug rich environment
[06:58] <zyga> guys, just a heads up
[06:58] <zyga> I noticed some unit tests hang
[06:58] <zyga> we may have a racy deadlock or something like that
[06:58] <zyga> I restarted about half a dozen tests like that yesterday
[07:03]  * zyga spawns more tests and goes for a break
[07:03] <zyga> I work way too long lately, need to take a walk and have breakfast
[07:53] <zyga> back
[07:53] <zyga> no breakfast yet but I feel much better
[07:53] <zyga> walk + shower :)
[07:55] <mup> PR snapd#7172 closed: tests: work around classic snap affecting the host <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7172>
[08:04] <zyga> mvo: did you see the python-apt + snapd build regression?
[08:04] <zyga> https://www.irccloud.com/pastebin/AcGQjDFA/
[08:05] <zyga> it was reported by Dimitri
[08:06] <abeato> zyga, hey, was testing the change to mount /lib/firmware, but it is not happening for me - besides bind-mounting snap-confine, is there anything else I should consider?
[08:13] <abeato> zyga, nm, reinstalling the snap made the trick (plus reloading the snap-confine apparmor profile)
[08:15] <mvo> zyga: looking
[08:28] <Chipaca> mo'in, mo'in
[08:31] <zyga> abeato: Due to the place where this change happens it requires the namespace to be discarded
[08:31] <zyga> Hey Chipaca
[08:55] <mvo> zyga: this looks like a bug in python-apt in eoan
[09:09] <zyga> re
[09:09]  * zyga made a coffee
[09:13] <mvo> juliank: hey, do you already know about https://paste.ubuntu.com/p/DH8YZj8Gfd/ in python-apt 1.9 - fetch_source (and probably fetch_binary) is unhappy. I can try to look into it later today if you are busy
[09:25]  * zyga chases another issue in core tests
[09:26] <zyga> on the up side, fewer things fail now, it takes a while to get to a broken one
[09:26] <mvo> zyga: nice
[09:27] <zyga> mvo: little by little, it's not green yet though
[09:35] <mup> PR snapd#7167 closed: cmd/Makefile.am: support building with the go snap <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7167>
[09:36] <zyga> brb, need to help my wife
[09:45] <zyga> re
[09:56] <mup> PR snapd#7173 opened: Support Tegra display drivers in x11/opengl interfaces <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/7173>
[10:02] <ogra> ogra@acheron:~/Devel/branches/snapd:master$ git pull
[10:02] <ogra> ...
[10:02] <ogra> 1578 files changed, 153607 insertions(+), 22623 deletions(-)
[10:02] <ogra> ...
[10:02] <ogra> hmm, i should perhaps do that more often ...
[10:03] <zyga> abeato: reviewed
[10:03] <zyga> ogra: wow
[10:03]  * zyga fixed another core test bug
[10:06] <abeato> zyga, thanks
[10:24] <mup> PR snapd#7174 opened: allow setting start_x=1 which enables the CSI interface for the RPi c… <Created by ogra1> <https://github.com/snapcore/snapd/pull/7174>
[10:26] <ogra> thanks zyga
[10:27] <zyga> thank you ogra
[10:28] <Chipaca> hm, what's even the purpose of snap.PlaceInfo
[10:56] <zyga> Chipaca: there must be a place for it
[10:56]  * zyga hides
[11:01] <mborzecki> hehe
[11:04] <mborzecki> ogra: hmm  ogra@ubuntu.com (https://api.launchpad.net/1.0/~ogra) has NOT signed the CLA
[11:04] <mborzecki> our CLA checker going bonkers?
[11:05] <mborzecki> Chipaca: do you have any clue what could be happening here? ^^
[11:06] <Chipaca> wat
[11:06] <Chipaca> mborzecki: dunno. Is there a commit by ogra in the PR in question?
[11:07] <mborzecki> Chipaca: yup, From: Oliver Grawert <ogra@ubuntu.com> checks out
[11:08] <Chipaca> mborzecki: hadn't we landed a change to make it pull the whole repo?
[11:08] <Chipaca> mborzecki: i can't see it in the .travis.yml though
[11:09] <Chipaca> mborzecki: there should be a git: depth: false in the CLA section
[11:09] <mborzecki> Chipaca: it was reverted apparently
[11:10] <Chipaca> mborzecki: anyway, that would/should fix it :-/
[11:22] <juliank> mvo: yes I have a fix in progress
[11:23] <juliank> Both hardcoded md5 so kind of good they broke
[11:39] <ogra> mborzecki, Chipaca, sorry, was melting^Wlunching ... do i need to do anything ?
[11:39] <Chipaca> ogra: sweat
[11:39] <ogra> at yur command !
[11:39] <ogra> *your
[11:39] <Chipaca> 'yur' worked well in context
[11:40] <Chipaca> ogra: I don't think you need to do anything, no
[11:40] <ogra> ok
[11:40] <Chipaca> ogra: the CLA checker has a bunch of heuristics to work around the fact that we can't ask launchpad for all your emails :-)
[11:40] <Chipaca> ogra: nor can we ask it about your group membership
[11:40] <Chipaca> bah
[11:41] <Chipaca> we can't ask it whether you're a member of a private team
[11:41] <ogra> geez ... how silly ... given you could screen-scrape them from my LP page
[11:41] <Chipaca> ogra: no you can't
[11:41] <Chipaca> that's the point :-)
[11:41] <ogra> ah, right, private
[11:41] <ogra> silly security !
[11:41] <ogra> always in the way
[11:56]  * zyga chases systemd/snapd mount bug :/
[11:56] <zyga> man that test is very har
[11:56] <zyga> dd
[11:58] <zyga> google:ubuntu-core-16-64:tests/main/ubuntu-core-gadget-config-defaults:ssh_common
[11:58] <zyga> this test is leaking a mount for a test snap
[11:58] <zyga> the test snap cannot be removed (gadget requirement)
[11:58] <zyga> the code hand crafts the removal
[11:58] <zyga> but the removal depends on the mount unit being okay
[11:58] <zyga> but it isnt
[11:58] <zyga> daemon-reload just a moment before _probably_ corrupts systemd state
[11:59] <zyga> I'm debugging but iteration is slow
[12:19] <mvo> juliank: thanks!
[12:20] <mvo> Chipaca: if ogra  signes with @canonical.com things are fine, no?
[12:21] <Chipaca> mvo: yes
[12:21] <Chipaca> mvo: or @mozilla.com :-)
[12:21] <Chipaca> mvo: or if he signs the CLA
[12:21] <Chipaca> s/signs/commits/
[12:22] <Chipaca> mvo: or with an email address in the commit history
[12:22] <Chipaca> mvo: the latter is already done, so it should work if it doesn't do --depth=50
[12:40] <zyga> DOH
[12:40] <zyga> man
[12:40] <zyga> that's sooooo frustrating
[12:40] <zyga> solved the bug
[12:41] <zyga> mvo, mborzecki: can we use systemd-escape in all tests or is it absent in 14.04?
[12:41] <mborzecki> zyga: don't remember
[12:42] <mborzecki> wow, it's standup coffee time
[12:44] <mup> PR snapd#7175 opened: gadget: effective structure role fallback, extra tests <Gadget update> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7175>
[12:46] <zyga> fun bug
[12:47] <zyga> and there are more of it!
[12:50] <zyga> running again
[12:50] <zyga> :)
[12:57] <zyga> https://github.com/snapcore/snapd/pull/7176
[12:57] <zyga> mborzecki, Chipaca: ^
[12:57] <mup> PR #7176: tests: correctly escape mount unit path <Created by zyga> <https://github.com/snapcore/snapd/pull/7176>
[12:58] <mup> PR snapd#7176 opened: tests: correctly escape mount unit path <Created by zyga> <https://github.com/snapcore/snapd/pull/7176>
[12:58] <zyga> though I think I've missed a nice pun chance there
[12:59] <zyga> better now
[12:59] <zyga> :D
[13:06] <diddledan> @popey you're better at words - can you try to explain what I failed to please?: https://forum.snapcraft.io/t/vlc-cve-a-good-oportunity-for-snappy/12440
[13:07]  * popey_ looks
[13:07] <diddledan> thanks :-)
[13:08] <ogra> note that this CVE is also very controversial ... vlc denies it is their issue blaming it on a distro lib)
[13:08] <diddledan> even more reason to steer clear :-)
[13:16] <ogra> mvo, have you seen last nights discussion about classic snap vs using lxd ? i wonder if we should sunset classic for core18 and onwards and point people to use lxd containers
[13:16]  * ogra must admit he hasnt used classic in ages ... 
[13:23] <mvo> ogra: I did not see that but it sounds great, I think lxd is really the better choice in many ways, only for real corner cases (like low level hw access) the real one might be needed
[13:24] <ogra> yeah and there you could simply download an ubuntu-base tarball and chroot
[13:24] <zyga> 180/277 core tests passed without leaking any mount entries
[13:27] <zyga> doh - I take that back
[13:27] <zyga> wrong branch :D
[13:37] <zyga> mvo: I didn't want to take more time at the standup but we have one more general issue
[13:37] <zyga> mvo: some snaps leave stuff on the system when we "remove" them
[13:37] <zyga> classic is one
[13:37] <zyga> lxd is another
[13:37] <zyga> I'll file a bug on lxd to make sure this is tracked
[13:46] <mvo> zyga: ok
[13:47] <zyga> mborzecki, mvo: https://github.com/snapcore/snapd/pull/7177
[13:47] <zyga> another simple one
[13:47] <mup> PR #7177: tests: remove test-snapd-curl <Created by zyga> <https://github.com/snapcore/snapd/pull/7177>
[13:48] <mup> PR snapd#7177 opened: tests: remove test-snapd-curl <Created by zyga> <https://github.com/snapcore/snapd/pull/7177>
[13:51] <zyga> sorry, force pushed because there are two tests like that
[13:52] <zyga> I'll dust my cleanup-tool patch
[13:52] <zyga> this will be the biggest win for reliability and speed
[13:52] <zyga> test prepare/restore won't be this "magic" anymore
[14:07] <mup> PR snapd#7178 opened: tests: remove test-snapd-snapctl-core18 in restore <Created by zyga> <https://github.com/snapcore/snapd/pull/7178>
[14:07] <mup> PR snapd#7179 opened: tests: remove installed test snap <Created by zyga> <https://github.com/snapcore/snapd/pull/7179>
[14:07] <mup> PR snapd#7180 opened: tests: remove installed snap in the restore section <Created by zyga> <https://github.com/snapcore/snapd/pull/7180>
[14:37] <zyga> cachio: https://github.com/snapcore/snapd/pull/7171#pullrequestreview-267225535
[14:37] <mup> PR #7171: tests: improve how the system is restored when the upgrade-from-2.15 test fails <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7171>
[14:39]  * zyga runs another pass
[14:39] <zyga> and spawns core18 to see what happens there
[14:39] <zyga> next up pass on more than main suite
[14:39] <zyga> I will land the test fix PRs when they become green
[14:39] <cachio> zyga, thanks
[14:41]  * zyga takes a break for an hour
[14:44] <zyga> ogra: what's up with the CLA test?
[14:47] <ogra> zyga, dunno, Chipaca said i dont need to do anything (i asked above)
[14:47] <Chipaca> is this happening in one PR, or everywhere?
[14:48] <Chipaca> zyga: ^?
[14:52] <juliank> Setting up snapd (2.39.2+18.04) ...
[14:52] <juliank> Installing new version of config file /etc/apparmor.d/usr.lib.snapd.snap-confine.real ...
[14:52] <juliank> md5sum: /etc/apparmor.d/usr.lib.snapd.snap-confine: No such file or directory
[14:52] <juliank> ^ don't like that
[14:52] <zyga> juliank: oh? where is that coming from
[14:52] <zyga> perhaps the dpkg conffile helpers?
[14:52] <zyga> mvo: ^ help
[14:53] <juliank> I just upgraded: Unpacking snapd (2.39.2+18.04) over (2.38+18.04) ...
[14:53] <zyga> Chipaca: in one PR
[14:53] <zyga> juliank: looks like a bug, let me look
[14:53] <Chipaca> zyga: that pr (or another one that lands and then is merged) needs to update .travis.yml
[14:54] <zyga> juliank: I see it, let me fix that for the next update
[14:54] <zyga> Chipaca: what needs to happen in travis.yml?
[14:54] <juliank> ah md5sum /etc/apparmor.d/usr.lib.snapd.snap-confine is just hardcoded in an upgrade check w/o checking if the file exists
 mborzecki: there should be a git: depth: false in the CLA section
[14:54] <Chipaca> zyga: ^
[14:54] <juliank> though there is a 2>/dev/null redirect
[14:54] <juliank> but at the wrong part of the pipe :D
[14:54] <juliank> md5sum /etc/apparmor.d/usr.lib.snapd.snap-confine | cut -f1 -d' ' 2>/dev/null
[14:55] <zyga> juliank: the redirect is on cut, I think
[14:55] <juliank> should be
[14:55] <zyga> yeah
[14:55] <juliank> md5sum /etc/apparmor.d/usr.lib.snapd.snap-confine 2>/dev/null | cut -f1 -d' '
[14:55] <zyga> -        if test "$(md5sum /etc/apparmor.d/usr.lib.snapd.snap-confine | cut -f1 -d' ' 2>/dev/null)" = "2a38d40fe662f46fedd0aefbe78f23e9"; then
[14:55] <zyga> +        if test -f /etc/apparmor.d/usr.lib.snapd.snap-confine && test "$(md5sum /etc/apparmor.d/usr.lib.snapd.snap-confine | cut -f1 -d' ')" = "2a38d40fe662f46fedd0aefbe78f23e9"; then
[14:55] <zyga> or like this
[14:55] <zyga> a bit more verbose but perhaps more to the point
[14:56] <zyga> right?
[14:56] <juliank> yeah
[14:56] <zyga> I'll send a PR
[14:56] <zyga> thanks for reporting this
[14:59] <zyga> mvo: https://github.com/snapcore/snapd/pull/7181
[14:59] <zyga> before you leave please
[14:59] <mup> PR #7181: packaging/debian: don't md5sum absent files <Created by zyga> <https://github.com/snapcore/snapd/pull/7181>
[14:59] <zyga> juliank: ^
[14:59] <juliank> thanks zyga
[14:59] <mup> PR snapd#7181 opened: packaging/debian: don't md5sum absent files <Created by zyga> <https://github.com/snapcore/snapd/pull/7181>
[14:59] <zyga> core16 main is clean, running all suite now
[15:00]  * cachio lunch
[15:00] <zyga> core18 looks ok after 50% of the pass
[15:00] <zyga> I think that's all of them :)
[15:05] <mup> Bug #1838040 opened: delete user data thunderbird <Snappy:New> <https://launchpad.net/bugs/1838040>
[15:14] <mup> Bug #1838040 changed: delete user data thunderbird <Snappy:Invalid> <https://launchpad.net/bugs/1838040>
[15:20] <zyga> some unit tests are hanging in travis
[15:20] <zyga> 10 minute timeout reached
[15:23] <juliank> $ snap info mojo
[15:23] <juliank> error: no snap found for "mojo/"
[15:23] <juliank> ^ what's that?
[15:23] <zyga> is there a mojo directory?
[15:23] <juliank> Oh now it works, this was happening while snap install mojo --classic was running
[15:23] <zyga> snap info can be used to look at unpacked snaps on disk
[15:23] <juliank> ah but yes, there is a mojo dir too
[15:24] <zyga> right, that's why
[15:30] <Chipaca> zyga: re https://answers.launchpad.net/snappy/+question/682352 if they removed the snap, the data is gone from disk
[15:30] <zyga> Chipaca: oh, no snapshot?
[15:30] <zyga> but right
[15:30] <Chipaca> zyga: (if new enough they'll have snapshots)
[15:30] <zyga> can you comment about the snapshot aspect
[15:31] <zyga> but if they removed snapd the snapshot data is gone as well
[15:31] <zyga> all core16 tests are mountinfo clean
[15:31] <zyga> that's all folks :)
[15:31] <Chipaca> zyga: huzzah
[15:31] <Chipaca> zyga: happy weekend
[15:32] <zyga> nah, I'm rewriting a helper tool from shell into python
[15:32] <zyga> it will be healthier for what it will do next
[15:32] <zyga> I want to fix more test bugs
[15:32] <Chipaca> I'm off to the gym, then I'll review ijohnson's PR when I get back while dinner cooks
[15:32] <zyga> test bugs drive me crazy
[15:32]  * Chipaca hugs zyga 
[15:32] <zyga> Chipaca: have fun, :)
[15:32] <Chipaca> zyga: you were crazy before we had anything to do with it
[15:32] <zyga> hahaha
[15:32] <ijohnson> thanks Chipaca
[15:32] <zyga> I'll take that as a compliment :)
[15:32] <Chipaca> zyga: :-)
[16:16] <mvo> zyga: thank you
[16:18] <mup> PR snapd#7176 closed: tests: correctly escape mount unit path <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7176>
[16:18] <zyga> lxd leakes more state on fedora
[16:18] <zyga> but I'll fix that later, need to run an errand now
[16:19] <zyga> two more failures from fedora: lxd cgroup state and binfmt_misc being mounted by something traversing the automount point
[16:33] <popey_> aaargh
[16:33] <popey_> I have a snap in a wedged state
[16:33] <popey_> installed:                               (11381)   0B disabled,broken
[16:33] <popey_> i can't refresh, install, enable it
[16:33] <popey_> - Setup snap "lxd" (11381) security profiles (cannot find installed snap "lxd" at revision 11381: missing file /snap/lxd/11381/meta/snap.yaml)
[16:34] <popey_> it's right /snap/lxd is empty
[16:51]  * popey_ starts https://discuss.linuxcontainers.org/t/lxc-snap-wedged-unable-to-refresh-install-enable/5343
[17:02]  * diddledan points at popey's lxd and laughs :-p
[17:02] <diddledan> https://media.giphy.com/media/Q8OOs80Hb5Bj1qNA1d/giphy.gif
[17:03] <diddledan> this one's better https://media.giphy.com/media/cO39srN2EUIRaVqaVq/giphy.gif
[17:03] <mup> PR snapd#7179 closed: tests: remove installed test snap <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7179>
[17:25] <Chipaca> popey_: are you running 5.2?
[17:50]  * ijohnson lunches back in hour or two
[18:01]  * cachio afk
[18:23] <mup> PR snapd#7180 closed: tests: remove installed snap in the restore section <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7180>
[18:42] <Chipaca> ijohnson: you mind if i push a patch to your PR?
[18:42] <diddledan> how rude
[18:42] <Chipaca> ijohnson: otherwise I'll pastebin a diff
[18:42] <diddledan> :-p
[18:42] <Chipaca> ijohnson: even if I push the patch it's still a suggestion :-)
[18:43] <Chipaca> it's just that it's easier to explain in code
[18:43] <Chipaca> anyway, i'm going to carry on ignoring diddledan and go make dinner
[18:43] <diddledan> github totally needs the ability to file a PR against someone's PR
[18:45] <ogra> ah, and i thought the ability to make dinner for you
[18:50] <Chipaca> diddledan: you can file a PR against someone's branch that's PR'ed though
[18:50] <diddledan> true, tho it's more complex by being a repo that you didn't "fork" from on the github ui
[19:06] <ijohnson> Chipaca: go for it
[19:08] <Chipaca> ijohnson: did I understand pedronis right that the values are always strings?
[19:08] <Chipaca> ijohnson: meaning that the list in the verbose test is bogus?
[19:13] <Chipaca> i could check the code myself but i'd have to stop stuffing my face
[19:17] <mup> PR snapd#7177 closed: tests: remove test-snapd-curl <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7177>
[19:17] <mup> PR snapd#7178 closed: tests: remove test-snapd-snapctl-core18 in restore <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7178>
[19:28] <Chipaca> ijohnson: i pushed, but i know it breaks a test
[19:28] <Chipaca> ijohnson: but the tests were broken before so i'm feeling only 90% sorry
[19:28] <Chipaca> now i need to go walk the dog (otherwise i would've spent more time on this)
[19:28] <Chipaca> (dog has almost given up in a huff :-( )
[19:31] <Chipaca> ijohnson: the test that was failing before is about the command not being categorised. Put it under 'other', beside 'known', at least for now
[19:31] <Chipaca> we're still under 80 chars so it's ok
[19:31]  * Chipaca hitches the dog up to the air con
[19:32] <mup> PR snapd#7181 closed: packaging/debian: don't md5sum absent files <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7181>
[19:35] <mup> PR snapd#7182 opened: tests: remove core18 if installed by tests <Created by zyga> <https://github.com/snapcore/snapd/pull/7182>
[19:38] <ijohnson> I think that's correct Chipaca, that's what I understood pedronis to mean
[19:39] <ijohnson> thanks for the patch, will review it, and no worries about the tests I'll clean those up
[19:53] <mup> PR snapcraft#2645 opened: file utils: better error for NotADirectory <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2645>
[19:55] <sergiusens> zyga: you are quick