| mup | PR snapd#7201 closed: HACKING.md: GitHub not Github <Created by doismellburning> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7201> | 01:58 |
|---|---|---|
| mborzecki | morning | 05:25 |
| === pstolowski|afk is now known as pstolowski | ||
| pstolowski | mornings | 07:22 |
| mborzecki | pstolowski: hey | 07:22 |
| mup | PR snapd#7203 opened: i18n, vendor, packaging: drop github.com/ojii/gettext.go, use github.com/snapcore/go-gettext <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7203> | 08:02 |
| mborzecki | pstolowski: can you take a look at https://github.com/snapcore/snapd/pull/7186 ? | 08:04 |
| mup | PR #7186: gadget: ensure filesystem labels are unique <Gadget update> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7186> | 08:04 |
| mup | PR snapd#7204 opened: cmd/snap: use showDone helper with 'snap switch' <Created by stolowski> <https://github.com/snapcore/snapd/pull/7204> | 08:14 |
| pstolowski | Chipaca: good morning! something for you sir ^ | 08:15 |
| pstolowski | mborzecki: will do | 08:15 |
| Chipaca | pstolowski: nice. Will look in a bit. | 08:16 |
| mborzecki | pstolowski: thanks | 08:20 |
| mborzecki | Chipaca: morning | 08:20 |
| Chipaca | mborzecki: mo'in | 08:20 |
| mup | PR snapd#7175 closed: gadget: effective structure role fallback, extra tests <Gadget update> <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7175> | 08:22 |
| mborzecki | is mvo the only one with write access to https://github.com/snapcore/go-gettext ? | 09:03 |
| mborzecki | Chipaca: pstolowski: can you take a quick look at https://github.com/snapcore/go-gettext/pull/2 ? | 09:04 |
| mup | PR go-gettext#2: Fix unit tests on hosts where /tmp is on a separate device <Created by bboozzoo> <https://github.com/snapcore/go-gettext/pull/2> | 09:04 |
| mborzecki | anyways, wonder why this didn't come up earlier | 09:07 |
| pstolowski | k | 09:13 |
| Chipaca | mborzecki: we weren't running the unit tests of it i guess? | 10:01 |
| mborzecki | Chipaca: or /tmp was on the same device as the source dir :/ | 10:02 |
| Chipaca | mborzecki: or they set TEMPDIR | 10:02 |
| Chipaca | or is it TMPDIR | 10:02 |
| mborzecki | Chipaca: or that ;) | 10:03 |
| pstolowski | mborzecki: can you take a look at #7204? | 10:13 |
| mup | PR #7204: cmd/snap: use showDone helper with 'snap switch' <Created by stolowski> <https://github.com/snapcore/snapd/pull/7204> | 10:13 |
| mborzecki | pstolowski: sure | 10:13 |
| pstolowski | mborzecki: thanks | 10:45 |
| === alan_g is now known as alan_g_ | ||
| mborzecki | hm weird, perhaps soemthing wrong with our spread images, this minimal task.yaml https://paste.ubuntu.com/p/B4ZBQc5pnT/ REBOOT fails on 16.04 but works on 18.04 | 10:55 |
| zigford | sorry, I asked this before, but my PC may have fallen asleep by the time I got a response. Anyone think of a reason why snapd 2.40 complains unless I add libncurses to the apparmor profile? | 11:06 |
| Chipaca | zigford: complains how? | 11:14 |
| zigford | 1 sec, it was about a week ago that I tested. I'll remove my entry and repro | 11:20 |
| mborzecki | Chipaca: do you have any idea what could be wrong here? https://paste.ubuntu.com/p/988jjnTcw2/ | 11:21 |
| zigford | "/bin/sh: error while loading shared libraries: libncurses.so.6: cannot open shared object file: No such file or directory | 11:22 |
| zigford | child exited with status 127" | 11:22 |
| zigford | "apparmor="DENIED" operation="open" profile="/usr/lib64/snapd/snap-confine" name="/lib64/libncurses.so.6.1" pid=13806 comm="snap-device-hel" requested_mask="r" denied_mask="r" fsuid=0 ouid=0 | 11:22 |
| zigford | " | 11:22 |
| Chipaca | mborzecki: what am i looking at? | 11:22 |
| Chipaca | zigford: what distro is this? | 11:22 |
| zigford | Sorry, that's after running snap run packagename | 11:23 |
| zigford | Gentoo | 11:23 |
| mborzecki | Chipaca: a spread restore script, executed on 16.04, returning 1, same script run on 18.04 returns 213 (as expected) | 11:23 |
| zigford | If I add an entry to apparmor.d snap-confine profile, the snaps run fine. | 11:23 |
| Chipaca | mborzecki: why doesn't it have a shebang? | 11:24 |
| zigford | Just wondering if something had changed in snapd that I need to account for in my snapd ebuild | 11:24 |
| mborzecki | Chipaca: running bash script.sh gives the same result, 1 on 16.04, 213 on 18.04 | 11:25 |
| Chipaca | zigford: there is a libncurses entry in the apparmor profile of snap-confine, at least on master | 11:26 |
| Chipaca | mborzecki: hmmmm | 11:26 |
| Chipaca | mborzecki: does shellcheck say anything? | 11:26 |
| mborzecki | Chipaca: nothing useful | 11:26 |
| zigford | Chipaca: is it libncurses or libncursesw? the makefile that generated the profile has libncursesw not libncurses | 11:27 |
| Chipaca | mborzecki: w | 11:27 |
| Chipaca | although why it even has that is unclear to me | 11:28 |
| Chipaca | er | 11:28 |
| Chipaca | zigford: libncursesw | 11:28 |
| Chipaca | zigford: actually, it used to have both i think? | 11:29 |
| Chipaca | ec4f3c07746 added both | 11:29 |
| zigford | Chipaca: curious. Guess the best bet might be to dig through the commits and see if/when/why it changed. I know Gentoo isn't supported, but I want to do my best to keep it running | 11:30 |
| Chipaca | er | 11:33 |
| Chipaca | mborzecki: the subshell | 11:33 |
| * Chipaca pokes more | 11:36 | |
| mborzecki | Chipaca: strace is a bit confusing too https://paste.ubuntu.com/p/VrXKfhQhkf/ | 11:38 |
| mborzecki | Chipaca: notice how on 16.04 3359 exits with 213, but then 3358 exits with 1 :?? | 11:38 |
| Chipaca | mborzecki: so | 11:42 |
| Chipaca | mborzecki: on 16.04 | 11:42 |
| Chipaca | ( foo ) | 11:42 |
| Chipaca | actually, let me double check that | 11:42 |
| Chipaca | yes | 11:44 |
| Chipaca | so | 11:44 |
| Chipaca | mborzecki: on 16.04, given: boo() { exit 213; } | 11:44 |
| Chipaca | mborzecki: and 'set -e' | 11:44 |
| Chipaca | mborzecki: then ( ( boo ); ( echo hi ) ) | 11:44 |
| Chipaca | exits with 1 | 11:45 |
| Chipaca | mborzecki: replace the outer subshell-causing ()s with {}s and it exits with 213 | 11:45 |
| Chipaca | mborzecki: a workaround | 11:46 |
| Chipaca | mborzecki: ( boo ) || exit $? | 11:46 |
| Chipaca | so, two workarounds | 11:47 |
| Chipaca | either replace the outer subshell with a group, or, explicitly re-raise the exit value | 11:48 |
| mborzecki | Chipaca: yet, we still need to get the fix through spread :/ | 11:48 |
| Chipaca | mborzecki: when did this start breaking? | 11:48 |
| Chipaca | what changed? | 11:48 |
| mborzecki | Chipaca: noticed this in https://github.com/snapcore/snapd/pull/7198 | 11:50 |
| mup | PR #7198: tests: reboot the node when restoring after a test involving lxd <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7198> | 11:51 |
| Chipaca | mborzecki: so I imagine the issue is that the restore is run in a further subshell, when compared to the test itself | 11:56 |
| Chipaca | mborzecki: but I don't know, care to check that? | 11:56 |
| Chipaca | the other REBOOT-using tests use it in the body afaik | 11:57 |
| Chipaca | anyway I should make lunch | 11:59 |
| Chipaca | and then, apparently, i need to go to the bank | 11:59 |
| Chipaca | mborzecki: can you lead the standup if I don't make it back in time? | 11:59 |
| mborzecki | Chipaca: sure | 12:01 |
| mborzecki | Chipaca: commented out restore-each in my spread.yaml, https://paste.ubuntu.com/p/6MkKSf9sqy/ | 12:01 |
| Chipaca | mborzecki: yes | 12:01 |
| Chipaca | mborzecki: I'd call it a bug in bash :) | 12:02 |
| mborzecki | Chipaca: yup, trying to find a bug report or a changelog entry | 12:02 |
| mup | PR snapd#7204 closed: cmd/snap: use showDone helper with 'snap switch' <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/7204> | 12:02 |
| mborzecki | Chipaca: since it's fixed in newer version anyway :) | 12:02 |
| zyga | Good morning | 12:05 |
| zyga | I’m sorry for not doing more last night | 12:05 |
| zyga | I sent some reviews but didn’t have time to work on blockers | 12:06 |
| zyga | mborzecki, Chipaca what does reboot expand to? | 12:06 |
| zyga | Is it the function or the executable | 12:07 |
| zyga | Reboot returns 130 AFAIR | 12:07 |
| zyga | Did you check what spread does to detect a reboot request? | 12:07 |
| mborzecki | zyga: awe already know that set -e ( () () ) behaves differently in bash 4.3 and 4.4 | 12:08 |
| mborzecki | zyga: the bottom snippet here shows how the script looks like in the minimal test case that fails https://paste.ubuntu.com/p/6MkKSf9sqy/ | 12:09 |
| zyga | Bash, the bane of development :-( | 12:09 |
| zyga | Thank you for digging | 12:09 |
| zyga | I read that | 12:09 |
| zyga | Did you see my question about command vs function? | 12:10 |
| Chipaca | zyga: I don't think that makes a difference | 12:10 |
| mborzecki | zyga: it's complicated, REBOOT is a function which echos <REBOOT> and exists with special exit code (213), the spread separately runs `reboot` command | 12:10 |
| Chipaca | zyga: you can change the 'REBOOT' for a direct 'exit 213' and it still misbehaves | 12:11 |
| Chipaca | mborzecki: REBOOT can also be tests/lib/bin/REBOOT which is what zyga is asking about i think | 12:11 |
| zyga | mborzecki: we also unset the function and do the equivalent in a reboot command | 12:11 |
| zyga | I wonder if that matters | 12:12 |
| zyga | Yeah | 12:12 |
| Chipaca | but, as i say, it's not the function, it's the double subshell followed by a subshell | 12:12 |
| Chipaca | or as mborzecki said | 12:12 |
| Chipaca | anyway why am i not making lunch | 12:12 |
| mborzecki | Chipaca: i know, though i'm using a minimal task sample https://paste.ubuntu.com/p/B4ZBQc5pnT/ outside of your spread setup ;) | 12:12 |
| mborzecki | zyga: ^^ | 12:12 |
| zyga | Ack | 12:13 |
| Chipaca | zyga: with 'set -e', this: ( ( exit 213 ); ( echo hi ) ) | 12:13 |
| Chipaca | zyga: exits with 1 | 12:13 |
| Chipaca | ¯\_(ツ)_/¯ | 12:13 |
| mborzecki | duh, bash git log is most useless :/ | 12:22 |
| mborzecki | (set -e ; ( ( exit 213 ) || exit $?; ( echo hi ) || exit $? ) || exit $? ); echo $? | 12:25 |
| mborzecki | omg /o\ | 12:25 |
| mup | PR snapcraft#2651 opened: Extension confinement <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2651> | 12:54 |
| mup | PR snapcraft#2648 closed: remote-build: include project name in build-id <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2648> | 12:57 |
| mup | PR snapcraft#2650 closed: store: send snapcraft-started-at in push requests <Created by cjwatson> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2650> | 12:57 |
| mborzecki | cachio: standup? | 13:01 |
| ijohnson | cachio: I talked to field and they said there's a ufw snap - would that work for you? if not, then iptables is included in network-manager, but there's no app exposed for it so you'd need to do `snap run --shell ...` | 13:37 |
| cachio | ijohnson, nice, thanks, I'll try ufw snap | 13:38 |
| ijohnson | +1 | 13:38 |
| cachio | and see if it works on the tests | 13:39 |
| cachio | ijohnson, thanks!! | 13:39 |
| ijohnson | if you have problems with it, blame ogra he recommended it to me so it's all his fault | 13:39 |
| cachio | ijohnson, hehhe | 13:40 |
| cachio | ijohnson, I'll do | 13:40 |
| cachio | thanks | 13:40 |
| ogra | ijohnson, cachio i'll pass that blame on to the owner of the snap .... jdstrand_ ;) | 13:44 |
| mborzecki | what do we do with changes to spread? shall I open a PR? | 13:48 |
| ogra | pstolowski, i'm just wondering, what happens to my hotplugged usb-serial device if i unplug and re-plug ... will the interface an app uses stay connected ? | 13:49 |
| pstolowski | ogra: when you unplug the device, the interface gets disconnected and slot disappears from the system; when you plug it back, the connection is restored | 13:53 |
| ogra | prefect, thanks ! | 13:53 |
| diddledan | funny: https://www.reddit.com/r/ProgrammerHumor/comments/btkri6/i_call_for_death_penalty/?ocid=AID740620_FACEBOOK_oo_spl100000841935315 | 14:09 |
| Chipaca | pstolowski: would you like to join the meeting about the channel vs risk thing? | 14:27 |
| Chipaca | pstolowski: wrt snapd-glib and the semantics change | 14:27 |
| pstolowski | Chipaca: sure | 14:27 |
| Chipaca | pstolowski: ok, i'll add you to the invite | 14:27 |
| Chipaca | it starts in ~3 :) | 14:27 |
| pstolowski | Chipaca: ok, np | 14:28 |
| Chipaca | man, i love short meetings of busy but smiling people | 14:43 |
| pstolowski | haha | 14:43 |
| pstolowski | Chipaca: thanks for overseeing this change & making Robert aware of it | 14:44 |
| Chipaca | "overseeing" is a big label :-) | 14:45 |
| * Chipaca adds "overseer" to his business cards | 14:45 | |
| pstolowski | lol | 14:46 |
| * ogra senses the next holliwood movie "The Overseer - featuring J. Lenton as the overseer" | 14:47 | |
| * Chipaca upgrades his cash-raking rake | 14:47 | |
| robert_ancell | Chipaca, pstolowski I just noticed the current G-S code doesn't use the full channel names, but I was intending to change that (to match snapcraft.io). Either way this still shouldn't be an issue. | 14:51 |
| Chipaca | robert_ancell: 👍 | 14:52 |
| pstolowski | robert_ancell: good, ty | 14:52 |
| * cachio lunch | 14:53 | |
| === pstolowski is now known as pstolowski|afk | ||
| mup | PR snapcraft#2652 opened: meta: transparently support command-chain <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2652> | 16:28 |
| mup | PR snapd#7205 opened: many: introduce security profile failsafe flag <Created by zyga> <https://github.com/snapcore/snapd/pull/7205> | 19:59 |
| * cachio EOD | 21:10 | |
| amurray | kenvandine popey: fyi my lame attempt to get drawing snapped yesterday evening - https://github.com/alexmurray/drawing-snap | 21:34 |
| kenvandine | amurray: I have one that's pretty close. Needs newer things, which are in the gnome build snap | 21:56 |
| kenvandine | amurray: which is still a WIP | 21:56 |
| === JamieBennett_ is now known as JamieBennett | ||
| === cprov_ is now known as cprov | ||
| === marosg_ is now known as marosg | ||
| === kalikiana_ is now known as kalikiana | ||
| === tedg_ is now known as tedg | ||
| === jamespage_ is now known as jamespage | ||
| === kenvandine_ is now known as kenvandine | ||
| === zyga_ is now known as zyga | ||
| === benoitc_ is now known as benoitc | ||
| === joedborg_ is now known as joedborg | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!