/srv/irclogs.ubuntu.com/2019/08/05/#lubuntu-devel.txt

wxlTIL no backup codes with 2FA in phab. that means that if someone loses theirs, its on us to manually strip 2FA from their account. but how do we verify them? that's a nice security catch-22. https://secure.phabricator.com/T654900:18
wxlthat said, new phone, and sadly i just discovered there's no simple backup solution in freeotp, so looks like i'm going to at least do that to my own account.00:20
-lugito:#lubuntu-devel- [rMANUALfac98585adea: Fix extraneous text] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALfac98585adea02:15
lubot<teward001> @tsimonq2 [So technically it's teward's fault], as I said before:02:20
lubot<teward001> it's actually Discourse's fault02:20
lubot<teward001> for using Apache under the hood02:20
-lugito:#lubuntu-devel- [rMANUALc6cec768b972: Remove extraneous backtick] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALc6cec768b97202:21
wxl@teward001 it seems that general concept (discourse being weird because it's weird) escapes poor simon02:29
lubot<teward001> :P02:30
wxlcase in point: backups02:37
-lugito:#lubuntu-devel- [rMANUALe25f7f29f46d: Add how to turn off line numbers] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALe25f7f29f46d04:37
-lugito:#lubuntu-devel- [rMANUAL26dea088b641: Add inertial scrolling checkbox to featherpad] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL26dea088b64104:45
-lugito:#lubuntu-devel- [rMANUAL15d921282ad0: Reorder Files tab sentences to follow what shows on the prefrences window] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL15d921282ad004:50
lubot<The_LoudSpeaker> Wxl: you there?04:53
wxlyep04:53
lubot<The_LoudSpeaker> I didn't understand the 2nd point of your "some quibbes" from the comment on D1704:54
lubot<The_LoudSpeaker> And about "GoToDesktop directional", yeah, removed it from changelog04:55
wxlyou have:04:55
wxl  * Some commented out items are removed04:55
wxl   - lxpanel menu04:55
wxl   - lxsession default lock04:55
wxl   - calculator04:55
wxl   - screenshot04:55
wxl- quit04:55
wxli'm suggesting just chaging that to the first line only04:55
lubot<The_LoudSpeaker> Okay.04:55
wxlno one really cares about things that weren't functional XD04:55
lubot<lynorian> Do we actually keybind calculator to anything now?04:56
lubot<lynorian> because with my new mechanical keyboard I have a calculator key for the first time04:56
wxlOOOOOOOOOOOOOOOOOOOOOOO04:56
lubot<The_LoudSpeaker> And about the 1st point there, "next panel" is what? Also switch desktop is in D1804:57
lubot<The_LoudSpeaker> @wxl [<wxl> no one really cares about things that weren't functional XD], I thought changelog should be nice and verbose?04:57
wxlthat's for switching between panels (weird)04:57
wxl  <keybind key="C-A-Tab">04:57
wxl    <action name="NextWindow">04:57
wxl      <panels>yes</panels><desktop>yes</desktop>04:57
wxl      <finalactions>04:57
wxl        <action name="Focus"/>04:57
wxl        <action name="Raise"/>04:57
wxl        <action name="Unshade"/>04:57
wxl      </finalactions>04:57
wxl    </action>04:57
wxl</keybind>04:57
wxlyou should seek a careful balance between saying enough but not saying too much :)04:58
lubot<The_LoudSpeaker> Ohh C+A+Tab ? Ah! That's actually weird only. Lite. Don't worry much.04:58
wxlif we were removing something that previously was functional, even if we said we don't care about it, i'd make note of it. but if it's useless, who cares?04:58
lubot<The_LoudSpeaker> @wxl [<wxl> if we were removing something that previously was functional, even if we s …], Okay. I will write it in only one line.04:59
lubot<The_LoudSpeaker> Check the diff now please.05:01
lubot<The_LoudSpeaker> Also, why version no 19.10.4 ? Last one was 19.10.1 na? So shouldn't this be .2?05:01
wxllooks good05:02
wxl!info lubuntu-default-settings eoan05:02
-lugito:#lubuntu-devel- [rMANUAL5ad257475610: Reword remember size on closing] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL5ad25747561005:02
ubot93lubuntu-default-settings (19.10.3, eoan): default settings for Lubuntu. In component universe, is optional. Built by lubuntu-default-settings. Size 14 kB / 126 kB05:02
lubot<The_LoudSpeaker> @ubot93 [<ubot93> lubuntu-default-settings (19.10.3, eoan): default settings for Lubuntu. …], Ack05:02
wxlyou might want to read the wiki page on versions05:02
lubot<The_LoudSpeaker> Can't do it rn. But send link anyways. Will read when free.05:02
lubot<The_LoudSpeaker> @TJ- [<TJ-> @The_LoudSpeaker: sounds like you're doing it back-to-front. The way I do …], Noted. Will see what I can do.05:03
wxlhttps://phab.lubuntu.me/w/packaging/packaging-versions/05:04
lubot<The_LoudSpeaker> Thanks!05:04
wxlhow's the xdg fix for globalkeys coming along?05:05
lubot<The_LoudSpeaker> Did you see T59#1772 ?05:05
wxlfull links might be more helpful here05:05
wxlright that's what i was asking about05:06
lubot<The_LoudSpeaker> @wxl [<wxl> how's the xdg fix for globalkeys coming along?], Latest package builds nicely. Without patch that is. Currently downloading the patch of latest commit from 2 days ago. Which merged the required PR into master.05:06
wxlokie dokie05:10
lubot<The_LoudSpeaker> It says patch doesnot apply05:33
lubot<The_LoudSpeaker> I was applying it to latest upstream release.05:35
lubot<The_LoudSpeaker> https://phab.lubuntu.me/P2305:36
TJ-@The_LoudSpeaker right, hunk #8 failed, so you examine the files where the >>>> and <<<< markers are and fix it up manually05:38
TJ-@The_LoudSpeaker: patch is telling you the file is daemon/core.cpp so you can search that for all markers and figure out a fix then remove the 'old' code plus the markers05:39
lubot<The_LoudSpeaker> thanks! will check.05:43
lubot<The_LoudSpeaker> also, why am I unable to clone rLXQT-GLOBALKEYS with ssh? It says check access rights06:20
-lugito:#lubuntu-devel- [rMANUALc2b0f606aaca: Add hide search bar by default] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALc2b0f606aaca10:52
-lugito:#lubuntu-devel- [rMANUAL727747d16081: Reword in quick launch to launch pcmanfm-qt] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL727747d1608110:57
-lugito:#lubuntu-devel- [T48: nm-tray icons] hmollercl (Hans P. Möller) commented on the task: https://phab.lubuntu.me/T48#177314:03
lubot<teward001> wxl @tsimonq2 Ubuntu SSO login for Discourse is not going to happen any time soon14:45
lubot<teward001> see the RT you're copied on14:45
lubot<teward001> (E:Incompatible)14:45
The_LoudSpeaker!info lxqt-globalkeys eoan14:50
ubot93lxqt-globalkeys (0.14.1-0ubuntu1, eoan): daemon used to register global keyboard shortcuts (appl.). In component universe, is optional. Built by lxqt-globalkeys. Size 137 kB / 538 kB14:50
lubot<The_LoudSpeaker> Ggwp lugito!14:51
lubot<The_LoudSpeaker> what version no do I give it?14:51
lubot<teward001> @tsimonq2 wake up already nooblet15:02
lubot<The_LoudSpeaker> Why do we use quilt push to push a patch and not git am < name.patch ?15:16
apt-ghettoBecause lxqt-globalkeys is a non-native package15:18
lubot<SamuelBanya> Sorry I missed the last meeting since I had surgery last week. The progress I remember is that i was able to get the iso tester running as indicated by the web interface but I don't think it was necessarily recognizing the iso I provided. I would want to work with someone on this sometime this week if anyone gets a chance15:50
-lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] The_LoudSpeaker (Raman Sarda) commented on the task: https://phab.lubuntu.me/T59#177517:38
lubot<The_LoudSpeaker> @lugito [<lugito>  3[  13T59: fix keyboard shortcuts  3]   15The_LoudSpeaker (Raman Sarda …], anyone understands whats happening here?17:39
lubot<teward001> @The_LoudSpeaker [anyone understands whats happening here?], well it SOUNDS like the patches as written don't apply to the 'latest upstream version' you've gone and downloaded17:40
lubot<teward001> or there's revisions in the Lubuntu ones which make the patches not apply properly17:40
lubot<teward001> which can happen.17:40
lubot<teward001> i'd have to dig deeper, but my guess is that this is a case of patches being invalid for what's in Ubuntu due to reasons such as invalid 'surrounding' code lines, etc.17:41
lubot<teward001> might have to do your diff manually and then apply it manually17:41
-lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] The_LoudSpeaker (Raman Sarda) commented on the task: https://phab.lubuntu.me/T59#177617:42
lubot<The_LoudSpeaker> @teward001 [or there's revisions in the Lubuntu ones which make the patches not apply proper …], in lubuntu we are only appliying one patch by ourselves which just changes the conf file ref https://phab.lubuntu.me/rLXQTGLOBALKEYSPACKAGINGc38d485eb9211ee4209058186658684a52cc5034 I don't think it should cause the patch to fa17:44
lubotil.17:44
lubot<RikMills> you do know you can just add '.patch' to the end of a github commit url to get the raw patch?17:54
lubot<teward001> ^ that17:54
lubot<The_LoudSpeaker> @The_LoudSpeaker [https://phab.lubuntu.me/P23], ^17:56
lubot<The_LoudSpeaker> @RikMills P23 is what happens when I do that.17:58
lubot<HMollerCl> @The_LoudSpeaker maybe you need to apply other upstream patches first.17:59
lubot<The_LoudSpeaker> @HMollerCl [@The_LoudSpeaker maybe you need to apply other upstream patches first.], If this patch was the last commit on the master branch and master branch builds correctly using their methods, then also?18:00
lubot<RikMills> I get … Applying patch xdg-final.patch … patching file daemon/core.cpp … Hunk #8 FAILED at 732. … Hunk #9 succeeded at 770 (offset -1 lines). … 1 out of 9 hunks FAILED -- rejects in file daemon/core.cpp … patching file daemon/core.h … patching file daemon/main.cpp … Hunk #1 succeeded at 43 with fuzz 1. … Patch xdg-final.patch does no18:00
lubott apply (enforce with -f)18:00
lubot<RikMills> against the unpacked source from Eoan archive18:01
lubot<The_LoudSpeaker> @RikMills [I get … Applying patch xdg-final.patch … patching file daemon/core.cpp … Hunk #8 FAIL …], That's exactly what I got. see P2318:01
lubot<HMollerCl> you need to apply patches from where eoan sources is to the one you need.18:01
lubot<RikMills> No, you got a lot more failed hunks18:01
lubot<teward001> also keep in mind fuzz is bad 😜18:02
lubot<RikMills> @teward001 [also keep in mind fuzz is bad 😜], yep, refresh, once the failing hunk is fixed18:02
lubot<RikMills> @HMollerCl [you need to apply patches from where eoan sources is to the one you need.], Yeah … ```pull-lp-source lxqt-globalkeys```18:03
lubot<The_LoudSpeaker> @HMollerCl [you need to apply patches from where eoan sources is to the one you need.], check P24 that's what I get when I am applying the patch to release 0.14.1 which is the one from which eoan sources.18:04
lubot<HMollerCl> eoan sources way ahead from github, last upstream was commited in march18:04
lubot<RikMills> @The_LoudSpeaker [check P24 that's what I get when I am applying the patch to release 0.14.1 which …], I did. they are not the same18:05
lubot<The_LoudSpeaker> @RikMills [No, you got a lot more failed hunks], more failed hunks are when I don't use raw patch.18:05
lubot<The_LoudSpeaker> @RikMills [I did. they are not the same], Just so we don't get confused,  … P23 is when I use a patch which I create by adding .patch to commit url. … P24 is when I use a patch created using `git diff bd9cb26d217ef7633570c947e5e7e410564eafc1 bd9cb26d217ef7633570c947e5e7e410564eafc1^ > ~/xdg-final.patch`18:07
lubot<The_LoudSpeaker> in earlier case, I get exactly what you got( 1 hunk fail) and in second case I have more hunks failing.18:08
lubot<HMollerCl> @The_LoudSpeaker have you follow this?18:08
lubot<HMollerCl> https://phab.lubuntu.me/w/packaging/packaging-example/18:09
lubot<The_LoudSpeaker> @HMollerCl [@The_LoudSpeaker have you follow this?], Yup! line to line. see https://phab.lubuntu.me/T59#177518:09
-lugito:#lubuntu-devel- [High, Open] fix keyboard shortcuts: https://phab.lubuntu.me/T59#177518:09
lubot<HMollerCl> What I think is that there need to be applied previous patches. Don't know well how to check which of them.18:13
kc2bezpaste a `quilt series` please18:14
lubot<RikMills> https://github.com/lxqt/lxqt-globalkeys/commit/e0b23717e2f2efe503d5b56936831d4f22aaf870#diff-ab80dc7dc08557f267fdbc304d93533f18:14
lubot<RikMills> that commit since 0.14.1 is the big cause of the hunk #8 fail18:15
lubot<The_LoudSpeaker> @kc2bez [<kc2bez> paste a `quilt series` please], `raman@Aspire-ES1-132:~/opt/lxqt-globalkeys$ quilt series  … complete-config-file.patch … xdg-final.patch … raman@Aspire-ES1-132:~/opt/lxqt-globalkeys$`18:18
lubot<The_LoudSpeaker> @RikMills [that commit since 0.14.1 is the big cause of the hunk #8 fail], so I will try patching that first and then applying raw patch of required commit.18:19
lubot<RikMills> It might be all that is need. However, danger is, unless you quite well understand the code/changes and their intent, backportring more patches to make other patches to apply can in some cases just make bigger problem. i.e. patches might apply, but not work at runtime/compiletime with the rest of the code18:21
lubot<The_LoudSpeaker> okay.18:22
lubot<The_LoudSpeaker> btw a side shot,  …  - I checkedout the branch `releases-0.14.x` on the upstream code. …  - then ran `git am > ~/xdg-final.patch`  … (xdg-final.patch is the one I created using git diff command on master branch's latest commit)  … I am planning to see it the patch applies. But the problem is that the command is running since l18:28
lubotast 10 mins. Should I stop it?18:28
wxli'm putting this down for posterity: PHABRICATOR DOES NOT PROVIDE 2FA BACKUP CODES. if you have it enabled and have lost access to your 2FA device, you will have to have an admin remove your 2FA manually. 19:04
wxla related tangent: freeotp does not offer a backup option.19:04
lubot<aptghetto> @The_LoudSpeaker [btw a side shot,  …  - I checkedout the branch releases-0.14.x on the upstream cod …], You are redirecting the output of `git am` to the file `~/xdg-final.patch`. Before producing some output (if any), `git am` expects some input, so you can wait a long, long time. … You should redirect the content of the patch19:04
lubot file into `git am`, using `git am < ~/xdg-final.patch`. … By the way, 'xdg-final.patch' is not a good name for the file, because it does not describe well, what this patch is good for (and it is very likely not the final patch).19:04
lubot<The_LoudSpeaker> @aptghetto [You are redirecting the output of git am to the file ~/xdg-final.patch. Before p …], *face palms*19:10
lubot<aptghetto> `git checkout master; git diff releases-0.14.x > ../all.diff` is not really small. … There are a lot of unrelated changes like translations. There are some cmake changes, and a lot of C to C++1x related changes.19:13
wxl@tsimonq2: you should go play with this and see if we can't set it up on our github repos https://help.github.com/en/articles/displaying-a-sponsor-button-in-your-repository19:15
lubot<aptghetto> Maybe you can try to delete the unrelated hunks from 'all.diff' and try to apply and build it.19:18
lubot<aptghetto> And then find a C++ dev to review your patch19:19
-queuebot:#lubuntu-devel- Builds: Lubuntu Desktop amd64 [Bionic 18.04.3] has been updated (20190805)19:21
-queuebot:#lubuntu-devel- Builds: Lubuntu Desktop i386 [Bionic 18.04.3] has been updated (20190805)19:21
lubot<aptghetto> @wxl [<wxl> @tsimonq2: you should go play with this and see if we can't set it up on o …], Seems to be pretty easy: `printf "%s\n%s\n%s\n" "patreon: lubuntu" "liberapay: lubuntu" "custom: ['https://teespring.com/stores/lubuntu', 'https://www.paypal.me/lubuntu']" > .github/FUNDING.yml`19:42
lubot<The_LoudSpeaker> wxl: You checked this: phab.lubuntu.me/T59#1775 ?19:43
-lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T59#177719:44
lubot<The_LoudSpeaker> wxl: I read your comment. I have few doubts: … 1. Is applying the patch to latest release necessary even if its already merged into master and latest master builds correctly? and aren't we applying the patch to latest release only when following packaging example ?19:49
wxllatest release != latest master19:49
lubot<The_LoudSpeaker> yeah latest release is 0.14.1 I know but see this: … ```raman@Aspire-ES1-132:~/opt/lxqt-globalkeys$ uscan --download-current-version … uscan: Newest version of lxqt-globalkeys on remote site is 0.14.1, specified download version is 0.14.1 … gpgv: Signature made Monday 25 February 2019 01:38:53 AM IST … gpgv:                usi19:50
lubotng RSA key 7C733BA5F585AAD669E4D23A42C9C8D3AF5EA5E3 … gpgv: Good signature from "Alf Gaida <agaida@siduction.org>" … Successfully symlinked ../lxqt-globalkeys-0.14.1.tar.xz to ../lxqt-globalkeys_0.14.1.orig.tar.xz.```19:50
wxlsecond quilt introduces debian/ubuntu changes19:50
wxlif it works fine with the latest release, then the issue is those changes19:51
lubot<The_LoudSpeaker> so I shouldn't apply patches under debian/patches ?19:51
wxlif we can determine that's the case, then we analyze the situation and figure out the appropriate solution19:53
lubot<The_LoudSpeaker> okay. I will try that.19:53
lubot<The_LoudSpeaker> which patch should I apply? one created by adding .patch at url's end or one created using git diff ?19:56
wxlthey should be the same19:57
wxlif they're not , that's a problem19:57
lubot<The_LoudSpeaker> @The_LoudSpeaker [so I shouldn't apply patches under debian/patches ?], This didn't work. patch didn't apply.20:03
lubot<The_LoudSpeaker> now trying to patch to `releases-0.14.x` on github. That's the latest release.20:04
RikMills18.04.3 RC ISOs to test --> https://lists.ubuntu.com/archives/ubuntu-release/2019-August/004790.html20:15
RikMillshttp://iso.qa.ubuntu.com/qatracker/milestones/405/builds20:15
-lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] The_LoudSpeaker (Raman Sarda) commented on the task: https://phab.lubuntu.me/T59#177920:29
lubot<The_LoudSpeaker> @lugito [<lugito>  3[  13T59: fix keyboard shortcuts  3]   15The_LoudSpeaker (Raman Sarda …], wxl: ^20:29
lubot<The_LoudSpeaker> also, should I ask upstream about when will the next release be available? If yes then how do I do that?20:31
lubot<The_LoudSpeaker> @RikMills [https://github.com/lxqt/lxqt-globalkeys/commit/e0b23717e2f2efe503d5b56936831d4f2 …], wxl: any ideas?20:47
-lugito:#lubuntu-devel- [T87: Calamares: Address security issue related to FDE] kc2bez (Dan Simmons) commented on the task: https://phab.lubuntu.me/T87#178021:01
-lugito:#lubuntu-devel- [T53: get rid of `$BROWSER`!] The_LoudSpeaker (Raman Sarda) commented on the task: https://phab.lubuntu.me/T53#178121:07
lubot<The_LoudSpeaker> @lugito [<lugito>  3[  13T53: get rid of `$BROWSER`!  3]   15The_LoudSpeaker (Raman Sarda …], wxl:21:07
lubot<HMollerCl> @The_LoudSpeaker [also, should I ask upstream about when will the next release be available? If ye …], just open an issue, I did that with nm-tray https://github.com/palinek/nm-tray/issues/4121:19
lubot<The_LoudSpeaker> @HMollerCl [just open an issue, I did that with nm-tray https://github.com/palinek/nm-tray/i …], Ack. Thanks!21:19
lubot<The_LoudSpeaker> created here: https://github.com/lxqt/lxqt-globalkeys/issues/13021:37
lubot<lynorian> also new 18.04.3 images are out21:58
-lugito:#lubuntu-devel- [rMANUAL6344baeebfc9: Add application_chooser screenshot] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL6344baeebfc922:36
-lugito:#lubuntu-devel- [T53: get rid of `$BROWSER`!] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T53#178223:07
-lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T59#178323:10
wxlif anyone can try to confirm this and comment about their experience in 19.04, i'd appreciate it https://www.reddit.com/r/Lubuntu/comments/ck31z4/no_windows_keyboard_shortcuts/evo5vwq/?st=jyz0ntdd&sh=d47bc2a623:19
lubot<kc2bez> Which part would you like for me to confirm? The checkbox part or the upgrade part?23:22
wxlcheckbox23:23
wxlmore or less trying to eliminate ctrl-f423:23
wxlseems to Just Work for me23:23
lubot<kc2bez> Yes, you need to double click. Weird.23:24
wxli'm not really worried about that23:24
lubot<kc2bez> Oh, that is eoan.23:24
wxlbut that you can disable it but then it's restored on reboot23:24
lubot<kc2bez> I will check that part too.23:25
lubot<kc2bez> Rebooted and still disabled.23:27
wxlcould you comment there? you did do that in disco right?23:27
lubot<kc2bez> Eoan but I will check with Disco first.23:27
wxlyes please23:28
wxlsupported only when dealing with support requests XD23:29
lubot<kc2bez> Yes. I know. I stopped myself. It was the closest machine I had.23:32
wxli hear you23:32
wxli almost do everything in it23:32
lubot<kc2bez> Same result in Disco. I will fire off a comment.23:35
-lugito:#lubuntu-devel- [T90: Bionic locker should be light-locker] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T90#178523:42
-lugito:#lubuntu-devel- [T106: 18.04 SRUs] wxl (Walter Lapchynski) just created this task: https://phab.lubuntu.me/T10623:43
wxlsidebar in phab now has all our metatasks23:52

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!