[00:18] <wxl> TIL no backup codes with 2FA in phab. that means that if someone loses theirs, its on us to manually strip 2FA from their account. but how do we verify them? that's a nice security catch-22. https://secure.phabricator.com/T6549
[00:20] <wxl> that said, new phone, and sadly i just discovered there's no simple backup solution in freeotp, so looks like i'm going to at least do that to my own account.
[02:15] -lugito:#lubuntu-devel- [rMANUALfac98585adea: Fix extraneous text] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALfac98585adea
 @tsimonq2 [So technically it's teward's fault], as I said before:
 it's actually Discourse's fault
 for using Apache under the hood
[02:21] -lugito:#lubuntu-devel- [rMANUALc6cec768b972: Remove extraneous backtick] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALc6cec768b972
[02:29] <wxl> @teward001 it seems that general concept (discourse being weird because it's weird) escapes poor simon
 :P
[02:37] <wxl> case in point: backups
[04:37] -lugito:#lubuntu-devel- [rMANUALe25f7f29f46d: Add how to turn off line numbers] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALe25f7f29f46d
[04:45] -lugito:#lubuntu-devel- [rMANUAL26dea088b641: Add inertial scrolling checkbox to featherpad] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL26dea088b641
[04:50] -lugito:#lubuntu-devel- [rMANUAL15d921282ad0: Reorder Files tab sentences to follow what shows on the prefrences window] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL15d921282ad0
 Wxl: you there?
[04:53] <wxl> yep
 I didn't understand the 2nd point of your "some quibbes" from the comment on D17
 And about "GoToDesktop directional", yeah, removed it from changelog
[04:55] <wxl> you have:
[04:55] <wxl>   * Some commented out items are removed
[04:55] <wxl>    - lxpanel menu
[04:55] <wxl>    - lxsession default lock
[04:55] <wxl>    - calculator
[04:55] <wxl>    - screenshot
[04:55] <wxl> - quit
[04:55] <wxl> i'm suggesting just chaging that to the first line only
 Okay.
[04:55] <wxl> no one really cares about things that weren't functional XD
 Do we actually keybind calculator to anything now?
 because with my new mechanical keyboard I have a calculator key for the first time
[04:56] <wxl> OOOOOOOOOOOOOOOOOOOOOOO
 And about the 1st point there, "next panel" is what? Also switch desktop is in D18
 @wxl [<wxl> no one really cares about things that weren't functional XD], I thought changelog should be nice and verbose?
[04:57] <wxl> that's for switching between panels (weird)
[04:57] <wxl>   <keybind key="C-A-Tab">
[04:57] <wxl>     <action name="NextWindow">
[04:57] <wxl>       <panels>yes</panels><desktop>yes</desktop>
[04:57] <wxl>       <finalactions>
[04:57] <wxl>         <action name="Focus"/>
[04:57] <wxl>         <action name="Raise"/>
[04:57] <wxl>         <action name="Unshade"/>
[04:57] <wxl>       </finalactions>
[04:57] <wxl>     </action>

[04:58] <wxl> you should seek a careful balance between saying enough but not saying too much :)
 Ohh C+A+Tab ? Ah! That's actually weird only. Lite. Don't worry much.
[04:58] <wxl> if we were removing something that previously was functional, even if we said we don't care about it, i'd make note of it. but if it's useless, who cares?
 @wxl [<wxl> if we were removing something that previously was functional, even if we s …], Okay. I will write it in only one line.
 Check the diff now please.
 Also, why version no 19.10.4 ? Last one was 19.10.1 na? So shouldn't this be .2?
[05:02] <wxl> looks good
[05:02] <wxl> !info lubuntu-default-settings eoan
[05:02] -lugito:#lubuntu-devel- [rMANUAL5ad257475610: Reword remember size on closing] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL5ad257475610
 @ubot93 [<ubot93> lubuntu-default-settings (19.10.3, eoan): default settings for Lubuntu. …], Ack
[05:02] <wxl> you might want to read the wiki page on versions
 Can't do it rn. But send link anyways. Will read when free.
 @TJ- [<TJ-> @The_LoudSpeaker: sounds like you're doing it back-to-front. The way I do …], Noted. Will see what I can do.
[05:04] <wxl> https://phab.lubuntu.me/w/packaging/packaging-versions/
 Thanks!
[05:05] <wxl> how's the xdg fix for globalkeys coming along?
 Did you see T59#1772 ?
[05:05] <wxl> full links might be more helpful here
[05:06] <wxl> right that's what i was asking about
 @wxl [<wxl> how's the xdg fix for globalkeys coming along?], Latest package builds nicely. Without patch that is. Currently downloading the patch of latest commit from 2 days ago. Which merged the required PR into master.
[05:10] <wxl> okie dokie
 It says patch doesnot apply
 I was applying it to latest upstream release.
 https://phab.lubuntu.me/P23
[05:38] <TJ-> @The_LoudSpeaker right, hunk #8 failed, so you examine the files where the >>>> and <<<< markers are and fix it up manually
[05:39] <TJ-> @The_LoudSpeaker: patch is telling you the file is daemon/core.cpp so you can search that for all markers and figure out a fix then remove the 'old' code plus the markers
 thanks! will check.
 also, why am I unable to clone rLXQT-GLOBALKEYS with ssh? It says check access rights
[10:52] -lugito:#lubuntu-devel- [rMANUALc2b0f606aaca: Add hide search bar by default] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUALc2b0f606aaca
[10:57] -lugito:#lubuntu-devel- [rMANUAL727747d16081: Reword in quick launch to launch pcmanfm-qt] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL727747d16081
[14:03] -lugito:#lubuntu-devel- [T48: nm-tray icons] hmollercl (Hans P. Möller) commented on the task: https://phab.lubuntu.me/T48#1773
 wxl @tsimonq2 Ubuntu SSO login for Discourse is not going to happen any time soon
 see the RT you're copied on
 (E:Incompatible)
[14:50] <The_LoudSpeaker> !info lxqt-globalkeys eoan
 Ggwp lugito!
 what version no do I give it?
 @tsimonq2 wake up already nooblet
 Why do we use quilt push to push a patch and not git am < name.patch ?
[15:18] <apt-ghetto> Because lxqt-globalkeys is a non-native package
 Sorry I missed the last meeting since I had surgery last week. The progress I remember is that i was able to get the iso tester running as indicated by the web interface but I don't think it was necessarily recognizing the iso I provided. I would want to work with someone on this sometime this week if anyone gets a chance
[17:38] -lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] The_LoudSpeaker (Raman Sarda) commented on the task: https://phab.lubuntu.me/T59#1775
 @lugito [<lugito>  3[  13T59: fix keyboard shortcuts  3]   15The_LoudSpeaker (Raman Sarda …], anyone understands whats happening here?
 @The_LoudSpeaker [anyone understands whats happening here?], well it SOUNDS like the patches as written don't apply to the 'latest upstream version' you've gone and downloaded
 or there's revisions in the Lubuntu ones which make the patches not apply properly
 which can happen.
 i'd have to dig deeper, but my guess is that this is a case of patches being invalid for what's in Ubuntu due to reasons such as invalid 'surrounding' code lines, etc.
 might have to do your diff manually and then apply it manually
[17:42] -lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] The_LoudSpeaker (Raman Sarda) commented on the task: https://phab.lubuntu.me/T59#1776
 @teward001 [or there's revisions in the Lubuntu ones which make the patches not apply proper …], in lubuntu we are only appliying one patch by ourselves which just changes the conf file ref https://phab.lubuntu.me/rLXQTGLOBALKEYSPACKAGINGc38d485eb9211ee4209058186658684a52cc5034 I don't think it should cause the patch to fa
 you do know you can just add '.patch' to the end of a github commit url to get the raw patch?
 ^ that
 @The_LoudSpeaker [https://phab.lubuntu.me/P23], ^
 @RikMills P23 is what happens when I do that.
 @The_LoudSpeaker maybe you need to apply other upstream patches first.
 @HMollerCl [@The_LoudSpeaker maybe you need to apply other upstream patches first.], If this patch was the last commit on the master branch and master branch builds correctly using their methods, then also?
 I get … Applying patch xdg-final.patch … patching file daemon/core.cpp … Hunk #8 FAILED at 732. … Hunk #9 succeeded at 770 (offset -1 lines). … 1 out of 9 hunks FAILED -- rejects in file daemon/core.cpp … patching file daemon/core.h … patching file daemon/main.cpp … Hunk #1 succeeded at 43 with fuzz 1. … Patch xdg-final.patch does no
 against the unpacked source from Eoan archive
 @RikMills [I get … Applying patch xdg-final.patch … patching file daemon/core.cpp … Hunk #8 FAIL …], That's exactly what I got. see P23
 you need to apply patches from where eoan sources is to the one you need.
 No, you got a lot more failed hunks
 also keep in mind fuzz is bad 😜
 @teward001 [also keep in mind fuzz is bad 😜], yep, refresh, once the failing hunk is fixed
 @HMollerCl [you need to apply patches from where eoan sources is to the one you need.], Yeah … ```pull-lp-source lxqt-globalkeys```
 @HMollerCl [you need to apply patches from where eoan sources is to the one you need.], check P24 that's what I get when I am applying the patch to release 0.14.1 which is the one from which eoan sources.
 eoan sources way ahead from github, last upstream was commited in march
 @The_LoudSpeaker [check P24 that's what I get when I am applying the patch to release 0.14.1 which …], I did. they are not the same
 @RikMills [No, you got a lot more failed hunks], more failed hunks are when I don't use raw patch.
 @RikMills [I did. they are not the same], Just so we don't get confused,  … P23 is when I use a patch which I create by adding .patch to commit url. … P24 is when I use a patch created using `git diff bd9cb26d217ef7633570c947e5e7e410564eafc1 bd9cb26d217ef7633570c947e5e7e410564eafc1^ > ~/xdg-final.patch`
 in earlier case, I get exactly what you got( 1 hunk fail) and in second case I have more hunks failing.
 @The_LoudSpeaker have you follow this?
 https://phab.lubuntu.me/w/packaging/packaging-example/
 @HMollerCl [@The_LoudSpeaker have you follow this?], Yup! line to line. see https://phab.lubuntu.me/T59#1775
[18:09] -lugito:#lubuntu-devel- [High, Open] fix keyboard shortcuts: https://phab.lubuntu.me/T59#1775
 What I think is that there need to be applied previous patches. Don't know well how to check which of them.
[18:14] <kc2bez> paste a `quilt series` please
 https://github.com/lxqt/lxqt-globalkeys/commit/e0b23717e2f2efe503d5b56936831d4f22aaf870#diff-ab80dc7dc08557f267fdbc304d93533f
 that commit since 0.14.1 is the big cause of the hunk #8 fail
 @kc2bez [<kc2bez> paste a `quilt series` please], `raman@Aspire-ES1-132:~/opt/lxqt-globalkeys$ quilt series  … complete-config-file.patch … xdg-final.patch … raman@Aspire-ES1-132:~/opt/lxqt-globalkeys$`
 @RikMills [that commit since 0.14.1 is the big cause of the hunk #8 fail], so I will try patching that first and then applying raw patch of required commit.
 It might be all that is need. However, danger is, unless you quite well understand the code/changes and their intent, backportring more patches to make other patches to apply can in some cases just make bigger problem. i.e. patches might apply, but not work at runtime/compiletime with the rest of the code
 okay.
 btw a side shot,  …  - I checkedout the branch `releases-0.14.x` on the upstream code. …  - then ran `git am > ~/xdg-final.patch`  … (xdg-final.patch is the one I created using git diff command on master branch's latest commit)  … I am planning to see it the patch applies. But the problem is that the command is running since l
[19:04] <wxl> i'm putting this down for posterity: PHABRICATOR DOES NOT PROVIDE 2FA BACKUP CODES. if you have it enabled and have lost access to your 2FA device, you will have to have an admin remove your 2FA manually. 
[19:04] <wxl> a related tangent: freeotp does not offer a backup option.
 @The_LoudSpeaker [btw a side shot,  …  - I checkedout the branch releases-0.14.x on the upstream cod …], You are redirecting the output of `git am` to the file `~/xdg-final.patch`. Before producing some output (if any), `git am` expects some input, so you can wait a long, long time. … You should redirect the content of the patch
 @aptghetto [You are redirecting the output of git am to the file ~/xdg-final.patch. Before p …], *face palms*
 `git checkout master; git diff releases-0.14.x > ../all.diff` is not really small. … There are a lot of unrelated changes like translations. There are some cmake changes, and a lot of C to C++1x related changes.
[19:15] <wxl> @tsimonq2: you should go play with this and see if we can't set it up on our github repos https://help.github.com/en/articles/displaying-a-sponsor-button-in-your-repository
 Maybe you can try to delete the unrelated hunks from 'all.diff' and try to apply and build it.
 And then find a C++ dev to review your patch
[19:21] -queuebot:#lubuntu-devel- Builds: Lubuntu Desktop amd64 [Bionic 18.04.3] has been updated (20190805)
[19:21] -queuebot:#lubuntu-devel- Builds: Lubuntu Desktop i386 [Bionic 18.04.3] has been updated (20190805)
 @wxl [<wxl> @tsimonq2: you should go play with this and see if we can't set it up on o …], Seems to be pretty easy: `printf "%s\n%s\n%s\n" "patreon: lubuntu" "liberapay: lubuntu" "custom: ['https://teespring.com/stores/lubuntu', 'https://www.paypal.me/lubuntu']" > .github/FUNDING.yml`
 wxl: You checked this: phab.lubuntu.me/T59#1775 ?
[19:44] -lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T59#1777
 wxl: I read your comment. I have few doubts: … 1. Is applying the patch to latest release necessary even if its already merged into master and latest master builds correctly? and aren't we applying the patch to latest release only when following packaging example ?
[19:49] <wxl> latest release != latest master
 yeah latest release is 0.14.1 I know but see this: … ```raman@Aspire-ES1-132:~/opt/lxqt-globalkeys$ uscan --download-current-version … uscan: Newest version of lxqt-globalkeys on remote site is 0.14.1, specified download version is 0.14.1 … gpgv: Signature made Monday 25 February 2019 01:38:53 AM IST … gpgv:                usi
[19:50] <wxl> second quilt introduces debian/ubuntu changes
[19:51] <wxl> if it works fine with the latest release, then the issue is those changes
 so I shouldn't apply patches under debian/patches ?
[19:53] <wxl> if we can determine that's the case, then we analyze the situation and figure out the appropriate solution
 okay. I will try that.
 which patch should I apply? one created by adding .patch at url's end or one created using git diff ?
[19:57] <wxl> they should be the same
[19:57] <wxl> if they're not , that's a problem
 @The_LoudSpeaker [so I shouldn't apply patches under debian/patches ?], This didn't work. patch didn't apply.
 now trying to patch to `releases-0.14.x` on github. That's the latest release.
[20:15] <RikMills> 18.04.3 RC ISOs to test --> https://lists.ubuntu.com/archives/ubuntu-release/2019-August/004790.html
[20:15] <RikMills> http://iso.qa.ubuntu.com/qatracker/milestones/405/builds
[20:29] -lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] The_LoudSpeaker (Raman Sarda) commented on the task: https://phab.lubuntu.me/T59#1779
 @lugito [<lugito>  3[  13T59: fix keyboard shortcuts  3]   15The_LoudSpeaker (Raman Sarda …], wxl: ^
 also, should I ask upstream about when will the next release be available? If yes then how do I do that?
 @RikMills [https://github.com/lxqt/lxqt-globalkeys/commit/e0b23717e2f2efe503d5b56936831d4f2 …], wxl: any ideas?
[21:01] -lugito:#lubuntu-devel- [T87: Calamares: Address security issue related to FDE] kc2bez (Dan Simmons) commented on the task: https://phab.lubuntu.me/T87#1780
[21:07] -lugito:#lubuntu-devel- [T53: get rid of `$BROWSER`!] The_LoudSpeaker (Raman Sarda) commented on the task: https://phab.lubuntu.me/T53#1781
 @lugito [<lugito>  3[  13T53: get rid of `$BROWSER`!  3]   15The_LoudSpeaker (Raman Sarda …], wxl:
 @The_LoudSpeaker [also, should I ask upstream about when will the next release be available? If ye …], just open an issue, I did that with nm-tray https://github.com/palinek/nm-tray/issues/41
 @HMollerCl [just open an issue, I did that with nm-tray https://github.com/palinek/nm-tray/i …], Ack. Thanks!
 created here: https://github.com/lxqt/lxqt-globalkeys/issues/130
 also new 18.04.3 images are out
[22:36] -lugito:#lubuntu-devel- [rMANUAL6344baeebfc9: Add application_chooser screenshot] lynorian (Lyn Perrine) committed: https://phab.lubuntu.me/rMANUAL6344baeebfc9
[23:07] -lugito:#lubuntu-devel- [T53: get rid of `$BROWSER`!] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T53#1782
[23:10] -lugito:#lubuntu-devel- [T59: fix keyboard shortcuts] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T59#1783
[23:19] <wxl> if anyone can try to confirm this and comment about their experience in 19.04, i'd appreciate it https://www.reddit.com/r/Lubuntu/comments/ck31z4/no_windows_keyboard_shortcuts/evo5vwq/?st=jyz0ntdd&sh=d47bc2a6
 Which part would you like for me to confirm? The checkbox part or the upgrade part?
[23:23] <wxl> checkbox
[23:23] <wxl> more or less trying to eliminate ctrl-f4
[23:23] <wxl> seems to Just Work for me
 Yes, you need to double click. Weird.
[23:24] <wxl> i'm not really worried about that
 Oh, that is eoan.
[23:24] <wxl> but that you can disable it but then it's restored on reboot
 I will check that part too.
 Rebooted and still disabled.
[23:27] <wxl> could you comment there? you did do that in disco right?
 Eoan but I will check with Disco first.
[23:28] <wxl> yes please
[23:29] <wxl> supported only when dealing with support requests XD
 Yes. I know. I stopped myself. It was the closest machine I had.
[23:32] <wxl> i hear you
[23:32] <wxl> i almost do everything in it
 Same result in Disco. I will fire off a comment.
[23:42] -lugito:#lubuntu-devel- [T90: Bionic locker should be light-locker] wxl (Walter Lapchynski) commented on the task: https://phab.lubuntu.me/T90#1785
[23:43] -lugito:#lubuntu-devel- [T106: 18.04 SRUs] wxl (Walter Lapchynski) just created this task: https://phab.lubuntu.me/T106
[23:52] <wxl> sidebar in phab now has all our metatasks