| timClicks | babbageclunk, et al.: have any time to take a look at https://github.com/juju/juju/pull/10461 before standup? | 00:06 |
|---|---|---|
| babbageclunk | timClicks: sorry, just looking briefly now | 00:11 |
| timClicks | babbageclunk: re the vm template's name | 02:18 |
| timClicks | perhaps it could simply be "juju-unit-template"? | 02:19 |
| timClicks | because it will be hosted in a directory that's unique to each controller | 02:19 |
| timClicks | or "juju-{series}-template"? | 02:20 |
| timClicks | we could use the SHA256 string, but that feels unnecessarily complicated | 02:20 |
| babbageclunk | timClicks: I know in the vmdk code it had some extra structure to disambiguate... just looking hang on | 02:21 |
| babbageclunk | I think series was one part, was there anything else? | 02:21 |
| timClicks | the series is still there, fwiw - was part of the directory | 02:21 |
| timClicks | used to be /{controller uuid}/{series}/{sha265}.vmdk I think | 02:22 |
| timClicks | PR is currently using /{controller uuid}/{series}/juju-{model uuid}-template | 02:22 |
| babbageclunk | Ah, right - I think the rationale for the hash was so that you'd get a new image if it was released. But is that right? Wouldn't it just use it if it was already there? | 02:23 |
| babbageclunk | timClicks: jump into standup? | 02:23 |
| timClicks | ok | 02:23 |
| timClicks | babbageclunk: can you test the internal vsphere instance? it doesn't to be responsive | 03:16 |
| babbageclunk | timClicks: trying | 03:19 |
| babbageclunk | timClicks: works for me (tm) | 03:20 |
| babbageclunk | maybe vpn? | 03:20 |
| timClicks | babbageclunk: hrm, it appears that turning things on and off again isn't helping | 03:56 |
| timClicks | nm | 03:58 |
| timClicks | looks like changing to the us-based VPN is getting me through | 03:58 |
| timClicks | babbageclunk: hey final thought on template naming | 04:58 |
| timClicks | is there any need for it to be namespaced by the controller uuid? | 04:58 |
| babbageclunk | timClicks: sorry, missed this! Dumb mouse ran out of batteries | 05:09 |
| babbageclunk | timClicks: if it's not by controller ID then we don't know when to clean it up. | 05:09 |
| timClicks | that's a good point | 05:09 |
| babbageclunk | (without implementing some kind of reference counting but I don't know how we'd do that) | 05:10 |
| achilleasa | can I please get a CR for https://github.com/juju/juju/pull/10484? | 11:21 |
| manadart | achilleasa: I am having a look. | 11:29 |
| stickupkid | achilleasa, man, they don't sort the bundle changes in pylib | 11:34 |
| stickupkid | achilleasa, :| | 11:34 |
| achilleasa | stickupkid: does it even work for more complicated bundles? | 11:35 |
| stickupkid | achilleasa, i have no idea, probably not | 11:36 |
| achilleasa | stickupkid: I remember we were hitting issues with relations not being created in the correct order when we were working on the bundle cmr stuff | 11:36 |
| stickupkid | achilleasa, guess where i'm at now :D | 11:36 |
| stickupkid | haha | 11:36 |
| achilleasa | aha! | 11:36 |
| stickupkid | achilleasa, i really don't want to copy the same sort method, but I guess I have to? | 11:37 |
| stickupkid | achilleasa, i.e. i don't like it's non-terminal if things go wrong | 11:37 |
| stickupkid | achilleasa, anyway, i'm going grabbing some food, so i'll think over lunch | 11:38 |
| achilleasa | stickupkid: yeah... I wonder if you can somehow make it bail out if it exceeds a large number of comparisons (of course, finding a safe value for that is definitely not trivial) | 11:38 |
| achilleasa | manadart: can you take a look at this one too? https://github.com/juju/charm/pull/289 (this one is for fixing the relative bundle issues in the develop branch) | 12:10 |
| manadart | achilleasa: Sure. | 12:13 |
| manadart | achilleasa: Approved. | 12:30 |
| achilleasa | tyvm | 12:30 |
| achilleasa | can I get a CR for https://github.com/juju/juju/pull/10487? (it's the new and improved fix for resolving relative charm paths - for dev) | 16:11 |
| achilleasa | rick_h: this one ^^ also works with overlays | 16:12 |
| rick_h | achilleasa: yay | 16:12 |
| stickupkid | achilleasa, i'll have a look soon, fighting with circular dependencies of deps :( | 16:12 |
| stickupkid | achilleasa, approved | 16:42 |
| achilleasa | stickupkid: tyvm | 16:47 |
| stickupkid | rick_h, so that worked https://github.com/juju/juju/pull/10471 - we just need to fork this into juju namespace and we're good to go https://github.com/SimonRichardson/rpcreflect | 17:19 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!