| wallyworld | kelvinliu: hpidcock: i need food so will ping you guys in a bit | 01:11 |
|---|---|---|
| kelvinliu | yep | 01:12 |
| wallyworld | hpidcock: forgot to mention - that podspec set commit fix should also land in 2.6 | 01:12 |
| hpidcock | ok | 01:13 |
| wallyworld | kelvinliu: hpidcock: is now ok for hangout? | 01:40 |
| hpidcock | give me a sec | 01:40 |
| wallyworld | np just ping when ready | 01:41 |
| kelvinliu | im ok, we will wait hpidcock | 01:41 |
| hpidcock | wallyworld kelvinliu | 01:43 |
| timClicks | babbageclunk, wallyworld: vSAN PR be good; once you're happy there is some unit test churn to fix then I'll rebase | 02:27 |
| wallyworld | awesome, i'll let babbageclunk +1 it | 02:28 |
| timClicks | ok | 02:28 |
| timClicks | *should be good | 02:29 |
| babbageclunk | timClicks: looking now | 02:29 |
| hpidcock | wallyworld: https://github.com/juju/juju/pull/10488 not sure if this is how you would backport or if I should give the PR the same description as the one that landed in develop. | 02:58 |
| babbageclunk | timClicks: reviewed - the scoping thing's a bit hard to explain, let me know if you want more detail | 03:00 |
| === _thumper_ is now known as thumper | ||
| timClicks | babbageclunk: could you please take a look to see if I've fixed that? | 03:10 |
| babbageclunk | yup yup | 03:11 |
| babbageclunk | timClicks: you don't need to assign to err on line 253 - just the normal return will set err for the deferred func | 03:15 |
| babbageclunk | but other than that yes that'll fix it | 03:16 |
| timClicks | babbageclunk: should be fixed | 03:18 |
| wallyworld | hpidcock: we can go either way. sometimes a copy of the description is useful | 03:20 |
| hpidcock | ok cool, thank-you | 03:24 |
| timClicks | babbageclunk: could you please click resolve convo if you're happy with that error scoping fix | 03:42 |
| babbageclunk | wilco | 03:44 |
| babbageclunk | timClicks: sorry, otp but will straight after | 03:47 |
| timClicks | np | 03:47 |
| babbageclunk | timClicks: approved | 04:17 |
| timClicks | whaaaat | 04:18 |
| hpidcock | https://github.com/juju/juju/pull/10492 merge 2.6 into develop, no changes, just forward-porting a merge commit that makes merging confusing for the next person. | 05:23 |
| wallyworld | kelvinliu: there's a few things to look at in the actions PR. could you go through the comments from me and harry and fix those you agree with and we can talk about the rest | 05:45 |
| kelvinliu | sure | 05:46 |
| kelvinliu | wallyworld: now? | 05:46 |
| wallyworld | kelvinliu: we can chat now if you want - have a read of the comments and ping me? | 05:48 |
| kelvinliu | wallyworld: i think we can go through now if you r free | 05:55 |
| wallyworld | ok | 05:55 |
| kelvinliu | and hpidcock | 05:55 |
| hpidcock | oops sorry, was in the zone | 07:00 |
| hpidcock | wallyworld: the juju.io/cloud node annotations used for detecting substrate, it appears compileK8sCloudCheckers() doesn't have rules to match openstack | 07:02 |
| wallyworld | hpidcock: yeah, i can believe that. i can't recall offhand what the solution is there. i think we'll need to check the charm source code to see what it sets up | 07:06 |
| hpidcock | already on it | 07:07 |
| wallyworld | hpidcock: i think there may even be something in CDK kube-master charm which when related does something | 07:09 |
| wallyworld | i can check with cory tomorrow | 07:09 |
| hpidcock | Looks like it's done inside the kubernetes-worker charm and only for gce, ec2 and azure | 07:18 |
| wallyworld | it was on the todo list | 07:21 |
| wallyworld | i'll follow up | 07:21 |
| hpidcock | thank-you | 07:25 |
| stickupkid | anyone around for a CR https://github.com/juju/jsonschema-gen/pull/3 | 09:54 |
| achilleasa | stickupkid: looking ^^^ | 10:00 |
| achilleasa | stickupkid: done | 10:02 |
| stickupkid | achilleasa, whilst you're at it https://github.com/juju/juju/pull/10471 | 10:35 |
| achilleasa | stickupkid: sure. will look in 10min if that's OK with you | 10:36 |
| stickupkid | achilleasa, fine with me | 10:36 |
| stickupkid | achilleasa, manadart approved the now closed develop version https://github.com/juju/juju/pull/10467 if that helps | 10:48 |
| achilleasa | stickupkid: done. sorry for the delay | 11:28 |
| stickupkid | achilleasa, nps, ty | 11:28 |
| stickupkid | CR for merging 2.6 into develop https://github.com/juju/juju/pull/10493 | 12:17 |
| achilleasa | stickupkid: I 've noticed that hpidcock also has a forward merge PR (https://github.com/juju/juju/pull/10492) for his changes (which are included in your PR as well). | 12:20 |
| rick_h | achilleasa: with john and joe out can you please give thumper some time on https://github.com/juju/juju/pull/10491 | 12:23 |
| achilleasa | rick_h: sure thing | 12:25 |
| stickupkid | rick_h, ah, i'll merge his and then redo mine | 12:58 |
| stickupkid | achilleasa, correct 2.6 into develop after hpidcock was merged https://github.com/juju/juju/pull/10495 | 14:10 |
| achilleasa | stickupkid: approved | 14:11 |
| stickupkid | achilleasa, ta | 14:12 |
| rick_h | stickupkid: ok'd the one, started to look at the other but it needs updating based on the first so going to hold off then if that's cool | 14:16 |
| stickupkid | rick_h, yes of course | 14:16 |
| pmatulis | is there a bug whereby a model cannot be removed if CMR is in use? | 15:34 |
| rick_h | pmatulis: https://bugs.launchpad.net/juju/+bug/1768682 I think | 15:35 |
| mup | Bug #1768682: cross model breakage <juju:Triaged> <https://launchpad.net/bugs/1768682> | 15:35 |
| pmatulis | rick_h, thank you | 15:36 |
| pmatulis | rick_h, in the help for remove-relation there is the example 'juju remove-relation 4' . where is the ID of '4' exposed/visible? | 15:57 |
| rick_h | pmatulis: hmm, good question. So there's a relation id that's used in hooks/etc. I'd have to poke around to see if that's exposed in the normal UX in any way | 16:06 |
| pmatulis | rick_h, alright. i'm having quite a hard time recovering from trying to remove this model. looks like i have to wipe out the controller | 16:33 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!