| mup | PR snapcraft#2670 closed: Plugin colcon: forward parallel build count <Created by artivis> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2670> | 02:51 |
|---|---|---|
| mup | PR snapcraft#2681 closed: spread: fix unbound variable error <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2681> | 02:54 |
| mup | PR snapcraft#2675 closed: docs: quick init for lxd in HACKING.md <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2675> | 03:03 |
| mborzecki | morning | 05:09 |
| mvo | morning! so much red :/ has anyone looked for patterns yet? | 05:49 |
| mborzecki | mvo: morning, no haven't looked yet, i'm pushing golang-github-snapcore-gettext to fedora, but noticed that it was all red yesterday evening too | 06:09 |
| mvo | mborzecki: ok, I have a look | 06:11 |
| mup | PR snapd#7317 opened: httputil: rework protocol error detection <Created by mvo5> <https://github.com/snapcore/snapd/pull/7317> | 06:15 |
| mvo | looks like fastly is very unhappy 503, protocl_errors etc | 06:17 |
| mborzecki | mvo: looked at 3 prs, 3 different errors :/ | 06:18 |
| mvo | mborzecki: I looked at the test update one from samuele and it was all protocol_errors | 06:18 |
| mvo | mborzecki: another one a mix of protocol_errors and 503 | 06:18 |
| mvo | mborzecki: but yes, there is odd stuff in the mix in others too | 06:18 |
| mvo | mborzecki: looks like the protocol_error detection is buggy :/ | 06:18 |
| mborzecki | mvo: perhaps looking at the string was more reliable | 06:19 |
| mvo | mborzecki: its funny, I think some of the ones failing use the old string detection so its something fishy, maybe the old code was buggy too and we were just lucky :( | 06:20 |
| mvo | mborzecki: but yeah, pushed a PR with better string based detection and slightly improved debug | 06:21 |
| mborzecki | mvo: hm type assertion didn't work then? | 06:21 |
| mvo | mborzecki: maybe or its something strange with the imports, the bundled golang h2_bundle.go does not have a StreamError | 06:22 |
| mvo | mborzecki: so it might be some strange interplay between the bunblded http2 and the x/net/http2 | 06:22 |
| mvo | mborzecki: I can dig some more, its just so time consuming :/ | 06:23 |
| mborzecki | mvo: there's http2StreamError, iirc h2_bundle is x/net/http2 impoted and all funcs and types with http2 prefix | 06:23 |
| mvo | mborzecki: yeah, this is the one my latest PR string matches on. its not an exported error unfortunately | 06:23 |
| mborzecki | mvo: //go:generate bundle -o h2_bundle.go -prefix http2 -underscore golang.org/x/net/http2 | 06:23 |
| mvo | mborzecki: what is strange is that I had a tiny go example client running against a (c) http2 server that would produce stream errors and there I got the right errors | 06:24 |
| mvo | mborzecki: anyway, I will investigate but it seems worthwhile to unblock ppl | 06:25 |
| mvo | mborzecki: also 7312 would be good | 06:25 |
| mvo | mborzecki: I saw some issues where the non-home user could not be deleteted because some process was still in use which I think this PR will fix (--force ftw!) | 06:25 |
| mborzecki | mvo: did you import x/net/http2 in that tiny go client? | 06:25 |
| mvo | mborzecki: yeah, I have to for the error casting | 06:26 |
| mvo | mborzecki: it is also imported in httputil | 06:27 |
| mvo | mborzecki: http://paste.ubuntu.com/p/5m7nzf3yNZ/ | 06:28 |
| mborzecki | mvo: ok, the docs on https://godoc.org/net/http say we'd need to use ConfigureTransport() or sth | 06:28 |
| mvo | mborzecki: hm, I thought its doing this automatically | 06:28 |
| mborzecki | mvo: perhaps then it would always use the http client from imported lib | 06:28 |
| mvo | mborzecki: let me try that | 06:29 |
| mvo | mborzecki: and indeed | 06:29 |
| mvo | mborzecki: my test code is doing this | 06:29 |
| mvo | mborzecki: because I need to override the tls config :( | 06:29 |
| mvo | mborzecki: if we override the default transport will it fall back to http1 automatically? | 06:30 |
| mvo | mborzecki: also - I wonder if its worth it vs string detection :/ | 06:30 |
| mborzecki | mvo: yeah, i'd assume that it falls back autmatically | 06:30 |
| mborzecki | mvo: quckly scanning the code, it sets up the handler of upgrading the protocol once h2 is seen in ALPN | 06:33 |
| mborzecki | mvo: so your client code would start with http.Transport{} and then call http2.ConigureTransport() on that | 06:34 |
| mvo | mborzecki: let me play with this | 06:36 |
| mup | PR snapd#7307 closed: mkversion.sh: fix version from git checkouts <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7307> | 06:39 |
| mup | PR snapd#7273 closed: gadget, overlord/devicestate: rename Position/Layout <Gadget update> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7273> | 06:47 |
| ackk | hi, anyone has an idea on how to find out what's keeping loop devices busy in https://bugs.launchpad.net/snapd/+bug/1841137 ? | 06:55 |
| mup | Bug #1841137: /dev/loopX devices left around for removed snap revisions <snapd:New> <https://launchpad.net/bugs/1841137> | 06:55 |
| mvo | Chipaca: hey, good morning, you are around early :) | 06:57 |
| mvo | hey pedronis ! still lots of reds but some progress in hopefully making things less red | 06:58 |
| Chipaca | mvo: forgot to close irc before suspending the notebook yesterday, so it connected as soon as i opened it to catch up with the world over breakfast | 06:58 |
| Chipaca | mvo: good morning =( | 06:58 |
| Chipaca | er, i meant =( | 06:58 |
| Chipaca | wait | 06:58 |
| Chipaca | =) | 06:58 |
| Chipaca | there | 06:58 |
| mvo | Chipaca: hahaha | 06:58 |
| Chipaca | silly half-asleep hands | 06:58 |
| * mvo kicks Chipaca from irc again until he has tea/coffee | 06:59 | |
| mup | PR snapd#7271 closed: many: generalize assertstate.Batch to asserts.Batch, have assertstate.AddBatch <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7271> | 06:59 |
| * Chipaca disappears | 06:59 | |
| mborzecki | Chipaca: hey, good morning | 07:05 |
| mborzecki | mvo: you're trying out wth ConfigureTransport then? in which case I'll stop going through 7317 ;) | 07:06 |
| mvo | mborzecki: I'm looking into it but I think its not worth waiting | 07:07 |
| mvo | mborzecki: I'm also more and more convinced that whatever we do we need a test :/ | 07:07 |
| === pstolowski|afk is now known as pstolowski | ||
| pstolowski | morning | 07:07 |
| mvo | mborzecki: which is annoying, I think I will snap my libevent-server hack from nghttp2 | 07:08 |
| mvo | mborzecki: so that we have something we can test against - one issue with this is that http2 is tls so I need keys and for self-signed I need to alter the config which lead to the issue that my test client was not quite in the same state as the real one | 07:08 |
| mvo | mborzecki: did I mention its annoying ;) | 07:09 |
| mup | PR snapd#7306 closed: overlord/configstate: sort patch keys to have deterministic order with snap set <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/7306> | 07:09 |
| mvo | thanks pstolowski ! nice to see this one goingin | 07:10 |
| pstolowski | mvo: yeah, that was the last one | 07:11 |
| pstolowski | mvo: can you take another look at https://github.com/snapcore/snapd/pull/7219 ? it's close to landing | 07:12 |
| mup | PR #7219: devicestate/firstboot: check for missing bases early <Created by stolowski> <https://github.com/snapcore/snapd/pull/7219> | 07:12 |
| mborzecki | pstolowski: hey | 07:13 |
| mvo | pstolowski: yes! fiddling a bit with tests then I'm ready | 07:13 |
| mvo | a review for 7312 would be great, it should eliminiate another relatively common test failure | 07:20 |
| zyga | Good morning | 07:21 |
| mvo | hey zyga | 07:23 |
| zyga | Sleeping with two kids and a dog on one bed | 07:27 |
| zyga | Ugh | 07:27 |
| zyga | Brb | 07:27 |
| mborzecki | looks like some redditors attended the london meetup https://www.reddit.com/r/linux/comments/ctxaff/rebootless_kernel_updates_by_canonical/ | 07:34 |
| mup | PR snapd#7318 opened: many: merging asserts.Batch Precheck with CommitTo and other clarifications <Created by pedronis> <https://github.com/snapcore/snapd/pull/7318> | 07:36 |
| pedronis | mvo: ^ the follow to asserts.Batch PR | 07:36 |
| mup | PR snapd#7312 closed: tests: use user-tool to remove test user in the non-home test <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7312> | 07:46 |
| mup | PR snapd#7319 opened: spread.yaml: set centos-7-64 to manual <Created by mvo5> <https://github.com/snapcore/snapd/pull/7319> | 07:50 |
| pedronis | Chipaca: have you have a moment, can you double check the last changes to https://github.com/snapcore/snapd/pull/7149 | 07:53 |
| mup | PR #7149: cmd: add snap model command; daemon: add /v2/model, /v2/model/serial REST APIs <Remodel :train:> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7149> | 07:53 |
| Chipaca | pedronis: sure, in a bit | 07:55 |
| pstolowski | pedronis: hey, on pi3 the aa_parser timings are indeed showing significant difference with multiple runs vs all-at-once, the later is 3x faster with just 11 snaps. i'm writing a summary | 07:58 |
| pedronis | thank you | 07:58 |
| zyga | pstolowski: nice work | 08:02 |
| mvo | pstolowski: nice! | 08:03 |
| mborzecki | mvo: have you seen this error /usr/sbin/deluser: `/sbin/userdel jim' returned error code 8. Exiting. ? | 08:03 |
| mborzecki | mvo: accroding to manapage, 8 means the user is logged in | 08:04 |
| zyga | jim? | 08:04 |
| mvo | mborzecki: yes | 08:04 |
| mvo | mborzecki: this is what the Pr you most recently reviewed was about | 08:04 |
| mvo | mborzecki: using the new "user-tool del" that uses deluser --force | 08:04 |
| mborzecki | mvo: wondering why userdel believes the user is logged in though | 08:06 |
| mborzecki | mvo: could that be somehow related to issues that zyga saw on arch | 08:06 |
| mvo | mborzecki: I think it checks for processes that are owned by the user | 08:06 |
| mvo | mborzecki: the issue from zyga was about systemd creating files or something? | 08:06 |
| zyga | mvo: why did you add --remove to userdel? | 08:07 |
| zyga | mvo: pam I think | 08:07 |
| zyga | mvo: and why only to one branch of the code? | 08:07 |
| mvo | zyga: it removes the homedir as well | 08:07 |
| zyga | aha, and should it run on core too? | 08:08 |
| mvo | zyga: uh, you are right, the second one should also have it for completness | 08:08 |
| zyga | mvo: I rebased https://github.com/snapcore/snapd/pull/7309/files | 08:08 |
| mvo | zyga: the current master should fix the practical failure but it still should be consistent | 08:08 |
| mvo | zyga: ta | 08:08 |
| mup | PR #7309: tests: re-implement user tool in python <Created by zyga> <https://github.com/snapcore/snapd/pull/7309> | 08:08 |
| zyga | mvo: if you can review that I'll follow up with extra --remove in the core case | 08:09 |
| zyga | I'm looking at chipaca's PR | 08:09 |
| mup | PR snapd#7320 opened: snap/pack, cmd_pack: 'snap pack --check-skeleton' checks interfaces <Created by chipaca> <https://github.com/snapcore/snapd/pull/7320> | 08:24 |
| * Chipaca curses at his trackpad | 08:25 | |
| Chipaca | zyga: thank you for looking at my pr | 08:26 |
| Chipaca | oh, drat, import cycle | 08:38 |
| Chipaca | in tests | 08:39 |
| Chipaca | :-( | 08:39 |
| mup | PR snapd#7320 closed: snap/pack, cmd_pack: 'snap pack --check-skeleton' checks interfaces <Created by chipaca> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/7320> | 08:42 |
| mborzecki | Chipaca: :( and i was looking at it | 08:43 |
| Chipaca | mborzecki: sorry :-( it shouldn't change too much, but import cycles are hard to fix | 08:43 |
| Chipaca | mborzecki: need to shunt the code around | 08:43 |
| mborzecki | Chipaca: fwiw you could just call snap.SanitizePlugsSlots | 08:44 |
| mborzecki | or not :/ need to import interfaces/builtin | 08:44 |
| Chipaca | pstolowski: question for you sir | 08:50 |
| Chipaca | pstolowski: why is 'plug/slot sanitization not possible from snap command'? | 08:50 |
| pstolowski | Chipaca: because that would required all interfaces/ code to be imported, since they define BeforePrepare* methods | 08:56 |
| Chipaca | pstolowski: and why is that bad? | 08:56 |
| pstolowski | Chipaca: i don't know, might be historical; at some point i was told it was bad ;). maybe pedronis / mvo / zyga remember | 08:59 |
| mborzecki | zyga: experimental.parallel-instances is set to true, shouldn't there be a feature file in /var/lib/snapd/features? | 08:59 |
| zyga | Chipaca: as in statically? | 08:59 |
| zyga | Chipaca: because some are only sanitized after connections I guess | 09:00 |
| zyga | but I think it'd be nice to have a pre-check | 09:00 |
| zyga | mborzecki: not always, check for is-exported | 09:00 |
| zyga | mborzecki: only exported flags have this | 09:00 |
| pedronis | Chipaca: I'm not sure what's the question there? | 09:00 |
| Chipaca | 1 sec | 09:01 |
| Chipaca | pedronis: in cmd/snap/main.go we replace snap.SanitizePlugSlots with a nop | 09:02 |
| mup | PR snapd#7320 opened: snap/pack, cmd_pack: 'snap pack --check-skeleton' checks interfaces <Created by chipaca> <https://github.com/snapcore/snapd/pull/7320> | 09:02 |
| Chipaca | pedronis: there's even a comment, // plug/slot sanitization not used nor possible from snap command, make it no-op | 09:03 |
| pedronis | Chipaca: ah | 09:03 |
| pedronis | not sure | 09:03 |
| Chipaca | pedronis: but, for #1617302, I _want_ that code to be usable | 09:03 |
| mup | Bug #1617302: Specifying a nonexistent plug does cause any errors <Snapcraft:Triaged> <Snappy:Triaged by chipaca> <https://launchpad.net/bugs/1617302> | 09:03 |
| pedronis | you'll have to dig | 09:03 |
| Chipaca | pedronis: so, I dropped that no-op'ing | 09:03 |
| Chipaca | pedronis: and nothing broke :-) | 09:03 |
| mborzecki | zyga: hm maybe we should export all experimental flags by default | 09:03 |
| pstolowski | zyga: no, this is about BeforePreparePlug|Slot, so static | 09:04 |
| zyga | mborzecki: we had that discussion | 09:04 |
| zyga | mborzecki: and it was nacked | 09:04 |
| pedronis | Chipaca: might be there is a size concern | 09:04 |
| mborzecki | zyga: duh, ok | 09:04 |
| zyga | mborzecki: I think it's fine to export it if there is a purpose | 09:04 |
| zyga | pstolowski: interesting, then I don't know | 09:04 |
| Chipaca | pedronis: might be; locally snapd goes from 17 to 18 MBs with that import (from 10 to 11 stripped) | 09:04 |
| mborzecki | zyga: heh, so we're missing a bit that updates the feature files on startup :/ | 09:07 |
| zyga | mborzecki: hmm? | 09:07 |
| mborzecki | zyga: the feature files are created only when core config is updated | 09:08 |
| pstolowski | Chipaca: ok, i've an idea | 09:08 |
| zyga | mborzecki: I thought we had that, because I kept looking at that code at the time and it was full of interesting avenues | 09:08 |
| zyga | mborzecki: ah, because you exported it now and it is gone | 09:08 |
| === alan_g is now known as alan_g_ | ||
| mborzecki | zyga: s/gone/not added/ | 09:08 |
| zyga | yeah | 09:08 |
| Chipaca | pstolowski: sounds dangerous | 09:09 |
| pstolowski | Chipaca: i think we did this because they were already validated on install, so you're not paying the penalty every time on snap run - execApp reads the yaml and calls Sanitize internally (and is noop atm) | 09:10 |
| Chipaca | pstolowski: can you comment on the PR? | 09:11 |
| Chipaca | pstolowski: it sounds like i need to do some trickery :-) | 09:11 |
| * Chipaca is fine with trickery | 09:11 | |
| pstolowski | sure | 09:14 |
| mup | PR snapd#7310 closed: devicestate: add missing test for remodeling possibly removing required flag <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7310> | 09:15 |
| mup | PR snapd#7318 closed: many: merging asserts.Batch Precheck with CommitTo and other clarifications <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7318> | 09:17 |
| pstolowski | Chipaca: commented | 09:22 |
| * pstolowski will learn one day the spelling of "negligible" after looking it up again in the dict | 09:24 | |
| pedronis | reminder: #7135 needs a 2nd review | 09:25 |
| mup | PR #7135: image: support prepare-image --classic for snapd snap only images <Created by pedronis> <https://github.com/snapcore/snapd/pull/7135> | 09:25 |
| zyga | Chipaca: https://github.com/snapcore/snapd/pull/7185#pullrequestreview-278861850 | 09:34 |
| mup | PR #7185: boot, etc.: refactor boot to have a lookup with different imps <Created by chipaca> <https://github.com/snapcore/snapd/pull/7185> | 09:34 |
| mup | PR snapd#7314 closed: tests/main/mount-ns: account for clone_children in cpuset cgroup on 18.04 <Simple 😃> <Created by bboozzoo> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7314> | 09:42 |
| Chipaca | zyga: I can't refactor all the things in a single PR :-/ | 09:49 |
| Chipaca | it'd be un-reviewable | 09:49 |
| zyga | Chipaca: that's fine, that's why my general comment was "how do you want to proceed" | 09:49 |
| Chipaca | zyga: "find a nice sandy riverbank and have a cookout" | 09:49 |
| * Chipaca goes for coffee | 09:51 | |
| mup | PR snapd#7135 closed: image: support prepare-image --classic for snapd snap only images <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7135> | 10:02 |
| pstolowski | pedronis: https://forum.snapcraft.io/t/apparmor-parser-performance-on-pi3/12909 | 10:03 |
| mup | PR snapd#7311 closed: snap/naming: introduce SnapRef, Snap, and SnapSet <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7311> | 10:04 |
| ogra | pstolowski, i wish you would test on actual low-end HW (imx6ull like rigado uses or a beaglebone/pocketbeagle) with actual single core CPU and respectively slow IO channels ... but it is awesome that this gets finally attacked at least :) | 10:13 |
| ogra | pi's are way to powerful :) | 10:14 |
| pstolowski | ogra: haha, pi3 is the slowest hw i have :) | 10:14 |
| zyga | pstolowski: boot with cpu=1 | 10:15 |
| zyga | or whatever the switch is | 10:15 |
| mborzecki | cpus iirc | 10:15 |
| ogra | zyga, that doesnt help shpwing actual single core IO performance | 10:16 |
| zyga | IO performance? | 10:16 |
| pstolowski | i think the point of the test has already been proved | 10:16 |
| ogra | yeah, the prob with real single core arm is that your IO is just something like a fifo ... if you take multi-core HW you still use the fast IO channels. even if you limite the number of cores | 10:17 |
| ogra | yeah, it has | 10:17 |
| pstolowski | and it obviously will be much worse on weaker specs | 10:17 |
| ogra | but it wont give you realistic numbers as we get them on real customer HW | 10:17 |
| ogra | right | 10:17 |
| mborzecki | pstolowski: maxcpus https://elixir.bootlin.com/linux/latest/source/Documentation/admin-guide/kernel-parameters.txt#L2368 if you want to play with it | 10:17 |
| * ogra points at 30min firstboot times :) | 10:17 | |
| pstolowski | mborzecki: yeah i know, i used it for some other test the other day | 10:18 |
| mborzecki | pstolowski: each time we do an interation on performance :P | 10:18 |
| mup | PR snapd#7321 opened: tests: restore dpkg selections after upgrade-from-2.15 test <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7321> | 10:23 |
| zyga | where did mvo go? | 10:26 |
| mup | PR snapd#7322 opened: tests: wait_for_service shows status after actual first minute <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7322> | 10:26 |
| zyga | mborzecki: ^ two trivial PRs | 10:26 |
| zyga | mborzecki: slightly longer but also simple https://github.com/snapcore/snapd/pull/7309 | 10:29 |
| mup | PR #7309: tests: re-implement user tool in python <Created by zyga> <https://github.com/snapcore/snapd/pull/7309> | 10:29 |
| mup | PR snapd#7323 opened: features, overlord: make parallel-installs exported, export flags on startup <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7323> | 10:35 |
| mborzecki | zyga: feature flag ^^ | 10:35 |
| zyga | looking | 10:36 |
| zyga | mborzecki: please also change cmd/libsnap-confine-private/feature.[ch] | 10:36 |
| mborzecki | duh /o\ | 10:37 |
| zyga | :D | 10:37 |
| mborzecki | ok, i can change that bit in the PR with C code | 10:38 |
| zyga | mborzecki: add one liner test to TestControlFile as well please | 10:39 |
| zyga | and if you do roll the C changes to flags here as well | 10:39 |
| zyga | so that the other PR focuses only on the meat of the parallel installs for classic snaps | 10:39 |
| zyga | d'oh | 10:40 |
| zyga | I found why interfaces-fuse_support misbehaved | 10:40 |
| zyga | I'll also rename the directory because it's silly | 10:41 |
| zyga | hey mvo | 10:45 |
| zyga | mvo: can you look at https://github.com/snapcore/snapd/pull/7319 - there's a question there | 10:45 |
| mup | PR #7319: spread.yaml: set centos-7-64 to manual <Created by mvo5> <https://github.com/snapcore/snapd/pull/7319> | 10:45 |
| mup | PR snapd#7319 closed: spread.yaml: set centos-7-64 to manual <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7319> | 10:46 |
| zyga | thanks! | 10:46 |
| mvo | zyga: yes, already replied, the most recent run of another PR was green so it seems to be resolved already | 10:46 |
| zyga | mvo: I think 7321 is something you want to look at as well | 10:46 |
| mvo | zyga: I saw it on 2 PRs before hence the change but looks short-lived | 10:46 |
| zyga | (super simple) | 10:46 |
| zyga | and if you still want to after that, https://github.com/snapcore/snapd/pull/7309 to put the user-tool change to rest | 10:47 |
| mup | PR #7309: tests: re-implement user tool in python <Created by zyga> <https://github.com/snapcore/snapd/pull/7309> | 10:47 |
| mvo | zyga: thanks, I will followup in this one | 10:47 |
| mvo | zyga: on the 7321 | 10:47 |
| mup | PR snapd#7324 opened: image: improve/tweak some warning/error messages <Created by pedronis> <https://github.com/snapcore/snapd/pull/7324> | 10:48 |
| pedronis | Chipaca: ^ | 10:48 |
| Chipaca | pedronis: thank you | 10:48 |
| mup | PR snapd#7325 opened: cmd/libsnap-confine-private: add checks for parallel instances feature flag <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7325> | 10:49 |
| mborzecki | zyga: ^^ | 10:49 |
| zyga | +1 | 10:50 |
| mup | PR snapd#7225 closed: tests: don't repeat checks <â›” Blocked> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/7225> | 10:51 |
| zyga | mborzecki: can you do a pass over the two simple PRs I sent | 10:51 |
| zyga | I'll grab coffee and be back soon | 10:51 |
| mvo | zyga: I added a comment to 7321, might be best to have a quick HO so that we can chat about the intended result | 10:54 |
| zyga | mvo: d'oh! | 11:02 |
| zyga | man so dpkg is not doing what I thought it would do | 11:02 |
| mvo | zyga: no worries, its a common misconception | 11:03 |
| mvo | zyga: this mechasnism is *really* old :) | 11:03 |
| mup | PR snapd#7299 closed: sanity: report proper errror when fuse is needed but not available <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7299> | 11:03 |
| zyga | mvo: so are you saying there is no reliably way to save/restore actual packages installed on the system? | 11:03 |
| mvo | zyga: is that what you want? checkpoint; do stuff; restore? | 11:03 |
| zyga | yes | 11:03 |
| zyga | so that this test doesn't impact the set of installed packages that much | 11:04 |
| mvo | zyga: ok, let me scratch my head about this a wee bit | 11:04 |
| mvo | zyga: there is no trivial way I think | 11:04 |
| zyga | mvo: also, to actually describe the snasphot | 11:05 |
| zyga | so that we can use the same thing for detection | 11:05 |
| zyga | (in other words, to produce a diff when test doesn't clean up) | 11:05 |
| mborzecki | zyga: sure, will do | 11:14 |
| mvo | zyga: I add something in python-apt to tests/lib/bin | 11:14 |
| zyga | mvo: super, thank you | 11:15 |
| mvo | zyga: there is actually a tool called apt-clone which we might use but it won't remove stuff, should be easy to add though | 11:15 |
| mvo | zyga: sry that this is so hard :/ | 11:15 |
| mup | PR snapd#7326 opened: tests: unmount fuse connections only if not initially mounted <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7326> | 11:15 |
| zyga | mvo: for context, I have an in-flight tool called "testbed-tool" that invokes helper tools to examine system state (it uses mountinfo-tool currently) | 11:15 |
| zyga | mvo: if we do it right I can use your apt code once you have it | 11:15 |
| zyga | mvo: please look at 7326 -- that's the last leak on classic | 11:16 |
| zyga | it took me longer because I was blind and didn't see - vs + in the diff :) | 11:16 |
| zyga | this unblocks mount-ns test again | 11:16 |
| zyga | we still leak stuff on core, mainly in mysterious ways (mounts that are not accounted to any snaps) | 11:16 |
| zyga | but this is a major step towards not leaking anything anymore :) | 11:16 |
| mup | PR snapd#7321 closed: tests: restore dpkg selections after upgrade-from-2.15 test <Simple 😃> <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/7321> | 11:17 |
| zyga | mborzecki: I'll focus on re-enabling mount-ns test on classic only now | 11:18 |
| mborzecki | zyga: btw. parallel installs PR also broke socket activation under enforcing selinux, wonde if there's osmething wrong with the contexts after the bind mount | 11:18 |
| mborzecki | zyga: obviously nothing in the logs :P | 11:18 |
| zyga | mborzecki: oh, that's odd | 11:18 |
| zyga | https://www.irccloud.com/pastebin/6v7HDXvH/ | 11:18 |
| zyga | do you have the log? | 11:18 |
| mborzecki | zyga: no, need to try locally and probably disable noaudit | 11:19 |
| zyga | +1 | 11:19 |
| zyga | I'll spawn some tests and return to 7218 | 11:25 |
| zyga | mvo: https://github.com/Originate/scriptkeeper | 11:26 |
| pedronis | pstolowski: can #7219 be landed? | 11:31 |
| mup | PR #7219: devicestate/firstboot: check for missing bases early <Created by stolowski> <https://github.com/snapcore/snapd/pull/7219> | 11:31 |
| mborzecki | zyga: https://forum.snapcraft.io/t/cannot-use-gimp-snap-as-rawtherapee-external-editor/12908 heh /tmp | 11:37 |
| mvo | zyga: I pushed something to your PR | 11:38 |
| mvo | zyga: I am running a test locally now | 11:38 |
| zyga | mvo: which one? | 11:39 |
| mvo | zyga: the apt one | 11:39 |
| zyga | ah, I closed it | 11:39 |
| zyga | you can reopen though | 11:39 |
| mvo | zyga: yeah, once the local run is done I will | 11:39 |
| zyga | mvo: what did you push, gh is not showing anything (because it is closeD) | 11:40 |
| * zyga hugs mvo for not giving up :) | 11:40 | |
| * zyga just ran 1400 tests without leaking a single mount entry | 11:40 | |
| zyga | I'm _so_ happy we reached this stage | 11:40 |
| zyga | core is the next battleground but it is already in a saner state because many of the bugs were shared | 11:40 |
| mvo | zyga: hm, it rejected my push with permission denied | 11:41 |
| mvo | zyga: thats odd | 11:41 |
| zyga | yeah because it's closed now | 11:41 |
| zyga | let me reopen | 11:41 |
| zyga | mvo: try now please | 11:41 |
| mvo | zyga: aha, interessting | 11:41 |
| mvo | zyga: yeha, that works now | 11:41 |
| mup | PR snapd#7321 opened: tests: restore dpkg selections after upgrade-from-2.15 test <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7321> | 11:42 |
| zyga | mvo: git add apt-tool | 11:42 |
| zyga | :D | 11:42 |
| zyga | and I *love* what we are doing to tests | 11:42 |
| zyga | 2000 tests and no leaks | 11:43 |
| mvo | zyga: yeah, I could have sworn I did a git add before, maybe typoed | 11:43 |
| mvo | oh well | 11:43 |
| mup | PR snapcraft#2671 closed: docker: remove snapcraft-wrapper <Created by abitrolly> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2671> | 11:43 |
| mborzecki | wow, systemctl restart bluetooth killed the whole shell | 11:43 |
| mvo | pushed now | 11:43 |
| zyga | I wonder if core has a systemic problem or is it some systemic test that messes up there | 11:43 |
| zyga | mborzecki: whaaat? | 11:43 |
| zyga | mvo: mind if I improve on it? :D | 11:43 |
| zyga | just with CLI and types | 11:44 |
| zyga | mvo: cli helps to detect bugs in the invocation form the hsell | 11:44 |
| zyga | *shell | 11:44 |
| zyga | mvo: types help others and somewhat ourselves as we read the code | 11:44 |
| mvo | zyga: lets wait to see if it actually works | 11:45 |
| zyga | mvo: what happens when cache.commit() fails? is there a rollback or something? | 11:45 |
| zyga | mvo: +1 | 11:45 |
| mvo | zyga: no, then the world is on fire | 11:45 |
| zyga | heh | 11:45 |
| zyga | the good old world of classic packages | 11:45 |
| mvo | zyga: yes | 11:45 |
| mvo | zyga: I destroyed my chroot just now with some strange maintainer script | 11:46 |
| mvo | oh well | 11:46 |
| * Chipaca wanders off to ponder lunch | 11:46 | |
| mvo | zyga: I'm a mupett s/python/pytho3/ for a start, reruning the test | 11:48 |
| zyga | mvo: try any-python if it is compatible with python2 and python3 | 11:48 |
| mup | PR snapd#7327 opened: snap/naming: simplify SnapSet somewhat <Created by pedronis> <https://github.com/snapcore/snapd/pull/7327> | 12:06 |
| mup | PR snapd#7322 closed: tests: wait_for_service shows status after actual first minute <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7322> | 12:09 |
| pedronis | pstolowski: could you merge master into #7207 ? #7129 has a conflict now | 12:10 |
| mup | PR #7207: snap: prevent duplicated snap name and snap files when parsing seed.yaml <Created by stolowski> <https://github.com/snapcore/snapd/pull/7207> | 12:10 |
| mup | PR #7129: userd: allow setting default-url-scheme-handler <Created by jwheare> <https://github.com/snapcore/snapd/pull/7129> | 12:10 |
| pedronis | wrong one | 12:11 |
| pedronis | #7219 | 12:11 |
| mup | PR #7219: devicestate/firstboot: check for missing bases early <Created by stolowski> <https://github.com/snapcore/snapd/pull/7219> | 12:11 |
| pstolowski | pedronis: yes, on it | 12:11 |
| pstolowski | ok, i hope i merged correctly.. it was slightly confusing | 12:31 |
| pedronis | pstolowski: I can double check | 12:32 |
| === ricab is now known as ricab|lunch | ||
| mborzecki | slightly larger review around configstate & configcore https://github.com/snapcore/snapd/pull/7323 if anyone's interested | 12:47 |
| mup | PR #7323: features, overlord: make parallel-installs exported, export flags on startup <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7323> | 12:47 |
| mborzecki | and it's green :P | 12:47 |
| zyga | mborzecki: one comment there still needs changes | 12:51 |
| mborzecki | hmmm | 12:52 |
| mborzecki | w8 | 12:52 |
| mborzecki | du, didn't force push :/ | 12:52 |
| zyga | mvo: what's the status of https://github.com/snapcore/snapd/pull/7321? | 12:57 |
| mup | PR #7321: tests: restore dpkg selections after upgrade-from-2.15 test <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7321> | 12:57 |
| mvo | zyga: meetings, sry, need to look | 13:04 |
| zyga | no worries | 13:04 |
| mborzecki | zyga: hm about dpkg selections, there's probably a quick'n'dirty way to do that with rpm, baiscally rpm -qa > state.before and later rpm -ev $(grep -f state.before -v state.after) | 13:22 |
| mborzecki | zyga: tbh, we could probably do the same with every package manager we support | 13:23 |
| pedronis | pstolowski: this one I think needs a merge from master: https://github.com/snapcore/snapd/pull/7207 | 13:25 |
| mup | PR #7207: snap: prevent duplicated snap name and snap files when parsing seed.yaml <Created by stolowski> <https://github.com/snapcore/snapd/pull/7207> | 13:25 |
| zyga | mborzecki: yeah, mvo started that for apt but we can explore generalizing it | 13:25 |
| mup | PR snapd#7325 closed: cmd/libsnap-confine-private: add checks for parallel instances feature flag <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7325> | 13:25 |
| mborzecki | zyga: and wow, rpm -e is sooo much faster than dnf erase zsh | 13:26 |
| zyga | python :) | 13:26 |
| pstolowski | pedronis: pushed | 13:26 |
| pedronis | pstolowski: thanks, let's see how it goes | 13:27 |
| * zyga runs a bunch of tests and breaks for a while | 13:41 | |
| zyga | ping me on TG for insta-back | 13:41 |
| mup | PR snapd#7324 closed: image: improve/tweak some warning/error messages <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7324> | 13:54 |
| === ricab|lunch is now known as ricab | ||
| mvo | zyga: the tool should finally be ok - sry for the slow going on this | 14:19 |
| zyga | mvo: cool, I'm back now | 14:19 |
| zyga | looking | 14:19 |
| zyga | - Download snap "snapd-hacker-toolbelt" (22) from channel "stable" (stream error: stream ID 1; PROTOCOL_ERROR) | 14:20 |
| zyga | booo | 14:20 |
| mvo | zyga: I have a PR for that :/ | 14:30 |
| mvo | zyga: which failed in system-usernames-missing-user cleanup on tumbleweed :( | 14:31 |
| pedronis | pstolowski: did you do something different when pushing the last time: https://travis-ci.org/snapcore/snapd/jobs/575808884 | 14:39 |
| pedronis | mvo ^ | 14:39 |
| zyga | mvo: do we have a deadlock in those PRs? | 14:39 |
| zyga | one fix blocking landing another | 14:40 |
| mvo | zyga: I'm not sure why the tumbleweed one fails, I need to check, its strange | 14:40 |
| mvo | zyga: I mean, I think we cleanup so I wonder how the snap_daemon can be there already | 14:41 |
| zyga | mvo: userdel vs deluser? | 14:41 |
| zyga | just a guess | 14:41 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/7309 is green | 14:48 |
| mup | PR #7309: tests: re-implement user tool in python <Created by zyga> <https://github.com/snapcore/snapd/pull/7309> | 14:48 |
| pstolowski | pedronis: hmm i don't think so | 14:49 |
| mvo | zyga: checking | 15:01 |
| pedronis | pstolowski: there is something weird there: https://github.com/snapcore/snapd/pull/7219/commits see the butlast commit | 15:01 |
| mup | PR #7219: devicestate/firstboot: check for missing bases early <Created by stolowski> <https://github.com/snapcore/snapd/pull/7219> | 15:01 |
| pedronis | pstolowski: I'm going to force push to it again | 15:02 |
| mvo | zyga: merged now, sorry, my comment about shell was actually super silly | 15:03 |
| mup | PR snapd#7309 closed: tests: re-implement user tool in python <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7309> | 15:04 |
| zyga | mvo: hah, no worries :) | 15:04 |
| zyga | mvo: thank you, one less PR | 15:04 |
| mvo | zyga: like this user-tool was using "not" which is so not-standard | 15:04 |
| zyga | not standard | 15:05 |
| zyga | yeah | 15:05 |
| zyga | just less insanity | 15:05 |
| pstolowski | pedronis: hmmmmm i might have ctrl+c'ed git push upon realizing i did this from the vm, maybe something github got confused | 15:05 |
| zyga | I think some of the shell stuff could be removed too, python has user/group lookup | 15:05 |
| mvo | zyga: I'm still super puzlled though, I got an error that "groupadd snap_daemon" already exists. however afaict we cleanup carefully where we add this group (and user) | 15:06 |
| zyga | mvo: hmmm, did you investigate with -debug | 15:06 |
| mvo | zyga: yeah, I added some quick comments | 15:06 |
| zyga | or with -shell-before | 15:06 |
| mvo | zyga: I'm doing this now | 15:06 |
| mvo | zyga: I suspect it depends on the order of tests so it will be tricky to reproduce | 15:06 |
| mvo | but its very annoying, I think we really want 7317 | 15:06 |
| zyga | mvo: use this thing before my helpers are merged | 15:07 |
| zyga | mvo: cat ../../runtime-state/runs | tr ' ' '\n' | 15:07 |
| zyga | offtopic | 15:07 |
| zyga | I just realized that the USB-C port on my GPU is really a generic USB-C port | 15:07 |
| zyga | so I just plugged an ethernet card into my GPU | 15:07 |
| mvo | zyga: yeah, not reproducible anymore when running locally :/ | 15:07 |
| zyga | and it worked | 15:07 |
| zyga | the future is indeed now | 15:07 |
| mvo | zyga: wuut? woah | 15:07 |
| zyga | haha | 15:07 |
| zyga | yeah | 15:07 |
| zyga | my reaction exactly | 15:07 |
| mvo | zyga: where does the ethernet card show up? on your main system? | 15:08 |
| pstolowski | heh | 15:08 |
| zyga | mvo: on the usb bus, the GPU provides an USB-C controller that is connected to the host | 15:08 |
| mvo | zyga: magic! | 15:08 |
| zyga | mvo: ubuntu 18.04 doesn't work with RTX 2080super so I need to reinstall 19.10 to try | 15:08 |
| zyga | I just plugged an USB-C SSD | 15:08 |
| zyga | and it also worked | 15:08 |
| zyga | lol | 15:08 |
| zyga | this is great | 15:09 |
| zyga | this is on a computer that has only 2.0 USB ports otherwise | 15:09 |
| zyga | (10 year old) | 15:09 |
| zyga | :D | 15:09 |
| mvo | zyga: where in the testsuite do you hook into to "measure" stuff. I want to see what test leaves the snap_daemon user behind | 15:10 |
| zyga | mvo: let me show you one sec | 15:10 |
| zyga | mvo: look at v | 15:11 |
| zyga | https://github.com/snapcore/snapd/pull/7168 | 15:11 |
| mup | PR #7168: tests: measure testbed for leaking mountinfo entries <Created by zyga> <https://github.com/snapcore/snapd/pull/7168> | 15:11 |
| mvo | zyga: is it restore_project_each? | 15:11 |
| zyga | look closer | 15:11 |
| mvo | zyga: looking | 15:11 |
| zyga | but ideally, just extend testbed-tool | 15:11 |
| zyga | it's very easy | 15:11 |
| zyga | though this is the shell version, the python rewrite is the one I will propose, it's just half done because I was busy fixing actual bugs | 15:12 |
| pedronis | pstolowski: I redid the merge and pushed again | 15:12 |
| mvo | zyga: aha, estore_suite_each() ? | 15:12 |
| zyga | mvo: not quite | 15:12 |
| pstolowski | pedronis: thank you | 15:12 |
| zyga | mvo: because there are two things at play | 15:12 |
| zyga | mvo: look where I put reset.sh --reuse-core call | 15:12 |
| zyga | mvo: both need to be in place for the tool to be effective and precise | 15:12 |
| zyga | mvo: please fork that and just hack testbed-tool | 15:13 |
| zyga | on core some tests reboot which actually affects the mount table | 15:14 |
| zyga | but that's fine, it's just a few of them | 15:14 |
| mvo | zyga: my use-case is much simpler, I just need to check for getent passwd snap_daemon | 15:16 |
| zyga | mvo: sure | 15:16 |
| mvo | zyga: but I appreciate the hints where to look/hook into etc | 15:17 |
| zyga | :-) | 15:17 |
| mvo | zyga: its probably something silly but I can't pinpoint it | 15:17 |
| mvo | zyga: maybe your python rewrite is enough, could be some stupid shell side effect or whatnot | 15:17 |
| * mvo shakes fist | 15:17 | |
| zyga | mvo: try it | 15:18 |
| mvo | yeah, doing a tumbleweed spread run now | 15:19 |
| mvo | zyga: also I think I only saw this on tumbleweed so far so maybe something funny is going on there for real | 15:19 |
| zyga | chasing bugs on Friday evening | 15:19 |
| zyga | could be | 15:19 |
| zyga | I'll make coffee and see how my tests are doing | 15:19 |
| mvo | yeah, not a great time, I will soon need to leave to play some hockey | 15:19 |
| mvo | zyga: good luck! | 15:20 |
| zyga | https://github.com/snapcore/snapd/pull/7326 failed again | 15:20 |
| mup | PR #7326: tests: unmount fuse connections only if not initially mounted <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7326> | 15:20 |
| zyga | I restarted it on xdg stuff and on some other junk before | 15:20 |
| zyga | slow transfers | 15:20 |
| zyga | mvo: replied to your python comments | 15:22 |
| zyga | I'll shoot a follow up with a comment and extra --remove | 15:22 |
| zyga | but first, coffee! | 15:23 |
| zyga | that USB-C thing made me think | 15:24 |
| zyga | I could use one cable to connect everything I need for my PCc | 15:24 |
| zyga | usb-c -> usb-c screen -> hub with mouse / keyboard network | 15:24 |
| zyga | the original motherboard would only have the power cord | 15:24 |
| zyga | so mac-like, gosh | 15:25 |
| zyga | :D | 15:25 |
| zyga | back to coffee | 15:25 |
| * genii 's ears perk up for a second when he gets highlighted by "coffee" | 15:34 | |
| pstolowski | pedronis: #7202 is green, we can merge | 15:51 |
| mup | PR #7202: tests: sync journal log before start the test <Simple 😃> <Created by sergiocazzolato> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/7202> | 15:51 |
| pstolowski | grr i mean #7207 | 15:52 |
| mup | PR #7207: snap: prevent duplicated snap name and snap files when parsing seed.yaml <Created by stolowski> <https://github.com/snapcore/snapd/pull/7207> | 15:52 |
| pstolowski | merged | 15:59 |
| mup | PR snapd#7207 closed: snap: prevent duplicated snap name and snap files when parsing seed.yaml <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/7207> | 16:00 |
| zyga | re, sorry | 16:11 |
| zyga | baby interrupt | 16:11 |
| zyga | lucy was walking a little for the first time! | 16:11 |
| pstolowski | zyga: wooah! | 16:14 |
| pstolowski | pedronis: and #7219 is in a weird limbo state | 16:15 |
| zyga | one small interrupt and I'm back a | 16:15 |
| mup | PR #7219: devicestate/firstboot: check for missing bases early <Created by stolowski> <https://github.com/snapcore/snapd/pull/7219> | 16:15 |
| pstolowski | i've canceled & restarted the job | 16:17 |
| zyga | back | 16:18 |
| zyga | stuff is annoyingly red | 16:18 |
| zyga | journal match failed | 16:19 |
| pstolowski | 7219 stuck on https://usercontent.irccloud-cdn.com/file/yVpp7zaJ/Zrzut%20ekranu%202019-08-23%20o%2018.27.57.png | 16:28 |
| zyga | pstolowski: I heard that travis has issues with google | 16:28 |
| zyga | pstolowski: requesting a VM on gce can take multiple minutes | 16:28 |
| zyga | pstolowski: that's why LXD is so hot for them | 16:28 |
| pstolowski | zyga: oh well, time for weekend i guess | 16:28 |
| zyga | it's insta-up | 16:28 |
| pstolowski | o/ | 16:29 |
| === pstolowski is now known as pstolowski|afk | ||
| zyga | pstolowski|afk: enjoy the summer! | 16:30 |
| zyga | see you on Monday | 16:30 |
| mup | PR snapd#7326 closed: tests: unmount fuse connections only if not initially mounted <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7326> | 17:00 |
| zyga | google:ubuntu-core-16-64:tests/main/interfaces-account-control:accore18 needs fixes | 18:11 |
| mup | PR snapcraft#2683 opened: meta: move _errors to errors with related error classes <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2683> | 18:35 |
| mup | PR snapd#7328 opened: tests: pass --remove to userdel on core <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7328> | 19:52 |
| mup | PR snapcraft#2683 closed: meta: move _errors to errors with related error classes <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2683> | 22:12 |
| mup | PR snapcraft#2684 opened: meta: decouple DesktopFile logic <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2684> | 22:15 |
| popey_ | ogra_: https://twitter.com/ABRStewart/status/1165029896013398016 | 22:36 |
| popey_ | (nethack is outdated) | 22:37 |
| popey_ | Words that I wouldn't have expected to say, with that meaning, in 2019 | 22:37 |
| popey_ | jdstrand: you may have noticed, we're catching up with store requests. | 22:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
