| babbageclunk | thumper: take another look at https://github.com/juju/juju/pull/10562 plz? | 01:18 |
|---|---|---|
| thumper | babbageclunk: ack | 01:45 |
| thumper | babbageclunk: lgtm with one minor change | 01:50 |
| thumper | adding a clock to the unit agent manifold config | 01:50 |
| thumper | there are three other uses of clock.WallClock in that file. | 01:50 |
| babbageclunk | thumper: ok wilco | 01:54 |
| * thumper starts looking at some of these intermittent failures | 02:06 | |
| * thumper wonders if there is some nifty scripting we could do to scrape jobs to determine frequency of intermittent failures | 02:06 | |
| ec0 | sounds like you need a job status prometheus exporter | 02:10 |
| babbageclunk | thumper: I keep meaning to write something to do that but getting distracted | 03:48 |
| thumper | babbageclunk: yeah, understood | 03:49 |
| babbageclunk | would be super useful though | 03:49 |
| wallyworld | hpidcock: when thumper is done with you.... https://github.com/juju/juju/pull/10563 | 03:54 |
| thumper | crap... | 04:23 |
| thumper | my fix didn't | 04:23 |
| * thumper pokes some more | 04:40 | |
| hpidcock | wallyworld: looks good, few comments that's all | 04:50 |
| wallyworld | ty | 04:50 |
| wallyworld | hpidcock: because the v3 CLI is strictly opt in, there's no need to be too verbose about reminding users what the v2 syntax is | 04:54 |
| hpidcock | wallyworld: yeah, I understand that, but I imagine at some point v3 won't be opt in. Was just trying to highlight that we should provide feedback when something is deprecated. | 04:56 |
| wallyworld | i can add a note to the help text for "juju run" | 04:58 |
| thumper | I think I have it now | 05:00 |
| thumper | over 200 concurrent successes without a failure and during a stress run of the entire test suite | 05:00 |
| * thumper pushes | 05:00 | |
| thumper | wallyworld: https://github.com/juju/juju/pull/10564 | 05:03 |
| wallyworld | ok | 05:03 |
| wallyworld | thumper: lgtm | 05:15 |
| thumper | wallyworld: ta | 05:15 |
| thumper | landing that branch, and EOD | 05:44 |
| thumper | later peeps | 05:44 |
| stickupkid | jam, got a sec? | 09:35 |
| stickupkid | jam, scratch that, i've worked it out | 09:40 |
| achilleasa | can someone do a quick CR on https://github.com/juju/charm/pull/290? | 10:11 |
| achilleasa | jam: ^^ is the fix for #1841105 | 10:12 |
| mup | Bug #1841105: panic: runtime error: invalid memory address or nil pointer dereference <juju:In Progress by achilleasa> <https://launchpad.net/bugs/1841105> | 10:12 |
| manadart | achilleasa: Looking. | 11:00 |
| manadart | achilleasa: approved. | 11:03 |
| achilleasa | manadart: can you also please check https://github.com/juju/juju/pull/10565 (brings the charm.v6 changes to juju) and try the QA step? | 11:18 |
| manadart | achilleasa: Sure, | 11:28 |
| hml | manadart: review please: https://github.com/juju/juju/pull/10555 | 12:35 |
| manadart | hml: Looking. | 12:44 |
| jam | guild in 9 | 12:51 |
| manadart | hml: What provider are you using to add subnets? | 14:21 |
| hml | manadart: :-) I used maas, but the call failed because the subnets were already created. so i made sure that the correct facade versions were being used and the errors stayed the same. i’ve since learned that aws might work there better. | 14:22 |
| manadart | hml: OK, yeah. I was using AWS. | 14:29 |
| hml | manadart: you had no issues bootstrapping a aws on a develop branch today? | 15:12 |
| stickupkid | rick_h, omitempty won't work for us, as the bundlechange api doesn't work the way other apis work | 15:14 |
| rick_h | stickupkid: doh, otp atm but let's table it then. We don't need to solve it until 2.7 | 15:41 |
| rick_h | stickupkid: and go with the release for the bug affecting the customer please | 15:41 |
| stickupkid | rick_h, ok sounds good | 15:41 |
| rick_h | stickupkid: and we can look into what it'll take to have bundlechanges behave like a real boy api | 15:41 |
| stickupkid | rick_h, https://github.com/juju/python-libjuju/pull/349 release bump | 16:01 |
| rick_h | stickupkid: k, +1'd | 16:03 |
| stickupkid | rick_h_, ty | 16:03 |
| manadart | hml: If you are interested, I have started to put together https://github.com/juju/juju/pull/10566. It will accrue context as I push the other pieces up. | 16:21 |
| hml | manadart: cool - will start to look | 16:21 |
| === hml_ is now known as hml | ||
| thumper | morning | 20:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!