| anastasiamac | wallyworld: btw, PTAL https://github.com/juju/juju/pull/10586 :) | 05:20 |
|---|---|---|
| anastasiamac | wallyworld: i've requested u as reviewer on github when I proposed but obviously it's way too subtle :) | 05:21 |
| wallyworld | ok | 05:21 |
| wallyworld | didn't see it | 05:21 |
| anastasiamac | all good | 05:21 |
| wallyworld | most gh email is filtered as it's too noisy | 05:21 |
| anastasiamac | :) | 05:23 |
| wallyworld | anastasiamac: see comment/question about the txn logic | 05:34 |
| anastasiamac | wallyworld: k | 05:34 |
| anastasiamac | wallyworld: i'd rather keep docxists assert but will add buildttxn loop and the test | 05:35 |
| wallyworld | in that case, also add assert for $ne Dead | 05:36 |
| anastasiamac | wallyworld: k | 05:36 |
| wallyworld | to match initial query | 05:36 |
| anastasiamac | wallyworld: funny but this code was almost verbatum from upgrade permissions... i wonder then if there'd b a problem there too.. | 05:36 |
| wallyworld | upgrade steps you are talking about" upgrades don't need to deal with concurrent access to db | 05:37 |
| wallyworld | s/"/? | 05:37 |
| anastasiamac | altho mayb just rmoving assert is fine... u r right, we don't care if we cannot clear cred on a gone model.. | 05:55 |
| wallyworld | i think in this case it may be ok to not care so much | 06:46 |
| anastasiamac | wallyworld: meh.. alreay pushed tansactionality and buildtxn ... want to look? | 06:48 |
| manadart | Can I get a tick on a forward-merge? https://github.com/juju/juju/pull/10590 | 07:13 |
| manadart | jam: Ta. | 07:14 |
| wallyworld | anastasiamac: sure, looking now | 07:30 |
| wallyworld | anastasiamac: still lgtm | 07:31 |
| anastasiamac | wallyworld: \o/ | 07:33 |
| anastasiamac | ah manadart if only that merge was a couple of hours late :) | 07:33 |
| anastasiamac | i'll just cherry-pcik my change into develop tomorrow :D | 07:34 |
| manadart | anastasiamac: If the merge fails, I'll add yours :) | 07:34 |
| anastasiamac | manadart: mine just went for landing now... | 07:36 |
| anastasiamac | into 2.6 that is.. | 07:39 |
| anastasiamac | wallyworld: and the cherry-pick for develop PTAL https://github.com/juju/juju/pull/10591 | 08:51 |
| anastasiamac | manadart: mayb u could a +1? srsly just cherry picking :) | 08:52 |
| manadart | anastasiamac: Tick! | 08:55 |
| anastasiamac | manadart: \o/ | 08:55 |
| stickupkid | achilleasa, any chance of a CR, this is the changes I talked about last week https://github.com/juju/bundlechanges/pull/57 | 10:31 |
| stickupkid | achilleasa, fixing the tests took a lot longer than i hoped :\ | 10:31 |
| achilleasa | stickupkid: sure thing. looking in a few min | 10:32 |
| stickupkid | achilleasa, it's a shame GUIArgs has to live on, as it's not a very efficient way to transport information... i.e. you need empty values for all options, even if they're empty | 10:33 |
| achilleasa | stickupkid: that's only being used for the GUI bits right? We could kindly ask them to switch to the map version instead ;-) | 10:36 |
| stickupkid | achilleasa, yes, i agree | 10:36 |
| achilleasa | stickupkid: approved. Yeah, I remember updating the tests to include the empty channel in the GUIArgs output was a pain too | 11:29 |
| parlos | anybody experienced "twd4f3: Unable to allocate static IP due to address exhaustion", and have a fix (not sure what network is exhausted, and from the maas there are plenty of IPs in all networks)... | 13:31 |
| parlos | (ignore twd4f3 its just the MAAS id) | 13:32 |
| hml | manadart: can or should 1 subnet be in 2 spaces? | 14:25 |
| manadart | hml: No. | 14:25 |
| hml | manadart: that’s what i thought. juju may be broken there. stumbled on it while updating RelationUnitSuite.TestNetworksForRelationWithSpaces | 14:26 |
| hml | for space-3 | 14:27 |
| hml | hoping was a copy paste error in the test setup | 14:27 |
| hml | look like we never check | 14:30 |
| hml | found the check… up in the apiserver code. but that doesn’t prevent state tests from doing interesting things. | 14:49 |
| === salmankhan1 is now known as salmankhan | ||
| stickupkid | rick_h, i've updated to pylibjuju PR, I want to now add more unit tests around the type classes, as it should be much easier to do so. Can you look to see if you've got any concerns | 15:00 |
| stickupkid | rick_h, https://github.com/juju/python-libjuju/pull/350 | 15:00 |
| rick_h | stickupkid: rgr, otp but will look in a few | 15:00 |
| rick_h | stickupkid: feedback in, looks much sweeter! | 15:12 |
| stickupkid | rick_h, the nice thing is, we can use mocks to test the run methods now! | 15:13 |
| rick_h | stickupkid: exactly | 15:13 |
| stickupkid | rick_h, yarp, just adding some tests | 15:13 |
| rick_h | stickupkid: sorry to create the work but I think it's on a nicer path for sure | 15:13 |
| stickupkid | rick_h, i'd rather have it right, 100% agree | 15:13 |
| yan0s | Hi all! | 19:27 |
| yan0s | has anyone used openstack as a cloud provider in Juju? | 19:28 |
| yan0s | I'm getting this error: ERROR juju.cmd.juju.commands bootstrap.go:697 failed to bootstrap model: no image metadata found | 19:31 |
| yan0s | also: skipping index "http://my_ip:8080/simplestreams/images/streams/v1/index.json" because of missing information: index file has no data for cloud {Louros https://mykeystoneurl:5000/v3} not found | 19:32 |
| yan0s | same steps have been working about a year ago.. | 19:36 |
| hml | yan0s: check the index.json to see if the exact url is given: https://mykeystoneurl:5000/v3 | 19:36 |
| hml | yan0s: i’ve seen where it’s https://mykeystoneurl:5000/v3 vs https://xx.xx.xx.xx:5000/v3 where technically they are the same, but it fails. | 19:37 |
| hml | it’s a straight string match, no lookup | 19:37 |
| yan0s | hml: it is the same in index.json | 20:07 |
| hml | yan0s: which version of juju? | 20:09 |
| hml | yan0s: any possibility of a link to or pastebin of the the index.json file? and the full bootstrap —debug output please? | 20:09 |
| yan0s | 2.6.8-bionic-amd64 | 20:10 |
| yan0s | https://pastebin.com/mrfzRMi3 | 20:11 |
| yan0s | actually here is my simplestream uploaded http://62.217.82.41:8080/simplestreams/images/streams/v1/ | 20:13 |
| hml | yan0s: there was a mistype in creating the simplestream files… “https:///keysto” 3 slashes instead of 2. | 20:17 |
| yan0s | oh god.. | 20:18 |
| yan0s | I'm so sorry for wasting your time | 20:19 |
| hml | yan0s: no problem. another set of eyes can be a good thing | 20:19 |
| hml | :-) | 20:19 |
| timClicks | yan0s: great to hear that this was an easy fix :) | 20:20 |
| timClicks | yan0s: do let us know if you have any further problems, we will be delighted to help | 20:23 |
| magicaltrout | https://discourse.jujucharms.com/t/square-brackets-in-env-vars/2024 if anyone knows what goes on under the hood and what I have to escape to get this working, that would be very nice indeed! :) | 23:18 |
| thumper | some more intermittent test failure fixes https://github.com/juju/juju/pull/10594 | 23:43 |
| thumper | wallyworld: you may have commentary for magicaltrout on that post | 23:44 |
| thumper | magicaltrout: I'm guessing that it is being parsed as a yaml array | 23:45 |
| * thumper thinks | 23:45 | |
| thumper | magicaltrout: now I read it a bit more, it does seem very strange | 23:46 |
| thumper | magicaltrout: you can use yaml type forcing | 23:46 |
| thumper | I'd expect | 23:46 |
| thumper | magicaltrout: also, what is dc4? | 23:46 |
| thumper | magicaltrout: you also don't mention where you are putting it in juju | 23:47 |
| thumper | wallyworld: I think I know what is going on though | 23:47 |
| thumper | wallyworld: I bet if you take a string like '["hello"]' and parse it as yaml, then write it out as yaml you get ["hello"] | 23:48 |
| wallyworld | thumper: sorry, was otp | 23:48 |
| thumper | which the second parser deeper is treating as a list | 23:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!