| zyga | good morning | 05:05 |
|---|---|---|
| zyga | hey mborzecki | 05:10 |
| mborzecki | zyga: morning | 05:11 |
| zyga | I have some changes to make in https://github.com/snapcore/snapd/pull/7400 | 05:11 |
| mup | PR #7400: cmd/snap-update-ns: don't propagate detaching changes <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/7400> | 05:11 |
| zyga | and then another round ad 2.41 suse package | 05:11 |
| mborzecki | zyga: yeah, i saw jstrand's review | 05:12 |
| mborzecki | mvo: morning | 05:52 |
| mvo | mborzecki: goooood morning! how are you? | 05:53 |
| mborzecki | mvo: cold ;) +11C outside | 05:54 |
| mvo | mborzecki: yeah, same here. but much better than the ~40 before :) | 05:54 |
| mvo | (at least IMO) | 05:54 |
| zyga | good morning mvo | 05:57 |
| zyga | mborzecki: +11 wow | 05:58 |
| mvo | hey zyga | 05:59 |
| zyga | I'm debugging something that I changed that causes seeding to fail | 05:59 |
| zyga | it's pretty frustrating because there's no output | 06:00 |
| mvo | mborzecki: hm, I think we have +9 outside | 06:00 |
| zyga | I'll try to de-focus and advance some other stuff later, maybe around noon | 06:00 |
| mborzecki | mvo: wow, my preference is +20 all day round :P | 06:00 |
| zyga | mborzecki: check out spain ;) | 06:00 |
| zyga | mvo: do we have any stats on spread usage? | 06:24 |
| mvo | zyga: stats in what sense? | 06:25 |
| zyga | mvo: number of vm/hours used per account | 06:25 |
| zyga | something like that | 06:25 |
| zyga | just as trivia | 06:26 |
| zyga | I wonder what's our record | 06:26 |
| mvo | zyga: I'm sure gustavo has them, maybe sergio - I don't | 06:26 |
| mup | PR snapd#7158 closed: tests: part5 making tests work on ubuntu-core-18 <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7158> | 06:35 |
| mborzecki | off to take my son to school and take some paperwork to my accountant | 06:37 |
| mborzecki | bbl | 06:37 |
| zyga | o/ | 06:51 |
| pstolowski | morning | 07:03 |
| zyga | good morning pawel | 07:03 |
| mup | PR snapd#7418 closed: many: pass the rootdir and options to bootloader.Find <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7418> | 07:29 |
| zyga | wow, small success | 07:43 |
| * zyga tries the other test now | 07:43 | |
| zyga | I'm on the way towards addressing the thing that made MS_SHARED bugfix be more complex in tests | 07:47 |
| zyga | caused by particular core16 behavior | 07:47 |
| mborzecki | re | 07:48 |
| zyga | mborzecki: hey | 07:48 |
| zyga | mborzecki: I added syslog to snap-confine | 07:49 |
| zyga | it helps when things faily mysteriously | 07:49 |
| zyga | added some draft code to unmap /writable from snaps POV | 07:49 |
| zyga | that could be the thing to cut the duplicated mount entries on core16 upsetting tests | 07:50 |
| mborzecki | zyga: syslog? as in syslog(3)? | 07:53 |
| zyga | yes | 07:53 |
| zyga | it shows up even if the invocation is otherwise hidden | 07:53 |
| zyga | made me realize a mistake earlier | 07:53 |
| mborzecki | zyga: got some cleanups in s-c unit tests | 07:56 |
| zyga | mborzecki: send them over and ping me | 07:58 |
| pedronis | mvo: morning, I looked at #6404 again | 08:18 |
| mup | PR #6404: snapstate: auto transition on experimental.snapd-snap=true <Created by mvo5> <https://github.com/snapcore/snapd/pull/6404> | 08:18 |
| mvo | pedronis: thanks, I check it out | 08:30 |
| mvo | pedronis: I updated the LK one, let me know if you want to go one step further | 08:30 |
| pedronis | mvo: I answered, yes, I think we should, but the change is smaller than what you thought I think | 08:31 |
| pedronis | mvo: we don't use InstallBootConfig at runtime | 08:31 |
| pedronis | I can look myself in a little bit | 08:31 |
| mvo | pedronis: also 7181 is green, I think we can merge it, yes? | 08:32 |
| pedronis | mvo: you mean 7381 ? | 08:32 |
| pedronis | yes I will merge it and make 7416 smaller | 08:33 |
| mup | PR snapd#7381 closed: seed,image,o/devicestate: extract seed loading to seed/seed16.go <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7381> | 08:34 |
| zyga | yay | 08:34 |
| zyga | I identified the core16 + core16 but that duplicated some entries that caused the MS_SLAVE test to fail originally | 08:34 |
| zyga | the fix is super easy and obviously so | 08:35 |
| zyga | coming up in 30-60 minutes after some more testing | 08:35 |
| mvo | pedronis: ok, I will leave the LK one for you then, thank you :) and yes, I did mean 7381 | 08:36 |
| mvo | (fat fingers) | 08:36 |
| zyga | it's almost over, the whole thing is aligning :) | 08:36 |
| pedronis | mvo: done, now #7416 is it's proper size (still big, again because tests), also is not the whole thing as I said, more like ~1/3 maybe | 08:37 |
| mup | PR #7416: seed/seedwriter: start of Writer and internal policy16/tree16 <Created by pedronis> <https://github.com/snapcore/snapd/pull/7416> | 08:37 |
| pedronis | *its | 08:37 |
| mvo | pedronis: ok, I try to get to it soon | 08:38 |
| zyga | mborzecki: it passed :D | 08:46 |
| zyga | mborzecki: mwahaha, the bug is fixed | 08:46 |
| zyga | running full run across all systems on that test | 08:47 |
| zyga | I'll start polishing the patch for submission | 08:47 |
| pedronis | mvo: I pushed changed to the LK PR, please have a look when you can | 09:20 |
| pedronis | *changes | 09:20 |
| mup | PR snapd#7419 opened: cmd/snap-confine: add unit tests for sc_invocation, cleanup memory leaks in tests <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7419> | 09:20 |
| mborzecki | zyga: ^^ | 09:21 |
| mborzecki | zyga: tried to use glib goodies in test_argc_argv() and fix memory leaks there, but gave up eventually as we modify the resulting argv in sc_nonfatal_parse_args() | 09:21 |
| pstolowski | pedronis: i'm cleaning up per-revision config stuff a bit and add some more tests | 09:22 |
| pedronis | pstolowski: ok, thx | 09:23 |
| mborzecki | ok, heading back home | 09:24 |
| mup | PR snapd#7420 opened: cmd/snap-confine: fix /snap duplication in legacy mode <Created by zyga> <https://github.com/snapcore/snapd/pull/7420> | 09:37 |
| pstolowski | pedronis: i thought i found a bug in that we only restore revision config on revert but not on refresh; but we explicitely test this behavior in config-revisions spread test. i'm not sure why we wanted that | 10:04 |
| pedronis | pstolowski: you mean a refresh to old revision? | 10:12 |
| pedronis | it makes sense to me though that we don't reapply old config in that case | 10:13 |
| pstolowski | pedronis: yep, snap refresh --revision=.. foo | 10:13 |
| pedronis | pstolowski: we don't go find the old data either I think | 10:14 |
| pedronis | revert is really the only op that says please get me back in time | 10:14 |
| pstolowski | pedronis: ah i see what you mean | 10:14 |
| pstolowski | thanks, all clear | 10:15 |
| pstolowski | good i had a spread test; i've added explicit unit test now | 10:15 |
| mborzecki | re | 10:17 |
| mborzecki | zyga: updated #7419 | 10:28 |
| mup | PR #7419: cmd/snap-confine: add unit tests for sc_invocation, cleanup memory leaks in tests <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7419> | 10:28 |
| zyga | mborzecki: thank you | 10:31 |
| zyga | mborzecki: https://github.com/snapcore/snapd/pull/7420 | 10:33 |
| mup | PR #7420: cmd/snap-confine: fix /snap duplication in legacy mode <Created by zyga> <https://github.com/snapcore/snapd/pull/7420> | 10:33 |
| zyga | mborzecki: +1, can you please push a change to include it in the new format | 10:40 |
| zyga | and reformat | 10:40 |
| zyga | it will have clang formatting (the -test.c file) so it will be a little bit nicer | 10:40 |
| mborzecki | zyga: in the same PR? | 10:40 |
| zyga | yeah, the -test file is new | 10:40 |
| mborzecki | ok | 10:41 |
| mborzecki | hmm we should be putting emacs formatting spec in *.[ch] files like systemd does | 10:42 |
| mborzecki | fwiw emacs and vim | 10:43 |
| zyga | mborzecki: +1 | 10:48 |
| zyga | thoguh I'm not using emacs, not sure if that is picked up universally | 10:49 |
| zyga | mvo: I need to do an errand downtown today, I will bring my laptop with me but not sure if I will have conditions for the call | 10:57 |
| zyga | mvo: my update is that I'm zeroing on the re-submission of MS_SHARED bug fix | 10:57 |
| zyga | mvo: I identified two causes of the failure of the integration test in the original pull request | 10:57 |
| zyga | mvo: one is under review now | 10:57 |
| zyga | mvo: the other was sent yesterday and +1'd but -1'd by jamie (code ok, comment tweaks requested) | 10:58 |
| zyga | mvo: I'll address those and try to propose the fix for MS_SHARED later today if I can | 10:58 |
| mvo | thanks for the update zyga | 11:07 |
| Psil0Cybin | cans omeoenm help me get snap working on kali linux? | 11:39 |
| zyga | Psil0Cybin: hey, perhaps | 11:40 |
| zyga | we did this enough times to have some experience | 11:40 |
| mup | PR snapd#7421 opened: cmd/snap-confine: unmount /writable from snap view <Created by zyga> <https://github.com/snapcore/snapd/pull/7421> | 11:41 |
| zyga | mborzecki: one more https://github.com/snapcore/snapd/pull/7421 | 11:41 |
| mup | PR #7421: cmd/snap-confine: unmount /writable from snap view <Created by zyga> <https://github.com/snapcore/snapd/pull/7421> | 11:41 |
| zyga | I made it a draft as it will be probably discussed longer and I want to perform some more analysis | 11:41 |
| Psil0Cybin | zyga, tank you becasue i was having problems that my home directory is in /username and not in /home/username | 11:47 |
| Psil0Cybin | and it would not let me run any appliations installed etc | 11:47 |
| zyga | Psil0Cybin: that's a known limitation and it is not supported | 11:47 |
| Psil0Cybin | shojld i provide the erorr logs? | 11:47 |
| zyga | it's not related to the distribution | 11:48 |
| Psil0Cybin | so how do i go bout gtting snap.d packages | 11:48 |
| zyga | Psil0Cybin: no need, we know about this and there is no solution now | 11:48 |
| Psil0Cybin | installed | 11:48 |
| Psil0Cybin | dang | 11:48 |
| zyga | you must use the regular location | 11:48 |
| Psil0Cybin | so im completely out of luck | 11:48 |
| zyga | that's the only outcome | 11:48 |
| zyga | no, just put it in /home/username | 11:48 |
| zyga | it's not a big deal, is it? | 11:48 |
| Psil0Cybin | should not be i just installed kali and created a non root account as per guide | 11:48 |
| Psil0Cybin | so what would i do now? | 11:49 |
| zyga | Psil0Cybin: I don't know much about kali | 11:49 |
| zyga | I cannot help with that directly | 11:49 |
| zyga | so what's your actual username? | 11:49 |
| zyga | and user home directory on the system? | 11:49 |
| cmatsuoka | mvo: I see in the spike code that ubuntu-image is actually installing the recovery bootloader files, is it supposed to work that way in the final code, or prepare-image should do that? | 12:10 |
| === ricab is now known as ricab|lunch | ||
| zyga | jdstrand: good day | 12:11 |
| zyga | jdstrand: I have updated the comment and replied tyo your question on https://github.com/snapcore/snapd/pull/7400 | 12:11 |
| mup | PR #7400: cmd/snap-update-ns: don't propagate detaching changes <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/7400> | 12:12 |
| zyga | jdstrand: I also opened two additional PRs as we discussed | 12:12 |
| zyga | jdstrand: only one is something I'd like you to review | 12:12 |
| zyga | jdstrand: it is https://github.com/snapcore/snapd/pull/7420 | 12:12 |
| cmatsuoka | mvo: I'm playing with snap-image to generate an image, after patching prepare-image to generate recovery (mostly from the spike code) | 12:12 |
| mup | PR #7420: cmd/snap-confine: fix /snap duplication in legacy mode <Created by zyga> <https://github.com/snapcore/snapd/pull/7420> | 12:12 |
| zyga | jdstrand: the other one is something that I want to experiment more with, you can see it in https://github.com/snapcore/snapd/pull/7421 if you are curious | 12:12 |
| mup | PR #7421: cmd/snap-confine: unmount /writable from snap view <Created by zyga> <https://github.com/snapcore/snapd/pull/7421> | 12:12 |
| zyga | as soon as 7400 and 7420 land I will propose a v2 of the MS_SHARED fix | 12:13 |
| zyga | mborzecki: if you can, please do a pass over 7420 | 12:14 |
| cmatsuoka | mvo: (also checking snap-image details with mborzecki) | 12:14 |
| zyga | mvo: perhaps as well, it's something you should know about | 12:14 |
| mup | PR snapd#7422 opened: interfaces: allow reading mutter Xauthority file <Bug> <Created by zyga> <https://github.com/snapcore/snapd/pull/7422> | 12:24 |
| mup | PR snapd#7423 opened: overlord/snapstate: config revision code cleanup and extra tests <Created by stolowski> <https://github.com/snapcore/snapd/pull/7423> | 12:35 |
| pstolowski | zyga: https://bugs.launchpad.net/snapd/+bug/1828354 didn't have solution, right? or was it fixed elsewhere? | 12:43 |
| mup | Bug #1828354: mount event propagation on snapd-mounted tmpfs is incorrect <snapd:In Progress by zyga> <https://launchpad.net/bugs/1828354> | 12:43 |
| mup | PR snapd#7415 closed: tests: fix mountinfo-tool filtering when used with rewriting <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7415> | 12:48 |
| zyga | pstolowski: it has a solution but we were unable to land it, my update above (for mvo) was about that | 12:52 |
| zyga | pstolowski: this is the MS_SHARED bug | 12:52 |
| zyga | pstolowski: it's close to being fixed now | 12:52 |
| zyga | pstolowski: I need to land two prerequisites and I can reopen the fix | 12:52 |
| pstolowski | zyga: ok, thanks | 12:54 |
| pstolowski | zyga: i'm keeping the bug 'in progress' then | 12:55 |
| tomwardill | hello! store team here, we've got some slowness issues that are causing timeouts, etc. Info will be here: https://status.snapcraft.io/ | 13:28 |
| zyga | thank you for sharing tomwardill | 13:28 |
| zyga | thank you jdstrand!!! | 13:32 |
| jdstrand | np | 13:35 |
| zyga | I'll adjust the git commit message and the comment before landing | 13:36 |
| zyga | jdstrand: adjusted and squashed for simplicity | 13:40 |
| === ricab|lunch is now known as ricab | ||
| jdstrand | mvo, cachio: thanks for 7288, 7346 and 7350 (system-usernames cleanups)! sorry they were needed | 13:50 |
| cachio | jdstrand, looking | 13:50 |
| mvo | jdstrand: no worries, the world is complicated | 13:50 |
| cmatsuoka | mvo: I thought you would stay a bit to discuss snap-image details? | 13:50 |
| mvo | jdstrand: thank you for making the system-user happen, 2.41 will make a few teams quite happy | 13:50 |
| mvo | cmatsuoka: yes | 13:50 |
| mvo | cmatsuoka: sorry, brain | 13:50 |
| jdstrand | mvo: 7346 was a particularly nice one | 13:51 |
| jdstrand | (validate before create) | 13:51 |
| mvo | cmatsuoka: I'm back again | 13:51 |
| jdstrand | mvo, cachio: hope it didn't cause too much trouble | 13:51 |
| jdstrand | cachio: no need to look them up. just you two working through testsuite issues after the feature landed | 13:52 |
| cachio | jdstrand, everything merged :) snap_daemon did not you | 13:52 |
| cachio | troubles | 13:52 |
| pstolowski | jdstrand: thanks for looking at my apparmor backend PR! | 14:18 |
| pstolowski | (k | 14:20 |
| pstolowski | ijohnson and pedronis - thank you too! | 14:20 |
| pstolowski | i think with the general approval for the direction of this PR i'll work on new tests & the feedback | 14:21 |
| ackk | hi, out of curiosity, why is that any user can call "snapctl set-health"? | 14:35 |
| ijohnson | pstolowski: you're welcome :-) | 14:48 |
| pstolowski | ackk: i think that's because any app can set health status of own snap (and doesn't need euid 0 to do that). note you cannot do anything useful by running snapctl set-health manually because of missing context | 14:48 |
| ackk | pstolowski, you mean it would only show up in snap info? | 14:49 |
| pstolowski | ackk: it would show in snap info, yes (not sure why "only"?) - see https://forum.snapcraft.io/t/health-checks/10605 | 14:56 |
| ackk | pstolowski, I see thanks | 14:58 |
| ackk | pstolowski, fwiw I meant, if you run it manually from a snap run --shell, you can still set it so that it shows in the status | 14:58 |
| mup | PR snapd#7270 closed: overlord/snapstate: save disabled snap svcs on unlink snap tasks <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/7270> | 15:00 |
| ackk | pstolowski, what would be the context you're referring to? | 15:00 |
| pstolowski | ackk: yes. but that's interesting case, i didn't think about it | 15:02 |
| ackk | pstolowski, I was wondering a malicious user could just snap set-health error "everything is broken" | 15:03 |
| pstolowski | ackk: yes i see what you mean | 15:03 |
| * cachio lunch | 15:10 | |
| zyga | re | 15:14 |
| * zyga reads backlog | 15:14 | |
| zyga | ackk: snap run --shell gives you a cookie | 15:14 |
| roadmr | 🍪 | 15:15 |
| zyga | ackk: snap run --shell | 15:15 |
| zyga | echo $SNAP_COOKIE | 15:15 |
| zyga | AFAIR | 15:15 |
| ackk | zyga, indeed | 15:16 |
| mup | PR snapd#7420 closed: cmd/snap-confine: fix /snap duplication in legacy mode <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7420> | 15:17 |
| mup | PR snapd#7422 closed: interfaces: allow reading mutter Xauthority file <Bug> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7422> | 15:23 |
| zyga | master moved by 64 revisions | 15:25 |
| zyga | man, today is busy | 15:25 |
| mvo | zyga: oh yes! | 15:30 |
| jdstrand | pstolowski: you're welcome! | 15:31 |
| mvo | code review for https://github.com/snapcore/spread/pull/69 would be great, probably needs some tweaks but a early test would be amazing | 15:39 |
| mup | PR spread#69: Manage pagination retrieving images from google backend <Created by sergiocazzolato> <https://github.com/snapcore/spread/pull/69> | 15:40 |
| pedronis | ijohnson: are you are aware of this bit of code: https://github.com/snapcore/snapd/blob/master/overlord/snapstate/backend/link.go#L152 | 15:43 |
| pedronis | ? (I was almost forgetting myself) | 15:43 |
| pedronis | it's called by link-snap | 15:43 |
| === pstolowski is now known as pstolowski|afk | ||
| mup | PR snapcraft#2703 opened: build provider: allow configuration of primary apt mirror <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2703> | 16:33 |
| pedronis | ijohnson: I left this comment: https://github.com/snapcore/snapd/pull/7270#issuecomment-528941176 | 17:25 |
| mup | PR #7270: overlord/snapstate: save disabled snap svcs on unlink snap tasks <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/7270> | 17:25 |
| mup | PR snapd#6697 closed: interfaces/daemon_notify: add {net,sys}_admin capabilities, update spread test <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/6697> | 18:09 |
| ardaguclu_ | run_checks first executes gofmt and in my local machine each time it returns "formatting wrong in following lines;..." | 18:17 |
| ardaguclu_ | Am I doing something wrong, because each time I manually run gofmt to complete run_checks and see results | 18:18 |
| ardaguclu_ | I am running it 1.13, is it something because of that? | 18:20 |
| zyga | ardaguclu_: it's a known flaw | 18:32 |
| zyga | ardaguclu_: ignore it | 18:33 |
| zyga | ardaguclu_: you can go test ./... | 18:33 |
| zyga | and that's just as good | 18:33 |
| zyga | ardaguclu_: there's a few things it doesn't do but you can check the script to see what's that | 18:33 |
| mup | PR snapcraft#2703 closed: build provider: allow configuration of primary apt mirror <Created by cjp256> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/2703> | 18:33 |
| zyga | ardaguclu_: go fmt has changed behavior across versions | 18:33 |
| ardaguclu_ | zyga: thanks, I am going to check it. | 18:37 |
| mup | PR snapcraft#2704 opened: extensions: create the gnome-platform directory <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2704> | 18:39 |
| mup | PR snapcraft#2705 opened: extensions: rename extension classes to known names <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2705> | 18:39 |
| ijohnson | thanks pedronis, sorry was afk for a bit, that makes sense | 18:43 |
| mup | PR snapcraft#2706 opened: extensions: improve docsting (used in the cli) <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2706> | 18:54 |
| mup | PR snapd#7400 closed: cmd/snap-update-ns: don't propagate detaching changes <Bug> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7400> | 18:54 |
| mup | PR snapd#7424 opened: fixme: move snapfrompid into osutils <Created by ardaguclu> <https://github.com/snapcore/snapd/pull/7424> | 19:04 |
| mup | PR snapd#7425 opened: channel: introduce Resolve and ResolveLocked <Created by pedronis> <https://github.com/snapcore/snapd/pull/7425> | 19:10 |
| * ijohnson reboots | 19:15 | |
| jdstrand | ijohnson: I went to update trello for the "rainy day list" to add 6697 and recalled from my notes something: https://github.com/snapcore/snapd/pull/6697#issuecomment-528987808 | 19:40 |
| mup | PR #6697: interfaces/daemon_notify: add {net,sys}_admin capabilities, update spread test <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/6697> | 19:40 |
| ijohnson | thanks jdstrand I'll take a look | 19:41 |
| * cachio EOW | 20:59 | |
| mup | PR snapd#7426 opened: cmd/snap-update-ns: clarify sharing comment <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7426> | 22:01 |
| * zyga goes to sleep | 22:20 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!