[05:09] <mborzecki> morning
[05:14] <mborzecki> mvo: morning :)
[05:14] <mvo> hey mborzecki
[05:15] <mvo> mborzecki: how is life this morning?
[05:15] <mborzecki> mvo: cold :P 5C outside
[05:15] <mvo> mborzecki: woah, thats cold indeed. we have ~15 here but it will change!
[05:17] <mborzecki> mvo: how was your train ride?
[05:20] <mvo> mborzecki: all went well, all trains on time
[05:20] <mvo> mborzecki: which is not the default anymore sadly. so it was a pleasant surprise
[05:21] <mvo> mborzecki: also it was the last train so any major delay would have left me stranded in the middle of nowhere :) so I was a little bit nervous
[05:22] <mborzecki> mvo: nice :) our trip to cdg from the hotel and the flight were smooth too
[05:22] <mborzecki> mvo: although saturday was apparently rather chaotic in paris
[05:24] <mvo> mborzecki: yeah, I read in the news there was a lot of protesting going on
[05:30] <mborzecki> mvo: our snapd snap has an 'unset' license in the store https://snapcraft.io/snapd
[05:36] <mup> PR snapd#7493 opened: snapcraft: set license to GPL-3.0 <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7493>
[05:51] <mvo> mborzecki: uh, lets me try to fix the license
[05:52] <mborzecki> mvo: opened a PR with an update in snapcraft.yaml ^^^
[05:52] <mvo> mborzecki: nice!
[05:52] <mborzecki> mvo: but maybe the store page needs an edit too
[05:52] <mvo> mborzecki: I have a look now
[05:54] <mvo> mborzecki: I updated the store page now
[05:54] <mborzecki> mvo: great, thanks!
[05:55] <mvo> mborzecki: not visible in snap info (yet?) though - so maybe the authoritative one is  the snapcraft
[06:17] <zyga> hey guys
[06:17] <zyga> eating breakfast
[06:17] <mborzecki> zyga: hey
[06:17] <zyga> did usual school run
[06:17] <zyga> so need a moment to get to office shape
[06:18] <mborzecki> mvo: https://paste.ubuntu.com/p/4tjyHvcn2S/ looks like it's still unset
[06:18] <mvo> hey zyga
[06:18] <mvo> mborzecki: yeah, confusing
[06:18] <zyga> everything ok?
[06:18] <zyga> any fires?
[06:19] <mborzecki> zyga: some confusion about the license of snapd snap, which apaprently is unset, opened #7493 to address that
[06:19] <mup> PR #7493: snapcraft: set license to GPL-3.0 <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7493>
[06:19] <zyga> :D
[06:20] <mborzecki> fwiw, do the review tools complain if license is not specified in the snap?
[06:23] <zyga> mborzecki: I think now
[06:23] <zyga> not
[06:52] <zyga> why is license only as a passthrough?
[06:52] <mborzecki> zyga: idk
[06:53] <zyga> how do you guys feel today?
[06:53] <mborzecki> and it's red :/
[06:54] <zyga> yeah :C
[06:54] <zyga> what was the failure?
[06:55] <mborzecki> zyga: centos, systemctl daemon-reload
[06:58] <mvo> zyga: feeling a bit sleepy
[06:59] <zyga> mvo: same here
[06:59] <zyga> mvo: I got up at 6 AM
[06:59] <zyga> but cannot stop going to bed before midnigth
[06:59] <zyga> er
[06:59] <zyga> after
[07:00] <zyga> https://github.com/snapcore/snapd/pull/7488 is green
[07:00] <mup> PR #7488: docs: Update README.md <Created by degville> <https://github.com/snapcore/snapd/pull/7488>
[07:01] <zyga> mvo: did you guys see  https://github.com/snapcore/snapd/pull/7488?
[07:02] <mup> PR snapd#7409 closed: interfaces/wayland: allow a confined server running in a user session to work with Qt, GTK3 & SDL2 clients <Created by AlanGriffiths> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7409>
[07:03] <zyga> mvo: policy idea: prioritize contributions from outside of the team above new features from the team
[07:03] <zyga> mvo: prioritize fixes over new features
[07:03] <mvo> zyga: yes, I thnk that is a good idea
[07:04] <zyga> it would improve our interactions with other teams
[07:04] <zyga> and could eventually outpace our own contributions
[07:09] <mborzecki> https://github.com/snapcore/snapd/pull/7490 this one needs a review
[07:09] <mup> PR #7490: interfaces/app-launch: support confined snaps launching other snaps <Created by AlanGriffiths> <https://github.com/snapcore/snapd/pull/7490>
[07:16] <mvo> does anyone know whats up with centos-7 ? I see a lot of errors from systemctl reload
[07:17] <mborzecki> mvo: we tried to investigate this a bit last week, so far i could not reproduce this running the whole suite
[07:21] <mvo> mborzecki: strange - thanks!
[07:24] <mborzecki> hmmm https://github.com/poettering/systemd/commit/1f37d342f3a32da5ce52123a5afb3498800097e9
[07:25] <mvo> mborzecki: this guy again ;)
[07:25] <zyga> mborzecki: I'm doing one now
[07:26] <zyga> mvo: note the super nice github issue integration
[07:27] <zyga> one line in a commit is enough to cross-reference everything
[07:27] <mborzecki> https://bugzilla.redhat.com/show_bug.cgi?id=1378449
[07:30] <mborzecki> hah, got a shell :P though it failed for different reason, but i can see systemctl daemon-reload times out
[07:32] <mborzecki> https://paste.ubuntu.com/p/MtVJ7j76gc/
[07:32] <mborzecki> zyga: mvo: ^^
[07:34] <zyga> mborzecki: do you know how long it had to run?
[07:34] <zyga> is it a busy vm? slow generator (or deadlocked generator?)
[07:34] <zyga> or something else?
[07:34] <mvo> mborzecki: nice! but does that mean we need the backported fix from systemd?
[07:34] <mvo> mborzecki: also, why does it start to fail now, it used to work, no?
[07:34] <mborzecki> hmmm systemctl times out all the time
[07:37] <mborzecki> i see systemd got updated during our test run, there's a yum transaction that pulled in 219-67.el7_7.1.x86_64
[07:38] <mborzecki> the command is: yum y install golang >= 1.9 systemd autoconf automake libtool gcc gettext gnupg pkgconfig(glib-2.0) pkgconfig(libcap) pkgconfig(libseccomp) pkgconfig(libselinux) pkgconfig(libudev) pkgconfig(systemd) pkgconfig(udev) xfsprogs-devel glibc-static valgrind /usr/bin/rst2man selinux-policy selinux-policy-devel
[07:38] <mborzecki> so it's part of our test setup
[07:47] <zyga> mborzecki: reviewed https://github.com/snapcore/snapd/pull/7490#pullrequestreview-291590702
[07:47] <mup> PR #7490: interfaces/app-launch: support confined snaps launching other snaps <Created by AlanGriffiths> <https://github.com/snapcore/snapd/pull/7490>
[07:47] <zyga> brb, shower
[07:47] <zyga> mvo: do you mind if we cancel the 1-2-1 today?
[07:48] <zyga> I'm super sleepy and my plan for the day is to go through reviews and bug triage
[07:48] <zyga> we can do one later during the week if you feel like we need one
[07:51] <zyga> mborzecki: can you review https://github.com/snapcore/snapd/pull/7484 later today?
[07:51] <zyga> mborzecki: I don't want to distract you from centos issue
[07:51] <mup> PR #7484: osutil: generalize SyncDir with FileState interface <Created by zyga> <https://github.com/snapcore/snapd/pull/7484>
[07:51] <mborzecki> zyga: ok, will do
[07:51] <zyga> thanks
[07:53] <mup> PR snapd#7479 closed: tests: skip centos when running interfaces-openvswitch for nigthly suite <Simple 😃> <Created by sergiocazzolato> <Closed by zyga> <https://github.com/snapcore/snapd/pull/7479>
[07:56] <mborzecki> Sep 23 07:22:49 sep230656-524345 systemd[1]: Caught <ABRT>, dumped core as pid 22180.
[07:56] <mborzecki> Sep 23 07:22:49 sep230656-524345 systemd[1]: Freezing execution.
[07:56] <mborzecki> Sep 23 07:23:06 sep230656-524345 sshd[19296]: Connection reset by 222.186.175.147 port 7036 [preauth]
[07:56] <mborzecki> Sep 23 07:23:14 sep230656-524345 dbus[475]: [system] Failed to activate service 'org.freedesktop.systemd1': timed out
[07:56] <mborzecki> mvo: zyga ^
[07:57] <zyga> ooo
[07:57] <zyga> abort?
[07:57] <mborzecki> mhm
[07:57] <zyga> grep systemd
[07:57] <mborzecki> no coredumps listed by coredumpctl
[07:57] <zyga> bugs are fun
[07:58] <mborzecki> zyga: the log https://paste.ubuntu.com/p/ynVRcCTBPN/ it goes south after ABRT
[07:59] <zyga> I wonder what "freezing execution" is
[07:59] <zyga> I mean, systemd just aborted, what does it freeze
[08:00] <mborzecki> duh, wonder where the coredumps are
[08:00] <mborzecki> normally they'd end up in the journal, but perhaps we cleaned up the journal?
[08:05] <mvo> zyga: I think it freezes because pid-1 canont die or the kernel is very unhappy
[08:05] <zyga> hmmm
[08:05] <zyga> mborzecki: is that really what happened? this is a log from the journal after all
[08:07] <mborzecki> zyga: that's all there is
[08:10] <mborzecki> zyga: wonder whether there's some 7.7 related problem, it only started a coulpe of days ago
[08:10] <mborzecki> zyga: and yum install pulls in a partial update from 7.7 actually
[08:21] <Chipaca> moin moin
[08:24] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/7475#pullrequestreview-291621672 needs fixing
[08:24] <zyga> hello chipaca
[08:24] <mup> PR #7475: sandbox/cgroup, usersession/userd: move cgroup related helper to a dedicated package <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7475>
[08:24] <zyga> now small break for warm tea, I'm cold today :|
[08:30] <Chipaca> zyga, mvo, if you were me, and wanted to give a golang-related talk, what would you talk about?
[08:32] <mvo> Chipaca: depends a bit on the audience - if its more beginners the export_test.go / package / package_test pattern is a nice one maybe ? I find it super useful but it seems to be not *that* common knowledge
[08:32] <Chipaca> is that called black-box testing?
[08:32] <Chipaca> white-box testing?
[08:33]  * Chipaca calls it orange-box testing to be onbrand
[08:33] <mvo> Chipaca: uh, thats a good question - I would go with black-box
[08:33] <mvo> Chipaca: *but* I'm sure there are people with different opinions
[08:33] <mvo> Chipaca: I would call it "api-surface-based-testing" or something
[08:34] <Chipaca> :-)
[09:02] <zyga> Chipaca: the language that defied the trend, retrospective from medium sized codebase written in go
[09:05] <Chipaca> zyga: what trend? :-)
[09:06] <zyga> Go went back to a simpler language
[09:06] <zyga> Language complexity seems to grow almost uniformly otherwise
[09:11] <Chipaca> hmm, i'll leave that one to you :-)
[09:12] <Chipaca> zyga: the directory still thinks you're in palamós
[09:12] <Chipaca> zyga: what city are you in / close to?
[09:13] <Chipaca> er, maybe i should ask in private :-p
[09:13]  * mborzecki going through systemd core dumps
[09:13] <Chipaca> mborzecki: weren't you taking today off?
[09:13] <mborzecki> Chipaca: nope, i'm swapping on 3.10
[09:14] <Chipaca> mborzecki: what happens on 3.10?
[09:14] <mborzecki> Chipaca: /me gets a day off :P
[09:14] <Chipaca> mborzecki: :-)
[09:18] <Chipaca> zyga: mborzecki: pstolowski: there's three GDGs in Poland AFAICT, go talk about golang / spread / snapd / etc
[09:18] <Chipaca> wait, no, just two
[09:19] <zyga> GDGs?
[09:19] <Chipaca> silly map confused me :-) (but kaliningrad might be fun to visit)
[09:19] <Chipaca> zyga: https://devfest.withgoogle.com/
[09:20] <mborzecki> iirc they loosened some visa rules if you travel to kaliningrad from PL
[09:21] <mborzecki> zyga: mvo: so ABRT comes from glibc apparently, let me post the backtrace
[09:21] <Chipaca> sadly there isn't one in Córdoba for Sergio to go to, otherwise he'd kill it
[09:22] <mborzecki> zyga: there's a GDG in wroclaw on 15.11 and one in warsaw in dec
[09:22] <zyga> yeah, I was looking at the one in Dec
[09:28] <mborzecki> zyga: mvo: https://bugs.centos.org/view.php?id=16441
[09:29] <mborzecki> it'd be great to try with a 7.7 image or just clean upgrade 7.6 to 7.7
[09:32] <zyga> mborzecki: memory corruption?
[09:32] <mborzecki> mhm
[09:32] <zyga> it seems that _int_free is the entry point to glibc
[09:32] <zyga> and ealier it was cg_enumerate_subgroups
[09:32] <zyga> well :/
[09:33] <zyga> mborzecki: btw, what is that bug tracker
[09:33] <zyga> it's not bugzilla
[09:33] <zyga> is it?
[09:33] <zyga> I like the fields it offers
[09:33] <mborzecki> mantis?
[09:33] <zyga> oh, is that mantis?
[09:33] <zyga> wow
[09:33] <zyga> that still exists
[09:34] <zyga> it was my first ever bug tracker like 20 years ago
[09:39] <mborzecki> ok, putting that core dump aside, back to some useful work
[09:42] <mup> PR snapd#7493 closed: snapcraft: set license to GPL-3.0 <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/7493>
[10:00] <om26er> who to ping for auto-connection requests in the absence of roadmr ?
[10:01] <om26er> context: https://forum.snapcraft.io/t/auto-connection-request-for-deskconnd/13364 -- I am the upstream of both the provider and the peer snap.
[10:04] <mvo> mborzecki: the centos question sounds like something for sergio?
[10:05] <mborzecki> mvo: yes, we're apparently using the official centos images in gcp, still waiting for 7.7 to be uploaded there
[10:05] <mborzecki> mvo: discussed taht with sergio in paris, but will ping him when he's back online
[10:07] <zyga> om26er: hmm, good question, I don't know
[10:30]  * Chipaca takes a break
[10:31] <Chipaca> om26er: doesn't that fall under the usual process for auto-connections?
[10:31] <Chipaca> or, actually, isnt' that automatic
[10:31]  * Chipaca should check
[10:31]  * Chipaca needs to take a break
[10:40] <zyga> break for tea and more reviews
[10:51] <om26er> @chipaca while I am the upstream for both snaps, they come from different organizations, hence it didnt work automatically
[11:07] <mborzecki> zyga: updated #7475
[11:07] <mup> PR #7475: sandbox/cgroup, usersession/userd: move cgroup related helper to a dedicated package <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7475>
[11:08] <mborzecki> ok, on to the review of 7484
[11:11] <zyga> thank you, I'll look soon
[11:11] <mborzecki> mvo: thanks for pushing the spread test to https://github.com/snapcore/spread/pull/85 !
[11:12] <mup> PR spread#85: spread/client: workaround bash 4.3 subshell errexit issues <Created by bboozzoo> <https://github.com/snapcore/spread/pull/85>
[11:15] <mvo> mborzecki: my pleasure - was looking at bit a spread this morning, could fully test locally though, so I hope it works ok
[11:28] <zyga> mborzecki: +1
[12:16] <Chipaca> hm, travis having a bad hair^Wnetwork day?
[12:24] <ijohnson> morning folks, perhaps Travis should also get a swap day too :-/
[12:28] <zyga> haha
[12:28] <zyga> I was thinking that just a second ago :D
[12:28] <zyga> looking at why the branches I review are red
[12:29] <zyga> does anyone know what this is about?
[12:29] <zyga> error: Get https://api.snapcraft.io/api/v1/snaps/download/99T7MUlRhtI3U0QFgl5mXXESAiSwt776_7396.snap: x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "Let's Encrypt Authority X3")
[12:29] <zyga> 1008
[12:29] <zyga> are we hitting some odd redirect, or something or the sort, that breaks ssl?
[12:37] <mborzecki> zyga: left some comments under #7484
[12:38] <mup> PR #7484: osutil: generalize SyncDir with FileState interface <Created by zyga> <https://github.com/snapcore/snapd/pull/7484>
[12:40] <zyga> mborzecki: I noticed, thank you so much!
[12:42] <mborzecki> zyga: tbh found the documentation of io.Reader somewhat vague
[12:42] <zyga> yeah, it's an interface after all :)
[12:42] <mborzecki> and the case of Read() returning <n>, io.EOF is quite fun to handle
[12:42] <zyga> I'll look at the error handling, I agree it's pretty complex
[12:54] <Chipaca> mborzecki: when does it return n, eof?
[12:55] <Chipaca> mborzecki: i mean, reading what?
[12:55] <Chipaca> os.File says it's 0, eof on eof
[12:56] <mborzecki> Chipaca: right, but we're passing io.Reader around
[12:56] <Chipaca> fair
[12:57] <mborzecki> Chipaca: i mean, the func is called StreamsEqual() so it does make sense to use io.Reader in there
[12:57] <Chipaca> totes
[12:58] <mborzecki> though that comes with some luggage :/
[13:20] <mborzecki> mvo: installed snapd from edge, it's showing GPL-3.0 correctly now https://paste.ubuntu.com/p/65D3S6KqKr/
[13:21] <mvo> mborzecki: nice, thanks
[13:25] <Chipaca> mborzecki: so
[13:25] <Chipaca> mborzecki: why not take an io.Reader and wrap it into a osutil.readerButAlwaysZeroWhenError ?
[13:25] <Chipaca> mborzecki: wouldn't that keep the code calling Read simpler?
[13:39] <mborzecki> Chipaca: perhaps, wonder if it's worth it, more code to test
[13:39] <Chipaca> mborzecki: depends how complex the code without it is
[13:39] <Chipaca> ¯\_(ツ)_/¯
[13:57] <mborzecki> off to pick up the kids
[14:03] <om26er> is roadmr on vacation ?
[14:06] <Chipaca> om26er: quite likely
[14:07] <om26er> Chipaca in his absence, do you know who to contact regarding store requests ?
[14:07] <om26er> I don't want to bug Jamie for everything ;-)
[14:07] <Chipaca> om26er: which request is it?
[14:07] <Chipaca> om26er: the one from this morning?
[14:08] <Chipaca> about content interface autoconnection between snaps of different publishers?
[14:08] <om26er> Chipaca yes, that and two others (a total of three auto-connection requests)
[14:08] <Chipaca> om26er: did you read the process for requesting auto-connection?
[14:09] <om26er> I have read, yes. But I have had the process fastened in the past and this is something I wanted sooner because its for a project that I have to show at Ubucon in few weeks
[14:10] <Chipaca> om26er: I'd be entirely unsurprised if today were a bad day for this
[14:10] <Chipaca> om26er: a lot of people take the day after a sprint off
[14:11] <om26er> aha, its the "swap day" day ;-)
[14:11] <Chipaca> yus
[14:13]  * om26er used to have two swap days after Canonical events due to two weekends consumed as a result of very long flights
[14:15] <Chipaca> om26er: ssh, don't tell cachio, he'll get ideas
[14:16]  * diddledan whistles nonchalantly: https://usercontent.irccloud-cdn.com/file/gXAW7XVu/image.png
[14:16] <diddledan> the full output: https://usercontent.irccloud-cdn.com/file/TgRSHRNQ/image.png
[14:17] <diddledan> start your rippers!
[14:17]  * Chipaca is already ripped
[14:29] <mup> PR snapd#7488 closed: docs: Update README.md <Created by degville> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/7488>
[14:56]  * zyga lunch and walk
[15:06] <mvo> Chipaca: thanks for merging this. are we back to green tests?
[15:30] <Chipaca> mvo: looked like it!
[15:47] <Chipaca> brb, need to get two birthday cakes into the oven
[16:18] <mup> PR snapd#7495 opened: [RFC] tests: add gh action for static checks <⛔ Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7495>