thumperec0: heh00:16
=== mpjetta_ is now known as mpjetta
manadartachilleasa: Need a review on a purely mechanical patch: https://github.com/juju/juju/pull/1065308:13
achilleasamanadart: looking08:14
achilleasamanadart: you also need to update the import paths for some other tests: https://jenkins.juju.canonical.com/job/github-make-check-juju/1152/console08:57
manadartachilleasa: Yeah, they are fixed; just running the tests now.08:58
nammn_demanadart: as we were talking about that before. Mind taking a quick look and review? https://github.com/juju/juju/pull/1065209:12
manadartnammn_de: Sure.09:12
manadartnammn_de: Reviewed.09:23
achilleasamanadart: overall LGTM; just have two questions (see comments)09:29
nammn_dethanks manadart and stickupkid09:29
nammn_degonna add a test for the sorting case, manadart: regarding the openstack provider. Would it be worthwhile to update the "flavor" of openstack? As we are using it's struct https://github.com/juju/juju/blob/26d73876d4daedca2a39c3f385f98ac5040f27e0/provider/openstack/provider.go#L557 , my implementation used cost as the second value to sort. Here i09:31
nammn_decould use ram though09:31
stickupkidmanadart, you'll like this update i'm about to post to your discourse post :D09:37
stickupkidmanadart, once i've written it09:38
achilleasastickupkid: can you post on discourse or are you getting back 500 errors?09:38
stickupkidachilleasa, argh, not thought about that, let me check09:38
achilleasamanadart: got a few sec for a quick question re charm upgrades?09:42
stickupkidmanadart, achilleasa https://discourse.jujucharms.com/t/thoughts-on-unit-testing/1451/909:49
stickupkidachilleasa worked for me09:49
manadartachilleasa: One sec.09:49
achilleasastickupkid: can you post in internal?09:54
stickupkidachilleasa let me check09:54
stickupkidachilleasa yeah i can09:56
achilleasamanadart: changes approved09:57
achilleasastickupkid: hmmm... maybe I don't have post permissions? :D09:59
stickupkidachilleasa, https://media.tenor.com/images/ea2db29e89e34daa1b3d9716a7644208/tenor.gif10:01
manadartachilleasa: Thanks. HO on the charm thing?10:02
achilleasamanadart: omw10:03
achilleasastickupkid: so I can create a post but when I try to paste the template and save I get an internal server error :-(10:09
achilleasastickupkid: can you try to paste https://pastebin.canonical.com/p/twG4txHRJX/ in https://discourse.jujucharms.com/t/juju-release-process-2-6-9/2091 ?10:10
stickupkidachilleasa legit 50010:11
achilleasais there a max post size limit or something?10:11
stickupkidachilleasa don't think so10:11
stickupkidachilleasa surely it would tell you10:12
achilleasastickupkid: pasting half the text seems to work though...10:13
stickupkidachilleasa the response from XHR, is the worst - 500, killed the server10:13
stickupkidachilleasa not much information to help diagnose10:13
achilleasastickupkid: it does seem like a max size limit... I managed to post up to the "homebrew" sections. Any attempts to append text after that point cause a 50010:19
stickupkidlet's check what discourse says10:19
stickupkid99k max char limit10:20
stickupkidunless an admin has restricted it10:20
achilleasaI could render the markdown into an image and paste that in the post :D10:21
stickupkidachilleasa i know why10:22
stickupkidachilleasa HO?10:26
achilleasastickupkid: omw10:26
manadartachilleasa, stickupkid: Anyone able to review another trivial mechanical one? I started on the substantive patch, but thought I'd add another one to ease eventual review.11:40
manadartstickupkid: Were you going to have a look at https://github.com/juju/juju/pull/10655 ?15:23
stickupkidmanadart, aye, was fighting with mocks15:24
stickupkidI won15:24
manadartDid ye ay?15:24
manadartForgot to pull that out at the sprint.15:24
stickupkidi wonder what the response to that is tbh15:25
* manadart realises the innuendo possibilities too late.15:25
stickupkidmanadart, done15:27
manadartstickupkid: Ta.15:28
gnuoyCould anyone tell me when 2.7 is likely to move to candidate ?15:37
rick_hgnuoy:  end of Oct15:37
gnuoythanks rick_h15:37
rick_hmagicalt1out:  any thought on putting your post on discourse? or mind if I do? https://www.spicule.co.uk/news/post/2019-09-25-how-to-deploy-applications-at-scale-in-kubernetes17:18
magicalt1outi don't mind rick_h go ahead17:31
=== magicalt1out is now known as magicaltrout

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!