[00:16] <thumper> ec0: heh
=== mpjetta_ is now known as mpjetta
[08:13] <manadart> achilleasa: Need a review on a purely mechanical patch: https://github.com/juju/juju/pull/10653
[08:14] <achilleasa> manadart: looking
[08:57] <achilleasa> manadart: you also need to update the import paths for some other tests: https://jenkins.juju.canonical.com/job/github-make-check-juju/1152/console
[08:58] <manadart> achilleasa: Yeah, they are fixed; just running the tests now.
[09:12] <nammn_de> manadart: as we were talking about that before. Mind taking a quick look and review? https://github.com/juju/juju/pull/10652
[09:12] <manadart> nammn_de: Sure.
[09:23] <manadart> nammn_de: Reviewed.
[09:29] <achilleasa> manadart: overall LGTM; just have two questions (see comments)
[09:29] <nammn_de> thanks manadart and stickupkid
[09:31] <nammn_de> gonna add a test for the sorting case, manadart: regarding the openstack provider. Would it be worthwhile to update the "flavor" of openstack? As we are using it's struct https://github.com/juju/juju/blob/26d73876d4daedca2a39c3f385f98ac5040f27e0/provider/openstack/provider.go#L557 , my implementation used cost as the second value to sort. Here i
[09:31] <nammn_de> could use ram though
[09:37] <stickupkid> manadart, you'll like this update i'm about to post to your discourse post :D
[09:38] <stickupkid> manadart, once i've written it
[09:38] <stickupkid> haha
[09:38] <achilleasa> stickupkid: can you post on discourse or are you getting back 500 errors?
[09:38] <stickupkid> achilleasa, argh, not thought about that, let me check
[09:42] <achilleasa> manadart: got a few sec for a quick question re charm upgrades?
[09:49] <stickupkid> manadart, achilleasa https://discourse.jujucharms.com/t/thoughts-on-unit-testing/1451/9
[09:49] <stickupkid> achilleasa worked for me
[09:49] <manadart> achilleasa: One sec.
[09:54] <achilleasa> stickupkid: can you post in internal?
[09:54] <stickupkid> achilleasa let me check
[09:56] <stickupkid> achilleasa yeah i can
[09:57] <achilleasa> manadart: changes approved
[09:59] <achilleasa> stickupkid: hmmm... maybe I don't have post permissions? :D
[10:01] <stickupkid> achilleasa, https://media.tenor.com/images/ea2db29e89e34daa1b3d9716a7644208/tenor.gif
[10:02] <manadart> achilleasa: Thanks. HO on the charm thing?
[10:03] <achilleasa> manadart: omw
[10:09] <achilleasa> stickupkid: so I can create a post but when I try to paste the template and save I get an internal server error :-(
[10:09] <stickupkid> lol
[10:10] <achilleasa> stickupkid: can you try to paste https://pastebin.canonical.com/p/twG4txHRJX/ in https://discourse.jujucharms.com/t/juju-release-process-2-6-9/2091 ?
[10:11] <stickupkid> achilleasa legit 500
[10:11] <achilleasa> is there a max post size limit or something?
[10:11] <stickupkid> achilleasa don't think so
[10:12] <stickupkid> achilleasa surely it would tell you
[10:13] <achilleasa> stickupkid: pasting half the text seems to work though...
[10:13] <stickupkid> achilleasa the response from XHR, is the worst - 500, killed the server
[10:13] <stickupkid> achilleasa not much information to help diagnose
[10:13] <achilleasa> yeap...
[10:19] <achilleasa> stickupkid: it does seem like a max size limit... I managed to post up to the "homebrew" sections. Any attempts to append text after that point cause a 500
[10:19] <stickupkid> lol
[10:19] <stickupkid> let's check what discourse says
[10:20] <stickupkid> 99k max char limit
[10:20] <stickupkid> unless an admin has restricted it
[10:21] <achilleasa> I could render the markdown into an image and paste that in the post :D
[10:21] <stickupkid> HAHA
[10:22] <stickupkid> achilleasa i know why
[10:26] <stickupkid> achilleasa HO?
[10:26] <achilleasa> stickupkid: omw
[11:40] <manadart> achilleasa, stickupkid: Anyone able to review another trivial mechanical one? I started on the substantive patch, but thought I'd add another one to ease eventual review.
[11:41] <manadart> https://github.com/juju/juju/pull/10655
[15:23] <manadart> stickupkid: Were you going to have a look at https://github.com/juju/juju/pull/10655 ?
[15:24] <stickupkid> manadart, aye, was fighting with mocks
[15:24] <stickupkid> I won
[15:24] <manadart> Did ye ay?
[15:24] <stickupkid> HAHAHA
[15:24] <manadart> Forgot to pull that out at the sprint.
[15:25] <stickupkid> i wonder what the response to that is tbh
[15:25]  * manadart realises the innuendo possibilities too late.
[15:27] <stickupkid> manadart, done
[15:28] <manadart> stickupkid: Ta.
[15:37] <gnuoy> Could anyone tell me when 2.7 is likely to move to candidate ?
[15:37] <rick_h> gnuoy:  end of Oct
[15:37] <gnuoy> thanks rick_h
[17:18] <rick_h> magicalt1out:  any thought on putting your post on discourse? or mind if I do? https://www.spicule.co.uk/news/post/2019-09-25-how-to-deploy-applications-at-scale-in-kubernetes
[17:31] <magicalt1out> i don't mind rick_h go ahead
=== magicalt1out is now known as magicaltrout