| manadart | Anyone about to do a review? https://github.com/juju/juju/pull/10661 | 06:47 |
|---|---|---|
| stickupkid | manadart, if you have a couple of minutes to look over my PR, before i submit it | 09:45 |
| stickupkid | manadart, might be worth HO first? | 09:45 |
| manadart | stickupkid: Yep. just need a few mins. | 09:46 |
| stickupkid | manadart, nice, need to push it first anyway | 09:46 |
| manadart | stickupkid: I am in daily. | 10:04 |
| stickupkid | the fact we don't use go mode, kills us with github actions :| | 12:11 |
| stickupkid | go module * | 12:11 |
| rick_h | stickupkid: that sucks | 12:27 |
| rick_h | nammn_de: review in, let me know if you have any questions | 13:41 |
| nammn_de | rick_h: great, thanks for the review! Added some questions https://github.com/juju/juju/pull/10665 | 13:56 |
| rick_h | k, looking | 14:00 |
| rick_h | guild anyone have a chance to review https://github.com/juju/juju/pull/10660 for thumper <3 | 14:27 |
| stickupkid | not only did I get 10000 PR number, I got 10666 https://github.com/juju/juju/pull/10666 | 14:29 |
| stickupkid | manadart, | 14:30 |
| manadart | Ja? | 14:30 |
| manadart | \m/ | 14:30 |
| achilleasa | stickupkid: wicked! | 14:37 |
| rick_h | stickupkid: 15m not bad! https://github.com/SimonRichardson/juju/runs/238881258 | 14:41 |
| rick_h | stickupkid: that'll work just peachy for check jobs | 14:41 |
| stickupkid | rick_h, yeah, that's a lot less that other stuff, we can actually turn off the pre-checks from jenkins now | 14:42 |
| stickupkid | rick_h, well, when it lands | 14:42 |
| rick_h | stickupkid: right, exciting | 14:42 |
| rick_h | stickupkid: I forsee a discourse post in your future! :P | 14:42 |
| stickupkid | haha, yeah, I might actually do that this afternoon, | 14:42 |
| stickupkid | rick_h, when you get back - https://github.com/juju/juju/pull/10667 | 16:22 |
| nammn_de | rick_h: same here: https://github.com/juju/juju/pull/10665/ | 17:35 |
| nammn_de | :D | 17:35 |
| nammn_de | If a PR gets some comments and you have addressed them. What do you prefer? Let the reviewer resolve them or resolve them yourselves so that the reviewer knows that it was implemented? | 17:37 |
| pmatulis | shouldn't this just work (on AWS)? juju deploy -n 3 ceph-osd --storage osd-devices=3G,2 --storage osd-journals=6G,1 | 20:17 |
| pmatulis | the appliations stay at 'agent initializing', presumably b/c OSD disks cannot be found. nothing in logs | 20:17 |
| pmatulis | so how is one supposed to deploy ceph-osd charm from the store? | 20:18 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!