/srv/irclogs.ubuntu.com/2019/09/30/#snappy.txt

mborzeckimorning05:06
mupPR snapd#7530 opened: tests: move "centos-7" to unstable systems (2.42) <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7530>05:48
mborzeckimvo: morning06:06
mvohey mborzecki06:06
mupPR snapd#7530 closed: tests: move "centos-7" to unstable systems (2.42) <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7530>06:16
mupPR snapd#7525 closed: tests: disable {contacts,calendar}-service tests on Arch Linux (2.42) <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7525>06:17
mupPR snapd#7524 closed: tests: add unit test for gadget defaults with a multiline string <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7524>06:18
mupPR snapd#7523 closed: sandbox/selinux: move SELinux related bits from 'release' to 'sandbox/selinux' <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7523>06:19
mborzeckimvo: can you take a look at https://github.com/snapcore/snapd/pull/7507 ?06:21
mupPR #7507: gadget: do not fail the update when old gadget snap is missing bare content <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7507>06:21
mvomborzecki: sure06:21
zygagood morning everyone06:22
zygasome weather ...06:22
mborzeckimvo: thanks06:24
mborzeckizyga: hey06:24
mborzeckihm can't launch anything under mulitpass06:55
mborzeckilaunch failed: Failed to set iptables rule for table filter: iptables v1.6.1: unknown option "--dport"06:55
mborzecki--beta works though06:59
=== pstolowski|afk is now known as pstolowski
pstolowskimorning07:01
dot-tobiasgood morning07:02
mborzeckiSaviq: filed https://github.com/CanonicalLtd/multipass/issues/1100 let me know if you need more info07:02
mborzeckipstolowski:  hey07:03
mvohey pstolowski07:12
mupPR snapd#7507 closed: gadget: do not fail the update when old gadget snap is missing bare content <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7507>07:18
mborzeckiyay :)07:18
mborzeckimvo:  can you cherry-pick that to 2.42? the commit hash is 31d33fa4e07:19
mvomborzecki: thanks, done07:22
mupPR snapd#7531 opened: cmd/system-shutdown: include correct prototype for die <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7531>07:33
zygamvo: there's one more thing to cherry pick07:34
zygait landed when you were away, one sec07:34
zygamvo: https://github.com/snapcore/snapd/pull/752607:34
mupPR #7526: cmd/snap-confine: allow digits in hook names <Bug> <Simple 😃> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7526>07:34
zygamvo: and perhaps https://github.com/snapcore/snapd/pull/7531 as well07:37
mupPR #7531: cmd/system-shutdown: include correct prototype for die <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7531>07:37
zygamvo: so that I can drop all patches from 2.42 in suse07:37
mvozyga: thanks, looking07:38
zygaI'll check why our builds don't catch that though, must be -Wsomething we're missing07:38
mvozyga: 7526 is in07:38
zygaThank you, ondra will be very happy this made it in07:41
zygamborzecki: ping about https://github.com/snapcore/snapd/pull/748407:52
mupPR #7484: osutil: generalize SyncDir with FileState interface <Created by zyga> <https://github.com/snapcore/snapd/pull/7484>07:52
zygamvo: not sure if you want to pull that into 2.4207:52
zygait's the memory optimization for icons07:52
pedronisit needs reviews07:53
mvozyga: no07:55
mvozyga: or *maybe* but it needs to be reviewed and obviously fixing something :)07:56
zygayeah, just asking because you indicated you might be interested in that at the sprint when it came up07:56
zygabut I think it's okay to get this in 2.4307:56
zygawe can use store to prevent people from sending huge icons07:57
pedronis#7277 needs 2nd review07:59
mupPR #7277: overlord/snapstate: fix undo on firstboot seeding <Created by stolowski> <https://github.com/snapcore/snapd/pull/7277>07:59
* Chipaca has successfully bred some kind of a throat bug over the weekend and feels this was a poor idea and would like to cancel his subscription to it08:38
zygare08:45
zygaChipaca: so you have my copy? :D08:46
zygaget well man08:46
Chipacazyga: eh, just my throat catching a lot and the general sense of fighting something bringing me down a bit, nothing that should stop me (might slow me down some)08:53
pedronisChipaca: hi, sorry about that08:56
pedronisChipaca: #7402 can be merged ?08:57
mupPR #7402: daemon, client, cmd/snap: include architecture in 'snap version' <Created by chipaca> <https://github.com/snapcore/snapd/pull/7402>08:57
Chipacapedronis: heading into a meeting, but … probably?08:59
mupPR snapd#7516 closed: daemon: allow /v2/assertions/{assertType} to query store <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7516>09:36
mupPR snapd#7402 closed: daemon, client, cmd/snap: include architecture in 'snap version' <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/7402>09:37
mupPR snapd#7531 closed: cmd/system-shutdown: include correct prototype for die <Simple 😃> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7531>09:41
zygaheavy rain here, hope no funny stuff with power lines toda09:43
Chipaca"hope no funny stuff with power lines toda--" KOOOOMzapWHUMP09:45
* zyga -> quick tea09:54
mvozyga: re 7484 - I wonder if it would make sense to push a PR that just adds the osutil.FileState interface and does all the mechanical stuff (no real code changes)10:23
zygamvo: I can do that10:23
zyganote that FileState became an interface from a struct10:24
zygaso it would involve a lot of changes already10:24
zyganot sure if that's what you had on your mind10:24
mvozyga: yeah, thats what I mean10:24
zygalet me try10:24
mvozyga: it might be simpler to review one PR with just this mechanical change FileState->interface previous FileState->MemoryThing no other changes10:25
mvozyga: i.e. no adding of FileReference or anything10:25
mvozyga: then it becomes a mechanical review and the actual implementation change is smaller and more obvious10:25
zygamhm10:25
zygaman, what a downpour!10:26
mvo(but of course if e.g. pedronis thinks 7418 is fine as is and should not be split that is fine for me too)10:26
pedronismvo: no strong opinion, is not very big either way10:36
* mvo nods10:36
mborzeckiduh, dates suuuck10:49
Chipacamborzecki: you're reminding me of this book that looked into systems that needed something like three different times referring to everything so as to answer questions such as "what price would the sales person have had on their laptop in the field at the time they gave the presentation?"10:56
mupBug #1628289 changed: snapd should depend on squashfuse (for use in containers) <lxd> <verification-done> <Snappy:Fix Released> <snapd (Ubuntu):Fix Released> <squashfuse (Ubuntu):Fix Released> <squashfuse (Ubuntu Xenial):Fix Released> <https://launchpad.net/bugs/1628289>11:03
mborzeckiok, pushed a fix to https://github.com/snapcore/snapd/pull/7443 think i got all the edge cases right11:07
mupPR #7443: timeutil: fix schedules with ambiguous nth weekday spans <Bug> <Needs Samuele review> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7443>11:07
mupBug #1548225 changed: Snapcraft/snappy should detect incompatible version mismatches <Snapcraft:Won't Fix> <Snappy:Won't Fix> <https://launchpad.net/bugs/1548225>11:09
mupBug #1636891 changed: Unable to log in using email with + character <Snappy:Fix Released> <subiquity (Ubuntu):Fix Released> <https://launchpad.net/bugs/1636891>11:09
mupBug #1636242 changed: snap fails to install a package if it doesn't start a daemon successfully <Snappy:Won't Fix> <https://launchpad.net/bugs/1636242>11:12
pedronisChipaca: do the current retries handle this better:  https://bugs.launchpad.net/snappy/+bug/1643893 ?11:13
mupBug #1637153 changed: plugging in a network cable when wifi config failed causes a traceback when restarting console-conf <Snappy:Fix Released> <subiquity (Ubuntu):Fix Released> <https://launchpad.net/bugs/1637153>11:15
mupBug #1644546 changed: [console-conf] Network screen continues to account setup with failing configuration <Snappy:Fix Released> <subiquity:Fix Released> <https://launchpad.net/bugs/1644546>11:15
zygaback from call, returning to branches11:15
Chipacapedronis: dunno11:19
pedronismborzecki: could you update/answer here: https://bugs.launchpad.net/snappy/+bug/183970911:27
mupBug #1839709: does not work under cgroup v2 <Snappy:New> <snapd (Debian):Confirmed> <snapd (Fedora):Unknown> <https://launchpad.net/bugs/1839709>11:27
mborzeckipedronis: sure11:27
pedronisthx11:27
mborzeckibtw. on this note, people are starting to notice cgroups v2 in fedora since docker broke :P11:28
zygamborzecki: I saw that11:28
zygamborzecki: note there's a fallback plan still, to push it for another release11:28
zygabut I'm curious11:28
zygasince it seems like fedora might want to push to the docker replacement stack (podman and friends) instead11:29
zygawhich would be perfectly in line with what they are trying to achieve (ship brand new software early)11:29
mborzeckiyeah, still it kind of assumes that you have the time to play with it and 1st, debug why docker doesn't work anymore, 2nd actually switch to podman11:30
zygamborzecki: I'm suprised docker is not a transitional package with a loads of wrapper scripts11:33
mborzeckizyga: well podman should be able to consume the same arguments as you normally pass to docker11:33
mborzeckiand it does not require a daemon11:34
zygamborzecki: right my point is that it feels like user-machine friction11:34
zyga"podman" != "docker"11:34
zygaso people get docker and bam11:34
mborzeckizyga: right, and docker inc. adds to that by having docker and moby :P11:34
mborzeckizyga: where moby may as well come from distro repos and behave a bit differently than docker from docker repos11:35
zygapart of FOSS complexity I guess11:36
diddledanwe should get podman into a snap11:49
pedronismvo: we got an answer to your request here: https://bugs.launchpad.net/snapd/+bug/184307711:53
mupBug #1843077: Data corruption when UC18 is not powered down cleanly <snapd:Confirmed> <https://launchpad.net/bugs/1843077>11:53
pedroniszyga: you got one +1 to 7484, splitting it now seems a bit a waste of time12:01
zygapedronis: I'm happy NOT to if mvo agrees :)12:02
zygaI can do more useful stuff then12:02
pedroniszyga: I don't think mvo had a strong opinion on this :) if you add the tests and get a +1 from mborzecki it can land I think12:03
zygacool, I'll do that then12:03
mborzeckipedronis: zyga: not splitting is ok for me12:08
zygamborzecki: +112:09
cachiomborzecki, hey, here there is a log when centos cannot start activate a service12:10
cachioand gives a timeout12:10
cachiohttps://paste.ubuntu.com/p/pNYYqPKJM7/12:10
cachiomborzecki, then you see12:11
cachio+ systemctl daemon-reload12:11
cachioFailed to execute operation: Connection timed out12:11
cachioin the log12:11
mborzeckicachio: yup, i filed a bug in centos with this last week, there's a fixed systemd build in the fasttrack repo, but we have to wait for it to end up in updates12:12
zygamborzecki: https://github.com/snapcore/snapd/pull/7484/commits/9481c3cba1a8a4a62c76df78fb7cb7bece6ee89d12:12
mupPR #7484: osutil: generalize SyncDir with FileState interface <Created by zyga> <https://github.com/snapcore/snapd/pull/7484>12:12
cachiomborzecki, nice12:13
cachiothanks for the update12:13
mborzeckicachio: https://bugs.centos.org/view.php?id=16441 if you want the details12:13
mvozyga: yeah, thats fine. was mostly wondering, especially since you suggested it for 2.4212:14
mvozyga: so not splitting is fine12:14
zygabreak for more tea12:16
zygabrb12:16
mupPR snapd#7532 opened: Allow ovs interface access to bridge sockets <Created by dosaboy> <https://github.com/snapcore/snapd/pull/7532>12:34
* Chipaca stops editing mborzecki's standup thing and goes to get something to nom12:51
mupPR snapd#7533 opened: client: add support to use the new "download" API <Created by mvo5> <https://github.com/snapcore/snapd/pull/7533>12:56
=== ricab is now known as ricab|lunch
mupPR snapd#7534 opened: sandbox/seccomp: move the remaining sandbox bits to a corresponding sandbox package <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7534>13:09
mborzeckizyga: ^^13:09
zygasure13:10
zygamborzecki: done13:12
zygamborzecki: can you review /writable PR please :)13:12
mborzeckizyga: hmm quite sure i posted a review13:12
zygaoh13:12
zygasilly github stale stuff13:13
zygathanks!13:13
zygamborzecki: replied13:14
zygathanks13:14
zygajdstrand: hey13:29
zygajdstrand: are you back this week?13:29
jdstrandzyga: today and tomorrow, yes13:29
jdstrand(hey)13:29
zygahey :)13:30
zygaI did an update over one branch and I'd like your re-review, just one today13:30
zygahttps://github.com/snapcore/snapd/pull/742113:30
zygait's also shorter and easier13:30
mupPR #7421: cmd/snap-confine: unmount /writable from snap view <Created by zyga> <https://github.com/snapcore/snapd/pull/7421>13:30
zygajdstrand: the whole complexity got reduced to one function with two if statements13:31
zygahttps://github.com/snapcore/snapd/pull/7421/files#diff-af477950316a096b57d91c74478bc4d2R52113:31
jdstrandzyga: ok13:32
zygathanks, I'm working on more :)13:35
* zyga -> walking the dog in the rain13:45
mborzeckiChipaca: so this one https://github.com/snapcore/snapd/pull/7166#discussion_r329554850 is actually quite interesting, bc the way i read it, timeout.C serves as the upper timit (time based though) for the retry mechanism (and that one is a workaround for snapd daemon restarts)13:47
mupPR #7166: client: add doTimeout to http.Client{Timeout} <Created by mvo5> <https://github.com/snapcore/snapd/pull/7166>13:48
mborzeckiChipaca: but since it doesn't affec the actual client.raw() call, it will have no effect when client.raw() gets stuck13:49
ijohnsonhey folks, could I get reviews for #7437? ping mborzecki :-)14:12
mupPR #7437:  wrappers/services.go: add disabled svc list arg to AddSnapServices <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/7437>14:12
mupPR snapd#7484 closed: osutil: generalize SyncDir with FileState interface <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7484>14:15
Chipacamborzecki: fair enough; that one wasn't the blocker :-)14:45
* zyga EODs for now, will return to garden one branch later tonight after homework and rest15:00
zygao/15:00
ChipacaI'm going to slither off early as well, got my monthly physio check-up thing and then maybe a run if I'm up to it (doubt it because bleh)15:03
mupPR snapd#7534 closed: sandbox/seccomp: move the remaining sandbox bits to a corresponding sandbox package <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7534>15:04
* cachio lunch15:06
cmatsuokamvo: pushed commits, still to check the test errors15:12
cmatsuokamvo: i'll be back after lunch15:13
mvocmatsuoka: thank you15:16
kyrofaUsing xdg-open within a snap: should I be using snap-xdg-open, or just xdg-open?15:28
abeatosil2100, fyi: https://github.com/CanonicalLtd/ubuntu-image/pull/17515:54
mupPR CanonicalLtd/ubuntu-image#175: Little kernel bootloader support <Created by alfonsosanchezbeato> <https://github.com/CanonicalLtd/ubuntu-image/pull/175>15:54
=== pstolowski is now known as pstolowski|afk
ijohnsonmvo got a minute to talk about uc18 spread test setup? I'm still having difficulties building an image with hacks in it by following parts of the spread prepare suite, and I'm not sure how much of the spread stuff I should be copying...16:17
ijohnsonwe could also talk tomorrow if you're EOD or about to EOD16:17
sil2100abeato: see it, thanks! Will review, but it looks solid from a first look16:22
mvoijohnson: pretty much eod, so unless its something specfic tomorrow is better. any particular thing that you are looking for?16:22
ijohnsonwell how to make it work haha16:23
ijohnsonlet's just talk tomorrow then16:23
sil2100abeato: could we get the gadget.yaml spec updated to include the new bootloader? https://forum.snapcraft.io/t/the-gadget-snap/69616:23
abeatosil2100, good point, will give that a go. or maybe ondra prefers to do that himself ^^16:27
sil2100abeato: anyway, thanks for the PR! I'll make sure it's reviewed and (hopefully) merged tomorrow16:27
abeatosil2100, awesome, thanks!16:27
sil2100o/16:27
ijohnsoncachio: is there an easy way to increase the size of the disk space provided to a qemu machine when setup with spread?17:04
ijohnsonI'm trying to run the ubuntu-core-18-64 tests (well a modified one) and it runs out of space before finishing preparing17:04
ijohnsonhmm actually I think if I just increase the empty space in the image that spread uses it should automatically expand to use that I think17:07
cachioijohnson, which image are you using?17:18
ijohnsonI am trying to use the qemu backend17:18
ijohnsoncachio: ^17:18
cachioijohnson, it is weird17:20
cachioijohnson, did you change the prapare phose of the test suite?17:21
ijohnsonno, not yet, just trying to see how uc18 in the tests is "bootstrapped" from classic 16.0417:21
cachioijohnson, so, you want to run uc18 on qemu right?17:22
ijohnsonyes, but I want to eventually modify the image that boots in order to add stuff to the root filesystem17:22
ijohnsonbut for now, just getting one that boots with spread is sufficient for me17:23
cachioand how did you create that image?17:23
cachioijohnson, the uc18 one17:23
ijohnsonI followed HACKING.md :-)17:23
ijohnsonhttps://github.com/snapcore/snapd/blob/master/HACKING.md#building-spread-vm-images17:23
ijohnsonI created the ubuntu-16.04-64.img with `adt-buildvm-ubuntu-cloud`17:24
cachioijohnson, ah, and then you want to transform it to core18, right?17:24
ijohnsonyes17:25
cachioijohnson,  did you try to generate the image directly by using ubuntu-image?17:25
ijohnsonI tried just modifying the official amd64 image by adding stuff to the rootfs but it didn't take, it seems to be ignored17:25
cachioand the using external system?17:25
ijohnsonI have not tried that yet17:25
ijohnsons/official amd64 image/official amd64 UC18 image/17:26
cachioso, you can generate the image by running17:27
cachiosudo ubuntu-image "$image_option" "$snaps" \17:28
cachio         -c "$CHANNEL" \17:28
cachio         -O "$output" \17:28
cachio         "./models/${platform}-${VERSION}.model"17:28
cachiowith17:28
cachioimage_option="--image-size 3G"17:28
cachiosnaps= --snap <path to local snap>17:28
cachioif you need to add any new snap17:29
ijohnsonhow would I do that for the qemu image?17:29
cachiothen you run17:29
cachiosudo kvm -snapshot -smp 2 -m 2000 -net nic,model=virtio -net user,hostfwd=tcp::8022-:22 -nographic -serial mon:stdio <PATH_TO_VM_IMAGE>17:29
cachioand you can connect to it17:30
cachiosetting the17:30
cachioSPREAD_EXTERNAL_ADDRESS=localhost:802217:30
cachioand using the external backend417:30
cachiobackend17:30
cachiothe qemu backend in fact is doing something similar to that17:30
cachiothe qemu backend is doing  this: https://github.com/snapcore/spread/blob/master/spread/qemu.go#L11717:31
cachioijohnson, I didnt try it, beu you could save the image generated with ubuntu-image into "$HOME/.spread/qemu/"17:32
cachioand then try to use the qemu backend17:32
ijohnsonyes I've been able to boot the image with qemu, I guess the problem I have is 2 problems17:33
ijohnson, first is that if I modify my UC18 image directly, the changes don't seem to work properly (I think this is because of the special UC18 boot process which is different from UC16 where my modifications do work)17:33
cachioijohnson, but it is not gonna work because ubuntu core needs to run console-conf17:33
ijohnsonand the second problem is that if I try to use spread to boot the default classic xenial image and let spread "prepare" the xenial image into a UC18, then preparing fails because the default image doesn't have enough space17:33
ijohnsoncachio: I successfully disabled console-conf in the image, that much still works from my days hacking on UC16 images :-)17:34
ijohnsonI need to break for lunch but will look at this again in a little bit, cachio do you know if the adt-build-vm-ubuntu-cloud created images are in raw format or a different format?17:35
cachioijohnson, no idea17:35
ijohnsonok, np17:36
cachioijohnson, but you should be able to resize the image17:36
ijohnsonhmm actually there is a qemu resize image command isn't there17:36
cachioijohnson,  for google images we run resize2fs17:36
cachioto resize them when it is needed17:37
ijohnsonack, thanks I'll look into that after lunch17:37
ijohnsonthanks cachio!17:37
* ijohnson lunches17:37
cachioijohnson, sure17:37
mupPR snapd#7535 opened: tests: disable {contacts,calendar}-service tests on debian-sid <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7535>17:43
mvoreview for -^ would be great17:45
mvosimple and will unbreak master17:45
mupPR snapcraft#2734 opened: SnapcraftError refactoring <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2734>17:48
cachiomvo, do you know why it is failing in debian17:52
cachiosame reason than arch?17:52
mvocachio: looks like it17:52
mvocachio: https://metadata.ftp-master.debian.org/changelogs//main/e/evolution-data-server/evolution-data-server_3.34.0-3_changelog17:53
mvocachio: looks like the updated version hit unstable today17:53
cachiomvo, today we updated debian sid17:54
ijohnsonmvo: reviewed17:59
mvota!17:59
mupPR snapd#7536 opened: gadget: accept system-seed role and ubuntu-data label <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/7536>19:18
mupPR snapd#7535 closed: tests: disable {contacts,calendar}-service tests on debian-sid <Simple 😃> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7535>19:57
jdstrandroadmr: hey, not urgent at all, can you pull 20190930-2141UTC. it is the override for spread for Chipaca21:42
roadmrjdstrand: sure, anything for Chipaca 👍21:42
jdstrand:)21:43
roadmrI'll aim to deploy that tomorrow but no promises - it'll be in the queue anyway, worst case a couple of days21:43
mupPR snapcraft#2735 opened: extensions: add gsettings plug to gnome-3-28 extension <Created by galgalesh> <https://github.com/snapcore/snapcraft/pull/2735>22:22
mupPR snapd#7537 opened: tests: fix ubuntu-core-device-reg test for arm devices on core18 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7537>22:24

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!