hpidcockthumper:  https://github.com/juju/juju/pull/10660 LGTM00:46
thumperhpidcock: thanks, still fixing some bugs in it though, just worker tests00:46
hpidcockhappy to look at it again when your done, but worked well for me on lxd and k8s, though I accidentally deployed something into the controller model and didn't get a log file, which looks to be what you wanted00:50
thumperhpidcock: yeah, that was planned02:54
thumperI'm just sitting here a little confused02:54
thumperI had test failures which I didn't understand02:54
thumperit seems like the test is flakey02:54
thumperbut I can't tell why02:54
thumperI don't like flakey tests02:54
hpidcockflakey tests make me sad02:55
babbageclunkI love 'em!02:55
thumperalthough the tests now pass...02:55
hpidcockbabbageclunk: keeps things exciting I guess :P02:55
babbageclunkproblem solved!02:55
thumperthey are also insanely long tests02:55
thumperI think there may be a bug in the reporting of the tests02:56
thumperthat would explain the weird test results02:56
* thumper pokes02:56
* thumper waits for things to pass03:10
hpidcockhttps://github.com/juju/testing/pull/147 small one for someone04:38
nammn_desomeone want to take a quick look?  https://github.com/juju/charm/pull/293, one-liner08:41
* stickupkid just fat fingered that08:49
nammn_detimClicks: thx for the quick look08:50
timClicksnammn_de: np only 21:50 here08:50
stickupkidjam, this is interesting, I was playing around with github actions for windows tests, but we fail because we don't have a windows 2019 server for the os/series package. That's fine, the issue is that the windows tests aren't run, we should fix that! https://github.com/juju/os/pull/1308:51
jamstickupkid: any other gaps than just 2019? There seems to be some big gaps in the dates08:52
stickupkidjam, i'm unsure, probably08:52
stickupkidjam, weirdly not - 2012, 2016, 201908:53
stickupkidjam, seems like they have long LTS support08:53
stickupkidjam, they do have a lot of annual releases, but we probably don't support that directly08:54
stickupkidjam, this is my reference - not the best tbh - https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions08:54
ociuhanduOn windows different versions should be treated differently, i.e. one can not consider Windows 2019 Datacenter same with Windows 2019 Standard08:59
ociuhanduimho there should be different entries for those in the definition (e.g. win2019dc / win2019std / win2019hv and so on)08:59
ociuhandualso, there is windows 2019 (which is the LTS version) and there are the frequent releases that get only 6 months support and are numbered based on year and month of release (i.e. 1809 or 1903 and so on)09:01
stickupkidwe should probably window the windows versions like the linux versions tbh09:03
stickupkidociuhandu, we only use these for if we support the OS, we don't deploy to windows directly and only the juju client runs on the OS, so I don't think we need to change.09:04
stickupkidmanadart, i'm back on cmr-migrations, i'm unsure about the attach method from your playground example10:00
nammn_detimClicks: still around?10:00
stickupkidmanadart, it inverts the dependency which causes us not to be able to move the migration to a new folder10:00
stickupkidmanadart, https://play.golang.org/p/GC1tbWd272e <- playground in question10:01
manadartstickupkid: Can we not export the parts that allow attachment?10:03
stickupkidmanadart, this is the problem "func (m RemoteEntitiesMigration) Attach(mig *ExportStateMigration) {"10:03
stickupkidmanadart, the ExportStateMigration knows too much info i.e. *State10:04
stickupkidmanadart, if we make it an interface, that means we then have to make shims for complex types, which we may have too10:04
stickupkidmanadart, let me have a think10:05
stickupkidmanadart, we're sooooo close10:05
manadartstickupkid: OTP with Atos. Let's HO in a mo'.10:06
stickupkidmanadart, sure10:06
nammn_dehey guys are we/the customers using `juju list-clouds --format yaml` in a automated way? Im thinking of adding an additional key on top for bug: https://bugs.launchpad.net/juju/+bug/182695710:57
mupBug #1826957: YAML produced by list-clouds is not acceptable to update-cloud <bitesize> <papercut> <update-clouds> <juju:Triaged by nammn> <https://launchpad.net/bugs/1826957>10:57
nammn_deelse i could change the yaml parser from `juju update-cloud ..` to accept values without the highest key being `clouds: `10:59
manadartstickupkid: I am good to go here if you've time.11:01
stickupkidmanadart, sure11:01
stickupkiddo it11:01
manadartstickupkid: Hanging out in daily.11:02
stickupkidnammn_de, isn't it a case of you can't update localhost because it's built in11:02
nammn_destickupkid: for me it works to update localhost if i modify the yaml file. Update in general does not work. Try to follow the steps from here: https://bugs.launchpad.net/juju/+bug/1826957 maybe we mean something different11:03
mupBug #1826957: YAML produced by list-clouds is not acceptable to update-cloud <bitesize> <papercut> <update-clouds> <juju:Triaged by nammn> <https://launchpad.net/bugs/1826957>11:03
achilleasajam: is there a recommended pattern for extracting lengthy code from inside buildTxn blocks?11:36
jamachilleasa: its just a function, so have helper functions. They tend to be called "doStuffOps"11:37
achilleasajam: makes sense. thanks11:37
nammn_derick_h: got a min to talk about the bug you just replied?11:59
rick_hnammn_de:  otp atm, will ping when free12:00
nammn_deOkay, im grabbing lunch we can talk after daily if that works for you :)12:01
nammn_derick_h: ^12:01
nammn_dewhat is the https://github.com/juju/juju/blob/9039181e06f6988b1c62d3e71d28fbc031c0d32f/juju/osenv/old_home.go#L19 "juju dir" used for? "home/<name>/.juju"12:52
nammn_destickupkid: im going to add an acceptance test into /tests/suites . Should i add this under the folder " cli" as this relates to the commandline?14:53
stickupkidnammn_de, yeah, we can always move it14:55
stickupkid"coverage: 100.0% of statements"14:55
stickupkidthis is a nice thing :D14:55
nammn_destickupkid: how do you run the suite? Feel like I am overlooking something important. `./main.sh test_static_analysis_go` does not work for me. Did we document that somewhere?15:23
stickupkidnammn_de, yeah, because you're running a task there not a suite15:24
nammn_destickupkid: ups, meant that. just wanna run a task but seems not to work for me regarding permissions15:25
stickupkidnammn_de, run `./main.sh static_analysis test_static_analysis_go`15:25
nammn_debut thats how I run a task, right?15:25
stickupkidalso ./main -h15:25
stickupkid./main.sh -h15:25
stickupkidsee the "Examples" section15:26
nammn_deahh  you need to define the <folder> and <file>15:26
stickupkidnammn_de, yeah, similar to how other test things work15:26
stickupkidnammn_de, go test <folder> -check.f <test>15:26
nammn_destickupkid: got it15:27
nammn_destickupkid: any readme/quick function to create a model? Could find destroy_model from examples?15:46
stickupkidnammn_de, juju add-model :D15:47
stickupkidnammn_de, ho?15:47
nammn_destickupkid: oh makes sense :D Thought maybe we did add some convenience things15:47
nammn_destickupkid: sure!15:47
nammn_destickupkid: probably faster to get into15:47
stickupkidnammn_de, yeah, just use normal juju cli15:48
=== hml_ is now known as hml
hpidcockhttps://github.com/juju/juju/pull/10669 PR for the person who reads this :) It's a short one.23:37
timClicksurgh why do I get notifications?23:37
hpidcocktimClicks: thanks :D23:40

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!