[00:46] thumper: https://github.com/juju/juju/pull/10660 LGTM [00:46] hpidcock: thanks, still fixing some bugs in it though, just worker tests [00:50] happy to look at it again when your done, but worked well for me on lxd and k8s, though I accidentally deployed something into the controller model and didn't get a log file, which looks to be what you wanted [02:54] hpidcock: yeah, that was planned [02:54] I'm just sitting here a little confused [02:54] I had test failures which I didn't understand [02:54] it seems like the test is flakey [02:54] but I can't tell why [02:54] I don't like flakey tests [02:55] flakey tests make me sad [02:55] I love 'em! [02:55] although the tests now pass... [02:55] babbageclunk: keeps things exciting I guess :P [02:55] problem solved! [02:55] they are also insanely long tests [02:56] I think there may be a bug in the reporting of the tests [02:56] that would explain the weird test results [02:56] * thumper pokes [03:10] * thumper waits for things to pass [04:38] https://github.com/juju/testing/pull/147 small one for someone [08:41] someone want to take a quick look? https://github.com/juju/charm/pull/293, one-liner [08:49] na [08:49] * stickupkid just fat fingered that [08:50] timClicks: thx for the quick look [08:50] nammn_de: np only 21:50 here [08:51] jam, this is interesting, I was playing around with github actions for windows tests, but we fail because we don't have a windows 2019 server for the os/series package. That's fine, the issue is that the windows tests aren't run, we should fix that! https://github.com/juju/os/pull/13 [08:52] stickupkid: any other gaps than just 2019? There seems to be some big gaps in the dates [08:52] jam, i'm unsure, probably [08:53] jam, weirdly not - 2012, 2016, 2019 [08:53] jam, seems like they have long LTS support [08:54] jam, they do have a lot of annual releases, but we probably don't support that directly [08:54] jam, this is my reference - not the best tbh - https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions [08:59] On windows different versions should be treated differently, i.e. one can not consider Windows 2019 Datacenter same with Windows 2019 Standard [08:59] imho there should be different entries for those in the definition (e.g. win2019dc / win2019std / win2019hv and so on) [09:01] also, there is windows 2019 (which is the LTS version) and there are the frequent releases that get only 6 months support and are numbered based on year and month of release (i.e. 1809 or 1903 and so on) [09:03] we should probably window the windows versions like the linux versions tbh [09:04] ociuhandu, we only use these for if we support the OS, we don't deploy to windows directly and only the juju client runs on the OS, so I don't think we need to change. [10:00] manadart, i'm back on cmr-migrations, i'm unsure about the attach method from your playground example [10:00] timClicks: still around? [10:00] manadart, it inverts the dependency which causes us not to be able to move the migration to a new folder [10:01] manadart, https://play.golang.org/p/GC1tbWd272e <- playground in question [10:03] stickupkid: Can we not export the parts that allow attachment? [10:03] manadart, this is the problem "func (m RemoteEntitiesMigration) Attach(mig *ExportStateMigration) {" [10:04] manadart, the ExportStateMigration knows too much info i.e. *State [10:04] manadart, if we make it an interface, that means we then have to make shims for complex types, which we may have too [10:05] manadart, let me have a think [10:05] manadart, we're sooooo close [10:06] stickupkid: OTP with Atos. Let's HO in a mo'. [10:06] manadart, sure [10:57] hey guys are we/the customers using `juju list-clouds --format yaml` in a automated way? Im thinking of adding an additional key on top for bug: https://bugs.launchpad.net/juju/+bug/1826957 [10:57] Bug #1826957: YAML produced by list-clouds is not acceptable to update-cloud

[10:59] else i could change the yaml parser from `juju update-cloud ..` to accept values without the highest key being `clouds: ` [11:01] stickupkid: I am good to go here if you've time. [11:01] manadart, sure [11:01] do it [11:02] stickupkid: Hanging out in daily. [11:02] nammn_de, isn't it a case of you can't update localhost because it's built in [11:03] stickupkid: for me it works to update localhost if i modify the yaml file. Update in general does not work. Try to follow the steps from here: https://bugs.launchpad.net/juju/+bug/1826957 maybe we mean something different [11:03] Bug #1826957: YAML produced by list-clouds is not acceptable to update-cloud

[11:36] jam: is there a recommended pattern for extracting lengthy code from inside buildTxn blocks? [11:37] achilleasa: its just a function, so have helper functions. They tend to be called "doStuffOps" [11:37] jam: makes sense. thanks [11:59] rick_h: got a min to talk about the bug you just replied? [12:00] nammn_de: otp atm, will ping when free [12:01] Okay, im grabbing lunch we can talk after daily if that works for you :) [12:01] rick_h: ^ [12:52] what is the https://github.com/juju/juju/blob/9039181e06f6988b1c62d3e71d28fbc031c0d32f/juju/osenv/old_home.go#L19 "juju dir" used for? "home//.juju" [14:53] stickupkid: im going to add an acceptance test into /tests/suites . Should i add this under the folder " cli" as this relates to the commandline? [14:55] nammn_de, yeah, we can always move it [14:55] "coverage: 100.0% of statements" [14:55] this is a nice thing :D [15:23] stickupkid: how do you run the suite? Feel like I am overlooking something important. `./main.sh test_static_analysis_go` does not work for me. Did we document that somewhere? [15:24] nammn_de, yeah, because you're running a task there not a suite [15:25] stickupkid: ups, meant that. just wanna run a task but seems not to work for me regarding permissions [15:25] nammn_de, run `./main.sh static_analysis test_static_analysis_go` [15:25] but thats how I run a task, right? [15:25] also ./main -h [15:25] ./main.sh -h [15:26] see the "Examples" section [15:26] ahh you need to define the and [15:26] nammn_de, yeah, similar to how other test things work [15:26] nammn_de, go test -check.f [15:27] stickupkid: got it [15:27] nice [15:46] stickupkid: any readme/quick function to create a model? Could find destroy_model from examples? [15:47] nammn_de, juju add-model :D [15:47] nammn_de, ho? [15:47] stickupkid: oh makes sense :D Thought maybe we did add some convenience things [15:47] stickupkid: sure! [15:47] stickupkid: probably faster to get into [15:48] nammn_de, yeah, just use normal juju cli === hml_ is now known as hml [23:37] https://github.com/juju/juju/pull/10669 PR for the person who reads this :) It's a short one. [23:37] urgh why do I get notifications? [23:40] timClicks: thanks :D