mupPR snapcraft#2738 opened: mypy: add coverage to tests <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/2738>00:48
zygaGood morning05:57
=== pstolowski|afk is now known as pstolowski
zygasorry, baby watch duty07:32
zygaback now07:32
zygahey pawel, good morning :)07:33
mupPR snapd#7532 closed: interfaces/openvswitch: allow access to other openvswitch sockets <Created by dosaboy> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7532>07:54
mupPR snapd#7549 opened: cmd/libsnap: use cgroup.procs instead of tasks <Created by zyga> <https://github.com/snapcore/snapd/pull/7549>09:24
zygasettle not converging https://www.irccloud.com/pastebin/qfxvW2Qh/09:53
zygapedronis: can we change settle for tests so that it has no timeout09:53
zygaand instead it just does more as long as a handler ran09:54
zygaI think it's incredibly fragile that our *unit* test suite is riddled with millisecond quantities09:54
zygathis is now blocking 2.42 release to opensuse09:54
pedroniszyga: it's not that simple because we do have retries09:56
zygait's fine if a test fails forever09:56
Chipacazyga: how are you running the unit tests on opensuse?09:56
zygaas in, code us buggy09:56
zygaand loops forever09:56
zygago's test stack catches that09:56
zygaI think the only problem would be tests that want to see failure09:56
pedroniszyga: you say that because you haven't had to debug that09:57
zygapedronis: I have to debug this :)09:57
zygapedronis: I think it is not a unit tests if it has timing-sensitive concurrent operation09:57
zygaChipaca: go test09:57
pedronisanyway, as I said is not that simple09:57
zygaChipaca: same as anywhere09:57
zygapedronis: nothing is simple, what we have is just broken randomly09:57
Chipacazyga: try 'go test -short'09:57
zygapedronis: I want to get to deterministic09:57
Chipacazyga: those are more likely to be unit tests09:57
zygaChipaca: I don't see how this is a solution, should we switch to "go test -short" for all unit tests across distributions?09:58
pedroniszyga: there is nothing that prevent us to use long settle on traviss09:58
Chipacazyga: do you want solutions, or do you want to vent?09:59
zygaChipaca: I want solutions, this is not one IMO09:59
zygapedronis: is there a place where we cannot?09:59
pedronisit's a timeout is set low just to fail fast locally10:00
ChipacaAIUI it's not about travis, is it?10:00
zygait is not about travis10:00
zygait's actually failing on my workstation right now10:00
pedronisreally ?10:00
pedroniswhich one10:00
* Chipaca hands zyga a nickel10:00
zygawhich test?10:00
pedronisyes, which test10:00
pedronisthat is recent and might have a real bug10:01
pedronisdon't know10:01
pedronisor be too slow10:01
pedronisto start with10:01
zygait has some comments that expand settle time 4 times10:01
zyga"because buildds are slow"10:01
pedroniswell, the test is problematic10:01
zygaanyway, since it affects me, I'll look10:01
pedronisbut I haven't looked at details10:02
zygapedronis: problematic in which sense?10:02
pedronisthat it might be buggy for real10:02
pedronisnot just slow10:02
zygaI'll look10:03
pedronisanyway consider that Ian made this: https://trello.com/c/foU3iOrs/321-investigate-testremodelswitchtodifferentkernel-failure10:03
zygathanks, this is useful!10:03
Chipacawhat is this sorcery10:04
Chipacaa trello card created before work is done?!?10:04
* Chipaca is so bad at trello10:04
pedronisit might never get done10:04
pedronisupcoming is like that10:04
pedronisto be fair10:04
mupPR snapd#7550 opened: spread.yaml: exclude automake cache <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7550>10:14
zygahttps://github.com/snapcore/snapd/pull/7550 <- trivial cleanup for build issues10:14
mupPR #7550: spread.yaml: exclude automake cache <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7550>10:14
zygatests failed with "unable to contact the snap store"10:16
zygahttps://status.snapcraft.io/ says all good10:16
* Chipaca breaks all the policy tests and weeps10:27
Chipacapedronis: I'm starting to suspect this last change doesn't make sense, but i need to take a break10:42
Chipacapedronis: but checking for model before checking rev.Unset means you can't ever remove even a single revision of the model kernel10:43
pedronisChipaca: you need to invert the condition11:00
pedronisof course11:00
pedronisif not model kernel: can remove     if in use: cannot remove11:01
pedronisChipaca: am I making sense, the flow is more complicated with the change (but more consistent)11:07
Chipacapedronis: currently it's: if !unset { if in_use { bzzzt } else { ok } } else if is_model { bzzt } else { ... }11:11
pedronisChipaca: that's not the question, is it?11:12
pedronisI can try to write it down, but does that make sense11:12
Chipacai'm trying to understand what exactly you're proposing11:13
pedronisChipaca: I'm not proposing "exactly" anything11:13
pedronisI don't want to be proposing extact things11:13
pedronisI can if it helps11:14
pedronisChipaca: the essence of the change is:  don't care about revision if the kernel is not the model kernel11:15
pedronisthat's my understanding11:15
Chipacado we care about the error, about it being a model kernel?11:17
pedronisChipaca: this:  https://pastebin.ubuntu.com/p/bJ6trqPcn3/11:18
pedronis(not promising it makes sense, it does still pass the tests though)11:19
zygacan I get a review for https://github.com/snapcore/snapd/pull/755011:19
mupPR #7550: spread.yaml: exclude automake cache <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/7550>11:19
zygait's a one liner11:19
zygaand it's green :)11:20
Chipacapedronis: I do think that makes sense, although it wasn't obvious to me. But I could blame the painkillers for that, today.11:23
zygapstolowski: perhaps you can look11:24
zygait's just a cache exclusion from spread.yaml11:24
pedronisChipaca: and we want something like this for bases/core too I suspect (if we do the change), well for the other thing using boot.InUse11:24
Chipacapedronis: yes i'm changing all three11:25
pedronisChipaca: thx11:25
pstolowskizyga: sure11:25
mupPR snapd#7550 closed: spread.yaml: exclude automake cache <Simple 😃> <Created by zyga> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7550>11:31
zygapedronis: thanks!11:32
* zyga goes for lunch11:37
=== ricab is now known as ricab|lunch
zygapedronis: quick question: release app awareness was so far only implemented for strict snaps12:06
zygapedronis: but there's nothing that holds us to this design, should we expand it to cover classic confinement?12:06
pedroniszyga: I don't even remember why?12:07
zygawhy yes or why not?12:07
pedroniswhy we didn't cover classic?12:07
pedronisI'm just not sure it was a design12:07
zygabecause the code adding tracking was in close proximity to other "strict" setup logic12:07
zygabut I think it's not meant to be this way12:07
zygait feels like we didn't notice12:07
pedronisyea, that's not a design12:07
pedronisit's a bug12:07
zygaI added a todo for it12:07
zygayeah, thanks for confirming that12:07
zygaI'll untangle that12:08
cmatsuokacachio: seen this in tests? dial tcp connect: connection refused12:35
cachiocmatsuoka, hi let me check12:42
cachiocmatsuoka, I can't see that, do yoiu have a log?12:48
cmatsuokacachio: yes, https://api.travis-ci.org/v3/job/592790683/log.txt12:50
cmatsuokacachio: look for connection refused12:50
cachiocmatsuoka, seems to be related to the store, let me talk to them12:52
zygaone sec13:01
pedroniscachio: zyga: standup?13:01
sergiusensblake_r (in case it was not answered, seems not) if maas-cli plugs into a slot in maas, then installing maas-cli would pull in the default provider but installing maas alone would not pull in every snap declaring a plug for it (I suspect that is how this is how these two snaps interact)13:22
MirvoSoMoN: is the chromium vaapi work mentioned in https://discourse.ubuntu.com/t/monday-21st-january-2019/9434/8 now merged in normal chromium snaps?13:24
blake_rsergiusens: its the other way13:26
blake_rsergiusens: "maas" plugs into "maas-cli", so installing "maas" will install "maas-cli", correct?13:27
MirvoSoMoN: at least I'm getting somewhat lower CPU use with snap versus native package of my distro (same video, full screen, drop from 30-40% to 20-30%). hmm, if only there was a way to query directly whether VAAPI is currently being used by software.13:31
sergiusensblake_r if you declare a default provider, yes13:33
roadmrohhh so snapd can now resolve dependencies? snapian.io here we gooooo 💪13:33
sergiusens/snap/gnome-calculator/current/meta/snap.yaml can be used for insipiration13:33
=== ricab|lunch is now known as ricab
sergiusensit can try and satisfy interfaces13:34
zygaoh, I forgot to mention one thing13:37
zygaover weekend (I realize that's a late recollection) I played with a static analyzer13:37
oSoMoNMirv, no it's not, but thanks for asking, it had slipped off my radar, I will test again and if everything still works I'll merge it13:37
zygawhile somewhat fiddly to setup I found the results useful13:37
zygait's not coverity13:37
Mirvok, thanks oSoMoN! and it seems intel_gpu_top is a good tool to check whether video hardware is being used - I can see a clear distinction between eg a browser and mpv13:41
Chipaca"Kindly correct this anomaly."14:01
* Chipaca hmms14:01
roadmrChipaca: well at least they asked nicely, right? 🤷14:02
Chipacatrue, true14:02
* diddledan blows up the anomoly with a photon torpedo and some inversed polarities14:09
diddledana tachyon beam is probably worth while, too14:10
Chipacadiddledan: just don't cross the tachyon beams, or sth14:10
diddledanand make sure you're travelling faster than 88 jiggerwatts14:11
* zyga is tired, needs a break/nap14:50
zygaalso, my daughter is 11 today14:50
zygaso perhaps time to EOD14:50
roadmrzyga: congrats to her! 🎂14:51
zygaroadmr: thank you :)14:51
zygaI'll let her know14:51
zygastore still wonky14:52
zygayeah, I'll take a nap now14:52
* Chipaca sharpens his hunting knife an goes for a cuppa14:58
mupPR snapd#7551 opened: tests: fix the how the systemd-journald.service is restarted during the prepare <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7551>15:06
* cachio lunch15:12
ackksergiusens, hi, any chance https://github.com/sergiusens/snapcraft-preload/pull/37 could be merged?15:49
mupPR sergiusens/snapcraft-preload#37: add option to only redirect paths for /dev/shm/* <Created by albertodonato> <https://github.com/sergiusens/snapcraft-preload/pull/37>15:49
=== pstolowski is now known as pstolowski|afk
mupPR snapcraft#2736 closed: cli: prompt for login if required <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2736>16:11
ondrasergiusens how do I create app in snap calling "pkill" which I have access to from 'process-control' without actually shipping pkill in my snap?16:20
ondrasergiusens I know I can do wrapper script, but I wonder is there is way to do it without wrapper script16:22
ondrasergiusens I guess even is snapcraft allows it. snapd will probably refuse it?16:23
sergiusensondra snapd for some reason does not allow command entries that start with / even though it allows it in shebangs (or wrappers), so all your enquiries are for the snapd team16:30
ondrasergiusens yep I realised so16:31
mupPR snapd#7552 opened: tests: add new option "invert" to retry-tool <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/7552>16:37
zygahey ondra17:40
zygahow are you doing17:40
zygathe nap worked, I feel so much better now17:40
Chipacazyga: go sing happy birthday17:45
zygaChipaca: we did that already17:45
zygaI prefer to avoid granpas and grammas that had some event-booze17:46
zygakids are off upstairs already17:46
zygaI'm here to ...17:46
zygamerge this https://github.com/snapcore/snapd/pull/742117:46
mupPR #7421: cmd/snap-confine: unmount /writable from snap view <Created by zyga> <https://github.com/snapcore/snapd/pull/7421>17:46
zygawhee :)17:46
zyganow what's the state of https://github.com/snapcore/snapd/pulls/zyga17:47
mupPR snapd#7421 closed: cmd/snap-confine: unmount /writable from snap view <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7421>17:47
zygadire :)17:51
zygamaybe I should go and have cake instead17:51
zygaChipaca: are you still working?17:58
Chipacai retired17:58
mupPR snapcraft#2738 closed: mypy: add coverage to tests <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2738>19:14
pokkWhen trying to rsync to a newly created ubuntu core instance I get a "Permission denied" from mkdir. I'm guessing it's an apparmor thing. Is there any good reading on this?20:10
joedborghi all, i'm seeing an issue where my snap isn't building on the snapcraft.io servers, but builds fine locally (with the command given from the site)20:22
joedborgHEAD is now at 2bd9643cee Add/Update CHANGELOG-1.16.md for v1.16.0-rc.2.20:22
joedborg+++ [1003 19:50:48] Building go targets for linux/amd64:20:22
joedborg    ./vendor/k8s.io/code-generator/cmd/deepcopy-gen20:22
joedborgfind: ‘rsync’: No such file or directory20:22
joedborgfind: ‘rsync’: No such file or directory20:22
joedborg./hack/run-in-gopath.sh: line 33: _output/bin/deepcopy-gen: Permission denied20:22
joedborgmake[1]: *** [gen_deepcopy] Error 120:22
joedborgMakefile.generated_files:152: recipe for target 'gen_deepcopy' failed20:22
joedborgMakefile:559: recipe for target 'generated_files' failed20:22
joedborgmake: *** [generated_files] Error 220:22
joedborgFailed to run 'override-build': Exit code was 2.20:22
joedborg^ sorry, I meant to send that as a snippet20:22
sergiusensijohnson are you around? Maybe you can answer https://forum.snapcraft.io/t/permissions-problem-using-snapcraft-in-azure-pipelines/13258/520:22
sergiusensjoedborg add rsync to build-packages20:23
sergiusensif using multipass, this should be addressed soon.20:23
sergiusensif using --use-lxd, it will take a bit longer20:23
joedborgsergiusens: locally, it works fine with both multipass and lxd20:23
joedborgit's only on the snapcraft io servers that it fails20:23
sergiusenswe are moving to the common denominator for building, and that is the same env used by the builders20:24
sergiusensjoedborg yeah, build servers are more minimal than minimal and we are going to be aligning with that20:24
joedborgsergiusens: okay thanks, I'll try now with adding rsync to build-packages20:25
Chipacapokk: what are you rsync'ing?20:36
Chipacapokk: joedborg: are you looking at the same issue, or is it a coincidence?20:36
joedborgChipaca: mines to do with buildign only20:37
Chipacajoedborg: ok :)20:37
Chipacastrange coincidence then20:37
joedborglooks like it :)20:38
Chipacapokk: 'trying to rsync a newly created ubuntu core instance' sounds like a fascinating exploration of a terribly bad idea, but do tell me more20:38
roadmrChipaca: he did say "trying to rsync *to* a newly created" :P20:41
Chipacaroadmr: s/he/they/20:42
Chipacaroadmr: and, curiouser and curiouser20:42
joedborgworking now thanks sergiusens !21:06
mupPR snapd#7553 opened: cmd/snap: update 'snap find' help because it's no longer narrow <Created by chipaca> <https://github.com/snapcore/snapd/pull/7553>21:29
mupPR snapd#7554 opened: recovery: update fde-utils calls <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/7554>22:07
mupPR core-build#54 opened: initramfs: update unlock keyfile parameter <Created by cmatsuoka> <https://github.com/snapcore/core-build/pull/54>23:00
mupPR snapcraft#2734 closed: SnapcraftError refactoring <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2734>23:18

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!