wallyworld | kelvinliu_: or babbageclunk: no rush, a small Python PR https://github.com/juju/charm-helpers/pull/385 | 01:47 |
---|---|---|
babbageclunk | wallyworld: lgtm | 01:49 |
wallyworld | yay, ty | 01:50 |
kelvinliu_ | lgtm as well | 01:50 |
kelvinliu_ | hi babbageclunk can i get ur a few mins to help me to understand about raftlease plz? | 02:27 |
babbageclunk | kelvinliu_: sure - in standup? | 02:28 |
kelvinliu_ | babbageclunk: yup thx | 02:28 |
wallyworld | thumper: not urgent, here's a PR which uses "function" terminology with the v3 feature flag for the actions CLI https://github.com/juju/juju/pull/10722 | 03:19 |
wallyworld | so now we have functions and "call" and tasks | 03:19 |
wallyworld | at least on the CLI | 03:19 |
wallyworld | charms still have actions.yaml etc | 03:20 |
thumper | wallyworld: do you have the bug for the caas peer relation? | 03:25 |
wallyworld | thumper: https://bugs.launchpad.net/juju/+bug/1818230 | 03:26 |
thumper | ta | 03:26 |
mup | Bug #1818230: k8s charm fails to access peer relation in peer relation-joined hook <juju:Fix Committed by wallyworld> <https://launchpad.net/bugs/1818230> | 03:26 |
wallyworld | kelvinliu_: how did you and babbageclunk get on with the raft/clock thing? | 03:39 |
kelvinliu_ | wallyworld: we r in standup. mind join us? | 03:40 |
wallyworld | sure | 03:42 |
wallyworld | kelvinliu: https://github.com/juju/juju/pull/10723 | 04:41 |
kelvinliu | wallyworld: lgtm thx! | 04:43 |
wallyworld | ty | 04:43 |
wallyworld | babbageclunk: hmmmm, maybe my X1 Extreme does seem a little quieter now.... | 04:45 |
babbageclunk | lol | 04:45 |
wallyworld | even with magnificant Goland running | 04:45 |
hpidcock | babbageclunk's sounded like it was taking off at the sprint | 04:52 |
hpidcock | for other reasons | 04:52 |
babbageclunk | bloody gnome. Actually, that seems to have been better lately - maybe they fixed the bug | 04:57 |
hpidcock | did you have it when using i3? | 04:58 |
babbageclunk | no, but there were too many other things I couldn't do with i3 so I've switched back | 05:06 |
hpidcock | :O | 05:07 |
kelvinliu | wallyworld: should we error if the crd scope was cluster scope or just always overwrite to Namespaced peacefully? | 05:11 |
=== nammn_de_ is now known as nammn_de | ||
manadart | Anyone able to review https://github.com/juju/juju/pull/10684 ? | 10:14 |
achilleasa | manadart: I will trade you for https://github.com/juju/juju/pull/10725 | 10:18 |
manadart | achilleasa: OK. | 10:18 |
manadart | achilleasa: My patch landed that changes the uniter around NetworksForRelation. This conflicts with your patch. Can you pull it down and fix? | 10:43 |
achilleasa | manadart: sure thing. I will rebase and force-push | 10:44 |
achilleasa | manadart: ready | 10:59 |
manadart | achilleasa: I see it. Ta. | 10:59 |
nammn_de | rick_h: if you around, can we HO before/after daily? Have Some small questions regarding caas and the pr we were talking before setting adm | 11:01 |
manadart | achilleasa: Reviewed. | 11:35 |
achilleasa | manadart: should the settings block return an error for nil or maybe simply skip over nil entries? | 11:41 |
manadart | achilleasa: I say return. If [0] is nil the write() call could panic. | 11:42 |
rick_h | nammn_de: morning, sure thing | 11:42 |
rick_h | nammn_de: meet you in daily? | 11:42 |
achilleasa | manadart: that's a valid point! | 11:42 |
nammn_de | rick_h: was having lunch, heading over daily | 11:47 |
icey | does `leader_set` stringify all values passed to it? ie: if I pass it a boolean, will I get back a string? | 13:30 |
icey | rick_h: maybe you know? ^ | 13:32 |
rick_h | icey: I'd expect so as it's a simple key/value vs types | 13:33 |
icey | :-/ | 13:33 |
rick_h | icey: since it's just bash data not sure what the python library is doing for type handling across the wire there | 13:33 |
rick_h | e.g. in a bash hook/etc it's just key=value | 13:34 |
icey | rick_h: apparently, stringing it up (https://github.com/juju/charm-helpers/blob/669821489497a547a768f686a2fadf88d2d5f2b2/charmhelpers/core/hookenv.py#L1121) :-/ | 13:34 |
rick_h | icey: yea, that's what I expected | 13:35 |
nammn_de | rick_h manadart hml regarding trying to upgrade a caas controller with juju. I tried to with " juju upgrade --build-agent" returns --build-agent is not supported for k8s model. Any idea how i can test those upgrades for caas else? | 14:16 |
rick_h | nammn_de: actually not sure tbh | 14:17 |
rick_h | they work through the operator pod but I'm not familiar with the dev scenario around using it | 14:17 |
rick_h | nammn_de: and a heads up, if you want to ping the team you can use the guild highlight nick | 14:18 |
nammn_de | ahhh now thats good to know | 14:18 |
nammn_de | probably need to sync with hpidcock wallyworld or kelvin once about caas | 14:18 |
rick_h | nammn_de: yea, but make sure to spread the word as honestly I *should* know :( | 14:19 |
nammn_de | rick_h: will do :D | 14:20 |
manadart | nammn_de: I *think* you would need to do something like "DOCKER_USERNAME=<you> make microk8s-operator-update" | 14:20 |
manadart | Then just "juju upgrade-controller" | 14:20 |
nammn_de | manadart: tahnks gonna try that out! Do we have that somewhere documented in case in run into bad things? | 14:21 |
manadart | nammn_de: According to https://discourse.jujucharms.com/t/whats-new-in-juju-k8s-for-2-6/1431 it's just upgrade-controller, but that will assume that there is a new official operator image on dockerhub. | 14:23 |
manadart | So I am guessing for local wrangling you need to have built the new image and somehow let juju know where to get it from. | 14:24 |
rick_h | manadart: right, that's the trick. Doing that with "my own operator" is the part I've not tried at all | 14:24 |
nammn_de | manadart: got it thanks | 14:43 |
manadart | achilleasa: I pushed that change to my upgrade patch too. | 14:46 |
achilleasa | manadart: looking | 14:47 |
achilleasa | manadart: much cleaner now! thanks for the change. Doing QA | 14:52 |
achilleasa | manadart: the machineaddresses collection has no spaceid anymore (addresses looks as expected). That's what I should be seeing right? | 15:23 |
manadart | achilleasa: Machine addresses has to-date never had space information (it only comes from the provider into addresses), so that is correct. | 15:25 |
achilleasa | manadart: PR approved | 15:25 |
manadart | achilleasa: Thanks. | 15:25 |
achilleasa | manadart: apparently accessing the unit from within Flush breaks a whole lot of uniter tests (in a different package).... :-( | 16:12 |
achilleasa | hml: got a few min to help me with the uniter test mess? | 16:20 |
hml | achilleasa: sure | 16:20 |
achilleasa | hml: daily? | 16:20 |
hml | achilleasa: omw | 16:21 |
achilleasa | hml: removing the hardcoded stuff fixed the test... | 16:44 |
hml | achilleasa: hahahahaha awesome | 16:44 |
achilleasa | I will replace the other occurrences as well | 16:45 |
achilleasa | hml: hopefully CI will be happy with my changes. I will wait for Joe to take a look before I land it so my PR is expected to land on Monday morn. Is that OK for your rebase work? | 17:01 |
hml | achilleasa: that should be okay. | 17:02 |
pmatulis1 | when i use option `--metadata-source` with the 'bootstrap' command i don't see anywhere that this value is exposed. should it not show up in the output to 'show-controller' command? | 18:41 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!