/srv/irclogs.ubuntu.com/2019/10/11/#snappy.txt

mupPR snapcraft#2749 closed: storeapi: add StoreErrorList to handle store errors <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2749>00:40
mborzeckimorning05:23
=== jamespage_ is now known as jamespage
=== abeato_ is now known as abeato
mborzeckizyga: i'm playing a bit with repck in spread, instead of a 5.5MB archive i usually got, i'm getting 2.8MB now06:40
mborzeckimvo:  morning06:50
mvohey mborzecki ! good morning06:56
mupPR snapd#7582 closed: spread: include mounts list in task debug output <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7582>06:57
=== pstolowski|afk is now known as pstolowski
pstolowskimorning07:04
zygaGood morning07:05
zygaI’ll start later today, just doing morning dog walk07:05
zygaSee you in 3007:05
zygamborzecki: try that with spread doing gitignore and the matching snapd branch please07:06
zygaback07:31
pstolowskimvo: #7558 can land, or do want to wait for Samuele?08:05
mupPR #7558: boot,dirs,image: various refinements in the prepare-image code switched to seedwriter <Created by pedronis> <https://github.com/snapcore/snapd/pull/7558>08:05
zygamborzecki: I updated https://github.com/snapcore/snapd/pull/7547/files a little08:09
mupPR #7547: many: use a dedicated named cgroup hierarchy for tracking <Created by zyga> <https://github.com/snapcore/snapd/pull/7547>08:09
bloodearnestChipaca: o/ - FYI, I worked around the this issue with services failing on refresh, and filed this bug for your consideration:08:21
bloodearnesthttps://bugs.launchpad.net/snapd/+bug/184772308:21
mupBug #1847723: Config hook is run after services start during refresh <snapd:New> <https://launchpad.net/bugs/1847723>08:21
Chipacabloodearnest: what about the different -refresh hooks?08:22
Chipacabloodearnest: e.g. post-refresh?08:22
Chipacabloodearnest: ISTR post-refresh comes right before start-services08:22
bloodearnestChipaca: so, my fix was to regenerate the config in post-refresh in my snap. But I think that that argubly shouldn't be nessesary?08:23
Chipacaah i see you mention that i the bug08:23
bloodearnestyeah08:23
bloodearnestI'm sure there's things I'm missing, but it was a suprise to me that the config hook ran after services had been started08:23
Chipacabloodearnest: I'll let pstolowski and/or pedronis figure out whether the current behaviour is correct or not :-)08:24
bloodearnestsure, thanks for your time08:24
pstolowskibloodearnest, Chipaca yes, this (config hook running after services start) has been known for a long time (and we know it's annoying), we touched that briefly with pedronis even recently with the conclusion that we might reconsider the order if there are strong arguments08:30
bloodearnestpstolowski: great. Well, consider that bug this user's vote on the isssue :) It's a dual of the install/config hook interplay really, where services can start before config hook as run there too.08:32
Chipacabloodearnest: OTOH I can imagine snaps with the opposite problem, needing the services running for 'configure' to make sense?08:48
Chipacabrb, installing eoaiun08:53
zygaChipaca: oh my :-)08:53
zygaI wonder what your experience will be like08:53
Chipacazyga: slow08:53
Chipacathe only machines i have that i'm willing to sacrifice to the goddess eoan are slow08:54
mupPR snapd#7586 opened: interfaces/optical-drive: additional permission needed by mir-kiosk-kodi <Created by AlanGriffiths> <https://github.com/snapcore/snapd/pull/7586>08:55
=== mborzeck1 is now known as mborzecki
mupPR snapd#7587 opened: spread: generate delta when using google backend <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7587>09:00
mborzeckizyga: mvo: ^^ this should fix the source package size uploaded by spread for a while09:01
zyganice09:01
zygathank you09:01
bloodearnestChipaca: very possiblly :)09:13
mvomborzecki: nice one!09:13
xiaojidoes anyone know How to statistics the number of software in gnome-software09:14
zygaxiaoji: gnome-software is a tarball, what it shows when you build and run depends heavily on configuration09:15
Chipacaxiaoji: by "software" do you mean packages? apps? binaries?09:20
Chipacaxiaoji: and do you mean the number installed, available for install, ...?09:20
Chipacaxiaoji: and do you mean how many does gnome-software show, or do you mean how do you get gnome-software to show you the number?09:21
xiaojithanks09:27
xiaojiyes09:27
xiaojiI want to know how many software can be installed and have been installed in gnome-software09:28
mupPR snapd#7588 opened: cmd/snap: add a "snap internal portal-info" command <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/7588>09:28
Chipacajamesh: that's not the first internal command we have, any reason to add the new toplevel 'internal', etc?09:31
* zyga installs gobs of updates09:32
Chipacaxiaoji: why are you asking in this channel?09:33
xiaojiI have asked on many channel and many IM..09:35
xiaojisorry09:35
Chipacaxiaoji: where?09:36
Chipacaxiaoji: as zyga pointed at, gnome-software is the frontend to a number of backends, and not all those backends offer a count. Also you haven't told me what "software" is, nor on what distro you are09:37
Chipacafor example, if "software" is a package, and you are on a debian-derived distro, you can answer "how many are installed" via the backend tools09:38
Chipacai guess the same is true for other distros09:38
Chipacaso it's not clear you know what you are asking09:38
Chipacaso, how to answer you? your question is unclear, to begin with09:38
xiaojiI am on ubuntu 18.0409:38
Chipacaare you using flatpak?09:39
xiaojino,only install software from software-center09:39
Chipacai thought you could get flatpak via the software-center, but ok09:40
Chipacaxiaoji: and, what is "software"?09:40
Chipacaxiaoji: is a library-only debian package, "software"?09:41
Chipacaxiaoji: is bash "software"?09:41
xiaoji.. I dont know09:46
Chipacaxiaoji: ok. Going back a step, why do you want to know statistics about this?09:47
xiaojiI saw many software in gnome-software,they have icon. I want know how many09:48
mupPR snapd#7558 closed: boot,dirs,image: various refinements in the prepare-image code switched to seedwriter <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/7558>09:51
jameshChipaca: I seem to remember zyga suggesting it during previous discussions, and it seemed like a reasonable idea.  I can remove that part of the PR quite easily though09:56
zygajamesh: I still like it09:59
Chipacajamesh: i don't think it's a bad idea, and i like the refactor, but i feel it should be separate from the feature10:09
Chipacaand maybe we should discuss moving other internal commands to this10:09
jameshChipaca: I can split it out easily enough: it's the first commit.10:10
Chipacajamesh: neat10:10
Chipacajamesh: I'd expect pedronis to have an Opinion about that, and he's off today10:10
Chipacajust fyi10:10
ChipacaWimpress: is there anything like an eoan mate installer already?10:17
Chipacafacubatista: "eoan mate", https://flic.kr/p/6wqZBC10:19
Chipacaxiaoji: so, for an approximation10:20
Chipacaxiaoji: open a terminal, and see if you have the "appstreamcli" command10:20
Chipacaxiaoji: if you do, then the number of things gnome software offers you is the number in Summary of "appstreamcli status", *plus*, the output of "wc -l /var/cache/snapd/names"10:21
Chipacaapproximately; some things might be counted twice in the above10:22
Chipacaif you _don't_ have appstreamcli, you need to 'sudo apt install appstream' and then 'sudo apt update' for the number to be right10:22
Chipacaboth numbers should be ~2k or more10:23
Chipacaalthough it varies by arch and region10:23
mupPR snapd#7589 opened: cmd/snap: add ability to register "snap internal" commands <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/7589>10:41
WimpressChipaca: Do you mean an iso image for Ubuntu MATE 19.10?10:50
ChipacaWimpress: i think i found it at http://cdimage.ubuntu.com/ubuntu-mate/daily-live/current/HEADER.html10:51
Chipacaheh, dunno why google took me to the header, but ok10:51
WimpressYep, that's what you want 👍10:51
mborzeckipstolowski: replied in #744311:03
mupPR #7443: timeutil: fix schedules with ambiguous nth weekday spans <Bug> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7443>11:03
pstolowskimborzecki: ok11:04
ChipacaWimpress: ooh, installer crashed :-)11:21
facubatistaChipaca, a mate, indeed, why eoan?11:23
Chipacafacubatista: eoan → mañanero11:23
Chipacaroughly11:23
facubatistaChipaca, ah, didn't know that11:23
Chipacafacubatista: https://en.wikipedia.org/wiki/Eos11:24
Chipacafacubatista: "diosa de la aurora"11:24
Chipacafacubatista: I would've written that as "diosa del aurora" but maybe la->el to avoid vowel clash is frowned on these days?11:25
facubatistaChipaca, much funnier name the roman equivalent11:25
facubatista"mater matuta"11:26
Chipacafacubatista: :)11:26
Chipacaxnox: if the ubuntu installer crashes, is there anything useful or interesting for you?11:27
Chipacaor should i just do over11:27
Chipaca(maybe not pick zfs next iteration)11:27
xnoxChipaca:  if it installed /var/log/installer otheriwse /var/log/syslog /var/log/partman and like /var/log/ubiquity11:28
xnoxChipaca:  possibly check with didrocks & jibel as they have been working on zfs bit in desktop iso.11:29
Chipacaxnox: it did not install, I don't think, it was fairly early in the process11:29
xnoxack11:29
ChipacaI now (after a few minutes) got the "system program problem detected" dialogue11:29
Chipacamaybe the "report problem" button gets all those bits of info?11:29
* Chipaca might be overly optimistic11:29
xnoxit will11:29
xnoxbut you can also do $ ubuntu-bug ubiquity11:30
xnox(will ask for SSO login.....)11:30
* Chipaca clicks the button and waits patiently11:30
Chipacaxnox: ack11:30
mborzeckizyga: hmm lxd snap https://paste.ubuntu.com/p/HzGx7PG4pc/11:30
jibelChipaca, give me the bug # once it's reported11:30
Chipacajibel: will do, thanks11:31
Chipacastill waiting on apport11:31
Chipacaxnox: the "report bug" button didn't seem to do anything fwiw, at least, no apport activity from there11:32
xnoxChipaca:  ubuntu-bug ubiquity11:32
Chipacayep11:32
xnoxChipaca:  at least that should make a thing in /var/crash/*11:32
xnoxChipaca:  any files from /var/crash/* will be useful11:33
Chipacaoh god my lp password with no password manager11:33
* Chipaca reaches for scp11:33
Chipacajibel: #184774811:37
mupBug #1847748: installer crashed <amd64> <apport-bug> <eoan> <ubiquity-19.10.18> <ubuntu-mate> <ubiquity (Ubuntu):New> <https://launchpad.net/bugs/1847748>11:37
Eighth_Doctormvo, zyga, mborzecki: https://bugzilla.redhat.com/show_bug.cgi?id=176056811:38
Eighth_Doctorany of you have any idea of a way to fix this?11:38
Chipacajibel: let me know if you need any more info from the system before i nuke it and start over11:38
mborzeckiEighth_Doctor: saw it in the monring, but wanted to try it myself11:39
Eighth_Doctor👍️11:39
jibelChipaca, thanks. I'll comment on the report11:39
mborzeckiEighth_Doctor: but yes, /var/home is a problem11:40
mborzeckiEighth_Doctor: also, not sure why silverblue is not using a bind mount for /var/home -> /home11:41
zygaEighth_Doctor: looking11:41
zygaaha, this one11:41
Eighth_Doctormborzecki: that's what langdon and I said too...11:41
Eighth_Doctorbut unfortunately it's an ostree thing :(11:41
zygathere is a way to fix it but not anytime soon IMO11:41
zygaenough stuff to fix :/11:42
zygawe could remap $HOME to /home/$LOGNAME11:42
zygabut that's far from close11:42
* pstolowski walk & lunch11:42
zygaoutput from gtest is an unreadable mess11:46
mborzeckizyga: duh, they changed it like 2 releases back11:48
zygayeah, but it only matters when you have to look11:48
Eighth_Doctorzyga: can we add `/var/home` as an allowed redirection?11:55
Eighth_Doctoror maybe just follow the symlink and bind-mount the target?11:55
Eighth_Doctor(I assume that's what we're doing here with the homedir perm?)11:56
kjackalIs there an interface that would allow a command to stop and/or start a service? https://forum.snapcraft.io/t/stop-and-or-start-a-service-from-a-command/1364911:56
zygaEighth_Doctor: not easily11:56
zygathere's more to it than that11:56
mborzeckioff to pick up the kids12:01
Chipacajibel: from your comment I gather you don't need more info and I can re-install12:02
ondraChipaca mvo https://github.com/snapcore/snapd/pull/759012:02
mupPR #7590: seed: seed16: run adding snaps in parallel <Created by kubiko> <https://github.com/snapcore/snapd/pull/7590>12:02
mupPR snapd#7590 opened: seed: seed16: run adding snaps in parallel <Created by kubiko> <https://github.com/snapcore/snapd/pull/7590>12:02
ondraChipaca if you help me to land this, I will owe you one extra beer :P12:02
Chipacaondra: hmmmmmmmmmmmm12:05
Chipacaondra: I suspect it needs locks in addEssential, at least12:05
Chipacaondra: but that's just a quick pass12:05
Chipacaondra: I'll take a deeper look later12:05
ondraChipaca not really12:05
ondraChipaca I did keep order there12:05
Chipacaondra: you are writing to a shared map from multiple goroutines12:06
ondraChipaca have a look, only non assync is gadget12:06
Chipacaondra: that's what i mean12:06
ondraChipaca errors are written to shared map12:06
ondraChipaca but there does not seem to be anything which would be related othetrwise12:06
ondrahave a look12:07
Chipacawill do12:07
Chipacaondra: in any case just the fact that you found out this speedup opportunity is awesome12:07
Chipacaso I'm happy12:08
ChipacaI might be even happier after reviewing this, who knows12:08
Chipacai just don't have the mental bandwidth right now to do it properly :-)12:08
ondraChipaca of course, this is not critical :)12:09
ondraChipaca and it's not remedy to all, make no different on single core, or if you have 3 snaps12:09
Chipacaondra: yeah, for that we need go to take ian's sha3 patches12:10
Chipacaondra: there we get ~60% speedups across all armhf12:10
ondraChipaca imagine combined those two :)12:10
Chipacaondra: ikr12:10
ondraChipaca unless that assembly code also utilises multicore12:11
Chipacai'm sure there exist people that can write multicore assembly12:12
Chipacai think it's all black magic anyway12:12
=== ricab is now known as ricab|lunch
vidal72[m]hi, every time I open firefox it tries to read /var/lib/snapd/desktop/icons which is blocked by apparmor. Is it something fixable?12:26
Chipacavidal72[m]: what snapd version are you on?12:27
vidal72[m]Chipaca: one from ubuntu 19.0412:28
Chipacavidal72[m]: what does 'snap version' say?12:28
vidal72[m]I'm not on that machine atm, give me a sec12:29
vidal72[m]Chipaca: 2.42 series 1612:31
Chipacavidal72[m]: are you sure you're seeing these messages with that version? (it's from yesterday)12:32
ograold stuff then :P12:32
vidal72[m]yes, just reproduced minute ago12:32
Chipacajamesh: have you seen this?12:32
ogravidal72[m], is that on app startup or if you do some specific action (opening a file or whatnot)12:33
jibelChipaca, yes, I've enough info, thanks12:33
Chipacajibel: good because i'm already finishing the re-install :-) this time around i had no issues12:34
jameshChipaca: it's not surprising that apps would try to read various paths under /var/lib/snapd/desktop: that directory is included in $XDG_DATA_DIRS, and various specs say to check all locations contained there12:35
vidal72[m]ogra: app startup12:35
Chipacajamesh: hrm, i thought we'd added desktop/icons as ok as part of your icons work12:35
Chipacamaybe i was confused then12:35
jameshChipaca: not for the benefit of confined apps: that was for the host12:36
Chipacaah12:36
Chipacashould we add a rule just to not have it spam syslog?12:36
Chipaca(i don't mean a rule to allow the read)12:37
vidal72[m]+112:37
jameshperhaps12:38
vidal72[m]is it sensitive dir? I think desktop/applicationds are allowed to read12:38
jameshbrowser-support currently allows access to /var/lib/snapd/desktop/applications, yes12:38
jameshbut it probably shouldn't12:39
jameshit's not really useful and is a data leak12:39
vidal72[m]I think those should be both allowed or both denied12:40
vidal72[m]my icons folder is empty anyway12:41
jameshpresumably firefox was trying to access /var/lib/snapd/desktop/icons previously, but it didn't warn due to the directory not existing12:42
jameshas long as we have that directory in XDG_DATA_DIRS, I agree that warnings for access denials are just noise12:43
vidal72[m]jamesh: desktop-legacy also allows desktop/applications https://github.com/snapcore/snapd/blob/release/2.42/interfaces/builtin/desktop_legacy.go#L22912:48
jameshvidal72[m]: yep.  I don't think it is useful there either, since neither interface provides a way to launch those applications or access e.g. referenced icons12:49
vidal72[m]heh, why it was added then? isn't it needed for xdg-open?12:51
vidal72[m]which doesn't work in ff anyway but that's another story...12:51
zygamborzecki: https://github.com/snapcore/snapd/pull/759112:52
mupPR #7591: cmd/snap-confine: remove loads of dead code <Created by zyga> <https://github.com/snapcore/snapd/pull/7591>12:52
mupPR snapd#7591 opened: cmd/snap-confine: remove loads of dead code <Created by zyga> <https://github.com/snapcore/snapd/pull/7591>12:53
Chipacazyga: can you lead the standup? I don't think I'm going to make it12:53
zygasyre12:54
zyga*sure12:54
Chipacazyga: thynks12:54
zygany proolbm12:54
Chipaca:)12:54
jameshvidal72[m]: I wouldn't be surprised if the rules grew out of watching the audit logs for various apps without fully thinking through whether it made sense12:54
zygasee you at the standup12:55
Chipacazyga: probably not, that's the point :)12:55
vidal72[m]jamesh: should I make PR which deny desktop/{applications,icons} then?12:55
jameshvidal72[m]: similar to the icons case, /var/lib/snapd/desktop/applications existed, so it would generate audit messages without the rule allowing read access12:55
Chipacavidal72[m]: jamesh: suspect jdstrand might need to peep into this12:55
jameshvidal72[m]: perhaps start a thread on the forum and tag @jdstrand.12:56
vidal72[m]ok12:56
vidal72[m]another thing: did anyone considered allowing writing to @{PROC}/@{pid}/clear_refs https://forum.snapcraft.io/t/call-for-testing-chromium-browser-deb-to-snap-transition/11772/1712:57
Chipacazyga: wait i thought mvo was off today13:01
degvilleChipaca: he's here - he changed his mind apparently.13:04
mvoChipaca: I was considering it13:08
vidal72[m]jamesh: done https://forum.snapcraft.io/t/reading-var-lib-snapd-desktop-applications-icons/1365013:08
zygamvo: thank you for the review :)13:36
zygadid you read the commit messages?13:36
vidal72[m]interestingly snap-store snap wants to read my /home/user/documents dir on each startup which is blocked13:36
=== ricab|lunch is now known as ricab
sparkiegeekhmm, how does one use (install, run) snaps inside a docker container? is that even plausible?13:45
roadmr🤯13:46
sparkiegeekroadmr: you have tips? :)13:46
roadmronly to run away as fast as you can!13:46
* roadmr does, woohooo13:46
sparkiegeekwell I was hoping zyga would just tell me that it all works :D13:47
zygasparkiegeek: no can do :(13:47
zygasorry, docker is not able to run docker either13:47
sparkiegeekk, am I basically SOL?13:48
zygaI'm afraid so13:48
roadmrsparkiegeek: why must it be docker?13:48
sparkiegeekzyga: np, knowing is better than flailing around13:49
sparkiegeekroadmr: Reasons™13:49
roadmraha, got it :013:49
roadmrheeh :)13:49
Chipacaman this system feels slow even over ssh13:57
ijohnsonondra, Chipaca: IIRC the SHA3 NEON assembly is not parallelized, so each core has it's own NEON processor and the parallel speedup that ondra has should multiple together with the assembly patches13:57
ograwe should also test on an imx6ull to see if there is any impact on single-core SoCs (positive or negative)13:59
ijohnsonthe imx6ull would definitely benefit from the SHA3 patches (I actually tested on one of those :-D ), probably not so much from ondra's parallelization patch though14:03
ograwell, the first is a given, the latter is what caused my question :)14:03
ograit might improve, leaving the ordering to the kernel effectively ... or it might degrade because it tries to parallelize where it can not14:04
ondraogra go seems to be somehow smart about loading, so if one tasks pegs the core, it will probably not try to run too many in parallel14:12
* zyga -> lunch14:14
Chipacacmatsuoka: after much chuntering, I have a booted core!14:20
Chipacajibel: not being too scientific, it seems on this system I need to let it finish disk activity for partitioning before choosing country and creating the user, or it fails14:22
Chipacajibel: "not too scientific" == tried it both ways twice14:22
Chipacapopey: Wimpress: I think mate would be better if it waited for seeded before giving you login14:36
Chipacabetter first boot, you'd get the welcome app for one14:36
ograondra, well, i'd still perfer if you could hand it to cwayne to see actual results on real imx6ull hw14:41
Chipacacmatsuoka: - Update assets from gadget "pc" (44) (cannot read current gadget snap details: invalid volume "pc": invalid structure #2 ("Recovery"): invalid role "system-recovery": unsupported role)14:46
Chipacacmatsuoka: expected?14:46
ondraogra feel free to get him involved14:50
ograwell, you got the patched binary :P14:50
ograi'm just sayig we should make sure to have them in the loop before this goes to stable14:50
ograi guess they'll run QA anyway14:51
ogra(on that HW)14:51
Chipacacmatsuoka: mvo: core20 needs to drop the ConditionKernelCommandLine=snap_core from snapd.system-shutdown.service14:59
Chipaca:)14:59
Chipacai need to dig into what creates that now that it's automagically put in etc by somethingorother14:59
Chipacanot now tho; now, tea14:59
abeatosil2100, hey, not sure if you saw my update to https://github.com/CanonicalLtd/ubuntu-image/pull/175 ?15:00
mupPR CanonicalLtd/ubuntu-image#175: Little kernel bootloader support <Created by alfonsosanchezbeato> <https://github.com/CanonicalLtd/ubuntu-image/pull/175>15:00
mvochrisccoulson: indeed, good point15:03
chrisccoulsonmvo, was that meant for me?15:06
mvochrisccoulson: sorry, for Chipaca15:08
* Chipaca hands chrisccoulson a "got called Chipaca" beginners badge15:09
* roadmr is now nown as Choadmr15:11
* Chipaca wonders if roadmr knows what a choad is15:13
* roadmr googles15:13
* roadmr is now known as google-before-changing-nick-mr15:13
Chipaca:)15:13
ijohnsonChipaca: thoughts on #1847788 ? is this a bug or "AsDesigned"?15:23
mupBug #1847788: reverting and installing a snap deletes a disabled revision that should be kept <snapd:New> <https://launchpad.net/bugs/1847788>15:23
kjackalIs there a problem if I maintain a channel branch (eg edge/strict) with a strictly confined snap revision while the rest of the snap revisions in the channel are classic? https://forum.snapcraft.io/t/mixing-strictly-confined-and-classic-snap-revisions-in-a-channel/1365215:24
zygakjackal: migrations from one and the other are not automatic15:25
zygayou can go classic -> strict15:25
Chipacaijohnson: the one that's removed is _blacklisted_ (because revert)15:25
zygabut not the other way around15:25
Chipacaijohnson: so that changes the behaviour a bit15:25
Chipacaijohnson: you could instead snap refresh --revision x1, that should dwyw?15:25
ijohnsonChipaca: I want to keep revision x2 though15:25
ijohnson(though this is for a test, so bit of an arbitrary use case)15:26
kjackalthanks zyga, it is going to be only me using this channel branch for demo purposes (i hope)15:26
Chipacaijohnson: yeah, it sounds like you want a refresh, not a revert15:26
Chipacaijohnson: it's also possible it's a bug, but i think the refresh should leave x2 there15:26
ijohnsonbasically I want to keep like 4 revisions of a snap around, going back and forth between them with reverts and refreshes without any of them being garbage colledged15:26
Chipacaif that makes sense15:26
zygakjackal: you can use a branch15:27
zygakjackal: not a channel15:27
Chipacaijohnson: why not with refreshes?15:27
zygathat's good for demos15:27
ijohnsonI do need a revert though because I'm testing that revert does the right thing too :-)15:27
Chipacaijohnson: ¯\_(ツ)_/¯ revert will discard things after 'current'15:28
kjackalzyga: I am probably messing up the terminology edge/strict is a channel with strict being a branch, yes/no ?15:28
zygano, that's a risk level15:28
ijohnsonChipaca: yes that seems to be what it does now, but do you think that's a bug or AsDesigned?15:28
zygayou can create an actual branch15:28
zygalike demo15:28
zygaedge/demo15:28
zygaor demo/edge, I don't recall15:28
zygapeople need to refresh to it explicitly15:29
Chipacaijohnson: i mean, https://github.com/snapcore/snapd/blob/master/overlord/snapstate/snapstate.go#L29115:29
ijohnsonzyga: demo/edge has demo as a track, while edge/demo has demo as a branch IIRC15:29
Chipacaijohnson: // discard everything after current15:29
Chipacaijohnson: it's very intentional :-)15:29
kjackalI thought the channel had a <track>/<risk>/<branch> format15:29
zygayou are probably right, as I said I don't recall15:30
zygamy whole point is that it's a good way for actual demos15:30
Chipacakjackal: it should be fine, subject to the limitations of branches15:30
kjackalyeap, thank you people15:30
Chipacai mean, they expire after a while unless you keep on pushing to them15:30
Chipacathat sort of thing15:30
ijohnsonChipaca: git blame says this was from mvo with commit message "review feedback" :-/15:31
ijohnsonalright if it is AsDesigned that's fine I guess15:31
ijohnsonjust makes my tests more complicated15:31
zyga"review feedback" is the worst15:31
Chipacaijohnson: https://github.com/snapcore/snapd/pull/145715:31
mupPR #1457:  snapstate: drop revisions after "current" on refresh <Created by mvo5> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/1457>15:31
Chipacai mean, it's not good, but you grab the commit hash and look it up and you see the review feedback15:32
Chipacaso it's not _the worst_ :)15:32
Chipacaoh god, "retest this please"15:32
* Chipaca hugs spread15:33
Chipacaijohnson: what do you need the revision to still be there after revert for?15:35
Chipacaijohnson: i mean, which is the path that you're testing for?15:35
ijohnsonbecause I want to reuse the revision later in a different permutation, i.e. one test case is reverting backwards in time to that revision to make sure things work, another use case is to refresh to that revision15:36
ijohnsonI think if I re-order how I have the tests to do the reverts last it should be simpler, but also some of my tests could be using refresh instead of revert15:36
ijohnsonChipaca: if it's helpful look at the comment at the top of https://github.com/snapcore/snapd/blob/e1d284981c5380ee9252bb77b878b44716a92829/tests/main/disabled-svcs-kept-happy/task.yaml15:38
Chipacaijohnson: you can also refresh back and then revert forwards15:44
ijohnsonhmmmm yes I suppose I could revert forwards couldn't I15:44
mupPR snapd#7591 closed: cmd/snap-confine: remove loads of dead code <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/7591>15:45
mvoijohnson: uh, what did I do ? also - sorry for the terrible commit message16:06
ijohnsonmvo: no worries, your PR from 3 years ago just makes my PR more complicated16:06
mvoijohnson: I will read backlog after dinner hopefully16:06
mvoijohnson: sorry for that16:06
ijohnsonmvo: it's not important you don't need to read the backlog unless you want to16:07
Chipacamvo: after dinner it's THE WEEKEND16:07
ijohnsonChipaca is right, the weekend is more important :-)16:08
mupPR core-build#56 opened: writable-paths: enable create writable /etc/systemd/user <Created by mvo5> <https://github.com/snapcore/core-build/pull/56>16:16
mvoChipaca: *cough* good point16:17
=== pstolowski is now known as pstolowski|afk
Chipacaok, I'm EOW'ing17:04
Chipacahave a good'un, those of you who remain! but do get out of here and do other stuff also17:04
mupPR snapcraft#2750 opened: cli: clean up StoreClientCLI <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2750>18:46
mupPR snapcraft#2750 closed: cli: clean up StoreClientCLI <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2750>20:14
mupPR snapd#7554 closed: recovery: update fde-utils calls <Created by cmatsuoka> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/7554>22:26
mupPR snapcraft#2751 opened: tests: move cli store push/upload tests to FakeStoreCommands <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/2751>22:32

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!