[13:12] <wonko> OvenWerks: there is one small bug I'd like to figure out yet but it's hard to debug because it depends on a dbus message. Technically I know what the issue is, but I just don't know the right way to handle it.
[13:12] <wonko> If JACK == False at startup last_master never gets set to anything
[13:12] <wonko> so we get this: https://paste.ubuntu.com/p/269jNZmgZD/
[13:14] <wonko> We bail out of config_start() pretty early if JACK == False
[13:15] <wonko> That may just be an issue with controls not setting it correctly though, I'll look into that real quick
[13:17] <wonko> I mean, a quick look doesn't show there being an issue there
[13:17] <wonko> well, no, I take that back
[13:18] <wonko> autojack starts before controls at session start, so that's not guaranteed
[13:18] <wonko> But on the other hand, it *is* set to True in my config file, so maybe it's a race condition?
[15:34] <OvenWerks> The place to set that, if it needs to be set, is in config_start.
[15:38] <wonko> yes, but if JACK is set to False it never gets set
[15:40] <wonko> Is there a legitimate case where JACK == Falsed and msg_cb_new needs to actually do something?
[15:40] <wonko> otherwise we should just have it also check JACK and not run the rest if False
[15:41] <wonko> oh, that might be old log messages, but it's still a thing either way.
[15:52] <wonko> Hmm, now I want to write a prometheus exporter for the studio bits. Hmmmmmmm.
[16:42] <OvenWerks> I don't think so, All of those things only make sense if jack is running
[16:44] <OvenWerks> Yes the callbacks for device detection, new and removed, should check that jack is actually running.
[16:45] <OvenWerks> That sounds like a thinko on my part. IT has gone un-noticed because I aways run jack and because anything those callbacks do will fail without doing anything too bad
[16:45] <OvenWerks>  (I think)
[16:52] <OvenWerks> Actually, this could be more robust if aside from checking if jack we check that the pid I store still exists
[17:00] <OvenWerks> wonko: are you making changes to autojack ? If not I could fix up some of these things otherwise I will wait. (fixing merges when two people are working on the same file is not fun)
[17:36] <Eickmeyer> Well done, everyone: http://ubuntustudio.org/2019/10/ubuntu-studio-19-10-released/
[18:01] <OvenWerks> Cool!
[18:42] <wonko> OvenWerks: I'm not doing anything right now. Just happened to look at the log file and remembered that was a thingv
[21:00] <OvenWerks> I will look at it then and fix...
[21:35] <wonko> groovy. I've been playing with Go, Grafana and Prometheus today. Having more fun than I probably should with this: https://imgur.com/fa909U1.png
[21:35] <wonko> :)