| anastasiamac | wallyworld: PTAL https://github.com/juju/juju/pull/10774 - update-cloud changes | 01:30 |
|---|---|---|
| thumper | https://github.com/juju/juju/pull/10763 updates for model log files on the controller | 01:42 |
| * wallyworld otp interviewing, soon | 01:43 | |
| thumper | ack | 01:45 |
| babbageclunk | thumper: approved | 01:49 |
| thumper | babbageclunk: thanks | 01:49 |
| wallyworld | hpidcock: got a sec? | 01:59 |
| hpidcock | yep | 02:00 |
| wallyworld | standup | 02:00 |
| babbageclunk | thumper: super-simple review? https://github.com/juju/os/pull/14 | 02:08 |
| thumper | sure | 02:08 |
| thumper | babbageclunk: all good | 02:09 |
| babbageclunk | to be followed by a dep update against 2.6 then a merge to 2.7 | 02:09 |
| babbageclunk | thumper: looks like there was a backwards-incompatible change made to juju/os before mine (used in 2.7 but not 2.6). Should I just make the change to 2.7, or update 2.6 so that it can work without the removed function? | 02:24 |
| babbageclunk | just looking to see how the juju/juju code was changed | 02:24 |
| wallyworld | hpidcock: i left a few more thoughts. see what you think, especiallyu about the worker setup | 02:42 |
| wallyworld | i need to head out to 1:1 in about 5 | 02:42 |
| babbageclunk | wallyworld: have you got 2 mins then? | 02:45 |
| babbageclunk | :)))) | 02:45 |
| babbageclunk | bah looks like he already went | 02:46 |
| thumper | wallyworld: looks like an intermittent failure in apiserver/facades/client/action | 02:48 |
| babbageclunk | thumper: can I grab you for a moment - confused about the series stuff | 02:48 |
| thumper | babbageclunk: sure | 02:48 |
| babbageclunk | in 1:1 | 02:49 |
| wallyworld | i'll look after 1:1 when i get back | 02:49 |
| thumper | wallyworld: ack | 02:52 |
| thumper | wallyworld: problem appears to be iterating over an unsorted set, using Values() rather than SortedValues() in action.go method Tasks | 02:57 |
| thumper | nope, just saw the swap in the test... that's gross | 03:04 |
| thumper | wallyworld: I'm on it | 03:07 |
| thumper | wallyworld: I have the fix | 03:15 |
| thumper | if my branch fails to merge again, I'll add it to mine and retry | 03:15 |
| thumper | if it merges I'll propose separately | 03:15 |
| thumper | we have a 50/50 chance either way | 03:16 |
| thumper | map ordering FTW | 03:16 |
| thumper | it failed again, so pushing fix to my branch | 03:17 |
| thumper | https://github.com/juju/juju/pull/10763/commits/4d6fee29f7e7614f5d546220f3c83cd208abeed1 FWIW | 03:17 |
| babbageclunk | I hate when a package has a directory that includes a broken symlink so they can test that it doesn't break them, and then it breaks any other tool that does stuff with that directory. | 03:21 |
| thumper | babbageclunk: like? | 03:30 |
| babbageclunk | make rebuild-dependencies is failing for me because of gopkg.in/juju/charmrepo.v2/internal/test-charm-repo/series/format2/hooks/symlink | 03:31 |
| thumper | stink | 03:35 |
| babbageclunk | it really is | 03:37 |
| babbageclunk | just blowing away the vendor dir fixes it. | 03:40 |
| wallyworld | hpidcock: back from 1:1 now if you need me to look at anything | 04:14 |
| hpidcock | wallyworld: just getting the worker together and fixing tests I just broke | 04:14 |
| hpidcock | probably 30min away | 04:14 |
| wallyworld | no worries, i reckon we can squeeze it in | 04:14 |
| hpidcock | hah let's hope so | 04:16 |
| hml | manadart: do either of 10772 and 10773 (the small refactoring ones) require additional qa to land? | 12:23 |
| manadart | hml: Probably prudent to flex them some. We can contrive some steps and discuss and stand-up. | 12:25 |
| manadart | *at stand-up. | 12:25 |
| hml | manadart: agreed, just wasn’t sure if it’d been done already | 12:26 |
| nammn_de | rick_h: mind turning on github actions for juju/os? I can open PR with the workflow later | 13:42 |
| rick_h | nammn_de: it's on | 13:42 |
| rick_h | "enable local & third party actions for this repository" | 13:42 |
| rick_h | nammn_de: they have to land first though | 13:42 |
| nammn_de | rick_h: ta, go it | 13:43 |
| nammn_de | *got it | 13:43 |
| hml | simple review if someone is willing https://github.com/juju/juju/pull/10781 | 14:37 |
| hml | achilleasa: ping | 14:51 |
| rick_h | woooo! juju 2.7-beta available in the beta track now | 14:51 |
| rick_h | errr 2.7-beta1 | 14:51 |
| achilleasa | hml: here | 14:51 |
| rick_h | ty stickupkid!! | 14:51 |
| rick_h | great stuff team! | 14:51 |
| * rick_h does a happy dance | 14:51 | |
| rick_h | stickupkid: hah, bug emails coming now | 14:51 |
| hml | achilleasa: i’m not understanding WHY we validate the old default endpoint space when changing to a new one. | 14:52 |
| achilleasa | hml: we don't, we validate the new default if different than the old and not set to network.DefaultSpaceID | 14:53 |
| achilleasa | oh... I see what you mean. We can just always validate the new one right? | 14:54 |
| achilleasa | (so passing the old one through would not be needed) | 14:54 |
| hml | achilleasa perhaps? i was misreading and not connecting that the oldDefaultSpaceIDForApp was only used to see if the value changes. | 14:55 |
| hml | achilleasa: either way is okay, now that i get what’s going on. :-) | 14:56 |
| achilleasa | hml: you are right. Let me strip that out | 14:56 |
| achilleasa | hml: pushed a commit | 15:00 |
| hml | achilleasa: ty, looking | 15:00 |
| hml | achilleasa: nice, i think simplier easier to understand, and revalidating doesn’t hurt. | 15:03 |
| hml | achilleasa: what are your thoughts around the Force values from the application and bind changes? | 15:03 |
| achilleasa | hml: did you see my comment in the other PR? | 15:04 |
| hml | achilleasa: just need to do qa on 10780 | 15:04 |
| hml | achilleasa: nope… will read now | 15:04 |
| achilleasa | hml: let me know if my reply makes sense :D | 15:04 |
| hml | achilleasa: yes, ty. the corollary makes sense to me also. put that in the pr. | 15:07 |
| hml | achilleasa: a question in 10780 before I approve. it’s logged in the pr | 15:54 |
| achilleasa | hml: I don't understand... This was caused by "spaceNotFeasibleError" which should work now | 15:55 |
| achilleasa | hml: it should have been fixed by this: https://github.com/juju/juju/pull/10780/commits/7bfbaa36128734ad63f0ed2c4d0bb7309f293e2c#diff-3b940d8ae0b2e8e93eabd0ea62b619feR314-R340 | 15:56 |
| hml | achilleasa: hrm… let me try again. | 15:56 |
| achilleasa | hml: is that on guimaas? | 15:57 |
| hml | achilleasa: yes | 15:57 |
| achilleasa | hml: I will try next with a few log bits in there to see what's going on | 15:58 |
| hml | achilleasa: let me check something first. | 15:58 |
| hml | achilleasa: shit… sorry. i think i know what’s going on. damn release. let me reproduce first | 15:59 |
| achilleasa | hml: I was about to suggest it's not running the right code :D | 15:59 |
| hml | checked my history and i didn’t use —build-agent during bootstrap | 16:00 |
| hml | probably picked up the wrong agents | 16:00 |
| nammn_de | stickupkid: os github actions and finally running on osx and windows https://github.com/juju/os/pull/15 :D | 16:13 |
| hml | achilleasa: i had the wrong code. qa from scratch now | 16:18 |
| === hardy is now known as falencastro | ||
| stickupkid | nammn_de, CR'd | 16:24 |
| nammn_de | stickupkid: thanks man. The reason I changed the signature of the function is that people in future working on it don't get confused as I do. Actually I was hell of confused what the reason for the test was and why it failed. As I am not on windows this was a not fun debug session :D. The function only get's used for the test anyway. | 16:27 |
| stickupkid | nammn_de, it gets used in newDetectHardwareScript in winrmprovisioner.go | 16:28 |
| stickupkid | nammn_de, and we would throw that info away in that function | 16:28 |
| nammn_de | stickupkid: ahh, we use it on other repos | 16:28 |
| stickupkid | nammn_de, yarp | 16:29 |
| nammn_de | stickupkid: then let me change it on test level. | 16:29 |
| stickupkid | nammn_de, hence why i think we shouldn't change the signature | 16:29 |
| stickupkid | wicked | 16:29 |
| stickupkid | :D | 16:29 |
| stickupkid | or WICKED | 16:29 |
| stickupkid | GREAT WORK | 16:29 |
| nammn_de | stickupkid: dammnit, this function itself is SIMPLE but CONFUSING at once :D | 16:29 |
| stickupkid | nammn_de, yeah, global state SUCKS | 16:29 |
| nammn_de | as for someone without context | 16:29 |
| stickupkid | nammn_de, no no, that package is horrid | 16:29 |
| nammn_de | stickupkid: ha, thats true 😿 | 16:30 |
| stickupkid | nammn_de, it should be take a inspector, which returns a host series as a dependency and then use the vistor pattern to walk over the series to ensure it's valid | 16:31 |
| stickupkid | nammn_de, that's what i'd do, but would cause pain to move to it | 16:31 |
| hml | achilleasa: much better with the correct code! | 16:37 |
| nammn_de | stickupkid: yeah seems like we have a lot of places where we could add work. I guess takes quite some time no one is really willing to invest for some spaces :D | 16:43 |
| stickupkid | nammn_de, looks good to me | 16:58 |
| nammn_de | stickupkid: thanks | 16:59 |
| nammn_de | stickupkid: catalina support should already be merged, right? no more work to be done | 17:00 |
| nammn_de | ? | 17:00 |
| timClicks | this is a really interesting post https://discourse.jujucharms.com/t/any-advice-on-using-juju-for-regular-websites/2223/6 | 20:26 |
| rick_h | timClicks: yea, crazy post | 20:27 |
| timClicks | single engineer has supported over 2,000 deployments (most test/staging, I expect) each with their own version of php, magento/wordpress, mail, SSO, ... | 20:28 |
| rick_h | wheeeee | 20:30 |
| rick_h | " | 20:30 |
| rick_h | "part time" | 20:30 |
| rick_h | timClicks: when you're free I'd love to catch up on how you'd like to go about the 2.7-beta1 release notes bit | 20:41 |
| rick_h | timClicks: we didn't send anything out yet because of the debs we'll process tomorrow but wanted to sync on highest priority material. I tried to add some bits on the "to document" discourse post but I'm not sure if that's meant for beta1 release notes and such | 20:42 |
| timClicks | ah right | 20:42 |
| timClicks | I removed the non-snap instructions from the notes and pushed it love | 20:43 |
| timClicks | *live | 20:43 |
| timClicks | we can edit them back in once they're available | 20:43 |
| timClicks | rick_h: did you want to jump into a call? | 20:44 |
| rick_h | timClicks: sure thing, omw to the cross team | 20:45 |
| admcleod | how is the lxd snap installer working with network restricted installs? | 22:11 |
| admcleod | i.e does the apt proxy get passed to snapd? | 22:13 |
| rick_h | admcleod: so there's a snap proxy config I would expect to be set | 22:15 |
| admcleod | rick_h: in model-config? | 22:16 |
| rick_h | admcleod: note this is 2.7 only as lxd is gotten from a deb before 2.7 | 22:16 |
| admcleod | rick_h: riiiight ok | 22:16 |
| rick_h | admcleod: and 2.7 has the updated code to handle lxd from a snap source and working in a better way | 22:16 |
| admcleod | rick_h: ok thanks. wont log a bug then | 22:16 |
| admcleod | rick_h: ad i seem to have wrked around it with 2.6.9 so \o/ | 22:23 |
| rick_h | admcleod: woot | 22:29 |
| anastasiamac | admcleod: would b awesome if u could document ur workaround in discourse \o/ well done!! | 22:51 |
| admcleod | anastasiamac: i can do that if you tell me which one specifically | 22:52 |
| anastasiamac | admcleod: I've create this for u using the wording in this conv... feel free to edit/comment | 23:00 |
| anastasiamac | admcleod: tyvm | 23:00 |
| anastasiamac | admcleod: https://discourse.jujucharms.com/t/pre-2-7-lxd-snap-installs-with-network-restrictions/2269 | 23:02 |
| admcleod | anastasiamac: done | 23:05 |
| anastasiamac | admcleod: \o/ | 23:06 |
| wallyworld | hpidcock: i have meetings for the next while soon, but i left a few comments to look at | 23:13 |
| hpidcock | thanks | 23:14 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!