anastasiamacwallyworld: PTAL https://github.com/juju/juju/pull/10774 - update-cloud changes01:30
thumperhttps://github.com/juju/juju/pull/10763 updates for model log files on the controller01:42
* wallyworld otp interviewing, soon01:43
babbageclunkthumper: approved01:49
thumperbabbageclunk: thanks01:49
wallyworldhpidcock: got a sec?01:59
babbageclunkthumper: super-simple review? https://github.com/juju/os/pull/1402:08
thumperbabbageclunk: all good02:09
babbageclunkto be followed by a dep update against 2.6 then a merge to 2.702:09
babbageclunkthumper: looks like there was a backwards-incompatible change made to juju/os before mine (used in 2.7 but not 2.6). Should I just make the change to 2.7, or update 2.6 so that it can work without the removed function?02:24
babbageclunkjust looking to see how the juju/juju code was changed02:24
wallyworldhpidcock: i left a few more thoughts. see what you think, especiallyu about the worker setup02:42
wallyworldi need to head out to 1:1 in about 502:42
babbageclunkwallyworld: have you got 2 mins then?02:45
babbageclunkbah looks like he already went02:46
thumperwallyworld: looks like an intermittent failure in apiserver/facades/client/action02:48
babbageclunkthumper: can I grab you for a moment - confused about the series stuff02:48
thumperbabbageclunk: sure02:48
babbageclunkin 1:102:49
wallyworldi'll look after 1:1 when i get back02:49
thumperwallyworld: ack02:52
thumperwallyworld: problem appears to be iterating over an unsorted set, using Values() rather than SortedValues() in action.go method Tasks02:57
thumpernope, just saw the swap in the test... that's gross03:04
thumperwallyworld: I'm on it03:07
thumperwallyworld: I have the fix03:15
thumperif my branch fails to merge again, I'll add it to mine and retry03:15
thumperif it merges I'll propose separately03:15
thumperwe have a 50/50 chance either way03:16
thumpermap ordering FTW03:16
thumperit failed again, so pushing fix to my branch03:17
thumperhttps://github.com/juju/juju/pull/10763/commits/4d6fee29f7e7614f5d546220f3c83cd208abeed1 FWIW03:17
babbageclunkI hate when a package has a directory that includes a broken symlink so they can test that it doesn't break them, and then it breaks any other tool that does stuff with that directory.03:21
thumperbabbageclunk: like?03:30
babbageclunkmake rebuild-dependencies is failing for me because of gopkg.in/juju/charmrepo.v2/internal/test-charm-repo/series/format2/hooks/symlink03:31
babbageclunkit really is03:37
babbageclunkjust blowing away the vendor dir fixes it.03:40
wallyworldhpidcock: back from 1:1 now if you need me to look at anything04:14
hpidcockwallyworld: just getting the worker together and fixing tests I just broke04:14
hpidcockprobably 30min away04:14
wallyworldno worries, i reckon we can squeeze it in04:14
hpidcockhah let's hope so04:16
hmlmanadart:  do either of 10772 and 10773 (the small refactoring ones) require additional qa to land?12:23
manadarthml: Probably prudent to flex them some. We can contrive some steps and discuss and stand-up.12:25
manadart*at stand-up.12:25
hmlmanadart: agreed, just wasn’t sure if it’d been done already12:26
nammn_derick_h: mind turning on github actions for juju/os? I can open PR with the workflow later13:42
rick_hnammn_de:  it's on13:42
rick_h"enable local & third party actions for this repository"13:42
rick_hnammn_de:  they have to land first though13:42
nammn_derick_h: ta, go it13:43
nammn_de*got it13:43
hmlsimple review if someone is willing https://github.com/juju/juju/pull/1078114:37
hmlachilleasa:  ping14:51
rick_hwoooo! juju 2.7-beta available in the beta track now14:51
rick_herrr 2.7-beta114:51
achilleasahml: here14:51
rick_hty stickupkid!!14:51
rick_hgreat stuff team!14:51
* rick_h does a happy dance14:51
rick_hstickupkid:  hah, bug emails coming now14:51
hmlachilleasa:  i’m not understanding WHY we validate the old default endpoint space when changing to a new one.14:52
achilleasahml: we don't, we validate the new default if different than the old and not set to network.DefaultSpaceID14:53
achilleasaoh... I see what you mean. We can just always validate the new one right?14:54
achilleasa(so passing the old one through would not be needed)14:54
hmlachilleasa perhaps? i was misreading and not connecting that the oldDefaultSpaceIDForApp was only used to see if the value changes.14:55
hmlachilleasa:  either way is okay, now that i get what’s going on.  :-)14:56
achilleasahml: you are right. Let me strip that out14:56
achilleasahml: pushed a commit15:00
hmlachilleasa: ty, looking15:00
hmlachilleasa: nice, i think simplier easier to understand, and revalidating doesn’t hurt.15:03
hmlachilleasa:  what are your thoughts around the Force values from the application and bind changes?15:03
achilleasahml: did you see my comment in the other PR?15:04
hmlachilleasa: just need to do qa on 1078015:04
hmlachilleasa:  nope… will read now15:04
achilleasahml: let me know if my reply makes sense :D15:04
hmlachilleasa: yes, ty.  the corollary makes sense to me also.  put that in the pr.15:07
hmlachilleasa: a question in 10780 before I approve.  it’s logged in the pr15:54
achilleasahml: I don't understand... This was caused by "spaceNotFeasibleError" which should work now15:55
achilleasahml: it should have been fixed by this: https://github.com/juju/juju/pull/10780/commits/7bfbaa36128734ad63f0ed2c4d0bb7309f293e2c#diff-3b940d8ae0b2e8e93eabd0ea62b619feR314-R34015:56
hmlachilleasa:  hrm…  let me try again.15:56
achilleasahml: is that on guimaas?15:57
hmlachilleasa:  yes15:57
achilleasahml: I will try next with a few log bits in there to see what's going on15:58
hmlachilleasa:  let me check something first.15:58
hmlachilleasa:  shit… sorry.  i think i know what’s going on.  damn release.  let me reproduce first15:59
achilleasahml: I was about to suggest it's not running the right code :D15:59
hmlchecked my history and i didn’t use —build-agent during bootstrap16:00
hmlprobably picked up the wrong agents16:00
nammn_destickupkid: os github actions and finally running on osx and windows https://github.com/juju/os/pull/15 :D16:13
hmlachilleasa:  i had the wrong code.  qa from scratch now16:18
=== hardy is now known as falencastro
stickupkidnammn_de, CR'd16:24
nammn_destickupkid: thanks man. The reason I changed the signature of the function is that people in future working on it don't get confused as I do. Actually I was hell of confused what the reason for the test was and why it failed. As I am not on windows this was a not fun debug session :D. The function only get's used for the test anyway.16:27
stickupkidnammn_de, it gets used in newDetectHardwareScript in winrmprovisioner.go16:28
stickupkidnammn_de, and we would throw that info away in that function16:28
nammn_destickupkid: ahh, we use it on other repos16:28
stickupkidnammn_de, yarp16:29
nammn_destickupkid: then let me change it on test level.16:29
stickupkidnammn_de, hence why i think we shouldn't change the signature16:29
stickupkidor WICKED16:29
stickupkidGREAT WORK16:29
nammn_destickupkid: dammnit, this function itself is SIMPLE but CONFUSING at once :D16:29
stickupkidnammn_de, yeah, global state SUCKS16:29
nammn_deas for someone without context16:29
stickupkidnammn_de, no no, that package is horrid16:29
nammn_destickupkid: ha, thats true 😿16:30
stickupkidnammn_de, it should be take a inspector, which returns a host series as a dependency and then use the vistor pattern to walk over the series to ensure it's valid16:31
stickupkidnammn_de, that's what i'd do, but would cause pain to move to it16:31
hmlachilleasa:  much better with the correct code!16:37
nammn_destickupkid: yeah seems like we have a lot of places where we could add work. I guess takes quite some time no one is really willing to invest for some spaces :D16:43
stickupkidnammn_de, looks good to me16:58
nammn_destickupkid: thanks16:59
nammn_destickupkid: catalina support should already be merged, right? no more work to be done17:00
timClicksthis is a really interesting post https://discourse.jujucharms.com/t/any-advice-on-using-juju-for-regular-websites/2223/620:26
rick_htimClicks:  yea, crazy post20:27
timClickssingle engineer has supported over 2,000 deployments (most test/staging, I expect) each with their own version of php, magento/wordpress, mail, SSO, ...20:28
rick_h"part time"20:30
rick_htimClicks:  when you're free I'd love to catch up on how you'd like to go about the 2.7-beta1 release notes bit20:41
rick_htimClicks:  we didn't send anything out yet because of the debs we'll process tomorrow but wanted to sync on highest priority material. I tried to add some bits on the "to document" discourse post but I'm not sure if that's meant for beta1 release notes and such20:42
timClicksah right20:42
timClicksI removed the non-snap instructions from the notes and pushed it love20:43
timClickswe can edit them back in once they're available20:43
timClicksrick_h: did you want to jump into a call?20:44
rick_htimClicks:  sure thing, omw to the cross team20:45
admcleodhow is the lxd snap installer working with network restricted installs?22:11
admcleodi.e does the apt proxy get passed to snapd?22:13
rick_hadmcleod:  so there's a snap proxy config I would expect to be set22:15
admcleodrick_h: in model-config?22:16
rick_hadmcleod:  note this is 2.7 only as lxd is gotten from a deb before 2.722:16
admcleodrick_h: riiiight ok22:16
rick_hadmcleod:  and 2.7 has the updated code to handle lxd from a snap source and working in a better way22:16
admcleodrick_h: ok thanks. wont log a bug then22:16
admcleodrick_h: ad i seem to have wrked around it with 2.6.9 so \o/22:23
rick_hadmcleod:  woot22:29
anastasiamacadmcleod: would b awesome if u could document ur workaround in discourse \o/ well done!!22:51
admcleodanastasiamac: i can do that if you tell me which one specifically22:52
anastasiamacadmcleod: I've create this for u using the wording in this conv... feel free to edit/comment23:00
anastasiamacadmcleod: tyvm23:00
anastasiamacadmcleod: https://discourse.jujucharms.com/t/pre-2-7-lxd-snap-installs-with-network-restrictions/226923:02
admcleodanastasiamac: done23:05
anastasiamacadmcleod: \o/23:06
wallyworldhpidcock: i have meetings for the next while soon, but i left a few comments to look at23:13

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!